@estebanforge/pi-ask-antigravity 1.3.1 → 1.3.4

package/CHANGELOG.md

@@ -2,7 +2,28 @@
 
 All notable changes to this project will be documented in this file.
 
-## [Unreleased]
+## [1.3.4] - 2026-11-10
+
+### Added
+
+- **The AskAntigravity defaults dialog reports blocked-on-user-input while open.** Pi 1.5.1 lets overlay dialogs declare a blocked program status (OSC 7501); the dialog now passes it, so terminal automation watching the session sees pi waiting on input instead of idle. Pi dependency floor moved to ^1.5.1.
+
+### Changed
+- The finishing-window stop guard now reads the run's registry status instead of a wall-clock-aligned side set: same refusal behavior, and the test awaits the lifecycle transition instead of a fixed 250ms delay (flaked under full-suite load). Shared dependency floor moves to ^0.1.5 (`markFinishing`) once shared publishes.
+
+### Fixed
+- Windows: `agy models` discovery now resolves the binary like the shared runner does (native `.exe`/`.com` on `PATH`, explicit `AGY_BIN` paths honored, npm shims reported as unavailable instead of a cryptic spawn failure), and every run kills its process tree via `taskkill` instead of POSIX group signals that never fire on Windows.
+
+## [1.3.3] - 2026-11-02
+
+### Fixed
+- The tool result expand hint now comes from the render context pi injects (`context.keyHint`) instead of the package import. pi 1.5 blinds an imported `keyHint` to the host keybindings (app.* ids format as ""), so the hint rendered as "to expand" with no key. Peer floor moves to `^1.5.0` accordingly.
+
+## [1.3.2] - 2026-10-27
+
+### Fixed
+
+- **`/agy-stop` no longer discards an answer that already finished computing.** Between the agy process closing and the run settling (conversation discovery + classification, up to ~500ms), a stop settled the run failed and silently dropped the computed answer. The stop handler now consults a finishing guard (the new opt-in `guard` option on pi-ask-shared's `createStopHandler`, dependency floor raised to ^0.1.3) and refuses with "already finished; its result is being delivered" while that window is open; the wake then delivers normally.
 
 ## [1.3.1] - 2026-10-21
 
@@ -41,7 +62,6 @@ All notable changes to this project will be documented in this file.
 
 - **Background runs (`background`, opt-in, default blocking).** Detached runs with the shared wake contract: `runId` at once, the answer arrives later as a conversation message with the resume handle (when agy reports one; discovery misses say so) under an UNTRUSTED banner. `/agy-stop [runId]` kills a run. One run per conversation at a time across blocking and background (per-handle lock). Refused in print/json mode; session replacement kills in-flight runs and loses their results; the staged context file and plan-mode reviewer dir are cleaned on every exit path including session shutdown.
 
-
 ### Fixed
 
 - **Plan runs are no longer auto-approved and no longer claim enforcement.** The CLI does not gate writes under plan mode ([#1181](https://github.com/google-antigravity/antigravity-cli/issues/1181)): the previously documented "write attempts fail at plan approval" behavior never held, and plan runs carrying the skip-permissions flag (whenever the restricted agent staged) were write-capable. Plan runs now never receive the flag (including via `AGY_EXTRA_ARGS`, filtered by prefix), the restricted agent is documented as a damper, and the tool description, param description, and README no longer call plan review-only or enforced.

package/extensions/index.ts

@@ -37,12 +37,11 @@ import {
 	type AgentToolResult,
 	buildSessionContext,
 	getAgentDir,
-	keyHint,
 	type ExtensionAPI,
 } from "@earendil-works/pi-coding-agent";
 
 import { Text } from "@earendil-works/pi-tui";
-import { DIALOG_OPTIONS, DialogMenu, type DialogRow } from "@estebanforge/pi-tui-dialogs";
+import { DIALOG_OPTIONS, DialogMenu, dialogBlocked, type DialogRow } from "@estebanforge/pi-tui-dialogs";
 import { contentText } from "@earendil-works/pi-ai";
 import { Type } from "typebox";
 import {
@@ -66,6 +65,7 @@ import {
 	newConversationId,
 	parseModelLine,
 	resolveAgyModel,
+	resolveSpawnTarget,
 	RunSpawnError,
 	runProcess,
 	saveLayeredConfig,
@@ -351,9 +351,11 @@ const sleep = (ms: number) => new Promise<void>((r) => setTimeout(r, ms));
 
 /** Query `agy models`. Returns [] on any failure (non-fatal). */
 async function discoverModels(binary: string): Promise<ModelEntry[]> {
+	const target = resolveSpawnTarget(binary);
+	if (target.kind === "unavailable") return [];
 	try {
 		const text = await new Promise<string>((resolve, reject) => {
-			const proc = spawn(binary, ["models"], {
+			const proc = spawn(target.file, ["models"], {
 				stdio: ["ignore", "pipe", "ignore"],
 				shell: false,
 			});
@@ -513,6 +515,8 @@ interface ProcessRunOptions {
 	/** Background only: hands over the tree-kill switch plus the live child
 	 *  handle (pid for the FD-disambiguation poll) as soon as the child exists. */
 	onSpawn?: (kill: () => void, proc: ChildProcess) => void;
+	/** Background only: the child closed; discovery/classification still running. Arms the stop handler's finishing guard. */
+	onClose?: () => void;
 }
 
 interface ProcessRunOutcome {
@@ -535,7 +539,7 @@ interface AskToolResult {
  * resolves when the process tree closes.
  */
 async function runAgyProcess(opts: ProcessRunOptions): Promise<ProcessRunOutcome> {
-	const { binary, args, workdir, timeoutMin, startAt, details, isContinuation, snapshot, signal, onPartial, onSpawn } = opts;
+	const { binary, args, workdir, timeoutMin, startAt, details, isContinuation, snapshot, signal, onPartial, onSpawn, onClose } = opts;
 	let out = "";
 
 	const statusInterval = onPartial
@@ -596,6 +600,9 @@ async function runAgyProcess(opts: ProcessRunOptions): Promise<ProcessRunOutcome
 		});
 
 		if (statusInterval) clearInterval(statusInterval);
+		// runProcess resolves only on stream close: the child is gone, output
+		// drained; discovery/classification still runs below.
+		onClose?.();
 
 		// Let the during-run bind poll finish (it bails immediately once agy
 		// has exited, so this rarely blocks).
@@ -687,7 +694,11 @@ function shapeFinalText(details: AgyDetails, outcome: ProcessRunOutcome, timeout
 	return text + footer;
 }
 
-export default async function (pi: ExtensionAPI) {
+export default async function (
+	pi: ExtensionAPI,
+	// Injectable so tests can await lifecycle phases; production uses the default.
+	registry: BackgroundRunRegistry = new BackgroundRunRegistry({ toolName: "ask-antigravity" }),
+) {
 	// If pi-antigravity-bridge is installed, it owns the AskAntigravity tool
 	// (and the provider). Stay silent and register nothing to avoid a
 	// duplicate-tool clash. Without the bridge, this extension behaves as
@@ -714,7 +725,6 @@ export default async function (pi: ExtensionAPI) {
 	// Pi wipes module state on /new, /resume, /fork and /reload: an in-flight
 	// background run is killed and its result is never delivered. Accepted
 	// trade-off, documented in the README.
-	const registry = new BackgroundRunRegistry({ toolName: "ask-antigravity" });
 	const kills = new Map<string, () => void>();
 	// Staged-artifact cleanup (contextFile + reviewer agent dir), keyed by run:
 	// the session_shutdown backstop runs these when a hard exit would skip the
@@ -737,6 +747,14 @@ export default async function (pi: ExtensionAPI) {
 				elapsedS: Math.round((Date.now() - run.startedAt) / 1000),
 				error: "stopped via /agy-stop",
 			}),
+		// The guard keeps /agy-stop from discarding an answer that already
+		// finished computing and is riding discovery to its wake. `finishing`
+		// lives in the registry (status set at child close), so the window is
+		// observable instead of wall-clock aligned.
+		guard: (run) =>
+			registry.get(run.runId)?.status === "finishing"
+				? `Run ${run.runId} already finished; its result is being delivered.`
+				: null,
 	});
 	pi.on("session_shutdown", () => {
 		// Latch first so close-handler wakes stay silent, then kill children,
@@ -846,7 +864,7 @@ export default async function (pi: ExtensionAPI) {
 						},
 					};
 				},
-				DIALOG_OPTIONS,
+				{ ...DIALOG_OPTIONS, blocked: dialogBlocked("AskAntigravity defaults") },
 			);
 
 			if (Object.keys(pending).length === 0) return;
@@ -981,7 +999,7 @@ export default async function (pi: ExtensionAPI) {
 			if (args.includeContext) tags.push("context=full");
 			if (args.background) tags.push("bg");
 
-			let text = theme.fg("mdLink", theme.bold("AskAntigravity "));
+			let text = theme.fg("success", theme.bold("AskAntigravity "));
 			text += `${theme.fg("accent", `[${tags.join(", ")}]`)} `;
 
 			const prompt = String(args.prompt ?? "");
@@ -993,11 +1011,11 @@ export default async function (pi: ExtensionAPI) {
 			}
 			return new Text(text, 0, 0);
 		},
-		renderResult(result, { expanded, isPartial }, theme) {
+		renderResult(result, { expanded, isPartial }, theme, context) {
 			const d = result.details as AgyDetails | undefined;
 			if (isPartial) {
 				const status = result.content[0]?.type === "text" ? result.content[0].text : "working...";
-				return new Text(theme.fg("mdLink", "◉ AskAntigravity ") + theme.fg("muted", status), 0, 0);
+				return new Text(theme.fg("success", "◉ AskAntigravity ") + theme.fg("muted", status), 0, 0);
 			}
 
 			const body = result.content[0]?.type === "text" ? result.content[0].text : "";
@@ -1006,7 +1024,7 @@ export default async function (pi: ExtensionAPI) {
 
 			let text = errored
 				? theme.fg("error", "✗ AskAntigravity error")
-				: theme.fg("mdLink", "✓ AskAntigravity");
+				: theme.fg("success", "✓ AskAntigravity");
 
 			const rTags: string[] = [];
 			if (d?.resolvedModel || d?.model) rTags.push(`model=${d?.resolvedModel ?? d?.model}`);
@@ -1023,7 +1041,7 @@ export default async function (pi: ExtensionAPI) {
 				const lines = truncated.split("\n").slice(0, PREVIEW_MAX_LINES);
 				if (lines.length) text += `\n${theme.fg("toolOutput", lines.join("\n"))}`;
 				if (body.length > PREVIEW_MAX_CHARS || body.split("\n").length > PREVIEW_MAX_LINES) {
-					text += `\n${theme.fg("dim", `… (${keyHint("app.tools.expand", "to expand")})`)}`;
+					text += `\n${theme.fg("dim", `… (${context.keyHint("app.tools.expand", "to expand")})`)}`;
 				}
 			}
 			return new Text(text, 0, 0);
@@ -1457,6 +1475,7 @@ export default async function (pi: ExtensionAPI) {
 			onSpawn: (kill) => {
 				kills.set(runId, kill);
 			},
+			onClose: () => registry.markFinishing(runId),
 		})
 			.then((outcome) => {
 				kills.delete(runId);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@estebanforge/pi-ask-antigravity",
-  "version": "1.3.1",
+  "version": "1.3.4",
   "description": "Pi tool that delegates a self-contained sub-task to Google Antigravity's agy CLI (the CLI for Gemini). Friendly model aliases (flash/pro/gemini), configurable default model + thinking, and the AskAntigravity delegation tool.",
   "keywords": [
     "pi-package",
@@ -28,8 +28,8 @@
   },
   "type": "module",
   "dependencies": {
-    "@estebanforge/pi-ask-shared": "^0.1.2",
-    "@estebanforge/pi-tui-dialogs": "^0.1.1"
+    "@estebanforge/pi-ask-shared": "^0.1.5",
+    "@estebanforge/pi-tui-dialogs": "^0.1.3"
   },
   "files": [
     "extensions",
@@ -43,7 +43,7 @@
     ]
   },
   "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "^1.0.0"
+    "@earendil-works/pi-coding-agent": "^1.5.1"
   },
   "peerDependenciesMeta": {
     "@earendil-works/pi-coding-agent": {