@estebanforge/pi-ask-antigravity 1.3.0 → 1.3.3

package/CHANGELOG.md

@@ -2,7 +2,21 @@
 
 All notable changes to this project will be documented in this file.
 
-## [Unreleased]
+## [1.3.3] - 2026-11-02
+
+### Fixed
+- The tool result expand hint now comes from the render context pi injects (`context.keyHint`) instead of the package import. pi 1.5 blinds an imported `keyHint` to the host keybindings (app.* ids format as ""), so the hint rendered as "to expand" with no key. Peer floor moves to `^1.5.0` accordingly.
+
+## [1.3.2] - 2026-10-27
+
+### Fixed
+
+- **`/agy-stop` no longer discards an answer that already finished computing.** Between the agy process closing and the run settling (conversation discovery + classification, up to ~500ms), a stop settled the run failed and silently dropped the computed answer. The stop handler now consults a finishing guard (the new opt-in `guard` option on pi-ask-shared's `createStopHandler`, dependency floor raised to ^0.1.3) and refuses with "already finished; its result is being delivered" while that window is open; the wake then delivers normally.
+
+## [1.3.1] - 2026-10-21
+
+### Added
+- The generated reviewer agent.md frontmatter is now pinned by a test that parses it with a real YAML parser. The plan-review tool shares the failure mode fixed in pi-antigravity-bridge 1.8.3 (agy silently drops an agent whose frontmatter does not parse); the guard keeps a future wording edit from reintroducing it here.
 
 ## [1.3.0] - 2026-10-12
 
@@ -36,7 +50,6 @@ All notable changes to this project will be documented in this file.
 
 - **Background runs (`background`, opt-in, default blocking).** Detached runs with the shared wake contract: `runId` at once, the answer arrives later as a conversation message with the resume handle (when agy reports one; discovery misses say so) under an UNTRUSTED banner. `/agy-stop [runId]` kills a run. One run per conversation at a time across blocking and background (per-handle lock). Refused in print/json mode; session replacement kills in-flight runs and loses their results; the staged context file and plan-mode reviewer dir are cleaned on every exit path including session shutdown.
 
-
 ### Fixed
 
 - **Plan runs are no longer auto-approved and no longer claim enforcement.** The CLI does not gate writes under plan mode ([#1181](https://github.com/google-antigravity/antigravity-cli/issues/1181)): the previously documented "write attempts fail at plan approval" behavior never held, and plan runs carrying the skip-permissions flag (whenever the restricted agent staged) were write-capable. Plan runs now never receive the flag (including via `AGY_EXTRA_ARGS`, filtered by prefix), the restricted agent is documented as a damper, and the tool description, param description, and README no longer call plan review-only or enforced.

package/extensions/index.ts

@@ -37,7 +37,6 @@ import {
 	type AgentToolResult,
 	buildSessionContext,
 	getAgentDir,
-	keyHint,
 	type ExtensionAPI,
 } from "@earendil-works/pi-coding-agent";
 
@@ -513,6 +512,8 @@ interface ProcessRunOptions {
 	/** Background only: hands over the tree-kill switch plus the live child
 	 *  handle (pid for the FD-disambiguation poll) as soon as the child exists. */
 	onSpawn?: (kill: () => void, proc: ChildProcess) => void;
+	/** Background only: the child closed; discovery/classification still running. Arms the stop handler's finishing guard. */
+	onClose?: () => void;
 }
 
 interface ProcessRunOutcome {
@@ -535,7 +536,7 @@ interface AskToolResult {
  * resolves when the process tree closes.
  */
 async function runAgyProcess(opts: ProcessRunOptions): Promise<ProcessRunOutcome> {
-	const { binary, args, workdir, timeoutMin, startAt, details, isContinuation, snapshot, signal, onPartial, onSpawn } = opts;
+	const { binary, args, workdir, timeoutMin, startAt, details, isContinuation, snapshot, signal, onPartial, onSpawn, onClose } = opts;
 	let out = "";
 
 	const statusInterval = onPartial
@@ -596,6 +597,9 @@ async function runAgyProcess(opts: ProcessRunOptions): Promise<ProcessRunOutcome
 		});
 
 		if (statusInterval) clearInterval(statusInterval);
+		// runProcess resolves only on stream close: the child is gone, output
+		// drained; discovery/classification still runs below.
+		onClose?.();
 
 		// Let the during-run bind poll finish (it bails immediately once agy
 		// has exited, so this rarely blocks).
@@ -723,6 +727,10 @@ export default async function (pi: ExtensionAPI) {
 	// One background run per conversationId at a time: two runs resuming the
 	// same conversation interleave their turns inside agy's SQLite state.
 	const busyHandles = new Set<string>();
+	// The child closed but the answer is not settled yet (discovery +
+	// classification): a stop in this window must refuse instead of settling
+	// failed and discarding a computed answer.
+	const finishing = new Set<string>();
 	const sendWake = createWakeSender(pi, {
 		customType: "ask-antigravity-result",
 		isDisposed: () => registry.isDisposed(),
@@ -737,6 +745,10 @@ export default async function (pi: ExtensionAPI) {
 				elapsedS: Math.round((Date.now() - run.startedAt) / 1000),
 				error: "stopped via /agy-stop",
 			}),
+		// The guard keeps /agy-stop from discarding an answer that already
+		// finished computing and is riding discovery to its wake.
+		guard: (run) =>
+			finishing.has(run.runId) ? `Run ${run.runId} already finished; its result is being delivered.` : null,
 	});
 	pi.on("session_shutdown", () => {
 		// Latch first so close-handler wakes stay silent, then kill children,
@@ -993,7 +1005,7 @@ export default async function (pi: ExtensionAPI) {
 			}
 			return new Text(text, 0, 0);
 		},
-		renderResult(result, { expanded, isPartial }, theme) {
+		renderResult(result, { expanded, isPartial }, theme, context) {
 			const d = result.details as AgyDetails | undefined;
 			if (isPartial) {
 				const status = result.content[0]?.type === "text" ? result.content[0].text : "working...";
@@ -1023,7 +1035,7 @@ export default async function (pi: ExtensionAPI) {
 				const lines = truncated.split("\n").slice(0, PREVIEW_MAX_LINES);
 				if (lines.length) text += `\n${theme.fg("toolOutput", lines.join("\n"))}`;
 				if (body.length > PREVIEW_MAX_CHARS || body.split("\n").length > PREVIEW_MAX_LINES) {
-					text += `\n${theme.fg("dim", `… (${keyHint("app.tools.expand", "to expand")})`)}`;
+					text += `\n${theme.fg("dim", `… (${context.keyHint("app.tools.expand", "to expand")})`)}`;
 				}
 			}
 			return new Text(text, 0, 0);
@@ -1457,6 +1469,7 @@ export default async function (pi: ExtensionAPI) {
 			onSpawn: (kill) => {
 				kills.set(runId, kill);
 			},
+			onClose: () => finishing.add(runId),
 		})
 			.then((outcome) => {
 				kills.delete(runId);
@@ -1501,6 +1514,7 @@ export default async function (pi: ExtensionAPI) {
 			})
 			.finally(() => {
 				cleanups.delete(runId);
+				finishing.delete(runId);
 				cleanupStaging();
 				if (o.conversationId) busyHandles.delete(o.conversationId);
 			});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@estebanforge/pi-ask-antigravity",
-  "version": "1.3.0",
+  "version": "1.3.3",
   "description": "Pi tool that delegates a self-contained sub-task to Google Antigravity's agy CLI (the CLI for Gemini). Friendly model aliases (flash/pro/gemini), configurable default model + thinking, and the AskAntigravity delegation tool.",
   "keywords": [
     "pi-package",
@@ -28,7 +28,7 @@
   },
   "type": "module",
   "dependencies": {
-    "@estebanforge/pi-ask-shared": "^0.1.2",
+    "@estebanforge/pi-ask-shared": "^0.1.3",
     "@estebanforge/pi-tui-dialogs": "^0.1.1"
   },
   "files": [
@@ -43,7 +43,7 @@
     ]
   },
   "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "^1.0.0"
+    "@earendil-works/pi-coding-agent": "^1.5.0"
   },
   "peerDependenciesMeta": {
     "@earendil-works/pi-coding-agent": {