@esso0428/pi-subagents 0.17.26 → 0.17.28

package/CHANGELOG.md

@@ -7,6 +7,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.17.28] - 2026-10-02
+
+### Fixed
+- **Stopped the agents widget from stealing arrow keys from `/settings` and other extensions' menus**: v0.17.24 replaced the widget's focus probe with "no modal of ours is open", which is strictly weaker than the check it removed. pi routes terminal input to extension listeners *before* the focused component, and it swaps the prompt editor out for every dialog while `getEditorText()` still reports the detached, empty editor — so the empty-prompt gate passed and the widget consumed `↑`/`↓`/`enter`/`escape` from pi's own `/settings`, from other extensions' selectors such as `qa-ask`, and from our `/agents` menus. Focus detection is restored to `focused == null || focused instanceof Editor`, kept alongside the `withModal()` tracking added in v0.17.25 so our own dialogs are additionally guaranteed priority.
+
+  Roster `↑`/`↓` navigation is consequently inert in installations where this extension resolves its own copy of `@earendil-works/pi-tui` at a different version than pi's host, because the two `Editor` classes are then unrelated objects. That is deliberate: `SettingsList` (what `/settings` focuses) is itself a pi-tui class instance, so no structural probe can tell it apart from the editor, and `setEditorComponent()` lets any extension wrap the editor (`pi-tmux-cursor-focus` subclasses it under tmux), so class identity is the only test that can. Inert is the safe failure — it disables this one feature instead of every other menu in the host.
+
+## [0.17.27] - 2026-10-02
+
+### Fixed
+- **Stopped the agents widget from drawing two tree terminators at once**: v0.17.26 taught the clipped render path to mark the final visible row as `└─`, but the footer's stable-height placeholder for the "scrolled to the end with rows hidden above" case was itself a bare `└─`, so both appeared stacked. That placeholder now reserves the row with blank indentation instead.
+
 ## [0.17.26] - 2026-10-02
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@esso0428/pi-subagents",
-  "version": "0.17.26",
+  "version": "0.17.28",
   "description": "A pi extension that brings smart Claude Code-style autonomous sub-agents to pi, with npm:pi-subagents-style JSON agent overrides.",
   "author": "ESSO0428",
   "repository": {

package/src/ui/agent-widget.ts

@@ -5,7 +5,7 @@
  * Uses the callback form of setWidget for themed rendering.
  */
 
-import { isKeyRelease, Key, matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
+import { Editor, isKeyRelease, Key, matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { AgentManager } from "../agent-manager.js";
 import { getConfig } from "../agent-types.js";
 import type { AgentInvocation, AgentRecord, SubagentType, WidgetMode } from "../types.js";
@@ -394,22 +394,44 @@ export class AgentWidget {
    * Track an AgentWidget-owned modal (the `/agents` menus and friends).
    *
    * The widget's terminal listener runs before the focused component, so while
-   * a modal is open the listener must not claim ↑/↓/enter/escape. Whether pi's
-   * prompt editor currently owns the keyboard is deliberately not consulted:
-   * pi can replace it through `ctx.ui.setEditorComponent()` (for example
-   * pi-tmux-cursor-focus wraps it under tmux), and the extension may also
-   * resolve its own copy of `@earendil-works/pi-tui` at a different version
-   * than the host's. Neither `instanceof` nor a structural probe can identify
-   * the editor reliably in that environment, and a wrong answer silently
-   * disables roster navigation entirely.
+   * a modal is open the listener must not claim ↑/↓/enter/escape.
    */
   setModalOpen(open: boolean): void {
     this.modalDepth = open ? this.modalDepth + 1 : Math.max(0, this.modalDepth - 1);
   }
 
-  /** True when no AgentWidget-owned modal is holding the keyboard. */
-  private keyboardAvailable(): boolean {
-    return this.modalDepth === 0;
+  /**
+   * True when pi's prompt editor owns the keyboard.
+   *
+   * Both halves of this are load-bearing, and both were arrived at the hard way.
+   *
+   * A terminal-input listener runs BEFORE the focused component, and pi swaps
+   * the prompt editor out for every dialog while `getEditorText()` keeps
+   * reporting the detached — empty — editor. Without this guard the widget eats
+   * ↑/↓/enter/escape from `/settings`, from other extensions' pickers, and from
+   * pi's own menus (upstream issue #123). Only the prompt editor may claim keys.
+   *
+   * `focused == null` errs toward the editor so list activation keeps working.
+   * `focused instanceof Editor` is deliberately NOT replaced with a structural
+   * probe: pi's own `/settings` focuses `SettingsList`, a pi-tui class instance,
+   * so no shape test separates it from the editor, and another extension can
+   * wrap the editor through `setEditorComponent()` (pi-tmux-cursor-focus does
+   * exactly that whenever pi runs under tmux), so class identity is the only
+   * test that can.
+   *
+   * That leaves one known failure mode, which is why this is conservative
+   * rather than clever: if this extension resolves its own copy of
+   * `@earendil-works/pi-tui` at a different version than the host's, the two
+   * `Editor` classes are unrelated objects, the check is always false, and
+   * roster ↑/↓ stays inert. Inert is the safe failure — it breaks this one
+   * feature instead of every other menu in the host. Aligning the peer so the
+   * check works is a dependency-graph change in the host project, not something
+   * to paper over here.
+   */
+  private editorHasFocus(): boolean {
+    if (this.modalDepth > 0) return false;
+    const focused = (this.tui as { focusedComponent?: unknown } | undefined)?.focusedComponent;
+    return focused == null || focused instanceof Editor;
   }
 
   private selectedIndexOf(records: readonly AgentRecord[]): number {
@@ -451,7 +473,7 @@ export class AgentWidget {
     if (records.length === 0 || !ui) return false;
 
     if (!this.navigationActive) {
-      if (direction !== 1 || !this.keyboardAvailable() || (ui.getEditorText?.() ?? "") !== "") return false;
+      if (direction !== 1 || !this.editorHasFocus() || (ui.getEditorText?.() ?? "") !== "") return false;
       this.activate(records);
       return true;
     }
@@ -479,7 +501,7 @@ export class AgentWidget {
   /** Handle terminal input before it reaches the focused prompt editor. */
   handleKey(data: string): { consume?: boolean; data?: string } | undefined {
     if (!this.uiCtx || isKeyRelease(data)) return undefined;
-    if (!this.keyboardAvailable()) {
+    if (!this.editorHasFocus()) {
       if (this.navigationActive) this.deactivate();
       return undefined;
     }
@@ -751,8 +773,10 @@ export class AgentWidget {
       } else if (!showTopMore) {
         lines.push(truncate(theme.fg("dim", "└─") + ` ${theme.fg("dim", summary)}`));
       } else {
-        // Keep a stable footer row when the selected viewport reaches the end.
-        lines.push(truncate(theme.fg("dim", "└─")));
+        // Scrolled to the end with rows hidden above. The final visible roster
+        // row already carries the tree terminator, so this row only reserves
+        // height for a stable footer — repeating `└─` would draw two of them.
+        lines.push("   ");
       }
     }