@essential-apps/shopify-test-runner 1.0.21 → 1.0.23

package/src/scripts/runOffline.ts

@@ -559,7 +559,7 @@ async function main(): Promise<void> {
     // `<essential-upsell-app-embed>` to attach or
     // `[data-essential-upsell-funnel-id]` to portal.
     //
-    // Source of truth is `tests/online/.apps.json` — same file the
+    // Source of truth is `tests/online/apps.json` — same file the
     // online tier reads (one app registry, shared across tiers). Each
     // extension entry needs a host-side `rootDir`; we translate it to
     // the VM-side `/workspace/<rel>` path so the orchestrator sees the
@@ -576,7 +576,7 @@ async function main(): Promise<void> {
             .filter((e) => e.rootDir)
             .map((e) => ({
               name: e.name,
-              // rootDir in .apps.json is relative to the consumer repo
+              // rootDir in apps.json is relative to the consumer repo
               // (e.g. `app_extensions/upsells`). Inside the VM, the
               // repo is bind-mounted at `/workspace`.
               rootDir: `/workspace/${e.rootDir!.replace(/^\.?\//, '')}`,
@@ -594,10 +594,10 @@ async function main(): Promise<void> {
           }
         }
       } catch (err) {
-        // .apps.json missing or malformed — skip auto-wiring rather than
+        // apps.json missing or malformed — skip auto-wiring rather than
         // crash. Tests that don't depend on extensions still run.
         console.error(
-          `[runOffline] couldn't auto-load extensions from .apps.json: ${(err as Error).message}`,
+          `[runOffline] couldn't auto-load extensions from apps.json: ${(err as Error).message}`,
         );
       }
     }

package/src/scripts/runOfflineFullTests.ts

@@ -1472,6 +1472,18 @@ async function main(): Promise<void> {
       TEST_OFFLINE_MOCK_CLIENT_ID: MOCK_CLIENT_ID,
       TEST_OFFLINE_MOCK_EDGE_URL: edge.baseUrl,
       TEST_OFFLINE_MOCK_EDGE_PORT: String(edge.port),
+      // Partner API creds — same values as the backend (see backendEnv).
+      // The issue-credit helper (tests/online/lib/issueCredit.ts) now runs
+      // the app's `issueAppCredit` codepath directly in THIS Playwright
+      // process (replacing the old /test-internal/issue-credit route), so
+      // it needs these to init the Partner API client. The request still
+      // resolves to the in-VM partner mock via /etc/hosts + the edge proxy.
+      // Values MUST match backendEnv so the org id lines up with the mock.
+      SHOPIFY_APP_ID: process.env['SHOPIFY_APP_ID'] ?? '999000000',
+      SHOPIFY_PARTNER_ORGANIZATION_ID:
+        process.env['SHOPIFY_PARTNER_ORGANIZATION_ID'] ?? '11111111',
+      SHOPIFY_PARTNER_ACCESS_TOKEN:
+        process.env['SHOPIFY_PARTNER_ACCESS_TOKEN'] ?? 'mock-partner-token',
     };
     // Use async spawn (NOT execSync) — execSync blocks the
     // orchestrator's event loop, so the in-process mock servers

package/src/scripts/runTests.ts

@@ -33,7 +33,7 @@ import { resolve } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { setTimeout as sleep } from 'node:timers/promises';
 import { Agent } from 'undici';
-import { loadEnv, printEnvSummary } from '@essential-apps/shopify-test-core';
+import { loadEnv, pickApp, printEnvSummary } from '@essential-apps/shopify-test-core';
 import { isPortFree } from '../lib/freePort.js';
 
 // Vite serves a self-signed cert in test mode — node:fetch rejects
@@ -159,18 +159,6 @@ async function main(): Promise<void> {
   console.log('[runTests] createdb…');
   execSync(`createdb -h ${PG_HOST} -p ${PG_PORT} ${dbName}`, { stdio: 'inherit' });
 
-  // Per-run secret for the test-internal store-cleanup endpoint.
-  // Generated fresh each run so we never depend on a long-lived
-  // shared secret in .env.test (which used to point at a personal
-  // dev tunnel and broke for any other dev / CI). Both the backend
-  // (validates) and the test process (sends header) see the same
-  // value via backendEnv below.
-  const cleanupSecret = randomUUID();
-  // Backend serves the cleanup endpoint at /test-internal/cleanup-shop.
-  // Reach it via the same localhost URL the test browser uses for
-  // the embedded app — no external tunnel involved.
-  const cleanupUrl = `${env.devAppUrl.replace(/\/$/, '')}/test-internal/cleanup-shop`;
-
   // Hermetic env for the spawned Vite + Playwright. We do NOT inherit
   // Shopify-related secrets from process.env — we hand-build them
   // from .env.test only.
@@ -187,7 +175,7 @@ async function main(): Promise<void> {
     SHOPIFY_API_SECRET: env.apiSecret,
     SCOPES: env.scopes,
     SHOPIFY_APP_URL: env.devAppUrl,
-    // Resolved from .apps.json (or .env.test) by loadEnv(). MUST be
+    // Resolved from apps.json (or .env.test) by loadEnv(). MUST be
     // forwarded: globalSetup.ts + the openApp fixture build the admin
     // deep link `…/apps/${SHOPIFY_APP_HANDLE}` from process.env directly,
     // and without this they fall back to the hardcoded 'essential-app'
@@ -197,20 +185,18 @@ async function main(): Promise<void> {
     SHOPIFY_APP_HANDLE: env.devAppHandle,
     PORT: port,
     HOST: env.devAppUrl,
-    // Store-cleanup wiring (see storePool.ts afterEach). Both the
-    // backend route handler (validates X-Test-Cleanup-Secret) and the
-    // Playwright test process (sends the header) read these.
-    TEST_ONLINE_CLEANUP_SECRET: cleanupSecret,
-    TEST_ONLINE_STORE_CLEANUP_URL: cleanupUrl,
     // Theme app extension UUID — relevant for apps with theme app
-    // extensions (essential-upsell). Without this, vite/remix loads
-    // the dev-app value from .env (since vite/remix auto-loads .env
-    // even with NODE_ENV=test), so the Activate deep link points at
-    // the wrong extension and isAppEmbedActive never matches.
-    // Harmless no-op for apps that don't use this var.
-    ...(process.env['SHOPIFY_UPSELLS_ID']
-      ? { SHOPIFY_UPSELLS_ID: process.env['SHOPIFY_UPSELLS_ID'] }
-      : {}),
+    // extensions (essential-upsell), sourced from tests/online/apps.json
+    // (extensions[].uuid) — the single source, NOT env. Without this the
+    // Activate deep link points at the wrong extension and
+    // isAppEmbedActive never matches. Harmless no-op for apps with no
+    // theme extension in apps.json.
+    ...(() => {
+      const uuid = pickApp().extensions?.find(
+        (e) => e.rootDir?.includes('upsells') || e.name === 'upsells',
+      )?.uuid;
+      return uuid ? { SHOPIFY_UPSELLS_ID: uuid } : {};
+    })(),
   };
 
   console.log('[runTests] prisma migrate deploy…');

package/src/scripts/runVm.ts

@@ -480,10 +480,9 @@ async function main(): Promise<void> {
       'TEST_VISIBLE',
       'TEST_WORKERS',
       'TEST_PRESERVE_DB',
-      // TEST_ONLINE_STORE_CLEANUP_URL / TEST_ONLINE_CLEANUP_SECRET intentionally not
-      // forwarded — runTests.ts generates the secret per-run and
-      // builds the URL from devAppUrl. Forwarding stale values from
-      // .env.test would override that.
+      // Store seed/cleanup no longer ride env vars — they're app-owned
+      // Prisma helpers registered via setStoreHooks (see storePool.ts),
+      // so there's nothing cleanup-related to forward here.
       'TEST_OFFLINE_STRICT_GRAPHQL',
       // TEST_FORCE_REAL_CHROME: storePool flips chromium.launch to
       // `channel: 'chrome'` (real Google Chrome amd64 installed in