@esri/solution-deployer 1.3.10 → 1.3.13

package/dist/node/deployerUtils.js

@@ -76,6 +76,7 @@ exports.updateDeployOptions = updateDeployOptions;
  * Check if an object is an Model
  *
  * @param obj any object
+ * @private
  */
 function _isModel(obj) {
     let result = false;

package/dist/node/deployerUtils.js.map

@@ -1 +1 @@
-{"version":3,"file":"deployerUtils.js","sourceRoot":"","sources":["../../src/deployerUtils.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;GAcG;;;;AAEH,sEAAgD;AAEhD;;;;;;GAMG;AACH,SAAgB,uBAAuB,CACrC,UAAe,EACf,cAAkC;IAElC,IAAI,OAAO,UAAU,KAAK,QAAQ,EAAE;QAClC,sBAAsB;QACtB,OAAO,OAAO,CAAC,GAAG,CAAC;YACjB,MAAM,CAAC,WAAW,CAAC,UAAU,EAAE,cAAc,CAAC;YAC9C,MAAM,CAAC,iBAAiB,CAAC,UAAU,EAAE,cAAc,CAAC;SACrD,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,EAAE;YACvB,6CAA6C;YAC7C,OAAO,MAAM,CAAC,aAAa,CAAC;gBAC1B,IAAI;gBACJ,IAAI;aACL,CAAC,CAAC;QACL,CAAC,CAAC,CAAC;KACJ;SAAM;QACL,2BAA2B;QAC3B,IAAI,QAAQ,CAAC,UAAU,CAAC,EAAE;YACxB,iBAAiB;YACjB,OAAO,MAAM,CAAC,aAAa,CAAC,UAAU,CAAC,CAAC;SACzC;aAAM;YACL,OAAO,OAAO,CAAC,MAAM,CACnB,MAAM,CAAC,IAAI,CACT,qEAAqE,CACtE,CACF,CAAC;SACH;KACF;AACH,CAAC;AA7BD,0DA6BC;AAED;;;;;;;GAOG;AACH,SAAgB,mBAAmB,CACjC,aAAkB,EAClB,IAAkB,EAClB,cAAkC;IAElC,aAAa,CAAC,KAAK,GAAG,aAAa,CAAC,KAAK,IAAI,IAAI,CAAC,EAAE,CAAC;IACrD,aAAa,CAAC,KAAK,GAAG,aAAa,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC;IACxD,aAAa,CAAC,OAAO,GAAG,aAAa,CAAC,OAAO,IAAI,IAAI,CAAC,OAAO,CAAC;IAC9D,aAAa,CAAC,WAAW,GAAG,aAAa,CAAC,WAAW,IAAI,IAAI,CAAC,WAAW,CAAC;IAC1E,aAAa,CAAC,IAAI,GAAG,aAAa,CAAC,IAAI,IAAI,IAAI,CAAC,IAAI,CAAC;IACrD,wBAAwB;IACxB,aAAa,CAAC,YAAY,GAAG,IAAI,CAAC,SAAS;QACzC,CAAC,CAAC,MAAM,CAAC,mBAAmB,CAAC,IAAI,CAAC,EAAE,EAAE,IAAI,CAAC,SAAS,EAAE,KAAK,EAAE,cAAc,CAAC;QAC5E,CAAC,CAAC,IAAI,CAAC;IAET,OAAO,aAAa,CAAC;AACvB,CAAC;AAhBD,kDAgBC;AAED;;;;GAIG;AACH,SAAgB,QAAQ,CAAC,GAAQ;IAC/B,IAAI,MAAM,GAAG,KAAgB,CAAC;IAC9B,0BAA0B;IAC1B,MAAM,kBAAkB,GAAG,CAAC,CAAM,EAAW,EAAE,CAC7C,CAAC,IAAI,IAAI;QACT,OAAO,CAAC,KAAK,QAAQ;QACrB,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC;QACjB,OAAO,CAAC,KAAK,QAAQ,CAAC;IAExB,IAAI,kBAAkB,CAAC,GAAG,CAAC,EAAE;QAC3B,MAAM,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,EAAE;YAC7C,IAAI,GAAG,EAAE;gBACP,GAAG,GAAG,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;aACrC;YACD,OAAO,GAAG,CAAC;QACb,CAAC,EAAE,IAAe,CAAC,CAAC;KACrB;IACD,OAAO,MAAM,CAAC;AAChB,CAAC;AAlBD,4BAkBC;AAED;;;;;GAKG;AACH,SAAgB,sBAAsB,CAAC,IAAkB;IACvD,MAAM,IAAI,GAAG,IAAI,CAAC,YAAY,CAAC;IAC/B,iBAAiB;IACjB,IAAI,MAAM,GAAG,KAAK,CAAC;IACnB,IAAI,IAAI,CAAC,IAAI,KAAK,UAAU,EAAE;QAC5B,IACE,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC;YAC7B,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,OAAO,CAAC,kBAAkB,CAAC,GAAG,CAAC,CAAC,CAAC,EACxE;YACA,MAAM,GAAG,IAAI,CAAC;SACf;KACF;IACD,yDAAyD;IACzD,IAAI,IAAI,CAAC,IAAI,KAAK,yBAAyB,EAAE;QAC3C,IAAI,IAAI,CAAC,OAAO,CAAC,qBAAqB,CAAC,GAAG,CAAC,CAAC,EAAE;YAC5C,MAAM,GAAG,IAAI,CAAC;SACf;KACF;IACD,OAAO,MAAM,CAAC;AAChB,CAAC;AAnBD,wDAmBC"}
+{"version":3,"file":"deployerUtils.js","sourceRoot":"","sources":["../../src/deployerUtils.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;GAcG;;;;AAEH,sEAAgD;AAEhD;;;;;;GAMG;AACH,SAAgB,uBAAuB,CACrC,UAAe,EACf,cAAkC;IAElC,IAAI,OAAO,UAAU,KAAK,QAAQ,EAAE;QAClC,sBAAsB;QACtB,OAAO,OAAO,CAAC,GAAG,CAAC;YACjB,MAAM,CAAC,WAAW,CAAC,UAAU,EAAE,cAAc,CAAC;YAC9C,MAAM,CAAC,iBAAiB,CAAC,UAAU,EAAE,cAAc,CAAC;SACrD,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,EAAE;YACvB,6CAA6C;YAC7C,OAAO,MAAM,CAAC,aAAa,CAAC;gBAC1B,IAAI;gBACJ,IAAI;aACL,CAAC,CAAC;QACL,CAAC,CAAC,CAAC;KACJ;SAAM;QACL,2BAA2B;QAC3B,IAAI,QAAQ,CAAC,UAAU,CAAC,EAAE;YACxB,iBAAiB;YACjB,OAAO,MAAM,CAAC,aAAa,CAAC,UAAU,CAAC,CAAC;SACzC;aAAM;YACL,OAAO,OAAO,CAAC,MAAM,CACnB,MAAM,CAAC,IAAI,CACT,qEAAqE,CACtE,CACF,CAAC;SACH;KACF;AACH,CAAC;AA7BD,0DA6BC;AAED;;;;;;;GAOG;AACH,SAAgB,mBAAmB,CACjC,aAAkB,EAClB,IAAkB,EAClB,cAAkC;IAElC,aAAa,CAAC,KAAK,GAAG,aAAa,CAAC,KAAK,IAAI,IAAI,CAAC,EAAE,CAAC;IACrD,aAAa,CAAC,KAAK,GAAG,aAAa,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC;IACxD,aAAa,CAAC,OAAO,GAAG,aAAa,CAAC,OAAO,IAAI,IAAI,CAAC,OAAO,CAAC;IAC9D,aAAa,CAAC,WAAW,GAAG,aAAa,CAAC,WAAW,IAAI,IAAI,CAAC,WAAW,CAAC;IAC1E,aAAa,CAAC,IAAI,GAAG,aAAa,CAAC,IAAI,IAAI,IAAI,CAAC,IAAI,CAAC;IACrD,wBAAwB;IACxB,aAAa,CAAC,YAAY,GAAG,IAAI,CAAC,SAAS;QACzC,CAAC,CAAC,MAAM,CAAC,mBAAmB,CAAC,IAAI,CAAC,EAAE,EAAE,IAAI,CAAC,SAAS,EAAE,KAAK,EAAE,cAAc,CAAC;QAC5E,CAAC,CAAC,IAAI,CAAC;IAET,OAAO,aAAa,CAAC;AACvB,CAAC;AAhBD,kDAgBC;AAED;;;;;GAKG;AACH,SAAgB,QAAQ,CAAC,GAAQ;IAC/B,IAAI,MAAM,GAAG,KAAgB,CAAC;IAC9B,0BAA0B;IAC1B,MAAM,kBAAkB,GAAG,CAAC,CAAM,EAAW,EAAE,CAC7C,CAAC,IAAI,IAAI;QACT,OAAO,CAAC,KAAK,QAAQ;QACrB,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC;QACjB,OAAO,CAAC,KAAK,QAAQ,CAAC;IAExB,IAAI,kBAAkB,CAAC,GAAG,CAAC,EAAE;QAC3B,MAAM,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,EAAE;YAC7C,IAAI,GAAG,EAAE;gBACP,GAAG,GAAG,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC;aACrC;YACD,OAAO,GAAG,CAAC;QACb,CAAC,EAAE,IAAe,CAAC,CAAC;KACrB;IACD,OAAO,MAAM,CAAC;AAChB,CAAC;AAlBD,4BAkBC;AAED;;;;;GAKG;AACH,SAAgB,sBAAsB,CAAC,IAAkB;IACvD,MAAM,IAAI,GAAG,IAAI,CAAC,YAAY,CAAC;IAC/B,iBAAiB;IACjB,IAAI,MAAM,GAAG,KAAK,CAAC;IACnB,IAAI,IAAI,CAAC,IAAI,KAAK,UAAU,EAAE;QAC5B,IACE,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC;YAC7B,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,OAAO,CAAC,kBAAkB,CAAC,GAAG,CAAC,CAAC,CAAC,EACxE;YACA,MAAM,GAAG,IAAI,CAAC;SACf;KACF;IACD,yDAAyD;IACzD,IAAI,IAAI,CAAC,IAAI,KAAK,yBAAyB,EAAE;QAC3C,IAAI,IAAI,CAAC,OAAO,CAAC,qBAAqB,CAAC,GAAG,CAAC,CAAC,EAAE;YAC5C,MAAM,GAAG,IAAI,CAAC;SACf;KACF;IACD,OAAO,MAAM,CAAC;AAChB,CAAC;AAnBD,wDAmBC"}

package/dist/umd/deploySolutionFromTemplate.d.ts

@@ -19,7 +19,7 @@ export declare function deploySolutionFromTemplate(templateSolutionId: string, s
  * Add source-id to items/groups typeKeywords
  *
  * @param template the array of solution data templates
- * @internal
+ * @private
  */
 export declare function _addSourceId(templates: common.IItemTemplate[]): common.IItemTemplate[];
 /**
@@ -29,7 +29,7 @@ export declare function _addSourceId(templates: common.IItemTemplate[]): common.
  * @param sourceInfo
  * @param authentication
  * @param isGroup Boolean to indicate if the files are associated with a group or item
- * @internal
+ * @private
  */
 export declare function _applySourceToDeployOptions(deployOptions: common.IDeploySolutionOptions, solutionTemplateBase: any, templateDictionary: any, authentication: common.UserSession): common.IDeploySolutionOptions;
 export declare function _replaceParamVariables(solutionTemplateData: any, templateDictionary: any): void;
@@ -43,6 +43,6 @@ export declare function _purgeTemplateProperties(itemTemplate: any): any;
  *
  * @param id Id to look for
  * @param templateDictionary Hash mapping property names to replacement values
- * @return Match in template dictionary or original id
+ * @returns Match in template dictionary or original id
  */
 export declare function _getNewItemId(id: string, templateDictionary: any): string;

package/dist/umd/deploySolutionItems.d.ts

@@ -30,7 +30,7 @@ import * as common from "@esri/solution-common";
  * @param deployedSolutionId Id of deployed Solution item
  * @param destinationAuthentication Credentials for the destination organization
  * @param options Options to tune deployment
- * @return A promise that will resolve with the list of information about the created items
+ * @returns A promise that will resolve with the list of information about the created items
  */
 export declare function deploySolutionItems(portalSharingUrl: string, storageItemId: string, templates: common.IItemTemplate[], storageAuthentication: common.UserSession, templateDictionary: any, deployedSolutionId: string, destinationAuthentication: common.UserSession, options: common.IDeploySolutionOptions): Promise<common.ICreateItemFromTemplateResponse[]>;
 /**
@@ -39,6 +39,7 @@ export declare function deploySolutionItems(portalSharingUrl: string, storageIte
  * @param itemsToBePatched List of items that need to have their dependencies patched
  * @param templateDictionary Hash of facts: org URL, adlib replacements
  * @param templates A collection of AGO item templates
+ * @private
  */
 export declare function _flagPatchItemsForPostProcessing(itemsToBePatched: common.IKeyedListsOfStrings, templateDictionary: any, templates: common.ICreateItemFromTemplateResponse[]): void;
 /**
@@ -49,7 +50,7 @@ export declare function _flagPatchItemsForPostProcessing(itemsToBePatched: commo
  * @param templates a collection of AGO item templates
  *
  * @returns An updated array of item templates
- *
+ * @private
  */
 export declare function _evaluateSharedViewSources(templates: common.IItemTemplate[]): common.IItemTemplate[];
 /**
@@ -61,7 +62,7 @@ export declare function _evaluateSharedViewSources(templates: common.IItemTempla
  * @param views an array of view template details
  *
  * @returns An updated array of item templates
- *
+ * @private
  */
 export declare function _updateViewTemplates(templates: common.IItemTemplate[], views: any[]): common.IItemTemplate[];
 /**
@@ -72,7 +73,7 @@ export declare function _updateViewTemplates(templates: common.IItemTemplate[],
  * @returns an array of objects with the source FS id as the key and a list of views that are
  * dependant upon it
  *
- * @protected
+ * @private
  */
 export declare function _getViewHash(views: any[]): any;
 /**
@@ -82,7 +83,7 @@ export declare function _getViewHash(views: any[]): any;
  *
  * @returns an array with the view id and its dependencies
  *
- * @protected
+ * @private
  */
 export declare function _getViews(templates: common.IItemTemplate[]): any[];
 /**
@@ -95,7 +96,7 @@ export declare function _getViews(templates: common.IItemTemplate[]): any[];
  *
  * @returns A Promise that will resolve once existing items have been evaluated
  *
- * @protected
+ * @private
  */
 export declare function _reuseDeployedItems(templates: common.IItemTemplate[], reuseItems: boolean, templateDictionary: any, authentication: common.UserSession): Promise<any>;
 /**
@@ -116,7 +117,7 @@ export declare function _reuseDeployedItems(templates: common.IItemTemplate[], r
  *
  * @returns A Promise that will resolve once existing items have been evaluated
  *
- * @protected
+ * @private
  */
 export declare function _useExistingItems(templates: common.IItemTemplate[], useExisting: boolean, templateDictionary: any, authentication: common.UserSession): Promise<any>;
 /**
@@ -128,7 +129,8 @@ export declare function _useExistingItems(templates: common.IItemTemplate[], use
  * @param sourceIdHash key value pairs..actual itemId is the key and the source itemId is the value
  * @param authentication credentials for the requests
  *
- * @return a promise to indicate when the requests are complete
+ * @returns a promise to indicate when the requests are complete
+ * @private
  */
 export declare function _setTypekeywordForExisting(itemDefs: Array<Promise<any>>, sourceIdHash: any, authentication: common.UserSession): Promise<any>;
 /**
@@ -137,7 +139,7 @@ export declare function _setTypekeywordForExisting(itemDefs: Array<Promise<any>>
  * @param templates A collection of AGO item templates
  * @param templateDictionary Hash of facts: org URL, adlib replacements, deferreds for dependencies
  *
- * @protected
+ * @private
  */
 export declare function _updateTemplateDictionary(templates: common.IItemTemplate[], templateDictionary: any, authentication: common.UserSession): Promise<any>;
 /**
@@ -148,7 +150,7 @@ export declare function _updateTemplateDictionary(templates: common.IItemTemplat
  * @param layerId the id for the layer
  * @param fields the fields to transfer
  *
- * @protected
+ * @private
  */
 export declare function _setFields(templateDictionary: any, itemId: string, layerId: string, fields: any[]): void;
 /**
@@ -161,7 +163,7 @@ export declare function _setFields(templateDictionary: any, itemId: string, laye
  * @param result the service request result
  * @param templateDictionary Hash of facts: org URL, adlib replacements, deferreds for dependencies
  *
- * @protected
+ * @private
  */
 export declare function _updateTemplateDictionaryForError(templateDictionary: any, itemId: string): any;
 /**
@@ -171,8 +173,8 @@ export declare function _updateTemplateDictionaryForError(templateDictionary: an
  * @param templateDictionary Hash of facts: org URL, adlib replacements, deferreds for dependencies
  * @param authentication Credentials for the request
  * @param addTagQuery Boolean to indicate if a search by tag should happen
- * @return A promise that will resolve with an array of results
- * @protected
+ * @returns A promise that will resolve with an array of results
+ * @private
  */
 export declare function _handleExistingItems(existingItemsResponse: any[], templateDictionary: any, authentication: common.UserSession, addTagQuery: boolean): Array<Promise<any>>;
 export declare function _updateTemplateDictionaryById(templateDictionary: any, sourceId: string, itemId: string, v: any): void;
@@ -181,8 +183,8 @@ export declare function _updateTemplateDictionaryById(templateDictionary: any, s
  *
  * @param query Query string to use
  * @param authentication Credentials for the request
- * @return A promise that will resolve with an array of results
- * @protected
+ * @returns A promise that will resolve with an array of results
+ * @private
  */
 export declare function _findExistingItemByKeyword(templates: common.IItemTemplate[], templateDictionary: any, authentication: common.UserSession): Array<Promise<any>>;
 /**
@@ -190,8 +192,8 @@ export declare function _findExistingItemByKeyword(templates: common.IItemTempla
  *
  * @param query Query string to use
  * @param authentication Credentials for the request
- * @return A promise that will resolve with an array of results
- * @protected
+ * @returns A promise that will resolve with an array of results
+ * @private
  */
 export declare function _findExistingItem(query: string, authentication: common.UserSession): Promise<any>;
 /**
@@ -202,17 +204,17 @@ export declare function _findExistingItem(query: string, authentication: common.
  * @param templateDictionary Hash of facts: org URL, adlib replacements, deferreds for dependencies
  * @param userSession Options for the request
  * @param itemProgressCallback Function for reporting progress updates from type-specific template handlers
- * @return A promise that will resolve with the id of the deployed item (which is simply returned if it's
+ * @returns A promise that will resolve with the id of the deployed item (which is simply returned if it's
  *         already in the templates list
- * @protected
+ * @private
  */
 export declare function _createItemFromTemplateWhenReady(template: common.IItemTemplate, resourceFilePaths: common.IDeployFileCopyPath[], storageAuthentication: common.UserSession, templateDictionary: any, destinationAuthentication: common.UserSession, itemProgressCallback: common.IItemProgressCallback): Promise<common.ICreateItemFromTemplateResponse>;
 /**
  * Accumulates the estimated deployment cost of a set of templates.
  *
  * @param templates Templates to examine
- * @return Sum of estimated deployment costs
- * @protected
+ * @returns Sum of estimated deployment costs
+ * @private
  */
 export declare function _estimateDeploymentCost(templates: common.IItemTemplate[]): number;
 export declare function _getGroupUpdates(template: common.IItemTemplate, authentication: common.UserSession, templateDictionary: any): Array<Promise<any>>;

package/dist/umd/deployer.d.ts

@@ -29,6 +29,6 @@ import { IModel } from "@esri/hub-common";
  * @param maybeModel Item Id or IModel
  * @param authentication Credentials for the destination organization
  * @param options Options to override deployed information and to provide additional credentials
- * @return The id of the created deployed solution item
+ * @returns The id of the created deployed solution item
  */
 export declare function deploySolution(maybeModel: string | IModel, authentication: common.UserSession, options?: common.IDeploySolutionOptions): Promise<string>;

package/dist/umd/deployer.umd.js

@@ -1,7 +1,7 @@
 /* @preserve
-* @esri/solution-deployer - v1.3.10 - Apache-2.0
+* @esri/solution-deployer - v1.3.13 - Apache-2.0
 * Copyright (c) 2018-2022 Esri, Inc.
-* Tue Mar 29 2022 11:39:49 GMT-0700 (Pacific Daylight Time)
+* Tue Apr 26 2022 15:05:39 GMT-0700 (Pacific Daylight Time)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -256,7 +256,7 @@
    * @param deployedSolutionId Id of deployed Solution item
    * @param destinationAuthentication Credentials for the destination organization
    * @param options Options to tune deployment
-   * @return A promise that will resolve with the list of information about the created items
+   * @returns A promise that will resolve with the list of information about the created items
    */
   function deploySolutionItems(portalSharingUrl, storageItemId, templates, storageAuthentication, templateDictionary, deployedSolutionId, destinationAuthentication, options) {
       return new Promise((resolve, reject) => {
@@ -358,6 +358,7 @@
    * @param itemsToBePatched List of items that need to have their dependencies patched
    * @param templateDictionary Hash of facts: org URL, adlib replacements
    * @param templates A collection of AGO item templates
+   * @private
    */
   function _flagPatchItemsForPostProcessing(itemsToBePatched, templateDictionary, templates) {
       let itemIdsToBePatched = Object.keys(itemsToBePatched);
@@ -382,7 +383,7 @@
    * @param templates a collection of AGO item templates
    *
    * @returns An updated array of item templates
-   *
+   * @private
    */
   function _evaluateSharedViewSources(templates) {
       // update the templates so we can defer the deployment when more than one view shares the same source
@@ -428,7 +429,7 @@
    * @param views an array of view template details
    *
    * @returns An updated array of item templates
-   *
+   * @private
    */
   function _updateViewTemplates(templates, views) {
       views.forEach(v => {
@@ -461,7 +462,7 @@
    * @returns an array of objects with the source FS id as the key and a list of views that are
    * dependant upon it
    *
-   * @protected
+   * @private
    */
   function _getViewHash(views) {
       const viewHash = {};
@@ -485,7 +486,7 @@
    *
    * @returns an array with the view id and its dependencies
    *
-   * @protected
+   * @private
    */
   function _getViews(templates) {
       return templates.reduce((acc, v) => {
@@ -509,7 +510,7 @@
    *
    * @returns A Promise that will resolve once existing items have been evaluated
    *
-   * @protected
+   * @private
    */
   function _reuseDeployedItems(templates, reuseItems, templateDictionary, authentication) {
       return new Promise((resolve, reject) => {
@@ -547,7 +548,7 @@
    *
    * @returns A Promise that will resolve once existing items have been evaluated
    *
-   * @protected
+   * @private
    */
   function _useExistingItems(templates, useExisting, templateDictionary, authentication) {
       return new Promise(resolve => {
@@ -590,7 +591,8 @@
    * @param sourceIdHash key value pairs..actual itemId is the key and the source itemId is the value
    * @param authentication credentials for the requests
    *
-   * @return a promise to indicate when the requests are complete
+   * @returns a promise to indicate when the requests are complete
+   * @private
    */
   function _setTypekeywordForExisting(itemDefs, sourceIdHash, authentication) {
       return new Promise(resolve => {
@@ -631,7 +633,7 @@
    * @param templates A collection of AGO item templates
    * @param templateDictionary Hash of facts: org URL, adlib replacements, deferreds for dependencies
    *
-   * @protected
+   * @private
    */
   function _updateTemplateDictionary(templates, templateDictionary, authentication) {
       return new Promise(resolve => {
@@ -757,7 +759,7 @@
    * @param layerId the id for the layer
    * @param fields the fields to transfer
    *
-   * @protected
+   * @private
    */
   function _setFields(templateDictionary, itemId, layerId, fields) {
       const layerInfo = common__namespace.getProp(templateDictionary, `${itemId}.layer${layerId}`);
@@ -776,7 +778,7 @@
    * @param result the service request result
    * @param templateDictionary Hash of facts: org URL, adlib replacements, deferreds for dependencies
    *
-   * @protected
+   * @private
    */
   function _updateTemplateDictionaryForError(templateDictionary, itemId) {
       /* istanbul ignore else */
@@ -803,8 +805,8 @@
    * @param templateDictionary Hash of facts: org URL, adlib replacements, deferreds for dependencies
    * @param authentication Credentials for the request
    * @param addTagQuery Boolean to indicate if a search by tag should happen
-   * @return A promise that will resolve with an array of results
-   * @protected
+   * @returns A promise that will resolve with an array of results
+   * @private
    */
   function _handleExistingItems(existingItemsResponse, templateDictionary, authentication, addTagQuery) {
       // if items are not found by type keyword search by tag
@@ -842,6 +844,7 @@
       }
       return existingItemsByTag;
   }
+  //???
   function _updateTemplateDictionaryById(templateDictionary, sourceId, itemId, v) {
       templateDictionary[sourceId] = Object.assign(templateDictionary[sourceId] || {}, {
           def: Promise.resolve(common__namespace.generateEmptyCreationResponse(v.type, itemId)),
@@ -856,8 +859,8 @@
    *
    * @param query Query string to use
    * @param authentication Credentials for the request
-   * @return A promise that will resolve with an array of results
-   * @protected
+   * @returns A promise that will resolve with an array of results
+   * @private
    */
   function _findExistingItemByKeyword(templates, templateDictionary, authentication) {
       const existingItemsDefs = [];
@@ -888,8 +891,8 @@
    *
    * @param query Query string to use
    * @param authentication Credentials for the request
-   * @return A promise that will resolve with an array of results
-   * @protected
+   * @returns A promise that will resolve with an array of results
+   * @private
    */
   function _findExistingItem(query, authentication) {
       const searchOptions = {
@@ -907,9 +910,9 @@
    * @param templateDictionary Hash of facts: org URL, adlib replacements, deferreds for dependencies
    * @param userSession Options for the request
    * @param itemProgressCallback Function for reporting progress updates from type-specific template handlers
-   * @return A promise that will resolve with the id of the deployed item (which is simply returned if it's
+   * @returns A promise that will resolve with the id of the deployed item (which is simply returned if it's
    *         already in the templates list
-   * @protected
+   * @private
    */
   function _createItemFromTemplateWhenReady(template, resourceFilePaths, storageAuthentication, templateDictionary, destinationAuthentication, itemProgressCallback) {
       // ensure this is present
@@ -1008,14 +1011,15 @@
    * Accumulates the estimated deployment cost of a set of templates.
    *
    * @param templates Templates to examine
-   * @return Sum of estimated deployment costs
-   * @protected
+   * @returns Sum of estimated deployment costs
+   * @private
    */
   function _estimateDeploymentCost(templates) {
       return templates.reduce((accumulatedEstimatedCost, template) => {
           return (accumulatedEstimatedCost + (template.estimatedDeploymentCostFactor || 1));
       }, 0);
   }
+  //???
   // TODO: Return a Promise vs array of promises
   function _getGroupUpdates(template, authentication, templateDictionary) {
       const groups = template.groups || [];
@@ -1327,7 +1331,7 @@
    * Add source-id to items/groups typeKeywords
    *
    * @param template the array of solution data templates
-   * @internal
+   * @private
    */
   function _addSourceId(templates) {
       return templates.map((template) => {
@@ -1347,7 +1351,7 @@
    * @param sourceInfo
    * @param authentication
    * @param isGroup Boolean to indicate if the files are associated with a group or item
-   * @internal
+   * @private
    */
   function _applySourceToDeployOptions(deployOptions, solutionTemplateBase, templateDictionary, authentication) {
       // Deploy a solution from the template's contents,
@@ -1367,6 +1371,7 @@
       }
       return deployOptions;
   }
+  //???
   function _replaceParamVariables(solutionTemplateData, templateDictionary) {
       // a custom params object can be passed in with the options to deploy a solution
       // in most cases we can defer to the item type handlers to use these values
@@ -1387,6 +1392,7 @@
           return template;
       });
   }
+  //???
   function _updateProp(template, path, lookup, templateDictionary) {
       const wkid = common__namespace.getProp(template, path);
       /* istanbul ignore else */
@@ -1395,6 +1401,7 @@
       }
       return template;
   }
+  //???
   function _checkedReplaceAll(template, oldValue, newValue) {
       let newTemplate;
       if (template && template.indexOf(oldValue) > -1) {
@@ -1406,6 +1413,7 @@
       }
       return newTemplate;
   }
+  //???
   function _getPortalBaseUrl(portalResponse, authentication) {
       // As of Spring 2020, only HTTPS (see
       // https://www.esri.com/arcgis-blog/products/product/administration/2019-arcgis-transport-security-improvements/)
@@ -1419,6 +1427,7 @@
               ? `${scheme}://${enterpriseBaseUrl}`
               : authentication.portal.replace("/sharing/rest", "");
   }
+  //???
   function _updateGroupReferences(itemTemplates, templateDictionary) {
       const groupIds = itemTemplates.reduce((result, t) => {
           if (t.type === "Group") {
@@ -1436,6 +1445,7 @@
       });
       return itemTemplates;
   }
+  //???
   function _purgeTemplateProperties(itemTemplate) {
       const retainProps = ["itemId", "type", "dependencies", "groups"];
       const deleteProps = Object.keys(itemTemplate).filter(k => retainProps.indexOf(k) < 0);
@@ -1514,6 +1524,7 @@
    * Check if an object is an Model
    *
    * @param obj any object
+   * @private
    */
   function _isModel(obj) {
       let result = false;
@@ -1581,7 +1592,7 @@
    * @param maybeModel Item Id or IModel
    * @param authentication Credentials for the destination organization
    * @param options Options to override deployed information and to provide additional credentials
-   * @return The id of the created deployed solution item
+   * @returns The id of the created deployed solution item
    */
   function deploySolution(maybeModel, authentication, options) {
       // if we are not passed the maybeModel, reject