@esri/solution-common 6.6.1-next.80 → 6.6.1-next.81

package/dist/cjs/featureServiceHelpers.d.ts

@@ -164,9 +164,12 @@ export declare function getLayerSettings(layerInfos: any, url: string, itemId: s
  * The feature service name will have a generated GUID appended.
  *
  * @param templates A collection of AGO item templates.
+ * @param templateDictionary Optional hash of values used to resolve `{{...}}` tokens in the name
+ *   before applying the 50-char base-name limit. When omitted, names containing unresolved tokens
+ *   are passed through untruncated (legacy behavior).
  * @returns An updated collection of AGO templates with unique feature service names.
  */
-export declare function setNamesAndTitles(templates: IItemTemplate[]): IItemTemplate[];
+export declare function setNamesAndTitles(templates: IItemTemplate[], templateDictionary?: any): IItemTemplate[];
 /**
  * This is used when deploying views.
  * We need to update fields referenced in adminLayerInfo for relationships prior to deploying the view.
@@ -243,6 +246,28 @@ export declare function getExistingLayersAndTables(url: string, ids: number[], a
  * @private
  */
 export declare function addFeatureServiceLayersAndTables(itemTemplate: IItemTemplate, templateDictionary: any, popupInfos: IPopupInfos, authentication: UserSession): Promise<void>;
+/**
+ * Shorten any layer or table name longer than `maxNameLength` to a unique value of at most
+ * `maxNameLength` characters, in preparation for an addToDefinition call, and report the original
+ * names so they can be restored afterward.
+ *
+ * Mutates the `name` of each over-long layer/table in `layerChunks` in place.
+ *
+ * @param layerChunks The addToDefinition chunks whose `layers` and `tables` will be added
+ * @param maxNameLength Names longer than this are truncated to a unique value of this length
+ * @returns The original names to restore, as `{ layers: [{ id, name }], tables: [{ id, name }] }`
+ * @private
+ */
+export declare function _truncateNamesForAddToDefinition(layerChunks: any[], maxNameLength: number): {
+    layers: Array<{
+        id: any;
+        name: string;
+    }>;
+    tables: Array<{
+        id: any;
+        name: string;
+    }>;
+};
 /**
  * Updates a feature service with a list of layers and/or tables.
  *

package/dist/cjs/featureServiceHelpers.js

@@ -15,8 +15,8 @@
  * limitations under the License.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports._validateEditFieldsInfo = exports._validateTypesTemplates = exports._validateTemplatesFields = exports._validateIndexes = exports._validateDisplayField = exports._validateFields = exports._templatizeLayer = exports._templatizeProperty = exports._templatize = exports.updatePopupInfo = exports._validateViewDomainFields = exports.postProcessFields = exports.updateLayerFieldReferences = exports._getSourceSpatialReferenceAndExtent = exports.validateSpatialReferenceAndExtent = exports.setDefaultSpatialReference = exports._updateTemplateDictionaryFields = exports._updateGeomFieldName = exports._updateSourceLayerFields = exports._updateItemFields = exports._getDynamicFieldNames = exports._getFieldNames = exports._updateForPortal = exports.removeLayerOptimization = exports._isSelfReferential = exports._updateAddOptions = exports._updateOrder = exports.addFeatureServiceDefinition = exports.addFeatureServiceLayersAndTables = exports.getExistingLayersAndTables = exports.getLayersAndTables = exports.deTemplatizeFieldInfos = exports.processContingentValues = exports.updateTemplateForInvalidDesignations = exports.updateSettingsFieldInfos = exports.setNamesAndTitles = exports.getLayerSettings = exports._setTrackingViewLayerSettings = exports._updateTypeKeywords = exports.updateTemplate = exports.cacheLayerInfo = exports._cachePopupInfo = exports.cachePopupInfos = exports._cacheFieldInfo = exports.cacheIndexes = exports.cacheContingentValues = exports.cacheFieldInfos = exports.deleteViewProps = exports.templatize = exports.getFeatureServiceRelatedRecords = void 0;
-exports._getLayerChunkSize = exports._getNameMapping = exports._templatizeDefinitionQuery = exports._templatizeTimeInfo = exports._templatizeKeys = exports._templatizeTypeTemplates = exports._templatizeTemplates = exports._templatizeLabelingInfo = exports._templatizeArcadeExpressions = exports._templatizeAuthoringInfo = exports._templatizeTemporalRenderer = exports._templatizeGenRenderer = exports._templatizeRenderer = exports._templatizeDrawingInfo = exports._templatizeSimpleName = exports._templatizeDefinitionExpression = exports._templatizeDefinitionEditor = exports._templatizeMediaInfos = exports._templatizePopupElements = exports._templatizeExpressionInfos = exports._templatizeFieldName = exports._templatizePopupInfoFieldInfos = exports._templatizeName = exports._templatizePopupInfo = exports._templatizeRelationshipFields = exports._templatizeTopFilter = exports._templatizeAdminSourceLayerFields = exports._getDependantItemId = exports._templatizeAdminLayerInfoFields = exports._templatizeSourceServiceName = exports._processAdminObject = exports._templatizeAdminLayerInfo = exports._templatizeLayerFieldReferences = void 0;
+exports._validateTypesTemplates = exports._validateTemplatesFields = exports._validateIndexes = exports._validateDisplayField = exports._validateFields = exports._templatizeLayer = exports._templatizeProperty = exports._templatize = exports.updatePopupInfo = exports._validateViewDomainFields = exports.postProcessFields = exports.updateLayerFieldReferences = exports._getSourceSpatialReferenceAndExtent = exports.validateSpatialReferenceAndExtent = exports.setDefaultSpatialReference = exports._updateTemplateDictionaryFields = exports._updateGeomFieldName = exports._updateSourceLayerFields = exports._updateItemFields = exports._getDynamicFieldNames = exports._getFieldNames = exports._updateForPortal = exports.removeLayerOptimization = exports._isSelfReferential = exports._updateAddOptions = exports._updateOrder = exports.addFeatureServiceDefinition = exports._truncateNamesForAddToDefinition = exports.addFeatureServiceLayersAndTables = exports.getExistingLayersAndTables = exports.getLayersAndTables = exports.deTemplatizeFieldInfos = exports.processContingentValues = exports.updateTemplateForInvalidDesignations = exports.updateSettingsFieldInfos = exports.setNamesAndTitles = exports.getLayerSettings = exports._setTrackingViewLayerSettings = exports._updateTypeKeywords = exports.updateTemplate = exports.cacheLayerInfo = exports._cachePopupInfo = exports.cachePopupInfos = exports._cacheFieldInfo = exports.cacheIndexes = exports.cacheContingentValues = exports.cacheFieldInfos = exports.deleteViewProps = exports.templatize = exports.getFeatureServiceRelatedRecords = void 0;
+exports._getLayerChunkSize = exports._getNameMapping = exports._templatizeDefinitionQuery = exports._templatizeTimeInfo = exports._templatizeKeys = exports._templatizeTypeTemplates = exports._templatizeTemplates = exports._templatizeLabelingInfo = exports._templatizeArcadeExpressions = exports._templatizeAuthoringInfo = exports._templatizeTemporalRenderer = exports._templatizeGenRenderer = exports._templatizeRenderer = exports._templatizeDrawingInfo = exports._templatizeSimpleName = exports._templatizeDefinitionExpression = exports._templatizeDefinitionEditor = exports._templatizeMediaInfos = exports._templatizePopupElements = exports._templatizeExpressionInfos = exports._templatizeFieldName = exports._templatizePopupInfoFieldInfos = exports._templatizeName = exports._templatizePopupInfo = exports._templatizeRelationshipFields = exports._templatizeTopFilter = exports._templatizeAdminSourceLayerFields = exports._getDependantItemId = exports._templatizeAdminLayerInfoFields = exports._templatizeSourceServiceName = exports._processAdminObject = exports._templatizeAdminLayerInfo = exports._templatizeLayerFieldReferences = exports._validateEditFieldsInfo = void 0;
 /**
  * Provides general helper functions.
  *
@@ -445,9 +445,12 @@ exports.getLayerSettings = getLayerSettings;
  * The feature service name will have a generated GUID appended.
  *
  * @param templates A collection of AGO item templates.
+ * @param templateDictionary Optional hash of values used to resolve `{{...}}` tokens in the name
+ *   before applying the 50-char base-name limit. When omitted, names containing unresolved tokens
+ *   are passed through untruncated (legacy behavior).
  * @returns An updated collection of AGO templates with unique feature service names.
  */
-function setNamesAndTitles(templates) {
+function setNamesAndTitles(templates, templateDictionary) {
     const guid = (0, generalHelpers_1.generateGUID)();
     const names = [];
     return templates.map((t) => {
@@ -461,12 +464,20 @@ function setNamesAndTitles(templates) {
                 let baseName = t.item.name || t.item.title;
                 // If the name already contains a GUID remove it
                 baseName = baseName.replace(/_[0-9A-F]{32}/gi, "");
-                // The name length limit is 98
-                // Limit the baseName to 50 characters before the _<guid>
-                // If the baseName includes '{{params' it is likely being used in a template replacement, so do not truncate.
-                const name = baseName.includes("{{params")
-                    ? baseName + "_" + guid
-                    : baseName.substring(0, 50) + "_" + guid;
+                // Resolve any {{...}} tokens (e.g. {{params.buildSolution.items.<id>.title}}) so the
+                // base-name length limit reflects the value AGOL will actually see at create time.
+                const resolvedBaseName = templateDictionary
+                    ? (0, templatization_1.replaceInTemplate)(baseName, templateDictionary)
+                    : baseName;
+                // Limit the base name to 50 chars so the full service name (base + "_" + 32-char guid)
+                // stays within AGOL's service-name length limit. This 50-char cap is long-standing
+                // behavior. If unresolved {{...}} tokens remain we can't know the resolved length, so
+                // leave the name untruncated.
+                const maxBaseNameLength = 50;
+                const stillTemplatized = resolvedBaseName.includes("{{");
+                const name = stillTemplatized
+                    ? resolvedBaseName + "_" + guid
+                    : resolvedBaseName.substring(0, maxBaseNameLength) + "_" + guid;
                 // If the name + GUID already exists then append "_occurrenceCount"
                 t.item.name = names.indexOf(name) === -1 ? name : `${name}_${names.filter((n) => n === name).length}`;
                 names.push(name);
@@ -747,6 +758,53 @@ function addFeatureServiceLayersAndTables(itemTemplate, templateDictionary, popu
     });
 }
 exports.addFeatureServiceLayersAndTables = addFeatureServiceLayersAndTables;
+/**
+ * Shorten any layer or table name longer than `maxNameLength` to a unique value of at most
+ * `maxNameLength` characters, in preparation for an addToDefinition call, and report the original
+ * names so they can be restored afterward.
+ *
+ * Mutates the `name` of each over-long layer/table in `layerChunks` in place.
+ *
+ * @param layerChunks The addToDefinition chunks whose `layers` and `tables` will be added
+ * @param maxNameLength Names longer than this are truncated to a unique value of this length
+ * @returns The original names to restore, as `{ layers: [{ id, name }], tables: [{ id, name }] }`
+ * @private
+ */
+function _truncateNamesForAddToDefinition(layerChunks, maxNameLength) {
+    const restore = {
+        layers: [],
+        tables: [],
+    };
+    const allItems = [];
+    layerChunks.forEach((chunk) => {
+        chunk.layers.forEach((layer) => allItems.push({ item: layer, isLayer: true }));
+        chunk.tables.forEach((table) => allItems.push({ item: table, isLayer: false }));
+    });
+    // Reserve names that are already short enough so the truncated names won't collide with them.
+    const usedNames = new Set();
+    allItems.forEach(({ item }) => {
+        if (item.name.length <= maxNameLength) {
+            usedNames.add(item.name.toLowerCase());
+        }
+    });
+    allItems.forEach(({ item, isLayer }) => {
+        if (item.name.length > maxNameLength) {
+            const originalName = item.name;
+            let candidate = originalName.substring(0, maxNameLength);
+            let counter = 1;
+            // Keep the truncated name unique by trimming room for a numeric suffix when needed.
+            while (usedNames.has(candidate.toLowerCase())) {
+                const suffix = `_${counter++}`;
+                candidate = originalName.substring(0, maxNameLength - suffix.length) + suffix;
+            }
+            usedNames.add(candidate.toLowerCase());
+            item.name = candidate;
+            (isLayer ? restore.layers : restore.tables).push({ id: item.id, name: originalName });
+        }
+    });
+    return restore;
+}
+exports._truncateNamesForAddToDefinition = _truncateNamesForAddToDefinition;
 /**
  * Updates a feature service with a list of layers and/or tables.
  *
@@ -859,9 +917,30 @@ function addFeatureServiceDefinition(serviceUrl, listToAdd, templateDictionary,
             // will use async by default rather than chunk the layer requests when we have more layers
             // than the defined chunk size
             const useAsync = listToAdd.length > chunkSize;
+            // Shorten any over-long layer/table names to short, unique values before adding them.
+            // Names will be restored afterward with one updateDefinition call per layer/table.
+            const maxBackingTableNameLength = 30;
+            const restoreNames = _truncateNamesForAddToDefinition(layerChunks, maxBackingTableNameLength);
+            // Base admin URL used for the per-layer updateDefinition restore calls below.
+            const adminServiceUrl = (0, generalHelpers_1.checkUrlPathTermination)(serviceUrl.replace("/rest/services", "/rest/admin/services"));
             layerChunks
                 .reduce((prev, curr) => prev.then(() => (0, restHelpers_1.addToServiceDefinition)(serviceUrl, curr, false, useAsync)), Promise.resolve(null))
-                .then(() => resolve(null), (e) => reject((0, generalHelpers_1.fail)(e)));
+                .then(() => {
+                // Restore the original (pre-truncation) display names.
+                // I was seeing the updateDefinition call succeed but the names not being restored when I was doing this
+                // with a single call at the service endpoint. So now we are doing this sequentially.
+                const restoreItems = [...restoreNames.layers, ...restoreNames.tables];
+                restoreItems
+                    .reduce((prev, entry) => prev.then(() => {
+                    const restoreUpdate = {
+                        url: adminServiceUrl + entry.id + "/updateDefinition",
+                        params: { updateDefinition: { name: entry.name } },
+                        args: { authentication },
+                    };
+                    return (0, restHelpers_1.getRequest)(restoreUpdate, false, false, templateDictionary.isPortal);
+                }), Promise.resolve(null))
+                    .then(() => resolve(null), (e) => reject((0, generalHelpers_1.fail)(e)));
+            }, (e) => reject((0, generalHelpers_1.fail)(e)));
         }
     });
 }

package/dist/esm/featureServiceHelpers.d.ts

@@ -164,9 +164,12 @@ export declare function getLayerSettings(layerInfos: any, url: string, itemId: s
  * The feature service name will have a generated GUID appended.
  *
  * @param templates A collection of AGO item templates.
+ * @param templateDictionary Optional hash of values used to resolve `{{...}}` tokens in the name
+ *   before applying the 50-char base-name limit. When omitted, names containing unresolved tokens
+ *   are passed through untruncated (legacy behavior).
  * @returns An updated collection of AGO templates with unique feature service names.
  */
-export declare function setNamesAndTitles(templates: IItemTemplate[]): IItemTemplate[];
+export declare function setNamesAndTitles(templates: IItemTemplate[], templateDictionary?: any): IItemTemplate[];
 /**
  * This is used when deploying views.
  * We need to update fields referenced in adminLayerInfo for relationships prior to deploying the view.
@@ -243,6 +246,28 @@ export declare function getExistingLayersAndTables(url: string, ids: number[], a
  * @private
  */
 export declare function addFeatureServiceLayersAndTables(itemTemplate: IItemTemplate, templateDictionary: any, popupInfos: IPopupInfos, authentication: UserSession): Promise<void>;
+/**
+ * Shorten any layer or table name longer than `maxNameLength` to a unique value of at most
+ * `maxNameLength` characters, in preparation for an addToDefinition call, and report the original
+ * names so they can be restored afterward.
+ *
+ * Mutates the `name` of each over-long layer/table in `layerChunks` in place.
+ *
+ * @param layerChunks The addToDefinition chunks whose `layers` and `tables` will be added
+ * @param maxNameLength Names longer than this are truncated to a unique value of this length
+ * @returns The original names to restore, as `{ layers: [{ id, name }], tables: [{ id, name }] }`
+ * @private
+ */
+export declare function _truncateNamesForAddToDefinition(layerChunks: any[], maxNameLength: number): {
+    layers: Array<{
+        id: any;
+        name: string;
+    }>;
+    tables: Array<{
+        id: any;
+        name: string;
+    }>;
+};
 /**
  * Updates a feature service with a list of layers and/or tables.
  *

package/dist/esm/featureServiceHelpers.js

@@ -427,9 +427,12 @@ export function getLayerSettings(layerInfos, url, itemId, enterpriseIDMapping) {
  * The feature service name will have a generated GUID appended.
  *
  * @param templates A collection of AGO item templates.
+ * @param templateDictionary Optional hash of values used to resolve `{{...}}` tokens in the name
+ *   before applying the 50-char base-name limit. When omitted, names containing unresolved tokens
+ *   are passed through untruncated (legacy behavior).
  * @returns An updated collection of AGO templates with unique feature service names.
  */
-export function setNamesAndTitles(templates) {
+export function setNamesAndTitles(templates, templateDictionary) {
     const guid = generateGUID();
     const names = [];
     return templates.map((t) => {
@@ -443,12 +446,20 @@ export function setNamesAndTitles(templates) {
                 let baseName = t.item.name || t.item.title;
                 // If the name already contains a GUID remove it
                 baseName = baseName.replace(/_[0-9A-F]{32}/gi, "");
-                // The name length limit is 98
-                // Limit the baseName to 50 characters before the _<guid>
-                // If the baseName includes '{{params' it is likely being used in a template replacement, so do not truncate.
-                const name = baseName.includes("{{params")
-                    ? baseName + "_" + guid
-                    : baseName.substring(0, 50) + "_" + guid;
+                // Resolve any {{...}} tokens (e.g. {{params.buildSolution.items.<id>.title}}) so the
+                // base-name length limit reflects the value AGOL will actually see at create time.
+                const resolvedBaseName = templateDictionary
+                    ? replaceInTemplate(baseName, templateDictionary)
+                    : baseName;
+                // Limit the base name to 50 chars so the full service name (base + "_" + 32-char guid)
+                // stays within AGOL's service-name length limit. This 50-char cap is long-standing
+                // behavior. If unresolved {{...}} tokens remain we can't know the resolved length, so
+                // leave the name untruncated.
+                const maxBaseNameLength = 50;
+                const stillTemplatized = resolvedBaseName.includes("{{");
+                const name = stillTemplatized
+                    ? resolvedBaseName + "_" + guid
+                    : resolvedBaseName.substring(0, maxBaseNameLength) + "_" + guid;
                 // If the name + GUID already exists then append "_occurrenceCount"
                 t.item.name = names.indexOf(name) === -1 ? name : `${name}_${names.filter((n) => n === name).length}`;
                 names.push(name);
@@ -721,6 +732,52 @@ export function addFeatureServiceLayersAndTables(itemTemplate, templateDictionar
         }
     });
 }
+/**
+ * Shorten any layer or table name longer than `maxNameLength` to a unique value of at most
+ * `maxNameLength` characters, in preparation for an addToDefinition call, and report the original
+ * names so they can be restored afterward.
+ *
+ * Mutates the `name` of each over-long layer/table in `layerChunks` in place.
+ *
+ * @param layerChunks The addToDefinition chunks whose `layers` and `tables` will be added
+ * @param maxNameLength Names longer than this are truncated to a unique value of this length
+ * @returns The original names to restore, as `{ layers: [{ id, name }], tables: [{ id, name }] }`
+ * @private
+ */
+export function _truncateNamesForAddToDefinition(layerChunks, maxNameLength) {
+    const restore = {
+        layers: [],
+        tables: [],
+    };
+    const allItems = [];
+    layerChunks.forEach((chunk) => {
+        chunk.layers.forEach((layer) => allItems.push({ item: layer, isLayer: true }));
+        chunk.tables.forEach((table) => allItems.push({ item: table, isLayer: false }));
+    });
+    // Reserve names that are already short enough so the truncated names won't collide with them.
+    const usedNames = new Set();
+    allItems.forEach(({ item }) => {
+        if (item.name.length <= maxNameLength) {
+            usedNames.add(item.name.toLowerCase());
+        }
+    });
+    allItems.forEach(({ item, isLayer }) => {
+        if (item.name.length > maxNameLength) {
+            const originalName = item.name;
+            let candidate = originalName.substring(0, maxNameLength);
+            let counter = 1;
+            // Keep the truncated name unique by trimming room for a numeric suffix when needed.
+            while (usedNames.has(candidate.toLowerCase())) {
+                const suffix = `_${counter++}`;
+                candidate = originalName.substring(0, maxNameLength - suffix.length) + suffix;
+            }
+            usedNames.add(candidate.toLowerCase());
+            item.name = candidate;
+            (isLayer ? restore.layers : restore.tables).push({ id: item.id, name: originalName });
+        }
+    });
+    return restore;
+}
 /**
  * Updates a feature service with a list of layers and/or tables.
  *
@@ -833,9 +890,30 @@ export function addFeatureServiceDefinition(serviceUrl, listToAdd, templateDicti
             // will use async by default rather than chunk the layer requests when we have more layers
             // than the defined chunk size
             const useAsync = listToAdd.length > chunkSize;
+            // Shorten any over-long layer/table names to short, unique values before adding them.
+            // Names will be restored afterward with one updateDefinition call per layer/table.
+            const maxBackingTableNameLength = 30;
+            const restoreNames = _truncateNamesForAddToDefinition(layerChunks, maxBackingTableNameLength);
+            // Base admin URL used for the per-layer updateDefinition restore calls below.
+            const adminServiceUrl = checkUrlPathTermination(serviceUrl.replace("/rest/services", "/rest/admin/services"));
             layerChunks
                 .reduce((prev, curr) => prev.then(() => addToServiceDefinition(serviceUrl, curr, false, useAsync)), Promise.resolve(null))
-                .then(() => resolve(null), (e) => reject(fail(e)));
+                .then(() => {
+                // Restore the original (pre-truncation) display names.
+                // I was seeing the updateDefinition call succeed but the names not being restored when I was doing this
+                // with a single call at the service endpoint. So now we are doing this sequentially.
+                const restoreItems = [...restoreNames.layers, ...restoreNames.tables];
+                restoreItems
+                    .reduce((prev, entry) => prev.then(() => {
+                    const restoreUpdate = {
+                        url: adminServiceUrl + entry.id + "/updateDefinition",
+                        params: { updateDefinition: { name: entry.name } },
+                        args: { authentication },
+                    };
+                    return getRequest(restoreUpdate, false, false, templateDictionary.isPortal);
+                }), Promise.resolve(null))
+                    .then(() => resolve(null), (e) => reject(fail(e)));
+            }, (e) => reject(fail(e)));
         }
     });
 }

package/dist/solution.js_commit.txt

@@ -1,7 +1,10 @@
-Built 06/24/2026 20:43:08.94 
+Built 06/25/2026 20:42:59.94 
 develop
-commit b62bc87cfa4b10e06c66968d572ac53ef470961b
-Author: Ryan Cosby <ryan9313@esri.com>
-Date:   Tue Jun 23 20:50:27 2026 -0700
+commit 8bce353fe3c3c3286c3d17f2c47ad0608160e78a
+Merge: 0713c37c5 bdf44674f
+Author: Previn Wong <pwong@esri.com>
+Date:   Thu Jun 25 16:16:57 2026 -0700
 
-    v6.6.1-next.79
+    Merge pull request #1591 from Esri/long-name-issue
+    
+    Long name issue

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@esri/solution-common",
-  "version": "6.6.1-next.80",
+  "version": "6.6.1-next.81",
   "description": "Provides general helper functions for @esri/solution.js.",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
@@ -96,5 +96,5 @@
     "esri",
     "ES6"
   ],
-  "gitHead": "b62bc87cfa4b10e06c66968d572ac53ef470961b"
+  "gitHead": "8bce353fe3c3c3286c3d17f2c47ad0608160e78a"
 }