@esri/solution-common 6.6.1-next.20 → 6.6.1-next.22

package/dist/cjs/arcgisRestJS.d.ts

@@ -19,9 +19,12 @@
 import { IFolderIdOptions, IGetGroupContentOptions, IGetUserOptions, IGroup, IGroupContentResult, IGetRelatedItemsResponse, IGroupSharingOptions, IItem, IItemRelationshipOptions, IItemResourceOptions, IItemResourceResponse, IPortal, IRemoveItemResourceOptions, ISearchOptions, ISearchResult, ISharingResponse, IUpdateGroupOptions, IUpdateItemOptions, IUpdateItemResponse, IUser, IUserGroupOptions, IUserItemOptions, SearchQueryBuilder } from "@esri/arcgis-rest-portal";
 import { IRequestOptions } from "@esri/arcgis-rest-request";
 import { IAddToServiceDefinitionOptions, IAddToServiceDefinitionResult, IQueryRelatedOptions, IQueryRelatedResponse } from "@esri/arcgis-rest-feature-service";
-export { IAddToServiceDefinitionOptions, IAddToServiceDefinitionResult, ICreateServiceParams, ICreateServiceResult, IExtent, ISpatialReference, IFeature, IQueryRelatedOptions, IQueryRelatedResponse, IRelatedRecordGroup, createFeatureService as svcAdminCreateFeatureService, queryFeatures, addFeatures, applyEdits, } from "@esri/arcgis-rest-feature-service";
-export { IAddFolderResponse, IAddItemDataOptions, ICreateItemOptions, ICreateItemResponse, IFolder, IFolderIdOptions, IGetGroupContentOptions, IGetRelatedItemsResponse, IGroup, IGroupAdd, IGroupCategorySchema as restIGroupCategorySchema, IItem, IItemRelationshipOptions, IItemResourceOptions, IItemResourceResponse, IManageItemRelationshipOptions, IMoveItemOptions, IMoveItemResponse, IPagedResponse, IPagingParams, IPortal, IRemoveItemResourceOptions, ISearchGroupContentOptions, ISearchOptions, ISearchResult, ISetAccessOptions, ISharingResponse, ItemRelationshipType, IUpdateGroupOptions, IUpdateItemOptions, IUpdateItemResponse, IUser, IUserContentResponse, IUserGroupOptions, IGroupSharingOptions, IUserItemOptions, addItemData as restAddItemData, addItemRelationship, createFolder, createGroup, createItem, createItemInFolder, moveItem, protectItem, SearchQueryBuilder, getGroupCategorySchema as restGetGroupCategorySchema, getItem, getItemData, getItemResources as restGetItemResources, getUserContent, getPortal as restGetPortal, getPortalUrl, searchGroupContent, setItemAccess, searchGroups as restSearchGroups, removeGroupUsers, removeItem as restRemoveItem, } from "@esri/arcgis-rest-portal";
-export { IArcGISIdentityManagerOptions, ICredential, IRequestOptions, IParams, ArcGISAuthError, encodeFormData, ArcGISIdentityManager as UserSession, } from "@esri/arcgis-rest-request";
+export { createFeatureService as svcAdminCreateFeatureService, queryFeatures, addFeatures, applyEdits, } from "@esri/arcgis-rest-feature-service";
+export type { IAddToServiceDefinitionOptions, IAddToServiceDefinitionResult, ICreateServiceParams, ICreateServiceResult, IExtent, ISpatialReference, IFeature, IQueryRelatedOptions, IQueryRelatedResponse, IRelatedRecordGroup, } from "@esri/arcgis-rest-feature-service";
+export { addItemData as restAddItemData, addItemRelationship, createFolder, createGroup, createItem, createItemInFolder, moveItem, protectItem, SearchQueryBuilder, getGroupCategorySchema as restGetGroupCategorySchema, getItem, getItemData, getItemResources as restGetItemResources, getUserContent, getPortal as restGetPortal, getPortalUrl, searchGroupContent, setItemAccess, searchGroups as restSearchGroups, removeGroupUsers, removeItem as restRemoveItem, } from "@esri/arcgis-rest-portal";
+export type { IAddFolderResponse, IAddItemDataOptions, ICreateItemOptions, ICreateItemResponse, IFolder, IFolderIdOptions, IGetGroupContentOptions, IGetRelatedItemsResponse, IGroup, IGroupAdd, IGroupCategorySchema as restIGroupCategorySchema, IItem, IItemRelationshipOptions, IItemResourceOptions, IItemResourceResponse, IManageItemRelationshipOptions, IMoveItemOptions, IMoveItemResponse, IPagedResponse, IPagingParams, IPortal, IRemoveItemResourceOptions, ISearchGroupContentOptions, ISearchOptions, ISearchResult, ISetAccessOptions, ISharingResponse, ItemRelationshipType, IUpdateGroupOptions, IUpdateItemOptions, IUpdateItemResponse, IUser, IUserContentResponse, IUserGroupOptions, IGroupSharingOptions, IUserItemOptions, } from "@esri/arcgis-rest-portal";
+export { ArcGISAuthError, encodeFormData, ArcGISIdentityManager as UserSession } from "@esri/arcgis-rest-request";
+export type { IArcGISIdentityManagerOptions, ICredential, IRequestOptions, IParams } from "@esri/arcgis-rest-request";
 export interface IFolderSuccessResult {
     success: boolean;
     folder: {

package/dist/cjs/featureServiceHelpers.js

@@ -158,9 +158,11 @@ exports.deleteViewProps = deleteViewProps;
  */
 function cacheFieldInfos(layer, fieldInfos, isView, isPortal) {
     // cache the source fields as they are in the original source
-    if (layer && layer.fields) {
+    // Note: layer.id is commonly 0 for the first layer, so use a presence check
+    // (not a truthy check) to avoid skipping the layer with id === 0.
+    if (layer && layer.id !== undefined && layer.id !== null) {
         fieldInfos[layer.id] = {
-            sourceFields: JSON.parse(JSON.stringify(layer.fields)),
+            sourceFields: layer.fields ? JSON.parse(JSON.stringify(layer.fields)) : [],
             type: layer.type,
             id: layer.id,
         };
@@ -826,7 +828,12 @@ function addFeatureServiceDefinition(serviceUrl, listToAdd, templateDictionary,
                 removeLayerOptimization(item);
                 // this can still chunk layers
                 options = _updateAddOptions(itemTemplate, options, layerChunks, isSelfReferential, authentication);
-                if (item.type === "Feature Layer") {
+                // Route based on the discriminator set by getLayersAndTables (which derives from
+                // properties.layers vs properties.tables) rather than the layer object's own `type`
+                // field. The latter may be missing when users supply custom layer JSON via
+                // params (e.g. {{params.buildSolution.items.<id>.service.layers}}), which would
+                // otherwise cause every layer to be pushed into the `tables` array.
+                if (toAdd.type === "layer" || item.type === "Feature Layer") {
                     options.layers.push(item);
                 }
                 else {

package/dist/esm/arcgisRestJS.d.ts

@@ -19,9 +19,12 @@
 import { IFolderIdOptions, IGetGroupContentOptions, IGetUserOptions, IGroup, IGroupContentResult, IGetRelatedItemsResponse, IGroupSharingOptions, IItem, IItemRelationshipOptions, IItemResourceOptions, IItemResourceResponse, IPortal, IRemoveItemResourceOptions, ISearchOptions, ISearchResult, ISharingResponse, IUpdateGroupOptions, IUpdateItemOptions, IUpdateItemResponse, IUser, IUserGroupOptions, IUserItemOptions, SearchQueryBuilder } from "@esri/arcgis-rest-portal";
 import { IRequestOptions } from "@esri/arcgis-rest-request";
 import { IAddToServiceDefinitionOptions, IAddToServiceDefinitionResult, IQueryRelatedOptions, IQueryRelatedResponse } from "@esri/arcgis-rest-feature-service";
-export { IAddToServiceDefinitionOptions, IAddToServiceDefinitionResult, ICreateServiceParams, ICreateServiceResult, IExtent, ISpatialReference, IFeature, IQueryRelatedOptions, IQueryRelatedResponse, IRelatedRecordGroup, createFeatureService as svcAdminCreateFeatureService, queryFeatures, addFeatures, applyEdits, } from "@esri/arcgis-rest-feature-service";
-export { IAddFolderResponse, IAddItemDataOptions, ICreateItemOptions, ICreateItemResponse, IFolder, IFolderIdOptions, IGetGroupContentOptions, IGetRelatedItemsResponse, IGroup, IGroupAdd, IGroupCategorySchema as restIGroupCategorySchema, IItem, IItemRelationshipOptions, IItemResourceOptions, IItemResourceResponse, IManageItemRelationshipOptions, IMoveItemOptions, IMoveItemResponse, IPagedResponse, IPagingParams, IPortal, IRemoveItemResourceOptions, ISearchGroupContentOptions, ISearchOptions, ISearchResult, ISetAccessOptions, ISharingResponse, ItemRelationshipType, IUpdateGroupOptions, IUpdateItemOptions, IUpdateItemResponse, IUser, IUserContentResponse, IUserGroupOptions, IGroupSharingOptions, IUserItemOptions, addItemData as restAddItemData, addItemRelationship, createFolder, createGroup, createItem, createItemInFolder, moveItem, protectItem, SearchQueryBuilder, getGroupCategorySchema as restGetGroupCategorySchema, getItem, getItemData, getItemResources as restGetItemResources, getUserContent, getPortal as restGetPortal, getPortalUrl, searchGroupContent, setItemAccess, searchGroups as restSearchGroups, removeGroupUsers, removeItem as restRemoveItem, } from "@esri/arcgis-rest-portal";
-export { IArcGISIdentityManagerOptions, ICredential, IRequestOptions, IParams, ArcGISAuthError, encodeFormData, ArcGISIdentityManager as UserSession, } from "@esri/arcgis-rest-request";
+export { createFeatureService as svcAdminCreateFeatureService, queryFeatures, addFeatures, applyEdits, } from "@esri/arcgis-rest-feature-service";
+export type { IAddToServiceDefinitionOptions, IAddToServiceDefinitionResult, ICreateServiceParams, ICreateServiceResult, IExtent, ISpatialReference, IFeature, IQueryRelatedOptions, IQueryRelatedResponse, IRelatedRecordGroup, } from "@esri/arcgis-rest-feature-service";
+export { addItemData as restAddItemData, addItemRelationship, createFolder, createGroup, createItem, createItemInFolder, moveItem, protectItem, SearchQueryBuilder, getGroupCategorySchema as restGetGroupCategorySchema, getItem, getItemData, getItemResources as restGetItemResources, getUserContent, getPortal as restGetPortal, getPortalUrl, searchGroupContent, setItemAccess, searchGroups as restSearchGroups, removeGroupUsers, removeItem as restRemoveItem, } from "@esri/arcgis-rest-portal";
+export type { IAddFolderResponse, IAddItemDataOptions, ICreateItemOptions, ICreateItemResponse, IFolder, IFolderIdOptions, IGetGroupContentOptions, IGetRelatedItemsResponse, IGroup, IGroupAdd, IGroupCategorySchema as restIGroupCategorySchema, IItem, IItemRelationshipOptions, IItemResourceOptions, IItemResourceResponse, IManageItemRelationshipOptions, IMoveItemOptions, IMoveItemResponse, IPagedResponse, IPagingParams, IPortal, IRemoveItemResourceOptions, ISearchGroupContentOptions, ISearchOptions, ISearchResult, ISetAccessOptions, ISharingResponse, ItemRelationshipType, IUpdateGroupOptions, IUpdateItemOptions, IUpdateItemResponse, IUser, IUserContentResponse, IUserGroupOptions, IGroupSharingOptions, IUserItemOptions, } from "@esri/arcgis-rest-portal";
+export { ArcGISAuthError, encodeFormData, ArcGISIdentityManager as UserSession } from "@esri/arcgis-rest-request";
+export type { IArcGISIdentityManagerOptions, ICredential, IRequestOptions, IParams } from "@esri/arcgis-rest-request";
 export interface IFolderSuccessResult {
     success: boolean;
     folder: {

package/dist/esm/arcgisRestJS.js

@@ -21,7 +21,7 @@ import { request as restRequest } from "@esri/arcgis-rest-request";
 import { addToServiceDefinition, queryRelated as restQueryRelated, } from "@esri/arcgis-rest-feature-service";
 export { createFeatureService as svcAdminCreateFeatureService, queryFeatures, addFeatures, applyEdits, } from "@esri/arcgis-rest-feature-service";
 export { addItemData as restAddItemData, addItemRelationship, createFolder, createGroup, createItem, createItemInFolder, moveItem, protectItem, SearchQueryBuilder, getGroupCategorySchema as restGetGroupCategorySchema, getItem, getItemData, getItemResources as restGetItemResources, getUserContent, getPortal as restGetPortal, getPortalUrl, searchGroupContent, setItemAccess, searchGroups as restSearchGroups, removeGroupUsers, removeItem as restRemoveItem, } from "@esri/arcgis-rest-portal";
-export { ArcGISAuthError, encodeFormData, ArcGISIdentityManager as UserSession, } from "@esri/arcgis-rest-request";
+export { ArcGISAuthError, encodeFormData, ArcGISIdentityManager as UserSession } from "@esri/arcgis-rest-request";
 //custom export functions that mimic the same export function from arcgis-rest-js
 //to bypass unit test error:
 //Error: <spyOn> : <functon or property> is not declared writable or has no setter

package/dist/esm/featureServiceHelpers.js

@@ -151,9 +151,11 @@ export function deleteViewProps(layer, isPortal) {
  */
 export function cacheFieldInfos(layer, fieldInfos, isView, isPortal) {
     // cache the source fields as they are in the original source
-    if (layer && layer.fields) {
+    // Note: layer.id is commonly 0 for the first layer, so use a presence check
+    // (not a truthy check) to avoid skipping the layer with id === 0.
+    if (layer && layer.id !== undefined && layer.id !== null) {
         fieldInfos[layer.id] = {
-            sourceFields: JSON.parse(JSON.stringify(layer.fields)),
+            sourceFields: layer.fields ? JSON.parse(JSON.stringify(layer.fields)) : [],
             type: layer.type,
             id: layer.id,
         };
@@ -800,7 +802,12 @@ export function addFeatureServiceDefinition(serviceUrl, listToAdd, templateDicti
                 removeLayerOptimization(item);
                 // this can still chunk layers
                 options = _updateAddOptions(itemTemplate, options, layerChunks, isSelfReferential, authentication);
-                if (item.type === "Feature Layer") {
+                // Route based on the discriminator set by getLayersAndTables (which derives from
+                // properties.layers vs properties.tables) rather than the layer object's own `type`
+                // field. The latter may be missing when users supply custom layer JSON via
+                // params (e.g. {{params.buildSolution.items.<id>.service.layers}}), which would
+                // otherwise cause every layer to be pushed into the `tables` array.
+                if (toAdd.type === "layer" || item.type === "Feature Layer") {
                     options.layers.push(item);
                 }
                 else {

package/dist/solution.js_commit.txt

@@ -1,7 +1,10 @@
-Built 04/27/2026 20:42:56.37 
+Built 04/29/2026 20:42:20.71 
 develop
-commit a29e6bb53d93ca13f9115b80bfda71cbe6ff0e17
-Author: Ryan Cosby <ryan9313@esri.com>
-Date:   Sun Apr 26 20:49:45 2026 -0700
+commit 4eeb9ac61a1286354f309f0c39518d87c563dc6e
+Merge: 2db5006bb 331225baf
+Author: John Hauck <jhauck@esri.com>
+Date:   Wed Apr 29 13:56:18 2026 -0600
 
-    v6.6.1-next.19
+    Merge pull request #1583 from Esri/layers-vs-tables
+    
+    update layer type check

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@esri/solution-common",
-  "version": "6.6.1-next.20",
+  "version": "6.6.1-next.22",
   "description": "Provides general helper functions for @esri/solution.js.",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
@@ -96,5 +96,5 @@
     "esri",
     "ES6"
   ],
-  "gitHead": "a29e6bb53d93ca13f9115b80bfda71cbe6ff0e17"
+  "gitHead": "4eeb9ac61a1286354f309f0c39518d87c563dc6e"
 }