@esportsplus/reactivity 0.37.2 → 0.38.1

package/test/compiler/compiler.test.ts

@@ -27,43 +27,47 @@ function applyIntents(code: string, sourceFile: ts.SourceFile, intents: Replacem
     return code;
 }
 
-function isReactiveCall(node: ts.Node): node is ts.CallExpression {
-    return ts.isCallExpression(node) && ts.isIdentifier(node.expression) && node.expression.text === 'reactive';
-}
+// The unit transforms run on real modules: `reactive` is resolved through the import like any consumer's
+const PRELUDE = "import { reactive, ReactiveArray } from '@esportsplus/reactivity';\n";
+
+
+function parse(code: string): { bindings: Bindings; code: string; isReactiveCall: (node: ts.Node) => node is ts.CallExpression; sourceFile: ts.SourceFile } {
+    code = PRELUDE + code;
 
-// Bindings resolve by symbol, so every transform needs a checker over the parsed source
-function parse(code: string): { bindings: Bindings; sourceFile: ts.SourceFile } {
-    let { checker, sourceFile } = languageService.scratch(process.cwd() + '/test.ts', code);
+    let { checker, program, sourceFile } = languageService.scratch(process.cwd() + '/test.ts', code),
+        bindings = scope.create(checker, program, sourceFile);
 
-    return { bindings: scope.create(checker), sourceFile };
+    return { bindings, code, isReactiveCall: (node): node is ts.CallExpression => scope.isReactiveCall(bindings, node), sourceFile };
 }
 
 // Full pipeline over a module importing reactive(): what a real consumer compiles
 function transformModule(code: string): string {
-    code = `import { reactive } from '@esportsplus/reactivity';\n` + code;
+    return transformSource(`import { reactive } from '@esportsplus/reactivity';\n` + code);
+}
 
-    let { checker, sourceFile } = languageService.scratch(process.cwd() + '/module.ts', code),
-        result = pipeline.transform({ checker, code, sourceFile } as never);
+function transformSource(code: string): string {
+    let { checker, program, sourceFile } = languageService.scratch(process.cwd() + '/module.ts', code),
+        result = pipeline.transform({ checker, code, program, sourceFile } as never);
 
     return applyIntents(code, sourceFile, result.replacements ?? []);
 }
 
-function transformPrimitives(code: string): { bindings: Bindings; output: string } {
-    let { bindings, sourceFile } = parse(code),
-        { replacements } = primitives(sourceFile, bindings, isReactiveCall);
+function transformPrimitives(source: string): { bindings: Bindings; failures: string[]; output: string } {
+    let { bindings, code, isReactiveCall, sourceFile } = parse(source),
+        { failures, replacements } = primitives(sourceFile, bindings, isReactiveCall);
 
-    return { bindings, output: applyIntents(code, sourceFile, replacements) };
+    return { bindings, failures: failures.map(f => f.message), output: applyIntents(code, sourceFile, replacements) };
 }
 
-function transformArray(code: string): { bindings: Bindings; output: string } {
-    let { bindings, sourceFile } = parse(code),
-        intents = array(sourceFile, bindings, isReactiveCall);
+function transformArray(source: string): { bindings: Bindings; output: string } {
+    let { bindings, code, isReactiveCall, sourceFile } = parse(source),
+        { replacements } = array(sourceFile, bindings, isReactiveCall);
 
-    return { bindings, output: applyIntents(code, sourceFile, intents) };
+    return { bindings, output: applyIntents(code, sourceFile, replacements) };
 }
 
-function transformObject(code: string): { bindings: Bindings; output: string; prepend: string[] } {
-    let { bindings, sourceFile } = parse(code),
+function transformObject(source: string): { bindings: Bindings; output: string; prepend: string[] } {
+    let { bindings, code, isReactiveCall, sourceFile } = parse(source),
         result = object(sourceFile, bindings, isReactiveCall);
 
     return {
@@ -73,24 +77,20 @@ function transformObject(code: string): { bindings: Bindings; output: string; pr
     };
 }
 
-function typeOf(bindings: Bindings, name: string): number | undefined {
-    for (let [symbol, type] of bindings.symbols) {
-        if (symbol.name === name) {
-            return type;
-        }
-    }
+// Kind of the binding the variable `name` declares
+function typeOf(bindings: Bindings, name: string): number | null {
+    let found: ts.Identifier | undefined,
+        visit = (node: ts.Node): void => {
+            if (!found && ts.isVariableDeclaration(node) && ts.isIdentifier(node.name) && node.name.text === name) {
+                found = node.name;
+            }
 
-    return undefined;
-}
+            node.forEachChild(visit);
+        };
 
-function hasPath(bindings: Bindings, name: string, path: string): boolean {
-    for (let [symbol, paths] of bindings.paths) {
-        if (symbol.name === name && paths.has(path)) {
-            return true;
-        }
-    }
+    visit(bindings.sourceFile);
 
-    return false;
+    return found ? scope.kind(bindings, scope.origin(bindings, found)) : null;
 }
 
 
@@ -150,12 +150,63 @@ describe('primitives transform', () => {
         expect(output).toContain(`${NAMESPACE}.read(x)`);
     });
 
-    it('transforms dynamic expression to namespace reactive', () => {
-        let { output } = transformPrimitives('let x = reactive(someCall());');
+    it('builds a non-literal array or object argument with the runtime reactive()', () => {
+        let { output } = transformPrimitives('declare function someCall(): number[];\nlet x = reactive(someCall());');
 
         expect(output).toContain(`${NAMESPACE}.reactive(someCall())`);
     });
 
+    it('classifies a non-literal primitive argument as a signal by its type', () => {
+        let { output } = transformPrimitives('declare let n: number;\nlet x = reactive(n);\nlet y = x + 1;');
+
+        expect(output).toContain(`let x = ${NAMESPACE}.signal(n)`);
+        expect(output).toContain(`let y = ${NAMESPACE}.read(x) + 1`);
+    });
+
+    it('classifies a function-typed argument as a computed', () => {
+        let { output } = transformPrimitives('declare function total(): number;\nlet x = reactive(total);');
+
+        expect(output).toContain(`let x = ${NAMESPACE}.computed(total)`);
+    });
+
+    it('rejects an argument whose kind is not provable', () => {
+        let { failures } = transformPrimitives('declare let value: any;\nlet x = reactive(value);');
+
+        expect(failures).toHaveLength(1);
+        expect(failures[0]).toContain('provable');
+    });
+
+    it('rejects a signal that does not initialize a variable', () => {
+        let { failures } = transformPrimitives('declare function take(value: unknown): void;\ntake(reactive(0));\nlet o = { count: reactive(1) };');
+
+        expect(failures).toHaveLength(2);
+        expect(failures[0]).toContain('must initialize a variable');
+    });
+
+    it('rejects a write to a computed', () => {
+        let { failures } = transformPrimitives('let d = reactive(() => 1);\nd = 2;');
+
+        expect(failures).toEqual(['a reactive computed is read-only']);
+    });
+
+    it('rejects a destructuring assignment into a reactive binding', () => {
+        let { failures } = transformPrimitives('let x = reactive(0);\n[x] = [1];');
+
+        expect(failures[0]).toContain('destructuring');
+    });
+
+    it('reads a binding assigned with reactive() after its declaration', () => {
+        let { output } = transformPrimitives('let x: number;\nx = reactive(0);\nlet y = x + 1;');
+
+        expect(output).toContain(`let y = ${NAMESPACE}.read(x) + 1`);
+    });
+
+    it('reads through typeof', () => {
+        let { output } = transformPrimitives("let x = reactive(0);\nlet t = typeof x;");
+
+        expect(output).toContain(`let t = typeof ${NAMESPACE}.read(x)`);
+    });
+
     it('tracks bindings for signal type', () => {
         let { bindings } = transformPrimitives('let x = reactive(0);');
 
@@ -250,10 +301,16 @@ describe('object transform', () => {
         expect(output).toContain('<MyType>');
     });
 
-    it('tracks nested array bindings', () => {
-        let { bindings } = transformObject('let obj = reactive({ items: [1, 2, 3] });');
+    it('passes every array property to the constructor, static elements included', () => {
+        let { output } = transformObject('let obj = reactive({ n: 1, items: [1, 2] });');
 
-        expect(hasPath(bindings, 'obj', 'items')).toBe(true);
+        expect(output).toMatch(/new ReactiveObject_\w+\(\[1, 2\]\)/);
+    });
+
+    it('makes a non-literal array property a reactive array', () => {
+        let { prepend } = transformObject('declare let list: number[];\nlet obj = reactive({ items: list });');
+
+        expect(prepend[0]).toContain(`${NAMESPACE}.REACTIVE_ARRAY`);
     });
 });
 
@@ -290,6 +347,20 @@ describe('array transform', () => {
         expect(output).toContain('arr.$length = arr.length + 3');
     });
 
+    it('transforms arr.length++ and --arr.length to $length writes', () => {
+        expect(transformArray('let arr = reactive([1]); arr.length++;').output).toContain('arr.$length = arr.length + 1');
+        expect(transformArray('let arr = reactive([1]); --arr.length;').output).toContain('arr.$length = arr.length - 1');
+    });
+
+    it('transforms non-mutating unary operators on arr.length as reads', () => {
+        for (let op of ['!', '-', '+', '~']) {
+            let { output } = transformArray(`let arr = reactive([1]); let x = ${op}arr.length;`);
+
+            expect(output).toContain(`${op}arr.$length`);
+            expect(output).not.toContain('arr.$length =');
+        }
+    });
+
     it('transforms every compound operator on arr.length with its own token', () => {
         for (let op of ['<<', '>>', '>>>', '??', '||', '&&', '-', '*', '/', '%', '**', '&', '|', '^']) {
             let { output } = transformArray(`let arr = reactive([1]); arr.length ${op}= 2;`);
@@ -311,16 +382,36 @@ describe('array transform', () => {
         expect(typeOf(bindings, 'arr')).toBe(TYPES.Array);
     });
 
-    it('tracks alias binding from reactive array', () => {
-        let { bindings } = transformArray('let a = reactive([1]); let b = a;');
+    it('compiles an alias of a reactive array by its type', () => {
+        let { output } = transformArray('let a = reactive([1]); let b = a; let n = b.length;');
 
-        expect(typeOf(bindings, 'b')).toBe(TYPES.Array);
+        expect(output).toContain('let n = b.$length');
     });
 
-    it('tracks typed parameter as ReactiveArray', () => {
-        let { bindings } = transformArray('function fn(arr: ReactiveArray) { return arr; }');
+    it('compiles a ReactiveArray-typed parameter by its type', () => {
+        let { output } = transformArray('function fn(arr: ReactiveArray<number>) { arr[0] = 1; return arr.length; }');
 
-        expect(typeOf(bindings, 'arr')).toBe(TYPES.Array);
+        expect(output).toContain('arr.$set(0, 1)');
+        expect(output).toContain('return arr.$length');
+    });
+
+    it('compiles an array property of a reactive object by its type', () => {
+        let { output } = transformArray('let obj = reactive({ items: [1] }); let n = obj.items.length;');
+
+        expect(output).toContain('let n = obj.items.$length');
+    });
+
+    it('routes compound and increment element writes through $set', () => {
+        let { output } = transformArray('let arr = reactive([1]); arr[0] += 2; arr[0]++;');
+
+        expect(output).toContain('((_a, _k) => _a.$set(_k, _a[_k] + (2)))(arr, 0)');
+        expect(output).toContain('((_a, _k, _v) => (_a.$set(_k, _v + 1), _v))(arr, 0, arr[0])');
+    });
+
+    it('leaves a plain array untouched', () => {
+        let { output } = transformArray('let arr = [1]; arr[0] = 2; let n = arr.length;');
+
+        expect(output).toContain('arr[0] = 2; let n = arr.length;');
     });
 
     it('transforms empty array', () => {
@@ -388,12 +479,39 @@ describe('binding resolution (full pipeline)', () => {
         expect(output).toContain(`let count = ${NAMESPACE}.signal(0);`);
         expect(output).toContain(`let next = ${NAMESPACE}.read(count) + 1;`);
     });
+
+    it('transforms calls through an aliased import', () => {
+        let output = transformSource("import { reactive as r } from '@esportsplus/reactivity';\nlet count = r(0);\nlet next = count + 1;");
+
+        expect(output).toContain(`let count = ${NAMESPACE}.signal(0);`);
+        expect(output).toContain(`let next = ${NAMESPACE}.read(count) + 1;`);
+    });
+
+    it('transforms a reactive array created through an aliased import', () => {
+        let output = transformSource("import { reactive as r } from '@esportsplus/reactivity';\nlet list = r([1, 2]);\nlet size = list.length;");
+
+        expect(output).not.toContain('r([1, 2])');
+        expect(output).toContain('let size = list.$length');
+    });
+
+    it('leaves a parameter that shadows an alias untouched', () => {
+        let code = "import { reactive as r } from '@esportsplus/reactivity';\nfunction f(r: (n: number) => number) { return r(1); }";
+
+        expect(transformSource(code)).toBe(code);
+    });
+
+    it('leaves another export imported under the name reactive untouched', () => {
+        let code = "import { root as reactive } from '@esportsplus/reactivity';\nlet value = reactive(() => 1);";
+
+        expect(transformSource(code)).toBe(code);
+    });
 });
 
 
 describe('index transform', () => {
-    it('exports patterns array', () => {
-        expect(pipeline.patterns).toEqual(['reactive(', 'reactive<']);
+    // A module can reach reactive() or read a binding under any name, so no text prefilter may skip it
+    it('has no text patterns', () => {
+        expect('patterns' in pipeline).toBe(false);
     });
 
     it('has transform function', () => {

package/test/compiler/coverage.test.ts

@@ -0,0 +1,164 @@
+import { afterEach, describe, expect, it } from 'vitest';
+import { mkdtempSync, rmSync, writeFileSync } from 'node:fs';
+import { join } from 'node:path';
+import { NAMESPACE } from '~/compiler/constants';
+import vite from '~/compiler/plugins/vite';
+
+
+// Every route by which a module reaches `reactive`, or a binding it created, must compile
+const FILES: Record<string, string> = {
+    'state.ts': [
+        "import { reactive } from '@esportsplus/reactivity';",
+        'export let count = reactive(0);',
+        'export let list = reactive([1, 2]);',
+        'export let store = reactive({ n: 1, items: [1] });',
+        'export default reactive(0);'
+    ].join('\n'),
+    'barrel.ts': [
+        "export { reactive as make } from '@esportsplus/reactivity';",
+        "export * as R from '@esportsplus/reactivity';",
+        "export * from './state';"
+    ].join('\n'),
+    'reads.ts': [
+        "import { count, list, store } from './state';",
+        "import * as S from './state';",
+        "import fallback from './state';",
+        "import { count as renamed } from './barrel';",
+        'export let a = () => count + 1;',
+        'export let b = () => S.count + 1;',
+        'export let c = () => fallback + 1;',
+        'export let d = () => renamed + 1;',
+        'export let e = () => list.length;',
+        'export let f = () => { list[0] = 5; };',
+        'export let g = () => store.items.length;',
+        "export let h = () => S['count'] + 1;"
+    ].join('\n'),
+    'entries.ts': [
+        "import { make, R } from './barrel';",
+        "import * as B from './barrel';",
+        'export let a = make(0);',
+        'export let b = R.reactive(0);',
+        'export let c = B.R.reactive(0);',
+        "export let d = R['reactive'](0);",
+        'const alias = make;',
+        'export let e = alias(0);',
+        'const { reactive: destructured } = R;',
+        'export let f = destructured(0);',
+        'export let g = () => a + b + c + d + e + f;'
+    ].join('\n')
+};
+
+
+let fixtures: string[] = [];
+
+
+function project(files: Record<string, string>) {
+    let directory = mkdtempSync(join(process.cwd(), '.fixture-coverage-')).replace(/\\/g, '/');
+
+    fixtures.push(directory);
+
+    for (let [name, code] of Object.entries(files)) {
+        writeFileSync(join(directory, name), code);
+    }
+
+    writeFileSync(join(directory, 'tsconfig.json'), JSON.stringify({
+        compilerOptions: { module: 'esnext', moduleResolution: 'bundler', strict: true, target: 'esnext', types: [] },
+        files: Object.keys(files).map(name => './' + name)
+    }));
+
+    let plugin = vite({ root: directory });
+
+    plugin.configResolved({ command: 'build', root: directory });
+
+    return {
+        directory,
+        plugin,
+        transform: (name: string) => plugin.transform(files[name], directory + '/' + name)
+    };
+}
+
+
+afterEach(() => {
+    for (let fixture of fixtures) {
+        rmSync(fixture, { force: true, recursive: true });
+    }
+
+    fixtures = [];
+});
+
+
+describe('compiler coverage', () => {
+    it('compiles reads of bindings imported by name, namespace, default, barrel and string key', () => {
+        let output = project(FILES).transform('reads.ts')!.code;
+
+        expect(output).toContain(`export let a = () => ${NAMESPACE}.read(count) + 1;`);
+        expect(output).toContain(`export let b = () => ${NAMESPACE}.read(S.count) + 1;`);
+        expect(output).toContain(`export let c = () => ${NAMESPACE}.read(fallback) + 1;`);
+        expect(output).toContain(`export let d = () => ${NAMESPACE}.read(renamed) + 1;`);
+        expect(output).toContain('export let e = () => list.$length;');
+        expect(output).toContain('list.$set(0, 5)');
+        expect(output).toContain('export let g = () => store.items.$length;');
+        expect(output).toContain(`export let h = () => ${NAMESPACE}.read(S['count']) + 1;`);
+    });
+
+    it('compiles reactive() reached through renames, namespaces, string keys and const aliases', () => {
+        let output = project(FILES).transform('entries.ts')!.code;
+
+        for (let name of ['a', 'b', 'c', 'd', 'e', 'f']) {
+            expect(output).toMatch(new RegExp(`export let ${name} = ${NAMESPACE}\\.signal\\(0\\);`));
+        }
+
+        expect(output).toContain(`${NAMESPACE}.read(a) + ${NAMESPACE}.read(b)`);
+    });
+
+    it('passes every array property of a reactive object to its constructor', () => {
+        let output = project(FILES).transform('state.ts')!.code;
+
+        expect(output).toMatch(/export let store = +new ReactiveObject_\w+\(\[1\]\);/);
+    });
+
+    it('fails the build on every use of reactive that cannot be compiled, with its location', () => {
+        let files = {
+                'escape.ts': [
+                    "import { reactive } from '@esportsplus/reactivity';",
+                    'declare function take(value: unknown): void;',
+                    'take(reactive);',
+                    'take(reactive(0));'
+                ].join('\n')
+            },
+            { transform } = project(files);
+
+        expect(() => transform('escape.ts')).toThrow(/escape\.ts:3:6[\s\S]*escape\.ts:4:6/);
+    });
+
+    it('fails the build when a signal is destructured out of a module namespace', () => {
+        let files = {
+                'state.ts': "import { reactive } from '@esportsplus/reactivity';\nexport let count = reactive(0);",
+                'copy.ts': "import * as S from './state';\nconst { count } = S;\nexport let n = count;"
+            },
+            { transform } = project(files);
+
+        expect(() => transform('copy.ts')).toThrow(/copy\.ts:2:9.*destructured/);
+    });
+
+    it('reports the modules a compile relied on so hosts can recompile it when they change', () => {
+        let { directory, plugin, transform } = project(FILES),
+            dependent = { id: directory + '/reads.ts' };
+
+        transform('reads.ts');
+
+        let result = plugin.handleHotUpdate({
+            file: directory + '/state.ts',
+            modules: [],
+            server: {
+                moduleGraph: {
+                    getModulesByFile: (file: string) => file.toLowerCase() === (directory + '/reads.ts').toLowerCase() ? new Set([dependent]) : undefined,
+                    invalidateModule: () => {}
+                }
+            },
+            timestamp: 1
+        });
+
+        expect(result).toEqual([dependent]);
+    });
+});