@esportsplus/reactivity 0.34.0 → 0.36.1

package/test/reactive/array.test.ts

@@ -3,6 +3,7 @@ import { effect, read, signal, write } from '~/system';
 import { ReactiveArray } from '~/reactive/array';
 import { ReactiveObject } from '~/reactive/object';
 import reactive from '~/reactive/index';
+import { captureUncaught } from '../lib/uncaught';
 
 
 describe('ReactiveArray', () => {
@@ -15,7 +16,7 @@ describe('ReactiveArray', () => {
         });
 
         it('creates array with initial items', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             expect(arr.length).toBe(3);
             expect(arr[0]).toBe(1);
@@ -24,7 +25,7 @@ describe('ReactiveArray', () => {
         });
 
         it('$length is reactive', async () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 lengths: number[] = [];
 
             effect(() => {
@@ -38,12 +39,32 @@ describe('ReactiveArray', () => {
 
             expect(lengths).toEqual([3, 4]);
         });
+
+        it('a single numeric item does not create holes', () => {
+            let arr = reactive([5]);
+
+            expect([...arr]).toEqual([5]);
+            expect(arr.length).toBe(1);
+            expect((arr as unknown as { $length: number }).$length).toBe(1);
+        });
+
+        it('empty and multi-item reactive arrays are unchanged', () => {
+            expect([...reactive([])]).toEqual([]);
+            expect([...reactive([1, 2, 3])]).toEqual([1, 2, 3]);
+        });
+
+        it('does not overflow the stack for a large array', () => {
+            let arr = new ReactiveArray(new Array(500000).fill(0));
+
+            expect(arr.length).toBe(500000);
+            expect(arr.$length).toBe(500000);
+        });
     });
 
 
     describe('$set', () => {
         it('sets value at index', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             arr.$set(1, 20);
 
@@ -51,7 +72,7 @@ describe('ReactiveArray', () => {
         });
 
         it('skips if same value', () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 dispatched = false;
 
             arr.on('set', () => { dispatched = true; });
@@ -61,7 +82,7 @@ describe('ReactiveArray', () => {
         });
 
         it('dispatches set event', () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 events: { index: number; item: number }[] = [];
 
             arr.on('set', (e) => { events.push(e); });
@@ -71,7 +92,7 @@ describe('ReactiveArray', () => {
         });
 
         it('updates length when setting beyond current length', async () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             arr.$set(5, 99);
 
@@ -79,7 +100,7 @@ describe('ReactiveArray', () => {
         });
 
         it('$set beyond length updates $length reactively', async () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 lengths: number[] = [];
 
             effect(() => {
@@ -125,7 +146,7 @@ describe('ReactiveArray', () => {
         });
 
         it('$set with negative index does not affect length', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             arr.$set(-1 as any, 42);
 
@@ -135,7 +156,7 @@ describe('ReactiveArray', () => {
         });
 
         it('$set at large index updates $length', async () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 lengths: number[] = [];
 
             effect(() => {
@@ -155,13 +176,13 @@ describe('ReactiveArray', () => {
 
     describe('$length', () => {
         it('getter returns reactive length', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             expect(arr.$length).toBe(3);
         });
 
         it('setter truncates array via splice', () => {
-            let arr = new ReactiveArray(1, 2, 3, 4, 5);
+            let arr = new ReactiveArray([1, 2, 3, 4, 5]);
 
             arr.$length = 2;
 
@@ -171,7 +192,7 @@ describe('ReactiveArray', () => {
         });
 
         it('throws when setting length larger than current', () => {
-            let arr = new ReactiveArray(1, 2);
+            let arr = new ReactiveArray([1, 2]);
 
             expect(() => { arr.$length = 5; }).toThrow();
         });
@@ -189,7 +210,7 @@ describe('ReactiveArray', () => {
         });
 
         it('returns new length', () => {
-            let arr = new ReactiveArray(1);
+            let arr = new ReactiveArray([1]);
 
             expect(arr.push(2, 3)).toBe(3);
         });
@@ -205,7 +226,7 @@ describe('ReactiveArray', () => {
         });
 
         it('no-op for empty push', () => {
-            let arr = new ReactiveArray(1),
+            let arr = new ReactiveArray([1]),
                 dispatched = false;
 
             arr.on('push', () => { dispatched = true; });
@@ -229,7 +250,7 @@ describe('ReactiveArray', () => {
 
     describe('pop', () => {
         it('removes last item', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             expect(arr.pop()).toBe(3);
             expect(arr.length).toBe(2);
@@ -242,7 +263,7 @@ describe('ReactiveArray', () => {
         });
 
         it('dispatches pop event', () => {
-            let arr = new ReactiveArray(1, 2),
+            let arr = new ReactiveArray([1, 2]),
                 events: { item: number }[] = [];
 
             arr.on('pop', (e) => { events.push(e); });
@@ -262,7 +283,7 @@ describe('ReactiveArray', () => {
         });
 
         it('does not dispatch when popping explicit undefined value', () => {
-            let arr = new ReactiveArray<number | undefined>(1, undefined),
+            let arr = new ReactiveArray<number | undefined>([1, undefined]),
                 dispatched = false;
 
             arr.on('pop', () => { dispatched = true; });
@@ -274,7 +295,7 @@ describe('ReactiveArray', () => {
         });
 
         it('does not update reactive length when popping explicit undefined value', async () => {
-            let arr = new ReactiveArray<number | undefined>(1, undefined),
+            let arr = new ReactiveArray<number | undefined>([1, undefined]),
                 lengths: number[] = [];
 
             effect(() => {
@@ -293,7 +314,7 @@ describe('ReactiveArray', () => {
 
     describe('shift', () => {
         it('removes first item', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             expect(arr.shift()).toBe(1);
             expect(arr.length).toBe(2);
@@ -307,7 +328,7 @@ describe('ReactiveArray', () => {
         });
 
         it('dispatches shift event', () => {
-            let arr = new ReactiveArray(10, 20),
+            let arr = new ReactiveArray([10, 20]),
                 events: { item: number }[] = [];
 
             arr.on('shift', (e) => { events.push(e); });
@@ -317,7 +338,7 @@ describe('ReactiveArray', () => {
         });
 
         it('does not dispatch when shifting explicit undefined value', () => {
-            let arr = new ReactiveArray<number | undefined>(undefined, 1, 2),
+            let arr = new ReactiveArray<number | undefined>([undefined, 1, 2]),
                 dispatched = false;
 
             arr.on('shift', () => { dispatched = true; });
@@ -330,7 +351,7 @@ describe('ReactiveArray', () => {
         });
 
         it('does not update reactive length when shifting explicit undefined value', async () => {
-            let arr = new ReactiveArray<number | undefined>(undefined, 1, 2),
+            let arr = new ReactiveArray<number | undefined>([undefined, 1, 2]),
                 lengths: number[] = [];
 
             effect(() => {
@@ -360,7 +381,7 @@ describe('ReactiveArray', () => {
         });
 
         it('returns new length', () => {
-            let arr = new ReactiveArray(1);
+            let arr = new ReactiveArray([1]);
 
             expect(arr.unshift(0)).toBe(2);
         });
@@ -376,7 +397,7 @@ describe('ReactiveArray', () => {
         });
 
         it('no-op for empty unshift', async () => {
-            let arr = new ReactiveArray(1, 2),
+            let arr = new ReactiveArray([1, 2]),
                 dispatched = false,
                 lengths: number[] = [];
 
@@ -399,7 +420,7 @@ describe('ReactiveArray', () => {
 
     describe('splice', () => {
         it('removes items', () => {
-            let arr = new ReactiveArray(1, 2, 3, 4, 5);
+            let arr = new ReactiveArray([1, 2, 3, 4, 5]);
 
             let removed = arr.splice(1, 2);
 
@@ -408,7 +429,7 @@ describe('ReactiveArray', () => {
         });
 
         it('inserts items', () => {
-            let arr = new ReactiveArray(1, 4, 5);
+            let arr = new ReactiveArray([1, 4, 5]);
 
             arr.splice(1, 0, 2, 3);
 
@@ -416,7 +437,7 @@ describe('ReactiveArray', () => {
         });
 
         it('replaces items', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             arr.splice(1, 1, 20);
 
@@ -424,7 +445,7 @@ describe('ReactiveArray', () => {
         });
 
         it('dispatches splice event', () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 events: { start: number; deleteCount: number; items: number[] }[] = [];
 
             arr.on('splice', (e) => { events.push(e); });
@@ -434,7 +455,7 @@ describe('ReactiveArray', () => {
         });
 
         it('no event when nothing changes', () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 dispatched = false;
 
             arr.on('splice', () => { dispatched = true; });
@@ -444,7 +465,7 @@ describe('ReactiveArray', () => {
         });
 
         it('splice with start beyond array length removes nothing', () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 dispatched = false;
 
             arr.on('splice', () => { dispatched = true; });
@@ -457,7 +478,7 @@ describe('ReactiveArray', () => {
         });
 
         it('splice with negative start removes from end', () => {
-            let arr = new ReactiveArray(1, 2, 3, 4, 5),
+            let arr = new ReactiveArray([1, 2, 3, 4, 5]),
                 events: { start: number; deleteCount: number; items: number[] }[] = [];
 
             arr.on('splice', (e) => { events.push(e); });
@@ -473,7 +494,7 @@ describe('ReactiveArray', () => {
 
     describe('concat', () => {
         it('appends arrays', () => {
-            let arr = new ReactiveArray(1, 2);
+            let arr = new ReactiveArray([1, 2]);
 
             arr.concat([3, 4], [5]);
 
@@ -490,7 +511,7 @@ describe('ReactiveArray', () => {
         });
 
         it('returns this (mutating)', () => {
-            let arr = new ReactiveArray(1);
+            let arr = new ReactiveArray([1]);
             let result = arr.concat([2]);
 
             expect(result).toBe(arr);
@@ -507,7 +528,7 @@ describe('ReactiveArray', () => {
         });
 
         it('no event when nothing added', () => {
-            let arr = new ReactiveArray(1),
+            let arr = new ReactiveArray([1]),
                 dispatched = false;
 
             arr.on('concat', () => { dispatched = true; });
@@ -517,7 +538,7 @@ describe('ReactiveArray', () => {
         });
 
         it('concat with mixed arrays and single primitive values', () => {
-            let arr = new ReactiveArray(1, 2),
+            let arr = new ReactiveArray([1, 2]),
                 events: number[][] = [];
 
             arr.on('concat', (e) => { events.push(e.items); });
@@ -531,7 +552,7 @@ describe('ReactiveArray', () => {
 
     describe('reverse', () => {
         it('reverses in place', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             arr.reverse();
 
@@ -539,13 +560,13 @@ describe('ReactiveArray', () => {
         });
 
         it('returns this', () => {
-            let arr = new ReactiveArray(1, 2);
+            let arr = new ReactiveArray([1, 2]);
 
             expect(arr.reverse()).toBe(arr);
         });
 
         it('dispatches reverse event', () => {
-            let arr = new ReactiveArray(1, 2),
+            let arr = new ReactiveArray([1, 2]),
                 dispatched = false;
 
             arr.on('reverse', () => { dispatched = true; });
@@ -558,7 +579,7 @@ describe('ReactiveArray', () => {
 
     describe('sort', () => {
         it('sorts in place', () => {
-            let arr = new ReactiveArray(3, 1, 2);
+            let arr = new ReactiveArray([3, 1, 2]);
 
             arr.sort((a, b) => a - b);
 
@@ -566,13 +587,13 @@ describe('ReactiveArray', () => {
         });
 
         it('returns this', () => {
-            let arr = new ReactiveArray(3, 1);
+            let arr = new ReactiveArray([3, 1]);
 
             expect(arr.sort()).toBe(arr);
         });
 
         it('dispatches sort event with order', () => {
-            let arr = new ReactiveArray(3, 1, 2),
+            let arr = new ReactiveArray([3, 1, 2]),
                 order: number[] = [];
 
             arr.on('sort', (e) => { order = e.order; });
@@ -584,7 +605,7 @@ describe('ReactiveArray', () => {
         });
 
         it('handles duplicates in sort', () => {
-            let arr = new ReactiveArray(2, 1, 2),
+            let arr = new ReactiveArray([2, 1, 2]),
                 order: number[] = [];
 
             arr.on('sort', (e) => { order = e.order; });
@@ -593,11 +614,32 @@ describe('ReactiveArray', () => {
             expect([...arr]).toEqual([1, 2, 2]);
         });
 
+        it('order maps duplicate values stably (first stays first)', () => {
+            let arr = new ReactiveArray([3, 1, 3, 2]),
+                order: number[] = [];
+
+            arr.on('sort', (e) => { order = e.order; });
+            arr.sort((a, b) => a - b);
+
+            expect([...arr]).toEqual([1, 2, 3, 3]);
+            expect(order).toEqual([1, 3, 0, 2]);
+        });
+
+        it('all-equal array yields identity order', () => {
+            let arr = new ReactiveArray([5, 5, 5]),
+                order: number[] = [];
+
+            arr.on('sort', (e) => { order = e.order; });
+            arr.sort((a, b) => a - b);
+
+            expect(order).toEqual([0, 1, 2]);
+        });
+
         it('sort preserves object references', () => {
             let a = { id: 3 },
                 b = { id: 1 },
                 c = { id: 2 },
-                arr = new ReactiveArray(a, b, c);
+                arr = new ReactiveArray([a, b, c]);
 
             arr.sort((x, y) => x.id - y.id);
 
@@ -611,7 +653,7 @@ describe('ReactiveArray', () => {
 
     describe('clear', () => {
         it('empties array', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             arr.clear();
 
@@ -619,7 +661,7 @@ describe('ReactiveArray', () => {
         });
 
         it('dispatches clear event', () => {
-            let arr = new ReactiveArray(1, 2),
+            let arr = new ReactiveArray([1, 2]),
                 dispatched = false;
 
             arr.on('clear', () => { dispatched = true; });
@@ -629,7 +671,7 @@ describe('ReactiveArray', () => {
         });
 
         it('updates reactive length to 0', async () => {
-            let arr = new ReactiveArray(1, 2, 3),
+            let arr = new ReactiveArray([1, 2, 3]),
                 lengths: number[] = [];
 
             effect(() => { lengths.push(arr.$length); });
@@ -643,7 +685,7 @@ describe('ReactiveArray', () => {
 
     describe('dispose', () => {
         it('empties array', () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             arr.dispose();
 
@@ -651,7 +693,7 @@ describe('ReactiveArray', () => {
         });
 
         it('sets reactive length to 0', async () => {
-            let arr = new ReactiveArray(1, 2, 3);
+            let arr = new ReactiveArray([1, 2, 3]);
 
             arr.dispose();
 
@@ -696,27 +738,33 @@ describe('ReactiveArray', () => {
             expect(calls).toBe(1);
         });
 
-        it('listener errors are caught and listener removed', () => {
+        it('listener errors surface asynchronously and the listener is removed', async () => {
             let arr = new ReactiveArray<number>(),
-                calls = 0;
+                calls = 0,
+                captured = await captureUncaught(() => {
+                    arr.on('push', () => { throw new Error('reactivity: test'); });
+                    arr.on('push', () => { calls++; });
 
-            arr.on('push', () => { throw new Error('test'); });
-            arr.on('push', () => { calls++; });
-
-            arr.push(1);
-            arr.push(2);
+                    arr.push(1);
+                    arr.push(2);
+                });
 
             expect(calls).toBe(2);
+            expect(captured.length).toBe(1);
+            expect((captured[0] as Error).message).toBe('reactivity: test');
         });
 
-        it('null slots reused for new listeners', () => {
-            let arr = new ReactiveArray<number>();
+        it('null slots reused for new listeners', async () => {
+            let arr = new ReactiveArray<number>(),
+                fn1 = () => { throw new Error('reactivity: remove me'); },
+                fn2 = vi.fn();
 
-            let fn1 = () => { throw new Error('remove me'); };
-            let fn2 = vi.fn();
+            let captured = await captureUncaught(() => {
+                arr.on('push', fn1);
+                arr.push(1); // fn1 throws and gets nulled
+            });
 
-            arr.on('push', fn1);
-            arr.push(1); // fn1 throws and gets nulled
+            expect(captured.length).toBe(1);
 
             arr.on('push', fn2);
             arr.push(2);
@@ -724,23 +772,26 @@ describe('ReactiveArray', () => {
             expect(fn2).toHaveBeenCalledTimes(1);
         });
 
-        it('multiple listeners removed via errors, new listeners fill holes in order', () => {
+        it('multiple listeners removed via errors, new listeners fill holes in order', async () => {
             let arr = new ReactiveArray<number>(),
-                order: number[] = [];
-
-            let err1 = () => { throw new Error('err1'); };
-            let err2 = () => { throw new Error('err2'); };
-            let fn3 = vi.fn();
-
-            arr.on('push', err1);
-            arr.on('push', err2);
-            arr.on('push', fn3);
-            arr.push(1); // err1 and err2 throw, slots 0 and 1 nulled
+                err1 = () => { throw new Error('reactivity: err1'); },
+                err2 = () => { throw new Error('reactivity: err2'); },
+                fn3 = vi.fn();
+
+            let captured = await captureUncaught(() => {
+                arr.on('push', err1);
+                arr.on('push', err2);
+                arr.on('push', fn3);
+                arr.push(1); // err1 and err2 throw, slots 0 and 1 nulled
+            });
 
             expect(fn3).toHaveBeenCalledTimes(1);
+            expect(captured.length).toBe(1);
+            expect(captured[0]).toBeInstanceOf(AggregateError);
+            expect((captured[0] as AggregateError).errors.length).toBe(2);
 
-            let fn4 = vi.fn();
-            let fn5 = vi.fn();
+            let fn4 = vi.fn(),
+                fn5 = vi.fn();
 
             arr.on('push', fn4); // fills hole at slot 0
             arr.on('push', fn5); // fills hole at slot 1
@@ -751,39 +802,44 @@ describe('ReactiveArray', () => {
             expect(fn5).toHaveBeenCalledTimes(1);
         });
 
-        it('trailing null slots cleaned after dispatch', () => {
-            let arr = new ReactiveArray<number>();
-
-            let fn1 = vi.fn();
-            let err2 = () => { throw new Error('remove'); };
+        it('trailing null slots cleaned after dispatch', async () => {
+            let arr = new ReactiveArray<number>(),
+                fn1 = vi.fn(),
+                err2 = () => { throw new Error('reactivity: remove'); };
 
-            arr.on('push', fn1);
-            arr.on('push', err2);
+            let captured = await captureUncaught(() => {
+                arr.on('push', fn1);
+                arr.on('push', err2);
 
-            // Before dispatch: listeners = [fn1, err2] (length 2)
-            arr.push(1); // err2 throws → nulled → trailing null cleaned
+                // Before dispatch: listeners = [fn1, err2] (length 2)
+                arr.push(1); // err2 throws → nulled → trailing null cleaned
+            });
 
             // Trailing null should be cleaned, so internal array length is 1
             expect(arr.listeners['push']!.length).toBe(1);
             expect(fn1).toHaveBeenCalledTimes(1);
+            expect(captured.length).toBe(1);
         });
 
-        it('on() inserts after trailing nulls cleaned from dispatch', () => {
+        it('on() inserts after trailing nulls cleaned from dispatch', async () => {
             let arr = new ReactiveArray<number>(),
                 fn1 = vi.fn(),
-                fn2 = () => { throw new Error('err2'); },
-                fn3 = () => { throw new Error('err3'); };
+                fn2 = () => { throw new Error('reactivity: err2'); },
+                fn3 = () => { throw new Error('reactivity: err3'); };
 
-            arr.on('push', fn1);
-            arr.on('push', fn2);
-            arr.on('push', fn3);
+            let captured = await captureUncaught(() => {
+                arr.on('push', fn1);
+                arr.on('push', fn2);
+                arr.on('push', fn3);
 
-            // Dispatch: fn2 and fn3 throw → nulled → trailing nulls cleaned
-            // listeners = [fn1, null, null] → cleanup → [fn1]
-            arr.push(1);
+                // Dispatch: fn2 and fn3 throw → nulled → trailing nulls cleaned
+                // listeners = [fn1, null, null] → cleanup → [fn1]
+                arr.push(1);
+            });
 
             expect(fn1).toHaveBeenCalledTimes(1);
             expect(arr.listeners['push']!.length).toBe(1);
+            expect(captured[0]).toBeInstanceOf(AggregateError);
 
             // Register fn4 — should append at index 1 (no holes left)
             let fn4 = vi.fn();
@@ -942,7 +998,7 @@ describe('ReactiveArray', () => {
                 spyB = vi.spyOn(b, 'dispose'),
                 spyC = vi.spyOn(c, 'dispose');
 
-            let arr = new ReactiveArray<ReactiveObject<any>>(a, b, c);
+            let arr = new ReactiveArray<ReactiveObject<any>>([a, b, c]);
 
             arr.dispose();
 
@@ -958,7 +1014,7 @@ describe('ReactiveArray', () => {
                 spyA = vi.spyOn(a, 'dispose'),
                 spyB = vi.spyOn(b, 'dispose');
 
-            let arr = new ReactiveArray<ReactiveObject<any>>(a, b);
+            let arr = new ReactiveArray<ReactiveObject<any>>([a, b]);
 
             arr.clear();
 
@@ -973,7 +1029,7 @@ describe('ReactiveArray', () => {
                 spyA = vi.spyOn(a, 'dispose'),
                 spyB = vi.spyOn(b, 'dispose');
 
-            let arr = new ReactiveArray<ReactiveObject<any>>(a, b);
+            let arr = new ReactiveArray<ReactiveObject<any>>([a, b]);
 
             arr.pop();
 
@@ -988,7 +1044,7 @@ describe('ReactiveArray', () => {
                 spyA = vi.spyOn(a, 'dispose'),
                 spyB = vi.spyOn(b, 'dispose');
 
-            let arr = new ReactiveArray<ReactiveObject<any>>(a, b);
+            let arr = new ReactiveArray<ReactiveObject<any>>([a, b]);
 
             arr.shift();
 
@@ -1007,7 +1063,7 @@ describe('ReactiveArray', () => {
                 spyC = vi.spyOn(c, 'dispose'),
                 spyD = vi.spyOn(d, 'dispose');
 
-            let arr = new ReactiveArray<ReactiveObject<any>>(a, b, c, d);
+            let arr = new ReactiveArray<ReactiveObject<any>>([a, b, c, d]);
 
             arr.splice(1, 2);
 
@@ -1026,7 +1082,7 @@ describe('ReactiveArray', () => {
                 spyB = vi.spyOn(b, 'dispose'),
                 spyR = vi.spyOn(replacement, 'dispose');
 
-            let arr = new ReactiveArray<ReactiveObject<any>>(a, b);
+            let arr = new ReactiveArray<ReactiveObject<any>>([a, b]);
 
             arr.splice(0, 1, replacement);
 
@@ -1036,10 +1092,24 @@ describe('ReactiveArray', () => {
             expect(arr.length).toBe(2);
         });
 
+        it('$set() disposes the replaced ReactiveObject', () => {
+            let a = new ReactiveObject({ x: 1 }),
+                b = new ReactiveObject({ y: 2 }),
+                spyA = vi.spyOn(a, 'dispose'),
+                spyB = vi.spyOn(b, 'dispose'),
+                arr = new ReactiveArray<ReactiveObject<any>>([a]);
+
+            arr.$set(0, b);
+
+            expect(spyA).toHaveBeenCalledTimes(1);
+            expect(spyB).not.toHaveBeenCalled();
+            expect(arr[0]).toBe(b);
+        });
+
         it('does not dispose non-ReactiveObject elements', () => {
             let obj = { dispose: vi.fn() };
 
-            let arr = new ReactiveArray<any>(1, 'str', obj);
+            let arr = new ReactiveArray<any>([1, 'str', obj]);
 
             arr.dispose();