@esportsplus/reactivity 0.25.2 → 0.25.3

package/build/reactive/index.d.ts

@@ -1,5 +1,4 @@
 import { Prettify } from '@esportsplus/utilities';
-import { REACTIVE_OBJECT } from '../constants.js';
 import { ReactiveArray } from './array.js';
 declare const READONLY: unique symbol;
 type Infer<T> = T extends (...args: unknown[]) => Promise<infer R> ? R | undefined : T extends (...args: any[]) => infer R ? R : T extends (infer U)[] ? ReactiveArray<U> : T extends ReactiveObject<any> ? T : T extends Record<PropertyKey, unknown> ? {
@@ -8,7 +7,6 @@ type Infer<T> = T extends (...args: unknown[]) => Promise<infer R> ? R | undefin
 type ReactiveObject<T> = T extends Record<PropertyKey, unknown> ? Prettify<{
     [K in keyof T]: Infer<T[K]>;
 } & {
-    [REACTIVE_OBJECT]: true;
     dispose: VoidFunction;
 }> : T extends (infer U)[] ? ReactiveArray<U> : never;
 type ReactiveObjectGuard<T> = T extends {

package/build/reactive/index.js

@@ -1,4 +1,3 @@
-import { REACTIVE_OBJECT } from '../constants.js';
 import { ReactiveArray } from './array.js';
 function reactive(_input) {
     throw new Error('@esportsplus/reactivity: reactive() called at runtime. ' +

package/build/transformer/transforms/array.js

@@ -23,6 +23,9 @@ function getPropertyPath(node) {
 }
 function isAssignmentTarget(node) {
     let parent = node.parent;
+    if (!parent) {
+        return false;
+    }
     if ((ts.isBinaryExpression(parent) && parent.left === node) ||
         ts.isPostfixUnaryExpression(parent) ||
         ts.isPrefixUnaryExpression(parent)) {

package/build/transformer/transforms/object.js

@@ -83,7 +83,7 @@ function visit(ctx, node) {
         let arg = node.arguments[0];
         if (arg && ts.isObjectLiteralExpression(arg)) {
             let varName = null;
-            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
+            if (node.parent && ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
                 varName = node.parent.name.text;
                 ctx.bindings.set(varName, 'object');
             }

package/build/transformer/transforms/primitives.js

@@ -170,10 +170,11 @@ function visit(ctx, node) {
         let arg = node.arguments[0], classification = classifyReactiveArg(arg);
         if (classification) {
             let varName = null;
-            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
+            if (node.parent && ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
                 varName = node.parent.name.text;
             }
-            else if (ts.isBinaryExpression(node.parent) &&
+            else if (node.parent &&
+                ts.isBinaryExpression(node.parent) &&
                 node.parent.operatorToken.kind === ts.SyntaxKind.EqualsToken &&
                 ts.isIdentifier(node.parent.left)) {
                 varName = node.parent.left.text;
@@ -215,7 +216,7 @@ function visit(ctx, node) {
             }
         }
     }
-    if (ts.isIdentifier(node) && !isInDeclarationInit(node.parent)) {
+    if (ts.isIdentifier(node) && node.parent && !isInDeclarationInit(node.parent)) {
         if (ts.isPropertyAccessExpression(node.parent) && node.parent.name === node) {
             ts.forEachChild(node, n => visit(ctx, n));
             return;
@@ -226,7 +227,7 @@ function visit(ctx, node) {
             return;
         }
         let binding = findBinding(ctx.scopedBindings, node.text, node), name = node.text;
-        if (binding) {
+        if (binding && node.parent) {
             if (!isReactiveReassignment(node.parent) &&
                 !(ts.isTypeOfExpression(node.parent) && node.parent.expression === node)) {
                 let writeCtx = isWriteContext(node);
@@ -291,7 +292,7 @@ function visit(ctx, node) {
     ts.forEachChild(node, n => visit(ctx, n));
 }
 function visitArg(ctx, node) {
-    if (ts.isIdentifier(node)) {
+    if (ts.isIdentifier(node) && node.parent) {
         if (ts.isPropertyAccessExpression(node.parent) && node.parent.name === node) {
             ts.forEachChild(node, n => visitArg(ctx, n));
             return;

package/package.json

@@ -4,7 +4,7 @@
     "@esportsplus/utilities": "^0.27.2"
   },
   "devDependencies": {
-    "@esportsplus/typescript": "^0.17.3",
+    "@esportsplus/typescript": "^0.17.4",
     "@types/node": "^25.0.3",
     "vite": "^7.3.0"
   },
@@ -36,7 +36,7 @@
   },
   "type": "module",
   "types": "build/index.d.ts",
-  "version": "0.25.2",
+  "version": "0.25.3",
   "scripts": {
     "build": "tsc",
     "build:test": "pnpm build && vite build --config test/vite.config.ts",

package/src/reactive/index.ts

@@ -1,5 +1,4 @@
 import { Prettify } from '@esportsplus/utilities';
-import { REACTIVE_OBJECT } from '~/constants';
 import { ReactiveArray } from './array';
 
 
@@ -21,10 +20,7 @@ type Infer<T> =
 
 type ReactiveObject<T> =
     T extends Record<PropertyKey, unknown>
-        ? Prettify<{ [K in keyof T]: Infer<T[K]> } & {
-            [REACTIVE_OBJECT]: true;
-            dispose: VoidFunction
-        }>
+        ? Prettify<{ [K in keyof T]: Infer<T[K]> } & { dispose: VoidFunction }>
         : T extends (infer U)[]
             ? ReactiveArray<U>
             : never;

package/src/transformer/transforms/array.ts

@@ -42,6 +42,10 @@ function getPropertyPath(node: ts.PropertyAccessExpression): string | null {
 function isAssignmentTarget(node: ts.Node): boolean {
     let parent = node.parent;
 
+    if (!parent) {
+        return false;
+    }
+
     if (
         (ts.isBinaryExpression(parent) && parent.left === node) ||
         ts.isPostfixUnaryExpression(parent) ||

package/src/transformer/transforms/object.ts

@@ -140,7 +140,7 @@ function visit(ctx: TransformContext, node: ts.Node): void {
         if (arg && ts.isObjectLiteralExpression(arg)) {
             let varName: string | null = null;
 
-            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
+            if (node.parent && ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
                 varName = node.parent.name.text;
                 ctx.bindings.set(varName, 'object');
             }

package/src/transformer/transforms/primitives.ts

@@ -245,10 +245,11 @@ function visit(ctx: TransformContext, node: ts.Node): void {
         if (classification) {
             let varName: string | null = null;
 
-            if (ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
+            if (node.parent && ts.isVariableDeclaration(node.parent) && ts.isIdentifier(node.parent.name)) {
                 varName = node.parent.name.text;
             }
             else if (
+                node.parent &&
                 ts.isBinaryExpression(node.parent) &&
                 node.parent.operatorToken.kind === ts.SyntaxKind.EqualsToken &&
                 ts.isIdentifier(node.parent.left)
@@ -303,7 +304,7 @@ function visit(ctx: TransformContext, node: ts.Node): void {
         }
     }
 
-    if (ts.isIdentifier(node) && !isInDeclarationInit(node.parent)) {
+    if (ts.isIdentifier(node) && node.parent && !isInDeclarationInit(node.parent)) {
         if (ts.isPropertyAccessExpression(node.parent) && node.parent.name === node) {
             ts.forEachChild(node, n => visit(ctx, n));
             return;
@@ -319,7 +320,7 @@ function visit(ctx: TransformContext, node: ts.Node): void {
         let binding = findBinding(ctx.scopedBindings, node.text, node),
             name = node.text;
 
-        if (binding) {
+        if (binding && node.parent) {
             if (
                 !isReactiveReassignment(node.parent) &&
                 !(ts.isTypeOfExpression(node.parent) && node.parent.expression === node)
@@ -399,7 +400,7 @@ function visit(ctx: TransformContext, node: ts.Node): void {
 }
 
 function visitArg(ctx: ArgContext, node: ts.Node): void {
-    if (ts.isIdentifier(node)) {
+    if (ts.isIdentifier(node) && node.parent) {
         if (ts.isPropertyAccessExpression(node.parent) && node.parent.name === node) {
             ts.forEachChild(node, n => visitArg(ctx, n));
             return;

package/storage/tsc-transform-analysis-2026-01-04.md

@@ -0,0 +1,125 @@
+# TSC Transform Analysis Report: @esportsplus/reactivity
+
+## Executive Summary
+
+1. **The library build is working as designed** - the reactivity library itself doesn't need transformation
+2. **Test build transformations work correctly** - vite plugin transforms `reactive()` calls
+3. **Confusion point**: The library PROVIDES transformers, it doesn't CONSUME them
+
+## Findings
+
+### How @esportsplus/typescript Custom TSC Works
+
+| File | Purpose |
+|------|---------|
+| [bin/tsc](node_modules/.pnpm/@esportsplus+typescript@0.17.3/node_modules/@esportsplus/typescript/bin/tsc) | Entry point - calls build/cli/tsc.js |
+| [build/cli/tsc.js:122-137](node_modules/.pnpm/@esportsplus+typescript@0.17.3/node_modules/@esportsplus/typescript/build/cli/tsc.js#L122-L137) | Main logic - checks for plugins in tsconfig |
+
+**Critical Logic** (cli/tsc.js:128-131):
+```javascript
+let plugins = getPlugins(tsconfig);
+if (plugins.length === 0) {
+    passthrough();  // Falls back to standard tsc
+    return;
+}
+```
+
+**Plugin Detection** (cli/tsc.js:97-98):
+```javascript
+return config?.compilerOptions?.plugins?.filter(
+    (p) => typeof p === 'object' && p !== null && 'transform' in p
+) ?? [];
+```
+
+### Why Library Build Has No Transformations
+
+| Issue | Evidence |
+|-------|----------|
+| No plugins configured | [tsconfig.json:1-3](tsconfig.json#L1-L3) only extends base config, no `compilerOptions.plugins` |
+| Library defines `reactive()` | [src/reactive/index.ts:42-47](src/reactive/index.ts#L42-L47) - throws at runtime by design |
+| Library doesn't use `reactive()` | Source files don't call `reactive()` as a consumer would |
+
+### Test Build Works Correctly
+
+**Source** ([test/primitives.ts:11](test/primitives.ts#L11)):
+```typescript
+let count = reactive(0);
+count = 10;
+console.log('Initial count:', count);
+```
+
+**Transformed Output** ([test/build/primitives.js:48-51](test/build/primitives.js#L48-L51)):
+```javascript
+let count = signal(0);
+set(count, 10);
+console.log("Initial count:", read(count));
+```
+
+**Reactive Objects** transform to classes with signal-backed getters/setters:
+```javascript
+class ReactiveObject_xxx {
+  #count = signal(0);
+  get count() { return read(this.#count); }
+  set count(v) { set(this.#count, v); }
+}
+```
+
+## Architecture
+
+```
+@esportsplus/reactivity
+├── src/                      # Library source (NOT transformed)
+│   ├── reactive/             # reactive() function definition
+│   └── transformer/          # Transformer implementation
+│       └── plugins/
+│           ├── tsc.ts        # TSC plugin for consumers
+│           └── vite.ts       # Vite plugin for consumers
+├── build/                    # Compiled library (standard tsc output)
+└── test/                     # Test files USING reactive()
+    └── build/                # Transformed test output (via vite)
+```
+
+## Build Commands
+
+| Command | What It Does | Uses Transformer? |
+|---------|--------------|-------------------|
+| `pnpm build` | Compiles library src/ to build/ | No - intentional |
+| `pnpm build:test` | Compiles test/ via vite | Yes - via vite plugin |
+
+## Expected Behavior
+
+The reactivity library follows a **compile-time transformation** pattern:
+
+1. **Library provides**: `reactive()` function + transformer plugins
+2. **Consumers configure**: transformer plugin in their build (vite/tsc)
+3. **At build time**: `reactive()` calls → signal/read/set/computed calls
+4. **At runtime**: If transformation didn't happen, `reactive()` throws with helpful error
+
+## If You Want TSC Plugins in Library Build
+
+Add to [tsconfig.json](tsconfig.json):
+```json
+{
+    "extends": "@esportsplus/typescript/tsconfig.package.json",
+    "compilerOptions": {
+        "plugins": [
+            { "transform": "@esportsplus/reactivity/plugins/tsc" }
+        ]
+    }
+}
+```
+
+**Note**: This would only affect files that actually use `reactive()` - the library source doesn't, so no change would occur.
+
+## Recommended Actions
+
+1. **If transformations ARE expected in library build**: Add plugins config to tsconfig.json
+2. **If testing transformer**: Run `pnpm build:test` to see transformations
+3. **If issue is in consuming project**: Ensure plugin is configured in consumer's build
+
+## Next Steps
+
+Clarify the specific scenario where transformations aren't working:
+- "Show me the file that should be transformed"
+- "What build command are you running?"
+- "Is this the library or a consuming project?"