@esphome/compose-eslint 0.2.0 → 0.3.0

package/dist/index.mjs

@@ -176,6 +176,53 @@ var jsx_children_intents_default = createRule({
   }
 });
 
+// src/rules/no-nested-functions.ts
+import { ESLintUtils as ESLintUtils2 } from "@typescript-eslint/utils";
+var createRule2 = ESLintUtils2.RuleCreator(
+  (name) => `https://github.com/xmlguy74/espcompose/blob/main/docs/rules/${name}.md`
+);
+var no_nested_functions_default = createRule2({
+  name: "no-nested-functions",
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Disallow function declarations nested inside other functions. Only top-level function declarations are compiled into ESPHome scripts."
+    },
+    messages: {
+      nestedFunction: `Function declaration "{{ name }}" is nested inside another function. Move it to the module's top level so the compiler can transform it into an ESPHome script, or use an inline arrow function in the trigger prop.`
+    },
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    let functionDepth = 0;
+    function enterFunction() {
+      functionDepth++;
+    }
+    function exitFunction() {
+      functionDepth--;
+    }
+    return {
+      // Track all function-like boundaries (declarations, expressions, arrows)
+      FunctionDeclaration(node) {
+        if (functionDepth > 0 && node.id) {
+          context.report({
+            node,
+            messageId: "nestedFunction",
+            data: { name: node.id.name }
+          });
+        }
+        enterFunction();
+      },
+      "FunctionDeclaration:exit": exitFunction,
+      FunctionExpression: enterFunction,
+      "FunctionExpression:exit": exitFunction,
+      ArrowFunctionExpression: enterFunction,
+      "ArrowFunctionExpression:exit": exitFunction
+    };
+  }
+});
+
 // src/index.ts
 var plugin = {
   meta: {
@@ -184,7 +231,9 @@ var plugin = {
   },
   rules: {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    "jsx-children-intents": jsx_children_intents_default
+    "jsx-children-intents": jsx_children_intents_default,
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    "no-nested-functions": no_nested_functions_default
   }
 };
 var recommended = [
@@ -209,7 +258,10 @@ var recommended = [
         varsIgnorePattern: "^ESPCompose$"
       }],
       // Enforce valid parent-child component nesting based on declared intents.
-      "@esphome/compose-eslint/jsx-children-intents": "error"
+      "@esphome/compose-eslint/jsx-children-intents": "error",
+      // Prevent nested function declarations — only top-level functions become
+      // ESPHome scripts; nested ones are silently ignored by the compiler.
+      "@esphome/compose-eslint/no-nested-functions": "error"
     }
   },
   {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@esphome/compose-eslint",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "description": "ESLint plugin with custom rules for ESPHome Compose projects",
   "main": "dist/index.mjs",
   "module": "dist/index.mjs",
@@ -35,17 +35,17 @@
   },
   "dependencies": {
     "@typescript-eslint/utils": "^8.0.0",
-    "typescript-eslint": "^8.0.0",
-    "@esphome/compose": "0.2.0"
+    "typescript-eslint": "^8.57.2",
+    "@esphome/compose": "0.3.0"
   },
   "peerDependencies": {
     "eslint": ">=9.0.0"
   },
   "devDependencies": {
     "@typescript-eslint/rule-tester": "^8.0.0",
-    "eslint": "^9.0.0",
+    "eslint": "^9.39.4",
     "tsup": "^8.0.0",
-    "typescript": "^5.4.0",
+    "typescript": "^5.9.3",
     "vitest": "^2.0.0"
   },
   "scripts": {