@es-joy/jsoe 0.28.0 → 0.28.2

package/src/fundamentalTypes/fileType.js

@@ -232,7 +232,7 @@ function binaryButton (
                 ['textarea', {
                   class: 'view-binary'
                 }, [
-                  /* istanbul ignore next */
+                  /* istanbul ignore next -- Guard */
                   /** @type {string|null} */ (reader.result) ?? ''
                 ]]
               ]]
@@ -242,11 +242,11 @@ function binaryButton (
         // Seems not feasible to accurately simulate
         reader.addEventListener(
           'error',
-          /* istanbul ignore next */
+          /* istanbul ignore next -- Should not err */
           async function () {
-            /* istanbul ignore next */
+            /* istanbul ignore next -- Should not err */
             console.error(reader.error);
-            /* istanbul ignore next */
+            /* istanbul ignore next -- Should not err */
             await dialogs.alert(/** @type {string} */ (
               /** @type {DOMException} */ (reader.error).message
             ));
@@ -341,7 +341,7 @@ const fileType = {
               'Text source',
               ['br'],
               ['textarea', {class: 'view-text'}, [
-                /* istanbul ignore next */
+                /* istanbul ignore next -- Guard */
                 /** @type {string|null} */ (reader.result) ?? ''
               ]]
             ]));
@@ -349,11 +349,11 @@ const fileType = {
           // Seems not feasible to accurately simulate
           reader.addEventListener(
             'error',
-            /* istanbul ignore next */
+            /* istanbul ignore next -- Should not err */
             function () {
-              /* istanbul ignore next */
+              /* istanbul ignore next -- Should not err */
               console.error(reader.error);
-              /* istanbul ignore next */
+              /* istanbul ignore next -- Should not err */
               div.append(
                 /** @type {DOMException} */ (reader.error).message
               );
@@ -882,7 +882,7 @@ const fileType = {
 
                 if (constraints) {
                   const mediaStream = await getUserMedia(constraints);
-                  /* istanbul ignore if */
+                  /* istanbul ignore if -- Should be present */
                   if (!mediaStream) {
                     await dialogs.alert('Error getting user media');
                     return;
@@ -930,7 +930,7 @@ const fileType = {
                   const mediaStream = await startScreenCapture(
                     screenShareConstraints
                   );
-                  /* istanbul ignore if */
+                  /* istanbul ignore if -- Should not err */
                   if (!mediaStream) {
                     await dialogs.alert('Error getting user media');
                     return;
@@ -1010,7 +1010,7 @@ const fileType = {
                     'video.previewMedia'
                   ));
 
-                /* istanbul ignore if */
+                /* istanbul ignore if -- Should not err */
                 if (!previewMedia.srcObject) {
                   dialogs.alert('No stream found to record');
                   return;
@@ -1044,7 +1044,7 @@ const fileType = {
 
                 try {
                   mediaRecorder.start();
-                } catch /* istanbul ignore next */ {
+                } catch /* istanbul ignore next -- Should not err */ {
                   dialogs.alert('Error starting media recorder');
                   return;
                 }
@@ -1195,7 +1195,7 @@ const fileType = {
                   ($e(videoContainer, 'img.photo'));
 
                 canvas.toBlob((blob) => {
-                  /* istanbul ignore if */
+                  /* istanbul ignore if -- Should not err */
                   if (!blob) {
                     dialogs.alert('Error converting canvas to Blob');
                     return;

package/src/fundamentalTypes/regexpType.js

@@ -19,7 +19,7 @@ const regexpType = {
     return toStringTag(x) === 'RegExp';
   },
   toValue (s) {
-    /* istanbul ignore if */
+    /* istanbul ignore if -- TS */
     if (typeof this.stringRegex !== 'function') {
       throw new TypeError('Guard for TS');
     }

package/src/fundamentalTypes/stringType.js

@@ -128,6 +128,11 @@ const stringType = {
       }
       if (kind) {
         switch (kind) {
+        case 'currency_code':
+          if (!regexes.currencyCode.test(value)) {
+            return `Value doesn't match currency code pattern.`;
+          }
+          break;
         case 'credit_card':
           if (!regexes.creditCard.test(value)) {
             return `Value doesn't match credit card pattern.`;

package/src/subTypes/blobHTMLType.js

@@ -127,7 +127,7 @@ const blobHTMLType = {
         jml('textarea', {name: `${typeNamespace}-blobHTML`})
       );
     textarea.sceditorInstance = {
-      /* istanbul ignore next */
+      /* istanbul ignore next -- Guard */
       val () {
         throw new Error('Not yet instantiated');
       }

package/src/superTypes/dommatrixType.js

@@ -348,7 +348,7 @@ const dommatrixType = {
         $on: {
           click (e) {
             const {target} = e;
-            /* istanbul ignore if */
+            /* istanbul ignore if -- Guard */
             if (/** @type {HTMLInputElement} */ (target).type !== 'radio') {
               return;
             }

package/src/superTypes/errorsSpecialType.js

@@ -36,7 +36,7 @@ if (typeof AggregateError !== 'undefined') {
   specialErrorsMap.set('AggregateError', AggregateError);
 }
 
-/* istanbul ignore next 5 */
+/* istanbul ignore next 5 -- May not exist */
 // @ts-expect-error Only use if available
 if (typeof InternalError !== 'undefined') {
   // @ts-expect-error Only use if available

package/src/typeChoices.js

@@ -193,9 +193,7 @@ function deriveXorBranchLabel (schemaObj, optText, idx) {
       return String(values[0]);
     }
   }
-  if (schemaObj &&
-    (schemaObj.type === 'object' || schemaObj.type === 'properties')
-  ) {
+  if (schemaObj && schemaObj.type === 'object') {
     const {properties} = /** @type {import('zodexy').SzObject} */ (schemaObj);
     const keys = properties && typeof properties === 'object'
       ? Object.keys(properties)

package/src/types.js

@@ -732,12 +732,6 @@ class Types {
     // `record`/`tuple` are not shown as their own pull-down entries; they render
     //   as `Object`/`Array` (their schema, incl. child descriptions, informs the
     //   layout — see `arrayType.js`).
-    // `z.properties()` likewise renders through the `object` type/UI; when the
-    //   schema supplies no label of its own, name it "Properties" so it is not
-    //   shown as an indistinguishable "Object".
-    if (type === 'object' && schemaContent?.type === 'properties') {
-      optInfo[0] = 'Properties';
-    }
 
     const schemaContentLabel = resolveSchemaMeta(schemaContent).label;
     if (schemaContentLabel) {

package/src/utils/media.js

@@ -77,9 +77,9 @@ async function getUserMedia (constraints) {
   try {
     stream = await navigator.mediaDevices.getUserMedia(constraints);
   } catch (err) {
-    /* istanbul ignore next */
+    /* istanbul ignore next -- Should be present */
     console.error('err', err);
-    /* istanbul ignore next */
+    /* istanbul ignore next -- Should be present */
     return null;
   }
   return stream;
@@ -96,7 +96,7 @@ async function startScreenCapture (displayMediaOptions) {
     captureStream =
       await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);
   } catch (err) {
-    /* istanbul ignore next */
+    /* istanbul ignore next -- Should not err */
     console.error(`Error: ${err}`);
   }
   return captureStream;

package/src/utils/rawTypesonEditor.js

@@ -613,11 +613,22 @@ export async function openRawEditorDialog ({
     ['div', {class: editorClass}]
   ];
 
+  // `dialogs.js`'s default `remove` behavior detaches the `<dialog>` from
+  //   the document on close, but never tears down the `EditorView` mounted
+  //   into it; left as-is, every "Edit raw"/"View raw" use leaks a live
+  //   `EditorView` (and its internal `ResizeObserver`/DOM observers) bound
+  //   to an already-detached subtree. Destroy it alongside the dialog.
+  const close = () => {
+    view.destroy();
+  };
+
   const dialog = readonly
     // @ts-expect-error TS bug
-    ? dialogs.makeCancelDialog({children})
+    ? dialogs.makeCancelDialog({children, close})
     : dialogs.makeSubmitDialog({
       submitText: 'Save',
+      // @ts-expect-error TS bug
+      close,
       async submit ({dialog: dlg}) {
         const text = view.state.doc.toString();
         showError(dlg, '');
@@ -652,7 +663,6 @@ export async function openRawEditorDialog ({
         }
         dlg.close();
       },
-      // @ts-expect-error TS bug
       children
     });
 

package/tsconfig.json

@@ -16,5 +16,5 @@
     "outDir": "dist"
   },
   "include": ["src/**/*.js", "typings/sceditor.d.ts", "typings/json-6.d.ts"],
-  "exclude": ["node_modules", "src/deepEqual.js", "src/formats/schema.js", "./src/index.ts", "./dist/**/*.js"]
+  "exclude": ["node_modules", "src/deepEqual.js"]
 }