@ericrisco/rsc 2.0.18 → 2.0.20

package/README.md

@@ -276,7 +276,7 @@ rsc consult "I want to launch a SaaS"  # recommend only, no install
 rsc registry refresh                 # write .rsc/skill-registry.{json,md}
 rsc list                             # installed skills, agents and commands
 rsc capabilities                    # installed/available surfaces + memory mode
-rsc doctor                           # health, missing backing, hooks and local memory
+rsc doctor                           # health, missing backing, hooks and local memory; exits 1 when unhealthy
 rsc memory status                    # full / assisted / unsupported / degraded
 rsc memory save --session handoff    # force a deterministic local checkpoint
 rsc memory resume                    # print this branch/worktree continuation

package/manifest.json

@@ -1,5 +1,5 @@
 {
-  "version": "2.0.18",
+  "version": "2.0.20",
   "counts": {
     "skills": 273,
     "agents": 33,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ericrisco/rsc",
-  "version": "2.0.18",
+  "version": "2.0.20",
   "description": "A guided harness builder that turns your goal into a minimal, verified AI-agent setup using strict best practices.",
   "type": "module",
   "bin": {
@@ -101,6 +101,14 @@
     {
       "fixedIn": "2.0.18",
       "symptom": "Onboarding silently replaced a skill you wrote yourself that had the same name as one of rsc's (review, plan, debug…)"
+    },
+    {
+      "fixedIn": "2.0.19",
+      "symptom": "rsc doctor reported missing pieces or an unwired hook but still exited with 0, so a CI or an editor extension could not tell"
+    },
+    {
+      "fixedIn": "2.0.20",
+      "symptom": "In a project whose path contains a space, rsc doctor reported every hook script as missing and exited 1, though the scripts were there and the hooks ran"
     }
   ]
 }

package/scripts/doctor.js

@@ -65,6 +65,10 @@ function selloStatus(root) {
 //
 // Hookless targets get an empty list by construction: their always-on surface is a
 // markdown block with no script behind it, so there is nothing that can go missing.
+// A quoted span counts as a path only if it starts like one and holds no shell operator: a whole
+// `sh -c '…'` snippet is not a path, and reading it as one reports a present script missing.
+const SCRIPT_RE =
+  /"((?:[A-Za-z]:)?[\\/~][^"&;|]*[\\/]\.rsc[\\/][^"\s]+?\.mjs)"|'((?:[A-Za-z]:)?[\\/~][^'&;|]*[\\/]\.rsc[\\/][^'\s]+?\.mjs)'|([^"'\s]*[\\/]\.rsc[\\/][^"'\s]+\.mjs)/g;
 export function missingHookScripts({ target, home = homedir(), cwd = process.cwd() } = {}) {
   if (HOOKLESS_TARGETS.has(target)) return [];
   const file = targetPaths(target, home, cwd).hookTarget;
@@ -84,8 +88,10 @@ export function missingHookScripts({ target, home = homedir(), cwd = process.cwd
   const expand = (c) => c.split('${CLAUDE_PROJECT_DIR}').join(cwd);
   for (const raw of commands) {
     const cmd = expand(raw);
-    for (const m of cmd.matchAll(/["']?([^"'\s]*[\\/]\.rsc[\\/][^"'\s]+\.mjs)["']?/g)) {
-      const script = m[1];
+    // Quoted forms first: a project path may hold a space, and stopping at whitespace kept only
+    // the tail (`entreno/.rsc/x.mjs`), which then resolved against the cwd and read as missing (#283).
+    for (const m of cmd.matchAll(SCRIPT_RE)) {
+      const script = m[1] ?? m[2] ?? m[3];
       if (!existsSync(script)) seen.add(script);
     }
   }
@@ -201,7 +207,7 @@ export function doctor({ target, home, cwd }) {
   const missingAgents = (state.agents || []).filter((id) => {
     const path = agentPath(target, root, id);
     return path && !existsSync(path);
-  }).map((id) => ({ id, action: 'Run `npx @ericrisco/rsc sync` to restore this managed agent.' }));
+  }).map((id) => ({ id, path: agentPath(target, root, id), action: 'Run `npx @ericrisco/rsc sync` to restore this managed agent.' }));
   const report = {
     target,
     installed: Object.keys(state.skills),
@@ -251,9 +257,12 @@ export function doctor({ target, home, cwd }) {
     commandOrphans,
     commandCollisions: state.commandCollisions || [],
   };
+  // #277 — the three "missing" lists share one shape, { id, path, action }, so whoever builds on top
+  // of doctor reads them the same way; and `healthy` is what the exit code says.
   for (const [id, e] of Object.entries(state.skills)) {
-    for (const f of e.files) if (!existsSync(f)) report.missing.push(`${id}:${f}`);
+    for (const f of e.files) if (!existsSync(f)) report.missing.push({ id, path: f, action: 'Run `npx @ericrisco/rsc sync` to restore this managed skill.' });
   }
+  report.healthy = report.hookWired && !report.missing.length && !missingAgents.length && !missingCommands.length;
   return report;
 }
 

package/scripts/rsc.js

@@ -758,6 +758,8 @@ async function main() {
     }
     case 'doctor': {
       const report = doctor({ target });
+      // #277 — an automation on top of rsc reads the exit code, not the prose.
+      if (!report.healthy) process.exitCode = 1;
       if (argv.includes('--json')) return void say(JSON.stringify(report, null, 2));
       printContextBudget(report.contextBudget);
       return void say(JSON.stringify({ ...report, contextBudget: undefined }, null, 2));