@erichll/pi-auto-review 0.18.2 → 0.19.0

package/CHANGELOG.md

@@ -1,5 +1,44 @@
 # Changelog
 
+## 0.19.0 - 2026-09-20
+
+- Require Pi `^0.86.0` for both the development and peer dependency of
+  `@earendil-works/pi-ai` and `@earendil-works/pi-coding-agent`.
+- Migrate the reviewer model call to Pi 0.86's normalized `TranscriptContext`:
+  a registered provider `streamSimple` (models.json or extension-registered
+  custom providers) now receives `normalizeContext(...)` so the reviewer system
+  prompt and tool declarations arrive as the transcript's leading system
+  message. Before this change such providers read the removed
+  `context.systemPrompt`/`context.tools` and silently reviewed with a fallback
+  system prompt and no tools.
+- Read the normalized transcript in the authorizer integration tests
+  (`getCurrentSystemPrompt` plus the last user message) and assert the leading
+  system message, so the fake `streamSimple` observes the same shape the real
+  provider adapters receive.
+
+## 0.18.3 - 2026-09-20
+
+- Move the `@gotgenes/pi-permission-system` development dependency to
+  `^33.0.1` and refresh the type-check/test surface to Pi `^0.85.1`.
+- Add an MCP rule-semantics regression test that locks the 33.x behavior this
+  package depends on: a prefix-named tool such as `atlassian_getJiraIssue`
+  derives its bare server (`atlassian`) as a candidate instead of an
+  unmatchable double-prefixed alias, and MCP rules are evaluated
+  last-match-wins across those candidates. A ruleset that puts
+  `"*": "allow"` before `"atlassian": "deny"` now denies such a call, and the
+  reviewer is shown the tool name as the boundary value.
+- Sync `examples/pi-permission-system.config.example.json` with the live
+  baseline: add the `mcp__atlassian` namespace-proxy allow and drop the
+  redundant bare `atlassian` allow (after 33.0.0 its only reachable effect was
+  silently allowing `mcp connect atlassian`, which starts the server). Ordinary
+  `atlassian` / `jira` / `confluence` tool calls stay allowed.
+- No runtime behavior change in this package: the public authorizer API it
+  consumes and the normalized evidence shape are unchanged, and the peer range
+  stays `>=30.0.0`. The bump only moves the development surface, so MCP rule
+  semantics come from the installed permission-system (33.0.0 made
+  prefix-named tools resolve to their bare server and evaluated MCP rules
+  last-match-wins).
+
 ## 0.18.2 - 2026-09-17
 
 - Treat empty or whitespace-only `.pi/pi-auto-review.json` files as missing

package/README.md

@@ -31,7 +31,8 @@ that dependency is a hard prerequisite (see [Install and enable](#install-and-en
 > **Prerequisite:** pi-auto-review is an authorizer inside
 > `@gotgenes/pi-permission-system`. Pi does not auto-install peer packages, so
 > install the permission system separately (once per machine) before this
-> extension. This release line supports permission-system 30.0.0 and later:
+> extension. This release line supports permission-system 30.0.0 and later,
+> validated through 33.0.1:
 
 Node.js 22.13.0 or newer is required. Permission auditing uses Node's built-in
 `node:sqlite`; it does not require a SQLite CLI, system SQLite library, or npm
@@ -117,6 +118,16 @@ read/write/edit, a read-only bash allowlist, an MCP discovery policy, and a
 `path` deny block for secret and credential files — see
 [`examples/pi-permission-system.config.example.json`](examples/pi-permission-system.config.example.json).
 
+MCP rules are evaluated last-match-wins across the candidates derived for one
+call: the tool name, its bare server, and `mcp_call`. Keep `"*"` first in the
+`mcp` block and narrower server or tool entries after it, as the example does,
+so a specific rule cannot be shadowed by the catch-all. A bare server entry
+such as `"atlassian": "allow"` also matches the `mcp connect <server>`
+candidate list, so it auto-allows starting that server — prefer the `server_*`
+and `server:*` forms for tool calls. Any entry meant to narrow a broad allow
+(such as a destructive-tool pattern) must be written after it, or
+last-match-wins shadows it.
+
 Package defaults:
 
 ```json

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@erichll/pi-auto-review",
-  "version": "0.18.2",
+  "version": "0.19.0",
   "description": "Fail-closed, model-backed approval broker for Pi: deterministically hard-denies dangerous operations, reviews dangerous boundaries with a reviewer model, and issues one-shot expiring grants that OS sandbox adapters must consume before retrying.",
   "type": "module",
   "license": "MIT",
@@ -47,15 +47,15 @@
     "test": "node --disable-warning=ExperimentalWarning --experimental-transform-types --import ./test/register-external-ts.mjs --test test/*.test.ts"
   },
   "peerDependencies": {
-    "@earendil-works/pi-ai": "^0.85.0",
-    "@earendil-works/pi-coding-agent": "^0.85.0",
+    "@earendil-works/pi-ai": "^0.86.0",
+    "@earendil-works/pi-coding-agent": "^0.86.0",
     "@gotgenes/pi-permission-system": ">=30.0.0"
   },
   "devDependencies": {
-    "@earendil-works/pi-ai": "^0.85.0",
-    "@earendil-works/pi-coding-agent": "^0.85.0",
-    "@earendil-works/pi-server": "^0.85.0",
-    "@gotgenes/pi-permission-system": "31.1.1",
+    "@earendil-works/pi-ai": "^0.86.0",
+    "@earendil-works/pi-coding-agent": "^0.86.0",
+    "@earendil-works/pi-server": "^0.86.0",
+    "@gotgenes/pi-permission-system": "^33.0.1",
     "@types/node": "^26.2.0",
     "typescript": "^6.0.3"
   }

package/src/review/provider.ts

@@ -1,6 +1,6 @@
 import { createHash } from "node:crypto";
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import { completeSimple } from "@earendil-works/pi-ai/compat";
+import { completeSimple, normalizeContext } from "@earendil-works/pi-ai/compat";
 import type { BoundaryRequest } from "../broker/index.ts";
 import type { UserReviewUsage } from "../user-feedback.ts";
 import type {
@@ -572,8 +572,17 @@ export async function modelCall(
       metadata.retryAfterMs = parseRetryAfterMs(response.headers);
     },
   };
+  // 0.86 moved the provider-facing request to a normalized transcript: the
+  // system prompt and tool declarations now travel as the transcript's leading
+  // system message. Providers registered by extensions receive that shape, so
+  // normalize before calling a registered streamSimple. completeSimple still
+  // accepts a Context and normalizes internally.
   return (runtime.streamSimple
-    ? await runtime.streamSimple(runtime.model, context, options).result()
+    ? await runtime.streamSimple(
+        runtime.model,
+        normalizeContext(context),
+        options,
+      ).result()
     : await completeSimple(runtime.model, context, options)) as CompletionMessage;
 }