@erdemtuna/doc-review 0.10.0 → 0.11.0

package/lib/feedback-panel-controller.js

@@ -0,0 +1,161 @@
+import { createControllerStore } from "./controller-store.js";
+export const createNoteDraft = () => ({ text: "", selectionStart: 0, selectionEnd: 0, composing: false });
+function savePresentation(state) {
+    if (state.save.conflict)
+        return "Source changed — reload latest before saving. Your page edits remain in this tab.";
+    if (state.kind === "url")
+        return "Localhost page — your direct edits go to the agent for source updates";
+    if (state.markdown)
+        return "Markdown source — edits go to the agent as feedback";
+    if (state.save.dynamic)
+        return "Live page — edits go to the agent, the file is left alone";
+    if (state.save.status === "saving")
+        return `Saving to ${state.filename}…`;
+    if (state.save.status === "failed")
+        return "Couldn't save — retry before sending";
+    return `Saved to ${state.filename}${state.save.savedAt ? ` · ${state.save.savedAt}` : ""}`;
+}
+export function createFeedbackPanelController(options) {
+    let disposed = false;
+    let expanded = false;
+    let editsOpen = true;
+    let dialog = null;
+    let copyStatus = "idle";
+    let copyError = "";
+    const fingerprint = (action, state) => JSON.stringify(action === "revert"
+        ? state.edits : [state.total, state.drafts, state.note.text]);
+    const valid = (owned, full = true) => {
+        const state = options.read();
+        return !disposed && !state.ended && state.available && !state.delivery.sending &&
+            state.identity === owned.identity && (!full ||
+            (state.source === owned.source && fingerprint(owned.action, state) === owned.fingerprint));
+    };
+    const store = createControllerStore(() => {
+        const state = options.read();
+        const busy = state.delivery.sending;
+        const sent = state.delivery.sent || state.agent === "working" || state.agent === "stranded";
+        const count = state.total;
+        const hasNote = !!state.note.text.trim();
+        return {
+            note: state.note, ended: state.ended, disabled: state.ended || !state.available,
+            edits: expanded ? state.edits : state.edits.slice(0, 5), editCount: state.edits.length, expanded, editsOpen,
+            saveText: savePresentation(state), saveError: state.save.conflict || state.save.status === "failed",
+            saveStatus: state.save.status, drafts: state.drafts, busy, delivery: state.delivery,
+            sendDisabled: state.ended || !state.available || (!count && !hasNote) || busy || sent || !!dialog || state.note.composing,
+            sendText: busy ? "Sending feedback…" : state.agent === "working" ? "Feedback delivered"
+                : state.agent === "stranded" ? "Sent — agent is not listening"
+                    : state.delivery.sent ? "Sent — waiting for agent" : count ? `Send ${count} to agent`
+                        : hasNote ? "Send note to agent" : "Nothing to send yet",
+            agent: state.agent, prompt: state.prompt, copyStatus, copyError,
+            dialog: dialog ? { ...dialog, stale: !valid(dialog) } : null,
+        };
+    });
+    const publish = () => { if (!disposed)
+        store.publish(); };
+    const available = () => !disposed && !options.read().ended && options.read().available;
+    async function send() {
+        const state = options.read();
+        if (!available() || dialog || state.note.composing || (!state.total && !state.note.text.trim()) ||
+            state.delivery.sending || state.delivery.sent || state.agent === "working" || state.agent === "stranded")
+            return;
+        await options.send();
+    }
+    return {
+        getSnapshot: store.getSnapshot, subscribe: store.subscribe, publish,
+        commands: {
+            setEditsOpen(open) {
+                if (!available() || dialog)
+                    return;
+                editsOpen = open;
+                publish();
+            },
+            updateNote(value) {
+                if (!available() || dialog)
+                    return;
+                Object.assign(options.read().note, value);
+                publish();
+            },
+            expand() { if (available()) {
+                expanded = !expanded;
+                publish();
+            } },
+            send,
+            open(action) {
+                const state = options.read();
+                if (!available() || dialog || state.delivery.sending || (action === "revert" && !state.edits.length))
+                    return;
+                if (action === "revert")
+                    editsOpen = true;
+                const drafts = state.drafts + Number(!!state.note.text.trim());
+                dialog = {
+                    action, identity: state.identity, source: state.source, fingerprint: fingerprint(action, state),
+                    pending: false, error: "",
+                    description: action === "revert" ? `Discard all ${state.edits.length} of your edits? Comments and the overall note are kept.`
+                        : `${state.total ? `${state.total} unsent ${state.total === 1 ? "item will" : "items will"} be kept for next time. ` : ""}${drafts ? `${drafts} open ${drafts === 1 ? "draft (including any overall note) is" : "drafts (including any overall note) are"} only in this tab and will not be sent. ` : ""}The waiting agent will be told to stop polling.`,
+                };
+                publish();
+            },
+            cancel() { if (dialog && !dialog.pending) {
+                dialog = null;
+                publish();
+            } },
+            async confirm() {
+                const owned = dialog;
+                if (!owned || owned.pending)
+                    return;
+                if (!valid(owned)) {
+                    owned.error = "The page or feedback changed. Cancel and review the current state before trying again.";
+                    publish();
+                    return;
+                }
+                owned.pending = true;
+                owned.error = "";
+                publish();
+                try {
+                    // Flush the SDK debounce window before either destructive request.
+                    await options.flush(owned.action);
+                    if (!valid(owned, false))
+                        throw new Error("The page changed while preparing this action. Cancel and try again on the current page.");
+                    if (owned.action === "revert")
+                        await options.revert();
+                    else
+                        await options.end();
+                    if (!disposed && dialog === owned)
+                        dialog = null;
+                }
+                catch (error) {
+                    if (!disposed && dialog === owned) {
+                        owned.error = error instanceof Error ? error.message : String(error);
+                        options.failed(owned.error);
+                    }
+                }
+                finally {
+                    owned.pending = false;
+                    publish();
+                }
+            },
+            async copy() {
+                const prompt = options.read().prompt;
+                if (!available() || !prompt || copyStatus === "copying")
+                    return;
+                copyStatus = "copying";
+                copyError = "";
+                publish();
+                try {
+                    await options.copy(prompt);
+                    if (!disposed)
+                        copyStatus = "copied";
+                }
+                catch {
+                    if (!disposed) {
+                        copyStatus = "failed";
+                        copyError = "Couldn't copy — select the prompt and copy it manually";
+                        options.failed(copyError);
+                    }
+                }
+                publish();
+            },
+        },
+        dispose() { disposed = true; dialog = null; store.dispose(); },
+    };
+}

package/lib/history-coordinator.js

@@ -153,6 +153,13 @@ export function createHistoryController({ request, changed = () => { }, refreshe
             state.targetKey = targetKey;
             if (selectedId)
                 targets.set(selectedId, targetKey);
+            const comparison = round?.targets?.find((target) => target.key === targetKey)?.comparison || {};
+            const modes = ["content", "source"].filter((mode) => comparison[mode]?.available === true);
+            state.mode = modes.includes(state.preferredMode) ? state.preferredMode : modes[0] || "content";
+            const value = comparison[state.mode];
+            const items = value?.changes || value?.items ||
+                (state.mode === "content" ? comparison.changes || comparison.items : null) || [];
+            state.index = Math.max(0, Math.min(state.index, items.length - 1));
             state.loading = false;
             changed();
             refreshed();

package/lib/icons.js

@@ -30,6 +30,74 @@ export const ICON_NODES = Object.freeze({
             }
         ]
     ],
+    "plus": [
+        [
+            "path",
+            {
+                "d": "M5 12h14"
+            }
+        ],
+        [
+            "path",
+            {
+                "d": "M12 5v14"
+            }
+        ]
+    ],
+    "minus": [
+        [
+            "path",
+            {
+                "d": "M5 12h14"
+            }
+        ]
+    ],
+    "locate": [
+        [
+            "line",
+            {
+                "x1": "2",
+                "x2": "5",
+                "y1": "12",
+                "y2": "12"
+            }
+        ],
+        [
+            "line",
+            {
+                "x1": "19",
+                "x2": "22",
+                "y1": "12",
+                "y2": "12"
+            }
+        ],
+        [
+            "line",
+            {
+                "x1": "12",
+                "x2": "12",
+                "y1": "2",
+                "y2": "5"
+            }
+        ],
+        [
+            "line",
+            {
+                "x1": "12",
+                "x2": "12",
+                "y1": "19",
+                "y2": "22"
+            }
+        ],
+        [
+            "circle",
+            {
+                "cx": "12",
+                "cy": "12",
+                "r": "7"
+            }
+        ]
+    ],
     "chevronDown": [
         [
             "path",
@@ -38,6 +106,14 @@ export const ICON_NODES = Object.freeze({
             }
         ]
     ],
+    "chevronRight": [
+        [
+            "path",
+            {
+                "d": "m9 18 6-6-6-6"
+            }
+        ]
+    ],
     "messageSquarePlus": [
         [
             "path",

package/lib/recovery-controller.js

@@ -0,0 +1,123 @@
+import { createControllerStore } from "./controller-store.js";
+import { decodePage, record } from "./chrome-api.js";
+import { executionPresentation } from "./execution-client.js";
+export function createRecoveryController(options) {
+    let disposed = false;
+    let busy = false;
+    let reloadBusy = false;
+    let menuOpen = false;
+    let restoreMenuFocus = true;
+    let failure = null;
+    const lifetime = new AbortController();
+    const matches = (a, b) => a.key === b.key && a.generation === b.generation && a.renderId === b.renderId;
+    function project() {
+        const context = options.read();
+        const view = executionPresentation(context.page, context.rendered, {
+            loading: context.loading, pendingReload: context.pendingReload, error: context.frameError,
+        });
+        const visible = !context.ended && !context.comparing;
+        const menuVisible = visible && (view.eligible || !!view.detail);
+        const error = failure && matches(failure.identity, context.identity) ? failure.message : null;
+        return {
+            menuVisible, menuOpen: menuVisible && menuOpen, restoreMenuFocus,
+            busy, canRecover: !disposed && !context.ended && !context.comparing && !busy && view.eligible && !!context.identity.key,
+            preference: view.preference, eligible: view.eligible, detail: view.detail,
+            reloadVisible: visible && context.reload.visible,
+            reloadMessage: context.reload.message, reloadError: context.reload.error,
+            canReload: !disposed && visible && context.reload.visible && !!context.identity.key && (!context.loading || !!context.frameError) && !reloadBusy,
+            reloadBusy,
+            status: visible && !context.reload.visible ? (context.frameError || error || view.status || (busy ? "Updating page recovery settings…" : "")) : "",
+            statusError: !!context.frameError || !!error,
+        };
+    }
+    const store = createControllerStore(project);
+    function setMenuOpen(open, { restoreFocus = true } = {}) {
+        if (disposed || (open && !project().menuVisible))
+            return;
+        if (menuOpen === open) {
+            // The iframe's interaction message can arrive after native dismissal.
+            if (!open && !restoreFocus) {
+                restoreMenuFocus = false;
+                store.publish();
+            }
+            return;
+        }
+        menuOpen = open;
+        restoreMenuFocus = restoreFocus;
+        store.publish();
+        options.menuChanged(open);
+    }
+    function publish() {
+        if (!project().menuVisible)
+            setMenuOpen(false, { restoreFocus: false });
+        return store.publish();
+    }
+    async function recover(preference) {
+        if (!project().canRecover)
+            return;
+        const identity = { ...options.read().identity };
+        busy = true;
+        failure = null;
+        setMenuOpen(false);
+        publish();
+        try {
+            const response = record(await options.request(`/api/session/${options.sessionId}/execution`, {
+                method: "POST", body: JSON.stringify({ key: identity.key, preference }), signal: lifetime.signal,
+            }));
+            const page = decodePage(response.page);
+            if (!disposed && matches(identity, options.read().identity)) {
+                if (page.key !== identity.key)
+                    throw new Error("The recovery response belongs to a different page.");
+                options.changed(page);
+            }
+            // The server event remains the only owner of draft-safe frame replacement.
+        }
+        catch (error) {
+            if (!disposed && matches(identity, options.read().identity)) {
+                const message = error instanceof Error ? error.message : String(error);
+                failure = { identity, message: `Recovery could not be updated: ${message}. Retry from More.` };
+                options.failed(message);
+            }
+        }
+        finally {
+            busy = false;
+            publish();
+        }
+    }
+    async function reload() {
+        if (!project().canReload)
+            return;
+        reloadBusy = true;
+        publish();
+        try {
+            await options.reload();
+        }
+        catch (error) {
+            if (!disposed)
+                options.failed(error instanceof Error ? error.message : String(error));
+        }
+        finally {
+            reloadBusy = false;
+            publish();
+        }
+    }
+    return {
+        getSnapshot: store.getSnapshot, subscribe: store.subscribe, publish,
+        commands: {
+            setMenuOpen, recover, reload,
+            keepCurrent() {
+                if (disposed || !project().reloadVisible || reloadBusy)
+                    return;
+                options.keepCurrent();
+                publish();
+            },
+        },
+        dispose() {
+            if (disposed)
+                return;
+            disposed = true;
+            lifetime.abort();
+            store.dispose();
+        },
+    };
+}

package/lib/save-controller.js

@@ -1,9 +1,10 @@
 import { decodePage, record } from "./chrome-api.js";
+import { createControllerStore } from "./controller-store.js";
 export function createSaveController({ sessionId, current, policy, request, flush, send, sourceHash, pageChanged, conflict, failed, diagnostic, sending, clock = () => new Date().toLocaleTimeString([], { hour: "numeric", minute: "2-digit" }), setTimer = globalThis.setTimeout, clearTimer = globalThis.clearTimeout, }) {
     const state = {
         status: "idle", savedAt: "", baseHash: null, conflict: false, dirty: false, dynamic: false,
     };
-    const listeners = new Set();
+    const store = createControllerStore(() => state);
     const pipelines = new Map();
     const backlogs = new Map();
     const errors = new Map();
@@ -19,8 +20,7 @@ export function createSaveController({ sessionId, current, policy, request, flus
         identity.key === current().key && identity.renderId === current().renderId &&
         identity.generation === current().generation;
     const publish = () => { if (!disposed)
-        for (const listener of listeners)
-            listener(); };
+        store.publish(); };
     const delay = (milliseconds) => new Promise((resolve) => {
         const timer = setTimer(() => { delays.delete(timer); resolve(); }, milliseconds);
         delays.set(timer, resolve);
@@ -171,12 +171,14 @@ export function createSaveController({ sessionId, current, policy, request, flus
         lastSave = { html, identity };
         pending++;
         state.dirty = true;
+        publish();
         activeSave = activeSave.then(async () => {
             if (!matches(identity) || state.conflict)
                 return false;
             const saved = await saveHtml(html, identity);
             if (saved && sequence === started)
                 state.dirty = false;
+            publish();
             return saved;
         }).finally(() => { pending--; applyClean(); });
         return activeSave;
@@ -204,6 +206,7 @@ export function createSaveController({ sessionId, current, policy, request, flus
         }
         if (policy() !== "writable" || state.dynamic)
             state.dirty = false;
+        publish();
     }
     async function captureStable(capture, signal) {
         const identity = current();
@@ -225,10 +228,8 @@ export function createSaveController({ sessionId, current, policy, request, flus
     }
     return {
         get state() { return state; },
-        subscribe(listener) {
-            listeners.add(listener);
-            return () => { listeners.delete(listener); };
-        },
+        getSnapshot: store.getSnapshot,
+        subscribe: store.subscribe,
         save, persistEdit, settleEdits, flush: flushEdits, barrier, captureStable,
         applyClean, queued, cancelRetries,
         async settled() { await activeSave; },
@@ -236,21 +237,23 @@ export function createSaveController({ sessionId, current, policy, request, flus
         markSaving() { state.dirty = true; state.status = "saving"; publish(); },
         markDynamic() { state.dynamic = true; publish(); },
         observeClean() { clean = { identity: current(), sequence, editSequence }; applyClean(); },
-        baseline(hash) { state.baseHash = hash; },
+        baseline(hash) { state.baseHash = hash; publish(); },
         hold() {
             state.baseHash = null;
             cancelRetries();
             if (state.dirty)
                 state.conflict = true;
             send({ type: "eh:abortSave" });
+            publish();
         },
-        markConflict() { state.conflict = true; },
+        markConflict() { state.conflict = true; publish(); },
         reset() {
             cancelRetries();
             clean = null;
             lastSave = null;
             sequence++;
             Object.assign(state, { status: "idle", savedAt: "", baseHash: null, conflict: false, dirty: false, dynamic: false });
+            publish();
         },
         async revert() {
             const identity = current();
@@ -294,7 +297,7 @@ export function createSaveController({ sessionId, current, policy, request, flus
                 return;
             disposed = true;
             cancelRetries();
-            listeners.clear();
+            store.dispose();
         },
     };
 }

package/lib/server.js

@@ -646,9 +646,9 @@ export function createServer({ store: suppliedStore, storeOptions, owner = null,
                 return undefined;
             // --- static chrome assets
             if (route === "/chrome.css")
-                return serveFile(res, path.join(here, "chrome.css"));
+                return serveFile(res, path.join(here, "ui", "chrome.css"));
             if (route === "/chrome.js")
-                return serveFile(res, path.join(here, "chrome-client.js"));
+                return serveFile(res, path.join(here, "ui", "chrome.js"));
             if (route === "/chrome-session.js")
                 return serveFile(res, path.join(here, "chrome-session.js"));
             if (route === "/chrome-api.js")
@@ -663,6 +663,8 @@ export function createServer({ store: suppliedStore, storeOptions, owner = null,
                 return serveFile(res, path.join(here, "save-controller.js"));
             if (route === "/feedback-controller.js")
                 return serveFile(res, path.join(here, "feedback-controller.js"));
+            if (route === "/controller-store.js")
+                return serveFile(res, path.join(here, "controller-store.js"));
             if (route === "/review-controller.js")
                 return serveFile(res, path.join(here, "review-controller.js"));
             if (route === "/icons.js")
@@ -695,8 +697,6 @@ export function createServer({ store: suppliedStore, storeOptions, owner = null,
                 return serveFile(res, path.join(here, "history-client.js"));
             if (route === "/view-identity.js")
                 return serveFile(res, path.join(here, "view-identity.js"), opaqueModuleCors(req));
-            if (route === "/comparison-view.js")
-                return serveFile(res, path.join(here, "comparison-view.js"));
             if (route === "/history-coordinator.js")
                 return serveFile(res, path.join(here, "history-coordinator.js"));
             if (route === "/execution-client.js")

package/lib/toolbar-controller.js

@@ -0,0 +1,32 @@
+import { createControllerStore } from "./controller-store.js";
+export function createToolbarController(read, commands) {
+    const store = createControllerStore(read);
+    return {
+        ...store,
+        commands: {
+            setComparing(comparing) {
+                if (!read().ended)
+                    commands.setComparing(comparing);
+            },
+            setMode(mode) {
+                const state = read();
+                if (!state.ended && !state.modeDisabled)
+                    commands.setMode(mode);
+            },
+            setModeMenu(open) {
+                const state = read();
+                if (!state.ended && (!open || !state.modeDisabled))
+                    commands.setModeMenu(open);
+            },
+            openComments() {
+                const state = read();
+                if (!state.ended && !state.comparing)
+                    commands.openComments();
+            },
+            toggleTheme() {
+                if (!read().ended)
+                    commands.toggleTheme();
+            },
+        },
+    };
+}