@epublishing/grunt-epublishing 1.2.5 → 1.2.6

package/lib/sass-compiler.js

@@ -141,7 +141,21 @@ async function ensureDir(filePath) {
 }
 
 /**
- * Compile a single Sass file
+ * Compile a single Sass file in an isolated dart-sass compiler instance.
+ *
+ * Uses `sass.initAsyncCompiler()` instead of the module-level
+ * `sass.compileAsync()` to guarantee no shared state between concurrent
+ * compilations.  The module-level singleton queues all calls through a
+ * single long-running dart-sass worker; in that model any subtle stateful
+ * behavior (import caching, in-flight deps, etc.) can bleed from one
+ * compilation's output into another's when we run a chunk in parallel.
+ *
+ * The symptom was stylesheets ending up with rules that their source
+ * file never imported (e.g. achrnews `application-v2.css` getting print
+ * rules from `jade-bnp-print.scss`).  With a per-file isolated compiler,
+ * each file is compiled in its own worker, disposed when done — no
+ * possible cross-contamination vector.
+ *
  * @param {string} src - Source file path
  * @param {string} dest - Destination file path
  * @param {Object} options - Compilation options
@@ -163,8 +177,10 @@ async function compileFile(src, dest, options = {}) {
     importers.push(adaptLegacyImporter(legacyImporter));
   }
 
+  let compiler = null;
   try {
-    const result = await sass.compileAsync(src, {
+    compiler = await sass.initAsyncCompiler();
+    const result = await compiler.compileAsync(src, {
       style,
       sourceMap,
       loadPaths,
@@ -187,6 +203,14 @@ async function compileFile(src, dest, options = {}) {
     return { src, dest, success: true };
   } catch (error) {
     return { src, dest, success: false, error };
+  } finally {
+    if (compiler) {
+      try {
+        await compiler.dispose();
+      } catch {
+        // Disposal errors are not actionable; compiler is going away.
+      }
+    }
   }
 }
 
@@ -198,7 +222,11 @@ async function compileFile(src, dest, options = {}) {
  */
 async function compileSass(config, options = {}) {
   const {
-    maxConcurrency = 2, // Limit for memory optimization
+    // Serial by default.  compileFile() now spawns an isolated dart-sass
+    // compiler per file so concurrency wouldn't actually share state, but
+    // running serial gives us deterministic output ordering and bounded
+    // memory use.  --parallel in cli.js still bumps this to 4 if needed.
+    maxConcurrency = 1,
     verbose = false,
   } = options;
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@epublishing/grunt-epublishing",
   "description": "Modern front-end build tools for ePublishing Jade and client sites.",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "homepage": "https://www.epublishing.com",
   "contributors": [
     {