@epic-web/config 1.18.1 → 1.18.3

package/docs/style-guide.md

@@ -602,117 +602,6 @@ const doubledGreaterThanTwoItems = items.filter(n => n > 2).map(n => n * 2)
 This makes it easier to add/remove parameters without having to futz around with
 parentheses.
 
-### Classes & Constructors
-
-#### Avoid Classes
-
-Avoid classes. Use objects and functions instead.
-
-```tsx
-type Role = 'admin' | 'user'
-
-type User = {
-	name: string
-	role: Role
-}
-
-// ✅ Good
-const user: User = {
-	name: 'Brittany',
-	role: 'admin',
-}
-
-function userHasAccess(user: User, requiredRole: Role) {
-	return user.role === requiredRole
-}
-
-// ❌ Avoid
-class User {
-	name: string
-	role: Role
-	constructor(name: string, role: Role) {
-		this.name = name
-		this.role = role
-	}
-	hasAccess(requiredRole: Role) {
-		return this.role === requiredRole
-	}
-}
-```
-
-#### Use as a performance optimization
-
-Use classes as a performance optimization when you need to create a large number
-of objects and you need to avoid the overhead of creating those objects with
-functions. It's even better to use simple objects and functions, but if for some
-reason you need the function to be attached to the object, then use a class.
-
-```tsx
-// ✅ Good
-class Point {
-	x: number
-	y: number
-	constructor(x: number, y: number) {
-		this.x = x
-		this.y = y
-	}
-	distanceTo(other: Point) {
-		const dx = this.x - other.x
-		const dy = this.y - other.y
-		return Math.sqrt(dx * dx + dy * dy)
-	}
-}
-
-// ✅ Better
-function distanceBetweenPoints(point1: Point, point2: Point) {
-	const dx = point1.x - point2.x
-	const dy = point1.y - point2.y
-	return Math.sqrt(dx * dx + dy * dy)
-}
-const point1 = { x: 0, y: 0 }
-const point2 = { x: 1, y: 1 }
-const distance = distanceBetweenPoints(point1, point2)
-
-// ❌ Avoid
-function createPoint(x: number, y: number) {
-	return {
-		x,
-		y,
-		distanceTo(other: Point) {
-			const dx = this.x - other.x
-			const dy = this.y - other.y
-			return Math.sqrt(dx * dx + dy * dy)
-		},
-	}
-}
-```
-
-#### Avoid Inheritance
-
-Avoid inheritance. If you need to extend a class, use duplication or composition
-instead of inheritance.
-
-```tsx
-// ✅ Good
-class User {
-	name: string
-	role: string
-	constructor(name: string, role: string) {
-		this.name = name
-		this.role = role
-	}
-}
-
-// ❌ Avoid
-class User extends Person {
-	role: string
-	constructor(name: string, role: string) {
-		super(name)
-		this.role = role
-	}
-}
-```
-
 ### Modules
 
 #### File Organization
@@ -1810,7 +1699,7 @@ describe('LoginForm', () => {
 })
 ```
 
-### Avoid Nesting Tests
+### [Avoid Nesting Tests](https://kentcdodds.com/blog/avoid-nesting-when-youre-testing)
 
 Keep your tests flat. Nesting makes tests harder to understand and maintain.
 

package/eslint.js

@@ -21,7 +21,7 @@ const hasPlaywright = has('playwright')
 
 const vitestFiles = ['**/__tests__/**/*', '**/*.test.*', '**/*.spec.*']
 const testFiles = ['**/tests/**', '**/#tests/**', ...vitestFiles]
-const playwrightFiles = ['**/e2e/**']
+const playwrightFiles = ['**/tests/e2e/**']
 
 export const config = [
 	{
@@ -35,6 +35,7 @@ export const config = [
 			'**/server-build/**',
 			'**/dist/**',
 			'**/coverage/**',
+			'**/*.tsbuildinfo',
 		],
 	},
 
@@ -313,8 +314,7 @@ export const config = [
 
 	hasPlaywright
 		? {
-				files: ['**/tests/*.ts?(x)', '**/tests/*.js?(x)'],
-				ignores: testFiles,
+				files: [...playwrightFiles],
 				plugins: {
 					playwright: (await import('eslint-plugin-playwright')).default,
 				},

package/package.json

@@ -4,7 +4,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "version": "1.18.1",
+  "version": "1.18.3",
   "description": "Reasonable ESLint configs for epic web devs",
   "main": "index.js",
   "type": "module",

package/tsconfig.json

@@ -1,7 +1,4 @@
 {
 	"extends": "./typescript.json",
-	"include": ["**/*.ts", "**/*.tsx", "**/*.js", "**/*.jsx"],
-	"compilerOptions": {
-		"types": ["./reset.d.ts"]
-	}
+	"include": ["**/*.ts", "**/*.tsx", "**/*.js", "**/*.jsx"]
 }