@eohjsc/react-native-smart-city 0.3.15 → 0.3.16

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@eohjsc/react-native-smart-city",
   "title": "React Native Smart Home",
-  "version": "0.3.15",
+  "version": "0.3.16",
   "description": "TODO",
   "main": "index.js",
   "files": [

package/src/commons/SubUnit/Favorites/index.js

@@ -24,7 +24,7 @@ const SubUnitFavorites = ({
   const { getStatus, serverDown } = useSensorsStatus(unit, favoriteDevices);
 
   const handleOnAddNew = () => {
-    navigate(Routes.SelectDevices, {
+    navigate(Routes.SelectFavoritesDevices, {
       unitId: unit.id,
     });
   };

package/src/hooks/IoT/__test__/useRemoteControl.test.js

@@ -113,6 +113,7 @@ describe('Test useRemoteControl', () => {
       'bluetooth',
       actionName
     );
+    expect(sendCommandOverInternet).toBeCalledTimes(1);
     expect(sendCommandOverGoogleHome).not.toBeCalled();
     expect(sendCommandOverLGThinq).not.toBeCalled();
   });

package/src/hooks/IoT/useRemoteControl.js

@@ -18,6 +18,7 @@ const useRemoteControl = () => {
     async (sensor, action, data, userId, actionName) => {
       // No action, raise not authorized
       let result = false;
+
       if (!action) {
         ToastBottomHelper.error(
           t('your_account_has_not_been_authorized_to_control')
@@ -29,6 +30,7 @@ const useRemoteControl = () => {
         try {
           result = await sendCommandOverBluetooth(sensor, action, data, userId);
         } catch (err) {
+          result = false;
           if (err === SEND_COMMAND_OVER_BLUETOOTH_FAIL) {
             result = await sendCommandOverInternet(
               sensor,
@@ -44,8 +46,9 @@ const useRemoteControl = () => {
       }
 
       if (
-        action.command_prefer_over_internet ||
-        action.command_prefer_over_bluetooth
+        (action.command_prefer_over_internet ||
+          action.command_prefer_over_bluetooth) &&
+        !result
       ) {
         result = await sendCommandOverInternet(
           sensor,
@@ -55,7 +58,7 @@ const useRemoteControl = () => {
         );
       }
 
-      if (action.command_prefer_over_googlehome) {
+      if (action.command_prefer_over_googlehome && !result) {
         result = await sendCommandOverGoogleHome(
           ggHomeConnections,
           sensor,

package/src/navigations/UnitStack.js

@@ -51,7 +51,7 @@ import EmergencySetting from '../screens/EmergencySetting';
 import ConfirmUnitDeletion from '../screens/ConfirmUnitDeletion';
 import InfoMemberUnit from '../screens/Sharing/InfoMemberUnit';
 import EnterPassword from '../screens/EnterPassword';
-import SelectDevices from '../screens/Unit/SelectDevices';
+import SelectFavoritesDevices from '../screens/Unit/SelectFavoritesDevices';
 import { HanetCameraStack } from './HanetCameraStack';
 import { axiosGet } from '../utils/Apis/axios';
 import { API } from '../configs';
@@ -402,8 +402,8 @@ export const UnitStack = memo((props) => {
         }}
       />
       <Stack.Screen
-        name={Route.SelectDevices}
-        component={SelectDevices}
+        name={Route.SelectFavoritesDevices}
+        component={SelectFavoritesDevices}
         options={{
           headerShown: false,
         }}

package/src/screens/AddNewAction/SelectAction.js

@@ -41,6 +41,7 @@ const SelectAction = memo(({ route }) => {
     isAutomateTab,
     isCreateNewAction,
     isMultiUnits,
+    oldType,
   } = route.params;
   const [data, setData] = useState([]);
   const [actions, setActions] = useState([]);
@@ -257,7 +258,7 @@ const SelectAction = memo(({ route }) => {
       navigate(Routes.ScriptDetail, {
         id: automateId,
         name: scriptName,
-        type: type,
+        type: oldType,
         havePermission: true,
         unit,
         isMultiUnits,

package/src/screens/AddNewAction/SelectSensorDevices.js

@@ -116,6 +116,7 @@ const SelectSensorDevices = memo(({ route }) => {
       isAutomateTab,
       isCreateNewAction,
       isMultiUnits,
+      oldType,
     });
   }, [
     navigate,
@@ -131,6 +132,7 @@ const SelectSensorDevices = memo(({ route }) => {
     isAutomateTab,
     isCreateNewAction,
     isMultiUnits,
+    oldType,
   ]);
 
   const onPressClose = useCallback(() => {

package/src/screens/Unit/Detail.js

@@ -257,7 +257,6 @@ const UnitDetail = ({ route }) => {
           unit={unit}
           favoriteDevices={favoriteDevices}
           favoriteAutomates={favoriteAutomates}
-          wrapItemStyle={styles.wrapItemStyle}
         />
       );
     }

package/src/screens/Unit/{SelectDevices.js → SelectFavoritesDevices.js}

@@ -20,9 +20,9 @@ import { SCContext } from '../../context';
 import { Action } from '../../context/actionType';
 import { axiosGet, axiosPost } from '../../utils/Apis/axios';
 import { API, Colors } from '../../configs';
-import styles from './SelectDevicesStyles';
+import styles from './SelectFavoritesDevicesStyles';
 
-const SelectDevices = memo(({ route }) => {
+const SelectFavoritesDevices = memo(({ route }) => {
   const t = useTranslations();
   const { goBack } = useNavigation();
   const { unitId } = route.params;
@@ -32,7 +32,7 @@ const SelectDevices = memo(({ route }) => {
   const [indexStation, setIndexStation] = useState(0);
   const [stations, setStations] = useState([]);
   const [selectedIds, setSelectedIds] = useState([]);
-  const [loading, setLoading] = useState(false);
+  const [loading, setLoading] = useState(true);
 
   const fetchData = useCallback(async () => {
     setLoading(true);
@@ -116,7 +116,7 @@ const SelectDevices = memo(({ route }) => {
           {t('select_device')}
         </Text>
 
-        {listStation.length ? (
+        {!!listStation.length && (
           <NavBar
             listStation={listStation}
             listMenuItem={listMenuItem}
@@ -124,7 +124,8 @@ const SelectDevices = memo(({ route }) => {
             indexStation={indexStation}
             style={styles.navbar}
           />
-        ) : (
+        )}
+        {!listStation.length && !loading && (
           <View style={styles.noneData}>
             <Text center>{t('text_unit_add_to_favorites_no_devices')}</Text>
           </View>
@@ -155,4 +156,4 @@ const SelectDevices = memo(({ route }) => {
   );
 });
 
-export default SelectDevices;
+export default SelectFavoritesDevices;

package/src/screens/Unit/__test__/{SelectDevices.test.js → SelectFavoritesDevices.test.js}

@@ -4,7 +4,7 @@ import MockAdapter from 'axios-mock-adapter';
 
 import { SCProvider } from '../../../context';
 import { mockSCStore } from '../../../context/mockStore';
-import SelectDevices from '../SelectDevices';
+import SelectFavoritesDevices from '../SelectFavoritesDevices';
 import Device from '../../AddNewAction/Device';
 import BottomButtonView from '../../../commons/BottomButtonView';
 import { API } from '../../../configs';
@@ -12,7 +12,7 @@ import api from '../../../utils/Apis/axios';
 
 const wrapComponent = (route) => (
   <SCProvider initState={mockSCStore({})}>
-    <SelectDevices route={route} />
+    <SelectFavoritesDevices route={route} />
   </SCProvider>
 );
 
@@ -35,7 +35,7 @@ jest.mock('react', () => {
   };
 });
 
-describe('Test SelectDevices', () => {
+describe('Test SelectFavoritesDevices', () => {
   let tree, route;
 
   beforeAll(() => {

package/src/screens/Unit/styles.js

@@ -1,10 +1,5 @@
 import { StyleSheet } from 'react-native';
-import { Colors, Constants } from '../../configs';
-
-const marginItem = 12;
-const marginHorizontal = 16;
-const widthItem = (Constants.width - marginHorizontal * 2 - marginItem) / 2;
-const heightItem = (widthItem / 166) * 126;
+import { Colors } from '../../configs';
 
 export default StyleSheet.create({
   container: {
@@ -76,10 +71,6 @@ export default StyleSheet.create({
     margin: 0,
     padding: 0,
   },
-  wrapItemStyle: {
-    height: heightItem,
-    marginVertical: 0,
-  },
   camera: {
     width: 1,
     height: 1,

package/src/utils/Route/index.js

@@ -146,7 +146,7 @@ const Routes = {
   ItemPasscode: 'ItemPasscode',
   UnitMemberInformation: 'UnitMemberInformation',
   EnterPassword: 'EnterPassword',
-  SelectDevices: 'SelectDevices',
+  SelectFavoritesDevices: 'SelectFavoritesDevices',
 };
 
 export default Routes;