@envive-ai/react-hooks 0.3.58 → 0.3.60

package/src/services/enviveConfigService/__tests__/enviveConfigService.test.ts

@@ -3,35 +3,30 @@ import { EnviveConfigService } from '../enviveConfigService';
 const mockFetch = vi.fn();
 globalThis.fetch = mockFetch;
 
-const ORG_CONFIG_RESPONSE = {
-  org: {
-    org: {
-      id: 'org-1',
-      short_name: 'test-org',
-      display_name: 'Test Org',
-      domain: 'test.com',
-      status: 'active',
-      created_at: '2024-01-01T00:00:00.000Z',
-      updated_at: '2024-01-01T00:00:00.000Z',
-    },
-  },
-  gates: [],
-};
-
-function makeOkOrgConfigFetch(overrides: Record<string, unknown> = {}) {
-  mockFetch.mockResolvedValueOnce({
-    ok: true,
-    json: () => Promise.resolve({ ...ORG_CONFIG_RESPONSE, ...overrides }),
-  });
-}
-
-// productsConfig has no colors, so fetchGraphQLConfig falls back to its mock
-// config (see fetchGraphQLConfig.test.ts "no colors fallback") - fine here
-// since these tests only care about caching/fetch-count behaviour.
-function makeOkGraphqlFetch() {
+// getWidgetConfig is the single config call now: it returns org identity +
+// gates + experiment assignments alongside productsConfig (the separate
+// GET /v1/org/config fetch was removed). productsConfig has no colors, so
+// fetchUnifiedGraphQLConfig falls back to its mock config — fine here since
+// these tests only care about caching / fetch-count behaviour.
+function makeOkConfigFetch() {
   mockFetch.mockResolvedValueOnce({
     ok: true,
-    json: () => Promise.resolve({ data: { me: { getProductsConfigByVersion: {} } } }),
+    json: () =>
+      Promise.resolve({
+        data: {
+          me: {
+            org: {
+              id: 'org-1',
+              shortName: 'test-org',
+              displayName: 'Test Org',
+              domain: 'test.com',
+              createdAt: '2024-01-01T00:00:00.000Z',
+              updatedAt: '2024-01-01T00:00:00.000Z',
+            },
+            getWidgetConfig: { productsConfig: {}, gates: [], experimentAssignments: [] },
+          },
+        },
+      }),
   });
 }
 
@@ -60,27 +55,25 @@ afterEach(() => {
 });
 
 describe('EnviveConfigService caching', () => {
-  it('fetches org config + GraphQL config on a cold cache', async () => {
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+  it('fetches the unified config once on a cold cache', async () => {
+    makeOkConfigFetch();
 
     const result = await makeService().getEnviveConfig();
 
-    expect(mockFetch).toHaveBeenCalledTimes(2);
+    expect(mockFetch).toHaveBeenCalledTimes(1);
     expect(result.org.org.id).toBe('org-1');
   });
 
   it('serves a warm cache to a new instance with identical params without hitting the network', async () => {
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService().getEnviveConfig();
-    expect(mockFetch).toHaveBeenCalledTimes(2);
+    expect(mockFetch).toHaveBeenCalledTimes(1);
 
     // A fresh instance (as happens on the next page navigation) should read
     // from the sessionStorage cache instead of refetching.
     const result = await makeService().getEnviveConfig();
 
-    expect(mockFetch).toHaveBeenCalledTimes(2);
+    expect(mockFetch).toHaveBeenCalledTimes(1);
     expect(result.org.org.id).toBe('org-1');
   });
 
@@ -88,18 +81,16 @@ describe('EnviveConfigService caching', () => {
     vi.useFakeTimers();
     vi.setSystemTime(new Date('2026-01-01T00:00:00.000Z'));
 
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService().getEnviveConfig();
-    expect(mockFetch).toHaveBeenCalledTimes(2);
+    expect(mockFetch).toHaveBeenCalledTimes(1);
 
     vi.setSystemTime(new Date('2026-01-01T00:05:01.000Z'));
 
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService().getEnviveConfig();
 
-    expect(mockFetch).toHaveBeenCalledTimes(4);
+    expect(mockFetch).toHaveBeenCalledTimes(2);
   });
 
   it.each(['envive_config_version', 'spiffy_config_version'])(
@@ -107,59 +98,51 @@ describe('EnviveConfigService caching', () => {
     async param => {
       window.history.replaceState({}, '', `/?${param}=1.2.3`);
 
-      makeOkOrgConfigFetch();
-      makeOkGraphqlFetch();
+      makeOkConfigFetch();
       await makeService().getEnviveConfig();
-      expect(mockFetch).toHaveBeenCalledTimes(2);
+      expect(mockFetch).toHaveBeenCalledTimes(1);
 
-      makeOkOrgConfigFetch();
-      makeOkGraphqlFetch();
+      makeOkConfigFetch();
       await makeService().getEnviveConfig();
 
       // No cache read/write happened, so a second instance refetches instead
       // of reusing anything the first instance stored.
-      expect(mockFetch).toHaveBeenCalledTimes(4);
+      expect(mockFetch).toHaveBeenCalledTimes(2);
     },
   );
 
   it('does not read a version-pinned cache entry after the override is removed', async () => {
     window.history.replaceState({}, '', '/?envive_config_version=1.2.3');
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService().getEnviveConfig();
 
     window.history.replaceState({}, '', '/');
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService().getEnviveConfig();
 
-    expect(mockFetch).toHaveBeenCalledTimes(4);
+    expect(mockFetch).toHaveBeenCalledTimes(2);
   });
 
   it('keeps separate cache entries per userId', async () => {
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService({ userId: 'user-1' }).getEnviveConfig();
-    expect(mockFetch).toHaveBeenCalledTimes(2);
+    expect(mockFetch).toHaveBeenCalledTimes(1);
 
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService({ userId: 'user-2' }).getEnviveConfig();
 
-    expect(mockFetch).toHaveBeenCalledTimes(4);
+    expect(mockFetch).toHaveBeenCalledTimes(2);
   });
 
   it('keeps separate cache entries per namespace/source/baseUrl/apiKey', async () => {
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService({ namespace: 'ns-a' }).getEnviveConfig();
-    expect(mockFetch).toHaveBeenCalledTimes(2);
+    expect(mockFetch).toHaveBeenCalledTimes(1);
 
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await makeService({ namespace: 'ns-b' }).getEnviveConfig();
 
-    expect(mockFetch).toHaveBeenCalledTimes(4);
+    expect(mockFetch).toHaveBeenCalledTimes(2);
   });
 
   it('fails open and still returns config when sessionStorage.setItem throws', async () => {
@@ -167,8 +150,7 @@ describe('EnviveConfigService caching', () => {
       throw new Error('quota exceeded');
     });
 
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
 
     const result = await makeService().getEnviveConfig();
 
@@ -180,8 +162,7 @@ describe('EnviveConfigService caching', () => {
       throw new Error('storage disabled');
     });
 
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
 
     const result = await makeService().getEnviveConfig();
 
@@ -190,17 +171,12 @@ describe('EnviveConfigService caching', () => {
 
   it('fails open and refetches when a cached entry is corrupted JSON', async () => {
     const service = makeService();
-    // Seed a corrupted entry under whatever key the service reads from by
-    // populating every session storage key with garbage after a real write,
-    // then corrupting it directly.
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     await service.getEnviveConfig();
     const [key] = Object.keys(sessionStorage);
     sessionStorage.setItem(key, 'not json');
 
-    makeOkOrgConfigFetch();
-    makeOkGraphqlFetch();
+    makeOkConfigFetch();
     const result = await makeService().getEnviveConfig();
 
     expect(result.org.org.id).toBe('org-1');