@entro314labs/ai-changelog-generator 3.1.1 → 3.2.0

package/src/infrastructure/interactive/interactive-staging.service.js

@@ -1,108 +1,108 @@
-import { execSync } from 'child_process';
-import colors from '../../shared/constants/colors.js';
+import { execSync } from 'node:child_process'
+
+import colors from '../../shared/constants/colors.js'
 
 /**
  * Interactive Staging Service
- * 
+ *
  * Provides interactive git staging functionality similar to better-commits
  * Handles file selection, staging, and unstaging operations
  */
 export class InteractiveStagingService {
   constructor(gitManager) {
-    this.gitManager = gitManager;
+    this.gitManager = gitManager
   }
 
   /**
    * Show git status with staged and unstaged changes
    */
   async showGitStatus() {
-    console.log(colors.processingMessage(' Checking Git Status '));
+    console.log(colors.processingMessage(' Checking Git Status '))
+
+    const statusResult = this.getDetailedStatus()
 
-    const statusResult = this.getDetailedStatus();
-    
     if (statusResult.staged.length > 0) {
-      console.log(colors.successMessage('Changes to be committed:'));
-      statusResult.staged.forEach(file => {
-        const icon = this.getStatusIcon(file.status);
-        console.log(colors.success(`  ${icon} ${file.status} ${file.path}`));
-      });
+      console.log(colors.successMessage('Changes to be committed:'))
+      statusResult.staged.forEach((file) => {
+        const icon = this.getStatusIcon(file.status)
+        console.log(colors.success(`  ${icon} ${file.status} ${file.path}`))
+      })
     }
 
     if (statusResult.unstaged.length > 0) {
-      console.log(colors.warningMessage('\nChanges not staged for commit:'));
-      statusResult.unstaged.forEach(file => {
-        const icon = this.getStatusIcon(file.status);
-        console.log(colors.warning(`  ${icon} ${file.status} ${file.path}`));
-      });
+      console.log(colors.warningMessage('\nChanges not staged for commit:'))
+      statusResult.unstaged.forEach((file) => {
+        const icon = this.getStatusIcon(file.status)
+        console.log(colors.warning(`  ${icon} ${file.status} ${file.path}`))
+      })
     }
 
     if (statusResult.untracked.length > 0) {
-      console.log(colors.infoMessage('\nUntracked files:'));
-      statusResult.untracked.forEach(file => {
-        console.log(colors.dim(`  ✨ ?? ${file.path}`));
-      });
+      console.log(colors.infoMessage('\nUntracked files:'))
+      statusResult.untracked.forEach((file) => {
+        console.log(colors.dim(`  ✨ ?? ${file.path}`))
+      })
     }
 
-    return statusResult;
+    return statusResult
   }
 
   /**
    * Interactive file selection for staging
    */
   async selectFilesToStage(files = null) {
-    const { multiselect, confirm } = await import('@clack/prompts');
+    const { multiselect, confirm } = await import('@clack/prompts')
 
     // Get current status if files not provided
     if (!files) {
-      const status = this.getDetailedStatus();
-      files = [...status.unstaged, ...status.untracked];
+      const status = this.getDetailedStatus()
+      files = [...status.unstaged, ...status.untracked]
     }
 
     if (files.length === 0) {
-      console.log(colors.infoMessage('No files available for staging.'));
-      return [];
+      console.log(colors.infoMessage('No files available for staging.'))
+      return []
     }
 
     // Create choices for the multiselect prompt
-    const choices = files.map(file => ({
+    const choices = files.map((file) => ({
       value: file.path,
       label: `${this.getStatusIcon(file.status)} ${file.status} ${file.path}`,
-      hint: this.getStatusDescription(file.status)
-    }));
+      hint: this.getStatusDescription(file.status),
+    }))
 
     try {
       const selectedFiles = await multiselect({
         message: 'Select files to stage for commit:',
         options: choices,
-        required: false
-      });
+        required: false,
+      })
 
       if (!selectedFiles || selectedFiles.length === 0) {
-        console.log(colors.infoMessage('No files selected for staging.'));
-        return [];
+        console.log(colors.infoMessage('No files selected for staging.'))
+        return []
       }
 
       // Confirm the selection
       const shouldStage = await confirm({
         message: `Stage ${selectedFiles.length} file(s)?`,
-        initialValue: true
-      });
+        initialValue: true,
+      })
 
       if (shouldStage) {
-        await this.stageFiles(selectedFiles);
-        console.log(colors.successMessage(`✅ Staged ${selectedFiles.length} file(s)`));
-        return selectedFiles;
-      } else {
-        console.log(colors.infoMessage('Staging cancelled.'));
-        return [];
+        await this.stageFiles(selectedFiles)
+        console.log(colors.successMessage(`✅ Staged ${selectedFiles.length} file(s)`))
+        return selectedFiles
       }
+      console.log(colors.infoMessage('Staging cancelled.'))
+      return []
     } catch (error) {
       if (error.message.includes('cancelled')) {
-        console.log(colors.infoMessage('File selection cancelled.'));
+        console.log(colors.infoMessage('File selection cancelled.'))
       } else {
-        console.error(colors.errorMessage(`Error during file selection: ${error.message}`));
+        console.error(colors.errorMessage(`Error during file selection: ${error.message}`))
       }
-      return [];
+      return []
     }
   }
 
@@ -110,54 +110,53 @@ export class InteractiveStagingService {
    * Interactive unstaging of files
    */
   async selectFilesToUnstage() {
-    const { multiselect, confirm } = await import('@clack/prompts');
+    const { multiselect, confirm } = await import('@clack/prompts')
 
-    const status = this.getDetailedStatus();
-    const stagedFiles = status.staged;
+    const status = this.getDetailedStatus()
+    const stagedFiles = status.staged
 
     if (stagedFiles.length === 0) {
-      console.log(colors.infoMessage('No staged files to unstage.'));
-      return [];
+      console.log(colors.infoMessage('No staged files to unstage.'))
+      return []
     }
 
-    const choices = stagedFiles.map(file => ({
+    const choices = stagedFiles.map((file) => ({
       value: file.path,
       label: `${this.getStatusIcon(file.status)} ${file.status} ${file.path}`,
-      hint: 'Remove from staging area'
-    }));
+      hint: 'Remove from staging area',
+    }))
 
     try {
       const selectedFiles = await multiselect({
         message: 'Select files to unstage:',
         options: choices,
-        required: false
-      });
+        required: false,
+      })
 
       if (!selectedFiles || selectedFiles.length === 0) {
-        console.log(colors.infoMessage('No files selected for unstaging.'));
-        return [];
+        console.log(colors.infoMessage('No files selected for unstaging.'))
+        return []
       }
 
       const shouldUnstage = await confirm({
         message: `Unstage ${selectedFiles.length} file(s)?`,
-        initialValue: true
-      });
+        initialValue: true,
+      })
 
       if (shouldUnstage) {
-        await this.unstageFiles(selectedFiles);
-        console.log(colors.successMessage(`✅ Unstaged ${selectedFiles.length} file(s)`));
-        return selectedFiles;
-      } else {
-        console.log(colors.infoMessage('Unstaging cancelled.'));
-        return [];
+        await this.unstageFiles(selectedFiles)
+        console.log(colors.successMessage(`✅ Unstaged ${selectedFiles.length} file(s)`))
+        return selectedFiles
       }
+      console.log(colors.infoMessage('Unstaging cancelled.'))
+      return []
     } catch (error) {
       if (error.message.includes('cancelled')) {
-        console.log(colors.infoMessage('File unstaging cancelled.'));
+        console.log(colors.infoMessage('File unstaging cancelled.'))
       } else {
-        console.error(colors.errorMessage(`Error during file unstaging: ${error.message}`));
+        console.error(colors.errorMessage(`Error during file unstaging: ${error.message}`))
       }
-      return [];
+      return []
     }
   }
 
@@ -166,13 +165,13 @@ export class InteractiveStagingService {
    */
   async stageAllChanges() {
     try {
-      console.log(colors.processingMessage('Staging all changes...'));
-      execSync('git add .', { stdio: 'pipe' });
-      console.log(colors.successMessage('✅ All changes staged'));
-      return true;
+      console.log(colors.processingMessage('Staging all changes...'))
+      execSync('git add .', { stdio: 'pipe' })
+      console.log(colors.successMessage('✅ All changes staged'))
+      return true
     } catch (error) {
-      console.error(colors.errorMessage(`Error staging all changes: ${error.message}`));
-      return false;
+      console.error(colors.errorMessage(`Error staging all changes: ${error.message}`))
+      return false
     }
   }
 
@@ -181,16 +180,25 @@ export class InteractiveStagingService {
    */
   async stageFiles(filePaths) {
     try {
-      const files = Array.isArray(filePaths) ? filePaths : [filePaths];
-      
-      for (const file of files) {
-        execSync(`git add "${file}"`, { stdio: 'pipe' });
+      const files = Array.isArray(filePaths) ? filePaths : [filePaths]
+
+      // Use spawn with argument array to avoid command injection
+      if (files.length > 0) {
+        const { spawnSync } = await import('node:child_process')
+        const result = spawnSync('git', ['add', ...files], {
+          stdio: 'pipe',
+          encoding: 'utf8',
+        })
+
+        if (result.status !== 0) {
+          throw new Error(`git add failed: ${result.stderr}`)
+        }
       }
-      
-      return true;
+
+      return true
     } catch (error) {
-      console.error(colors.errorMessage(`Error staging files: ${error.message}`));
-      return false;
+      console.error(colors.errorMessage(`Error staging files: ${error.message}`))
+      return false
     }
   }
 
@@ -199,16 +207,25 @@ export class InteractiveStagingService {
    */
   async unstageFiles(filePaths) {
     try {
-      const files = Array.isArray(filePaths) ? filePaths : [filePaths];
-      
-      for (const file of files) {
-        execSync(`git reset HEAD "${file}"`, { stdio: 'pipe' });
+      const files = Array.isArray(filePaths) ? filePaths : [filePaths]
+
+      // Use spawn with argument array to avoid command injection
+      if (files.length > 0) {
+        const { spawnSync } = await import('node:child_process')
+        const result = spawnSync('git', ['reset', 'HEAD', ...files], {
+          stdio: 'pipe',
+          encoding: 'utf8',
+        })
+
+        if (result.status !== 0) {
+          throw new Error(`git reset failed: ${result.stderr}`)
+        }
       }
-      
-      return true;
+
+      return true
     } catch (error) {
-      console.error(colors.errorMessage(`Error unstaging files: ${error.message}`));
-      return false;
+      console.error(colors.errorMessage(`Error unstaging files: ${error.message}`))
+      return false
     }
   }
 
@@ -217,41 +234,43 @@ export class InteractiveStagingService {
    */
   getDetailedStatus() {
     try {
-      const output = execSync('git status --porcelain', { encoding: 'utf8' });
-      const lines = output.split('\n').filter(Boolean);
+      const output = execSync('git status --porcelain', { encoding: 'utf8' })
+      const lines = output.split('\n').filter(Boolean)
 
-      const staged = [];
-      const unstaged = [];
-      const untracked = [];
+      const staged = []
+      const unstaged = []
+      const untracked = []
 
-      lines.forEach(line => {
-        if (line.length < 3) return;
+      lines.forEach((line) => {
+        if (line.length < 3) {
+          return
+        }
 
-        const indexStatus = line.charAt(0);
-        const workTreeStatus = line.charAt(1);
-        const filePath = line.substring(3).trim();
+        const indexStatus = line.charAt(0)
+        const workTreeStatus = line.charAt(1)
+        const filePath = line.substring(3).trim()
 
         // Handle different status combinations
         if (indexStatus === '?' && workTreeStatus === '?') {
           // Untracked file
-          untracked.push({ status: '??', path: filePath });
+          untracked.push({ status: '??', path: filePath })
         } else {
           // Staged changes (index status)
           if (indexStatus !== ' ') {
-            staged.push({ status: indexStatus, path: filePath });
+            staged.push({ status: indexStatus, path: filePath })
           }
-          
+
           // Unstaged changes (work tree status)
           if (workTreeStatus !== ' ') {
-            unstaged.push({ status: workTreeStatus, path: filePath });
+            unstaged.push({ status: workTreeStatus, path: filePath })
           }
         }
-      });
+      })
 
-      return { staged, unstaged, untracked };
+      return { staged, unstaged, untracked }
     } catch (error) {
-      console.error(colors.errorMessage(`Error getting git status: ${error.message}`));
-      return { staged: [], unstaged: [], untracked: [] };
+      console.error(colors.errorMessage(`Error getting git status: ${error.message}`))
+      return { staged: [], unstaged: [], untracked: [] }
     }
   }
 
@@ -260,15 +279,15 @@ export class InteractiveStagingService {
    */
   getStatusIcon(status) {
     const icons = {
-      'M': '📝', // Modified
-      'A': '✨', // Added
-      'D': '🗑️', // Deleted
-      'R': '🔄', // Renamed
-      'C': '📋', // Copied
-      'U': '⚠️', // Unmerged
-      '??': '✨' // Untracked
-    };
-    return icons[status] || '📄';
+      M: '📝', // Modified
+      A: '✨', // Added
+      D: '🗑️', // Deleted
+      R: '🔄', // Renamed
+      C: '📋', // Copied
+      U: '⚠️', // Unmerged
+      '??': '✨', // Untracked
+    }
+    return icons[status] || '📄'
   }
 
   /**
@@ -276,15 +295,15 @@ export class InteractiveStagingService {
    */
   getStatusDescription(status) {
     const descriptions = {
-      'M': 'Modified file',
-      'A': 'New file',
-      'D': 'Deleted file', 
-      'R': 'Renamed file',
-      'C': 'Copied file',
-      'U': 'Unmerged file',
-      '??': 'Untracked file'
-    };
-    return descriptions[status] || 'Changed file';
+      M: 'Modified file',
+      A: 'New file',
+      D: 'Deleted file',
+      R: 'Renamed file',
+      C: 'Copied file',
+      U: 'Unmerged file',
+      '??': 'Untracked file',
+    }
+    return descriptions[status] || 'Changed file'
   }
 
   /**
@@ -292,10 +311,10 @@ export class InteractiveStagingService {
    */
   hasStagedChanges() {
     try {
-      const output = execSync('git diff --cached --name-only', { encoding: 'utf8' });
-      return output.trim().length > 0;
-    } catch (error) {
-      return false;
+      const output = execSync('git diff --cached --name-only', { encoding: 'utf8' })
+      return output.trim().length > 0
+    } catch (_error) {
+      return false
     }
   }
 
@@ -304,10 +323,10 @@ export class InteractiveStagingService {
    */
   hasUnstagedChanges() {
     try {
-      const output = execSync('git diff --name-only', { encoding: 'utf8' });
-      return output.trim().length > 0;
-    } catch (error) {
-      return false;
+      const output = execSync('git diff --name-only', { encoding: 'utf8' })
+      return output.trim().length > 0
+    } catch (_error) {
+      return false
     }
   }
-}
+}