@entelligentsia/forgecli 1.0.25 → 1.0.40

package/dist/extensions/forgecli/orchestrators/task/task-phase-dispatch.js

@@ -0,0 +1,370 @@
+// task-phase-dispatch.ts — per-phase subagent dispatch for the run-task
+// pipeline: persona load → task-body compose → model resolution → viewport
+// observer attach → context-governor injection → runForgeSubagent (IL10) →
+// post-subagent abort / halt-on-failure detection. Extracted VERBATIM from
+// run-task.ts's phase loop (FORGE-S31 file-size refactor) with no logic
+// changes — the inline `return {...}` paths now return `{ kind: "return";
+// result }`, and the success path returns `{ kind: "ok"; ... }` carrying the
+// live locals the loop needs (subagent result, finishPhaseNode closure,
+// observer, phaseStart, writeDebug).
+//
+// IL10 — ALL LLM dispatch goes through runForgeSubagent (NO sendKickoff here).
+import * as fs from "node:fs";
+import * as path from "node:path";
+import { CallerContextStore } from "../../audience-gate.js";
+import { buildGovernorFactory } from "../../context-governor.js";
+import { buildForgeCompactionFactory } from "../../context-governor-compaction.js";
+import { loadForgePersona, runForgeSubagent } from "../../forge-subagent.js";
+import { getSubagentTools } from "../../forge-tools.js";
+import { resolveModelForPhase } from "../../config/model-resolver.js";
+import { getOrchestratorTree } from "../../orchestrator-tree.js";
+import { attachViewportObserver } from "../../viewport/events.js";
+import { composeTaskBody, buildSummariesBlock } from "./task-body.js";
+import { emitIncompletePhaseEvent } from "./task-events.js";
+import { PHASES } from "./task-phases.js";
+import { readTaskRecord } from "./task-record.js";
+import { writeState } from "./task-state.js";
+const STATUS_KEY = "forge:run-task";
+const MESSAGE_KEY = "forge:run-task:message";
+/**
+ * Run a single phase's subagent dispatch and classify the immediate outcome
+ * (persona-load failure, subagent throw, cancellation, or non-zero exit) into
+ * a discriminated result. On success returns `kind: "ok"` with the live locals
+ * the caller's loop needs for verdict/postflight handling and advance.
+ */
+export async function dispatchPhase(p) {
+    const { opts, phase, taskId, cwd, ctx, storeCli, currentPhaseIndex, iterationCounts, dispatchCounts, modelRoutingConfig, registry, cacheSessionId, taskRecordAtStart, } = p;
+    const tree = getOrchestratorTree();
+    // ── Persona load ──────────────────────────────────────────────
+    let persona;
+    try {
+        persona = loadForgePersona(phase.personaNoun, cwd);
+    }
+    catch (err) {
+        const e = err;
+        ctx.ui.notify(`× forge:run-task — persona '${phase.personaNoun}' not found for phase ${phase.role}: ${e.message ?? "unknown"}. ` +
+            "Run /forge:regenerate to materialize persona files.", "error");
+        writeState(cwd, {
+            taskId,
+            phaseIndex: currentPhaseIndex,
+            iterationCounts,
+            halted: true,
+            lastError: `persona load failed: ${e.message ?? "unknown"}`,
+            savedAt: new Date().toISOString(),
+        });
+        return {
+            kind: "return",
+            result: {
+                status: "failed",
+                lastPhaseIndex: currentPhaseIndex,
+                iterationCounts,
+                lastError: `persona load failed: ${e.message ?? "unknown"}`,
+            },
+        };
+    }
+    // ── 4. Dispatch via runForgeSubagent (IL10) ───────────────────
+    // NEVER sendKickoff here — that would reproduce issue #30 (same-context inline = no fork).
+    // Read fresh task record to carry forward prior phase summaries (forge-cli#19).
+    const taskRecordForSummaries = currentPhaseIndex > 0 ? readTaskRecord(taskId, storeCli, cwd) : null;
+    const summariesBlock = buildSummariesBlock(taskRecordForSummaries?.summaries);
+    const taskBody = composeTaskBody(p.subWorkflowMd, taskId, summariesBlock || undefined);
+    // Log whether carry-forward summaries were injected (forge-cli#19).
+    if (summariesBlock) {
+        const debugCarryPath = path.join(cwd, ".forge", "cache", `run-task-debug-${taskId}.jsonl`);
+        try {
+            fs.mkdirSync(path.dirname(debugCarryPath), { recursive: true });
+            fs.appendFileSync(debugCarryPath, `${JSON.stringify({ ts: new Date().toISOString(), phase: phase.role, kind: "carry_forward_injected", summariesLength: summariesBlock.length, summariesBlock })}\n`, "utf8");
+        }
+        catch {
+            /* best-effort debug log */
+        }
+    }
+    // Resolve per-phase model from layered config (Plan 16 Slice 2).
+    // Pipeline name "default" matches the Forge plugin's shipped pipeline.
+    // When config is absent or cascade bottoms out, resolves to inherit
+    // (model: undefined) — setModel is skipped and pi's current model is used.
+    const modelResolution = resolveModelForPhase("default", phase.role, phase.personaNoun, modelRoutingConfig);
+    const dispatchModelLabel = modelResolution.model
+        ? `${modelResolution.model.provider}:${modelResolution.model.model}`
+        : "inherit";
+    ctx.ui.notify(`  dispatch: persona=${phase.personaNoun} · model=${dispatchModelLabel} [${modelResolution.source}]`, "info");
+    const phaseStart = Date.now();
+    // Stabilization debug log — every subagent event appended as JSONL.
+    const debugLogPath = path.join(cwd, ".forge", "cache", `run-task-debug-${taskId}.jsonl`);
+    const writeDebug = (rec) => {
+        try {
+            fs.mkdirSync(path.dirname(debugLogPath), { recursive: true });
+            fs.appendFileSync(debugLogPath, `${JSON.stringify({ ts: new Date().toISOString(), phase: phase.role, ...rec })}\n`, "utf8");
+        }
+        catch {
+            // non-fatal; debug log is best-effort
+        }
+    };
+    writeDebug({ kind: "phase_start", phaseIndex: currentPhaseIndex });
+    writeDebug({
+        kind: "requested_model",
+        requested: modelResolution.model ?? null,
+        source: modelResolution.source,
+        persona: phase.personaNoun,
+    });
+    registry.startPhase(taskId, phase.role, currentPhaseIndex);
+    // Bridge: register phase in OrchestratorTree. Node identity is
+    // per-dispatch (see dispatchCounts above) — never reuse an ID for a
+    // re-dispatched role.
+    const iteration = (dispatchCounts[phase.role] = (dispatchCounts[phase.role] ?? 0) + 1);
+    const phaseNodeId = `${taskId}:${phase.role}:${iteration}`;
+    tree.startNode(phaseNodeId, {
+        parentId: taskId,
+        label: `${phase.role}:${iteration}`,
+        kind: "leaf",
+        // Full body — display clamping/expansion is the view's decision
+        // (the tree applies only a storage cap).
+        promptPreview: taskBody,
+    });
+    // Capture the first stream-observed model on turn_end (IL10 visibility).
+    // If pi auto-substitutes or setModel silently no-ops, this line will diverge
+    // from requested_model — exactly the diagnostic signal we want.
+    let modelObservedLogged = false;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    const wrappedOnEvent = (event) => {
+        if (!modelObservedLogged && event?.type === "turn_end" && typeof event?.message?.model === "string") {
+            modelObservedLogged = true;
+            writeDebug({
+                kind: "model_observed",
+                provider: event.message.provider ?? null,
+                model: event.message.model,
+            });
+        }
+        observer.onEvent(event);
+    };
+    const refreshStatus = () => {
+        if (process.env.FORGE_VERBOSE !== "1")
+            return;
+        const elapsed = Math.floor((Date.now() - phaseStart) / 1000);
+        const tail = observer.state.lastTool ? ` · ${observer.state.lastTool}` : "";
+        ctx.ui.setStatus?.(STATUS_KEY, `run-task ${taskId}: ${phase.role} · t${observer.state.turn} · tools ${observer.state.toolCount}${observer.state.errCount ? ` · err ${observer.state.errCount}` : ""} · ${elapsed}s${tail}`);
+    };
+    const observer = attachViewportObserver({
+        registry,
+        sessionId: taskId,
+        phaseRole: phase.role,
+        nodeId: phaseNodeId,
+        beginHeader: `─── phase ${currentPhaseIndex + 1}/${PHASES.length} ${phase.role} begin · ${taskId} ───`,
+        writeDebug,
+        notify: (msg, level) => ctx.ui.notify(msg, level),
+        setStatusVerbose: process.env.FORGE_VERBOSE === "1" ? (k, v) => ctx.ui.setStatus?.(k, v) : undefined,
+        verboseKeys: { messageKey: MESSAGE_KEY },
+        afterEach: refreshStatus,
+    });
+    // ── Context governor injection (completes FORGE-S30-T07) ──────
+    // Per-phase factories built HERE because only the pipeline knows the
+    // `${personaNoun}/${role}` phase key — pi never sets persona/phase on
+    // ExtensionContext, and the parent session's registerHookDispatcher
+    // governor never sees subagent tool traffic (dormant-governor defect,
+    // CART-S02-T03 benchmark). Flag-gated: FORGE_CTX_GOVERNOR=1.
+    //   buildGovernorFactory        — Mechanisms A/B/C/D in the subagent
+    //   buildForgeCompactionFactory — Mechanism E with warm-tier path opts
+    //     (previously injected from index.ts with NO opts → warm-tier dead)
+    const phaseKey = `${phase.personaNoun}/${phase.role}`;
+    // Sprint ID from the task record's sprint FK (the store owns that
+    // relationship); the taskId-shape regex is only a fallback for records
+    // missing the FK (FORGE-BUG-043 PR 2).
+    const sprintIdForSummaries = taskRecordAtStart?.sprintId ?? /^(.*)-T\d+$/.exec(taskId)?.[1];
+    const governorFactories = process.env.FORGE_CTX_GOVERNOR === "1"
+        ? [
+            buildGovernorFactory({ phaseKey, cwd }),
+            buildForgeCompactionFactory({
+                cwd,
+                phaseKey,
+                entityId: taskId,
+                sprintId: sprintIdForSummaries,
+            }),
+        ]
+        : [];
+    const phaseExtensionFactories = [...(opts.extensionFactories ?? []), ...governorFactories];
+    let result;
+    try {
+        // FORGE-BUG-040: wrap the runForgeSubagent dispatch in the phase
+        // caller context (parity with fix-bug.ts) so the phase-ownership
+        // guard can verify tool calls from the subagent. Single setter
+        // of phase context for the task pipeline.
+        result = await CallerContextStore.asSubagent(phase.role, () => runForgeSubagent({
+            persona,
+            task: taskBody,
+            cwd,
+            exportTag: `${taskId}__${phase.role}`,
+            tailLog: observer.state.tailLog,
+            cacheSessionId,
+            streamFn: opts.streamFnFactory?.({
+                kind: "task-phase",
+                persona: persona.name,
+                phase: phase.role,
+                taskId,
+            }),
+            onEvent: wrappedOnEvent,
+            requestedModel: modelResolution.model,
+            modelRegistry: ctx.modelRegistry,
+            signal: opts.signal,
+            customTools: opts.forgeToolDefs ? getSubagentTools(opts.forgeToolDefs, persona.name) : undefined,
+            extensionFactories: phaseExtensionFactories.length > 0 ? phaseExtensionFactories : undefined,
+        }));
+    }
+    catch (err) {
+        const e = err;
+        ctx.ui.notify(`× forge:run-task — runForgeSubagent threw for phase ${phase.role}: ${e.message ?? "unknown"}`, "error");
+        tree.completeNode(phaseNodeId, "failed");
+        writeState(cwd, {
+            taskId,
+            phaseIndex: currentPhaseIndex,
+            iterationCounts,
+            halted: true,
+            lastError: `runForgeSubagent threw: ${e.message ?? "unknown"}`,
+            savedAt: new Date().toISOString(),
+        });
+        return {
+            kind: "return",
+            result: {
+                status: "failed",
+                lastPhaseIndex: currentPhaseIndex,
+                iterationCounts,
+                lastError: `runForgeSubagent threw: ${e.message ?? "unknown"}`,
+            },
+        };
+    }
+    // Close this dispatch's tree node with final usage/model — MUST be
+    // called on every exit path below (failure, halt, escalation,
+    // loopback, advance). A node left `running` keeps a live spinner in
+    // the dashboard forever AND absorbs the next same-role dispatch's
+    // telemetry via the observer's legacy role-prefix scan.
+    const finishPhaseNode = (status) => {
+        tree.setNodeUsage(phaseNodeId, {
+            input: result.usage.input,
+            output: result.usage.output,
+            cacheRead: result.usage.cacheRead,
+        });
+        if (result.model)
+            tree.setNodeModel(phaseNodeId, result.model, result.provider ?? "");
+        tree.completeNode(phaseNodeId, status);
+    };
+    // ── Post-subagent abort detection ─────────────────────────────────
+    // If the abort signal fired during the subagent run, treat it as
+    // cancellation regardless of the exit code (subagent may have been
+    // mid-turn when aborted — exitCode could be 0 or 1).
+    // This check MUST come before halt-on-failure so that
+    // stopReason="aborted" + exitCode=1 is classified as cancellation,
+    // not a phase failure.
+    if (result.stopReason === "aborted" || opts.signal?.aborted) {
+        ctx.ui.notify(`⊘ forge:run-task — ${taskId} phase ${phase.role} cancelled.`, "info");
+        registry.completePhase(taskId, phase.role, "cancelled");
+        tree.completeNode(phaseNodeId, "cancelled");
+        registry.confirmCancelled(taskId);
+        // Bug B: account the billed tokens of this aborted attempt before returning.
+        {
+            const abortSprintId = readTaskRecord(taskId, storeCli, cwd)?.sprintId;
+            if (abortSprintId) {
+                emitIncompletePhaseEvent({
+                    emitCtx: {
+                        entityType: "task",
+                        taskId,
+                        sprintId: abortSprintId,
+                        phase,
+                        iteration: (iterationCounts[phase.role] ?? 0) + 1,
+                        startMs: phaseStart,
+                        endMs: Date.now(),
+                        model: result.model ?? "unknown",
+                        provider: result.provider ?? "unknown",
+                        usage: {
+                            input: result.usage.input,
+                            output: result.usage.output,
+                            cacheRead: result.usage.cacheRead,
+                            cacheWrite: result.usage.cacheWrite,
+                        },
+                        judgement: undefined,
+                        storeCli,
+                        cwd,
+                    },
+                    outcome: "aborted",
+                    notes: result.errorMessage ?? result.stopReason ?? undefined,
+                    onDebug: writeDebug,
+                });
+            }
+            else {
+                writeDebug({ kind: "incomplete_emit_skipped", reason: "no-sprintId", outcome: "aborted" });
+            }
+        }
+        // ADR-S21-01: preserve state file so cancelled runs are resumable
+        writeState(cwd, {
+            taskId,
+            phaseIndex: currentPhaseIndex,
+            iterationCounts,
+            halted: false,
+            status: "cancelled",
+            lastError: undefined,
+            savedAt: new Date().toISOString(),
+        });
+        return {
+            kind: "return",
+            result: { status: "cancelled", lastPhaseIndex: currentPhaseIndex, iterationCounts },
+        };
+    }
+    // ── Halt-on-failure ───────────────────────────────────────────
+    if (result.exitCode !== 0) {
+        ctx.ui.notify(`× forge:run-task — phase ${phase.role} failed (exit ${result.exitCode})` +
+            (result.errorMessage ? `: ${result.errorMessage}` : "") +
+            (result.stopReason ? ` [${result.stopReason}]` : ""), "error");
+        finishPhaseNode("failed");
+        // Bug B: account the billed tokens of this failed attempt before returning.
+        {
+            const failSprintId = readTaskRecord(taskId, storeCli, cwd)?.sprintId;
+            if (failSprintId) {
+                emitIncompletePhaseEvent({
+                    emitCtx: {
+                        entityType: "task",
+                        taskId,
+                        sprintId: failSprintId,
+                        phase,
+                        iteration: (iterationCounts[phase.role] ?? 0) + 1,
+                        startMs: phaseStart,
+                        endMs: Date.now(),
+                        model: result.model ?? "unknown",
+                        provider: result.provider ?? "unknown",
+                        usage: {
+                            input: result.usage.input,
+                            output: result.usage.output,
+                            cacheRead: result.usage.cacheRead,
+                            cacheWrite: result.usage.cacheWrite,
+                        },
+                        judgement: undefined,
+                        storeCli,
+                        cwd,
+                    },
+                    outcome: "failed",
+                    notes: result.errorMessage ?? result.stopReason ?? undefined,
+                    onDebug: writeDebug,
+                });
+            }
+            else {
+                writeDebug({ kind: "incomplete_emit_skipped", reason: "no-sprintId", outcome: "failed" });
+            }
+        }
+        writeState(cwd, {
+            taskId,
+            phaseIndex: currentPhaseIndex,
+            iterationCounts,
+            halted: true,
+            lastError: result.errorMessage ?? result.stopReason ?? "subagent exit non-zero",
+            savedAt: new Date().toISOString(),
+        });
+        return {
+            kind: "return",
+            result: {
+                status: "failed",
+                lastPhaseIndex: currentPhaseIndex,
+                iterationCounts,
+                lastError: result.errorMessage ?? result.stopReason ?? "subagent exit non-zero",
+            },
+        };
+    }
+    return { kind: "ok", result, finishPhaseNode, observer, phaseStart, writeDebug };
+}
+//# sourceMappingURL=task-phase-dispatch.js.map

package/dist/extensions/forgecli/orchestrators/task/task-phase-dispatch.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"task-phase-dispatch.js","sourceRoot":"","sources":["../../../../../src/extensions/forgecli/orchestrators/task/task-phase-dispatch.ts"],"names":[],"mappings":"AAAA,wEAAwE;AACxE,2EAA2E;AAC3E,2EAA2E;AAC3E,2EAA2E;AAC3E,wEAAwE;AACxE,0EAA0E;AAC1E,6EAA6E;AAC7E,wEAAwE;AACxE,qCAAqC;AACrC,EAAE;AACF,+EAA+E;AAE/E,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAC9B,OAAO,KAAK,IAAI,MAAM,WAAW,CAAC;AAIlC,OAAO,EAAE,kBAAkB,EAAE,MAAM,wBAAwB,CAAC;AAG5D,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,2BAA2B,EAAE,MAAM,sCAAsC,CAAC;AACnF,OAAO,EAAE,gBAAgB,EAAE,gBAAgB,EAAuB,MAAM,yBAAyB,CAAC;AAClG,OAAO,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AACxD,OAAO,EAAE,oBAAoB,EAAE,MAAM,gCAAgC,CAAC;AACtE,OAAO,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACjE,OAAO,EAAE,sBAAsB,EAAE,MAAM,0BAA0B,CAAC;AAElE,OAAO,EAAE,eAAe,EAAE,mBAAmB,EAAE,MAAM,gBAAgB,CAAC;AACtE,OAAO,EAAE,wBAAwB,EAAE,MAAM,kBAAkB,CAAC;AAC5D,OAAO,EAAE,MAAM,EAAwB,MAAM,kBAAkB,CAAC;AAChE,OAAO,EAAE,cAAc,EAAmB,MAAM,kBAAkB,CAAC;AACnE,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAG7C,MAAM,UAAU,GAAG,gBAAgB,CAAC;AACpC,MAAM,WAAW,GAAG,wBAAwB,CAAC;AA+B7C;;;;;GAKG;AACH,MAAM,CAAC,KAAK,UAAU,aAAa,CAAC,CAAsB;IACzD,MAAM,EACL,IAAI,EACJ,KAAK,EACL,MAAM,EACN,GAAG,EACH,GAAG,EACH,QAAQ,EACR,iBAAiB,EACjB,eAAe,EACf,cAAc,EACd,kBAAkB,EAClB,QAAQ,EACR,cAAc,EACd,iBAAiB,GACjB,GAAG,CAAC,CAAC;IAEN,MAAM,IAAI,GAAG,mBAAmB,EAAE,CAAC;IAEnC,iEAAiE;IACjE,IAAI,OAAO,CAAC;IACZ,IAAI,CAAC;QACJ,OAAO,GAAG,gBAAgB,CAAC,KAAK,CAAC,WAAW,EAAE,GAAG,CAAC,CAAC;IACpD,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACvB,MAAM,CAAC,GAAG,GAA2B,CAAC;QACtC,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,+BAA+B,KAAK,CAAC,WAAW,yBAAyB,KAAK,CAAC,IAAI,KAAK,CAAC,CAAC,OAAO,IAAI,SAAS,IAAI;YACjH,qDAAqD,EACtD,OAAO,CACP,CAAC;QACF,UAAU,CAAC,GAAG,EAAE;YACf,MAAM;YACN,UAAU,EAAE,iBAAiB;YAC7B,eAAe;YACf,MAAM,EAAE,IAAI;YACZ,SAAS,EAAE,wBAAwB,CAAC,CAAC,OAAO,IAAI,SAAS,EAAE;YAC3D,OAAO,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;SACjC,CAAC,CAAC;QACH,OAAO;YACN,IAAI,EAAE,QAAQ;YACd,MAAM,EAAE;gBACP,MAAM,EAAE,QAAQ;gBAChB,cAAc,EAAE,iBAAiB;gBACjC,eAAe;gBACf,SAAS,EAAE,wBAAwB,CAAC,CAAC,OAAO,IAAI,SAAS,EAAE;aAC3D;SACD,CAAC;IACH,CAAC;IAED,iEAAiE;IACjE,2FAA2F;IAC3F,gFAAgF;IAChF,MAAM,sBAAsB,GAAG,iBAAiB,GAAG,CAAC,CAAC,CAAC,CAAC,cAAc,CAAC,MAAM,EAAE,QAAQ,EAAE,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IACpG,MAAM,cAAc,GAAG,mBAAmB,CAAC,sBAAsB,EAAE,SAAS,CAAC,CAAC;IAC9E,MAAM,QAAQ,GAAG,eAAe,CAAC,CAAC,CAAC,aAAa,EAAE,MAAM,EAAE,cAAc,IAAI,SAAS,CAAC,CAAC;IAEvF,oEAAoE;IACpE,IAAI,cAAc,EAAE,CAAC;QACpB,MAAM,cAAc,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,EAAE,kBAAkB,MAAM,QAAQ,CAAC,CAAC;QAC3F,IAAI,CAAC;YACJ,EAAE,CAAC,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,cAAc,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;YAChE,EAAE,CAAC,cAAc,CAChB,cAAc,EACd,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,EAAE,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,KAAK,EAAE,KAAK,CAAC,IAAI,EAAE,IAAI,EAAE,wBAAwB,EAAE,eAAe,EAAE,cAAc,CAAC,MAAM,EAAE,cAAc,EAAE,CAAC,IAAI,EAClK,MAAM,CACN,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACR,2BAA2B;QAC5B,CAAC;IACF,CAAC;IAED,iEAAiE;IACjE,uEAAuE;IACvE,oEAAoE;IACpE,2EAA2E;IAC3E,MAAM,eAAe,GAAG,oBAAoB,CAAC,SAAS,EAAE,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,WAAW,EAAE,kBAAkB,CAAC,CAAC;IAC3G,MAAM,kBAAkB,GAAG,eAAe,CAAC,KAAK;QAC/C,CAAC,CAAC,GAAG,eAAe,CAAC,KAAK,CAAC,QAAQ,IAAI,eAAe,CAAC,KAAK,CAAC,KAAK,EAAE;QACpE,CAAC,CAAC,SAAS,CAAC;IACb,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,uBAAuB,KAAK,CAAC,WAAW,YAAY,kBAAkB,KAAK,eAAe,CAAC,MAAM,GAAG,EACpG,MAAM,CACN,CAAC;IAEF,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IAE9B,oEAAoE;IACpE,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,EAAE,kBAAkB,MAAM,QAAQ,CAAC,CAAC;IACzF,MAAM,UAAU,GAAG,CAAC,GAA4B,EAAE,EAAE;QACnD,IAAI,CAAC;YACJ,EAAE,CAAC,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,YAAY,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;YAC9D,EAAE,CAAC,cAAc,CAChB,YAAY,EACZ,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,EAAE,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,KAAK,EAAE,KAAK,CAAC,IAAI,EAAE,GAAG,GAAG,EAAE,CAAC,IAAI,EAClF,MAAM,CACN,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACR,sCAAsC;QACvC,CAAC;IACF,CAAC,CAAC;IACF,UAAU,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,UAAU,EAAE,iBAAiB,EAAE,CAAC,CAAC;IACnE,UAAU,CAAC;QACV,IAAI,EAAE,iBAAiB;QACvB,SAAS,EAAE,eAAe,CAAC,KAAK,IAAI,IAAI;QACxC,MAAM,EAAE,eAAe,CAAC,MAAM;QAC9B,OAAO,EAAE,KAAK,CAAC,WAAW;KAC1B,CAAC,CAAC;IACH,QAAQ,CAAC,UAAU,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,EAAE,iBAAiB,CAAC,CAAC;IAE3D,+DAA+D;IAC/D,oEAAoE;IACpE,sBAAsB;IACtB,MAAM,SAAS,GAAG,CAAC,cAAc,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,cAAc,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC;IACvF,MAAM,WAAW,GAAG,GAAG,MAAM,IAAI,KAAK,CAAC,IAAI,IAAI,SAAS,EAAE,CAAC;IAC3D,IAAI,CAAC,SAAS,CAAC,WAAW,EAAE;QAC3B,QAAQ,EAAE,MAAM;QAChB,KAAK,EAAE,GAAG,KAAK,CAAC,IAAI,IAAI,SAAS,EAAE;QACnC,IAAI,EAAE,MAAM;QACZ,gEAAgE;QAChE,yCAAyC;QACzC,aAAa,EAAE,QAAQ;KACvB,CAAC,CAAC;IAEH,yEAAyE;IACzE,6EAA6E;IAC7E,gEAAgE;IAChE,IAAI,mBAAmB,GAAG,KAAK,CAAC;IAChC,8DAA8D;IAC9D,MAAM,cAAc,GAAG,CAAC,KAAU,EAAE,EAAE;QACrC,IAAI,CAAC,mBAAmB,IAAI,KAAK,EAAE,IAAI,KAAK,UAAU,IAAI,OAAO,KAAK,EAAE,OAAO,EAAE,KAAK,KAAK,QAAQ,EAAE,CAAC;YACrG,mBAAmB,GAAG,IAAI,CAAC;YAC3B,UAAU,CAAC;gBACV,IAAI,EAAE,gBAAgB;gBACtB,QAAQ,EAAE,KAAK,CAAC,OAAO,CAAC,QAAQ,IAAI,IAAI;gBACxC,KAAK,EAAE,KAAK,CAAC,OAAO,CAAC,KAAK;aAC1B,CAAC,CAAC;QACJ,CAAC;QACD,QAAQ,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;IACzB,CAAC,CAAC;IAEF,MAAM,aAAa,GAAG,GAAG,EAAE;QAC1B,IAAI,OAAO,CAAC,GAAG,CAAC,aAAa,KAAK,GAAG;YAAE,OAAO;QAC9C,MAAM,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,UAAU,CAAC,GAAG,IAAI,CAAC,CAAC;QAC7D,MAAM,IAAI,GAAG,QAAQ,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,MAAM,QAAQ,CAAC,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAC5E,GAAG,CAAC,EAAE,CAAC,SAAS,EAAE,CACjB,UAAU,EACV,YAAY,MAAM,KAAK,KAAK,CAAC,IAAI,OAAO,QAAQ,CAAC,KAAK,CAAC,IAAI,YAAY,QAAQ,CAAC,KAAK,CAAC,SAAS,GAAG,QAAQ,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,UAAU,QAAQ,CAAC,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC,EAAE,MAAM,OAAO,IAAI,IAAI,EAAE,CAC3L,CAAC;IACH,CAAC,CAAC;IAEF,MAAM,QAAQ,GAAG,sBAAsB,CAAC;QACvC,QAAQ;QACR,SAAS,EAAE,MAAM;QACjB,SAAS,EAAE,KAAK,CAAC,IAAI;QACrB,MAAM,EAAE,WAAW;QACnB,WAAW,EAAE,aAAa,iBAAiB,GAAG,CAAC,IAAI,MAAM,CAAC,MAAM,IAAI,KAAK,CAAC,IAAI,YAAY,MAAM,MAAM;QACtG,UAAU;QACV,MAAM,EAAE,CAAC,GAAG,EAAE,KAAK,EAAE,EAAE,CAAC,GAAG,CAAC,EAAE,CAAC,MAAM,CAAC,GAAG,EAAE,KAAK,CAAC;QACjD,gBAAgB,EAAE,OAAO,CAAC,GAAG,CAAC,aAAa,KAAK,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,EAAE,CAAC,SAAS,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS;QACpG,WAAW,EAAE,EAAE,UAAU,EAAE,WAAW,EAAE;QACxC,SAAS,EAAE,aAAa;KACxB,CAAC,CAAC;IAEH,iEAAiE;IACjE,qEAAqE;IACrE,sEAAsE;IACtE,oEAAoE;IACpE,sEAAsE;IACtE,6DAA6D;IAC7D,qEAAqE;IACrE,uEAAuE;IACvE,wEAAwE;IACxE,MAAM,QAAQ,GAAG,GAAG,KAAK,CAAC,WAAW,IAAI,KAAK,CAAC,IAAI,EAAE,CAAC;IACtD,kEAAkE;IAClE,uEAAuE;IACvE,uCAAuC;IACvC,MAAM,oBAAoB,GAAG,iBAAiB,EAAE,QAAQ,IAAI,aAAa,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IAC5F,MAAM,iBAAiB,GACtB,OAAO,CAAC,GAAG,CAAC,kBAAkB,KAAK,GAAG;QACrC,CAAC,CAAC;YACA,oBAAoB,CAAC,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC;YACvC,2BAA2B,CAAC;gBAC3B,GAAG;gBACH,QAAQ;gBACR,QAAQ,EAAE,MAAM;gBAChB,QAAQ,EAAE,oBAAoB;aAC9B,CAAC;SACF;QACF,CAAC,CAAC,EAAE,CAAC;IACP,MAAM,uBAAuB,GAAG,CAAC,GAAG,CAAC,IAAI,CAAC,kBAAkB,IAAI,EAAE,CAAC,EAAE,GAAG,iBAAiB,CAAC,CAAC;IAE3F,IAAI,MAAM,CAAC;IACX,IAAI,CAAC;QACJ,iEAAiE;QACjE,iEAAiE;QACjE,+DAA+D;QAC/D,0CAA0C;QAC1C,MAAM,GAAG,MAAM,kBAAkB,CAAC,UAAU,CAAC,KAAK,CAAC,IAAiB,EAAE,GAAG,EAAE,CAC1E,gBAAgB,CAAC;YAChB,OAAO;YACP,IAAI,EAAE,QAAQ;YACd,GAAG;YACH,SAAS,EAAE,GAAG,MAAM,KAAK,KAAK,CAAC,IAAI,EAAE;YACrC,OAAO,EAAE,QAAQ,CAAC,KAAK,CAAC,OAAO;YAC/B,cAAc;YACd,QAAQ,EAAE,IAAI,CAAC,eAAe,EAAE,CAAC;gBAChC,IAAI,EAAE,YAAY;gBAClB,OAAO,EAAE,OAAO,CAAC,IAAI;gBACrB,KAAK,EAAE,KAAK,CAAC,IAAI;gBACjB,MAAM;aACN,CAAC;YACF,OAAO,EAAE,cAAc;YACvB,cAAc,EAAE,eAAe,CAAC,KAAK;YACrC,aAAa,EAAE,GAAG,CAAC,aAAa;YAChC,MAAM,EAAE,IAAI,CAAC,MAAM;YACnB,WAAW,EAAE,IAAI,CAAC,aAAa,CAAC,CAAC,CAAC,gBAAgB,CAAC,IAAI,CAAC,aAAa,EAAE,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS;YAChG,kBAAkB,EAAE,uBAAuB,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,uBAAuB,CAAC,CAAC,CAAC,SAAS;SAC5F,CAAC,CACF,CAAC;IACH,CAAC;IAAC,OAAO,GAAY,EAAE,CAAC;QACvB,MAAM,CAAC,GAAG,GAA2B,CAAC;QACtC,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,uDAAuD,KAAK,CAAC,IAAI,KAAK,CAAC,CAAC,OAAO,IAAI,SAAS,EAAE,EAC9F,OAAO,CACP,CAAC;QACF,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAC;QACzC,UAAU,CAAC,GAAG,EAAE;YACf,MAAM;YACN,UAAU,EAAE,iBAAiB;YAC7B,eAAe;YACf,MAAM,EAAE,IAAI;YACZ,SAAS,EAAE,2BAA2B,CAAC,CAAC,OAAO,IAAI,SAAS,EAAE;YAC9D,OAAO,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;SACjC,CAAC,CAAC;QACH,OAAO;YACN,IAAI,EAAE,QAAQ;YACd,MAAM,EAAE;gBACP,MAAM,EAAE,QAAQ;gBAChB,cAAc,EAAE,iBAAiB;gBACjC,eAAe;gBACf,SAAS,EAAE,2BAA2B,CAAC,CAAC,OAAO,IAAI,SAAS,EAAE;aAC9D;SACD,CAAC;IACH,CAAC;IAED,mEAAmE;IACnE,8DAA8D;IAC9D,oEAAoE;IACpE,kEAAkE;IAClE,wDAAwD;IACxD,MAAM,eAAe,GAAG,CAAC,MAA4C,EAAQ,EAAE;QAC9E,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE;YAC9B,KAAK,EAAE,MAAM,CAAC,KAAK,CAAC,KAAK;YACzB,MAAM,EAAE,MAAM,CAAC,KAAK,CAAC,MAAM;YAC3B,SAAS,EAAE,MAAM,CAAC,KAAK,CAAC,SAAS;SACjC,CAAC,CAAC;QACH,IAAI,MAAM,CAAC,KAAK;YAAE,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,MAAM,CAAC,KAAK,EAAE,MAAM,CAAC,QAAQ,IAAI,EAAE,CAAC,CAAC;QACtF,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC;IACxC,CAAC,CAAC;IAEF,qEAAqE;IACrE,iEAAiE;IACjE,mEAAmE;IACnE,qDAAqD;IACrD,sDAAsD;IACtD,mEAAmE;IACnE,uBAAuB;IACvB,IAAI,MAAM,CAAC,UAAU,KAAK,SAAS,IAAI,IAAI,CAAC,MAAM,EAAE,OAAO,EAAE,CAAC;QAC7D,GAAG,CAAC,EAAE,CAAC,MAAM,CAAC,sBAAsB,MAAM,UAAU,KAAK,CAAC,IAAI,aAAa,EAAE,MAAM,CAAC,CAAC;QACrF,QAAQ,CAAC,aAAa,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;QACxD,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,WAAW,CAAC,CAAC;QAC5C,QAAQ,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC;QAClC,6EAA6E;QAC7E,CAAC;YACA,MAAM,aAAa,GAAG,cAAc,CAAC,MAAM,EAAE,QAAQ,EAAE,GAAG,CAAC,EAAE,QAAQ,CAAC;YACtE,IAAI,aAAa,EAAE,CAAC;gBACnB,wBAAwB,CAAC;oBACxB,OAAO,EAAE;wBACR,UAAU,EAAE,MAAM;wBAClB,MAAM;wBACN,QAAQ,EAAE,aAAa;wBACvB,KAAK;wBACL,SAAS,EAAE,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC;wBACjD,OAAO,EAAE,UAAU;wBACnB,KAAK,EAAE,IAAI,CAAC,GAAG,EAAE;wBACjB,KAAK,EAAE,MAAM,CAAC,KAAK,IAAI,SAAS;wBAChC,QAAQ,EAAE,MAAM,CAAC,QAAQ,IAAI,SAAS;wBACtC,KAAK,EAAE;4BACN,KAAK,EAAE,MAAM,CAAC,KAAK,CAAC,KAAK;4BACzB,MAAM,EAAE,MAAM,CAAC,KAAK,CAAC,MAAM;4BAC3B,SAAS,EAAE,MAAM,CAAC,KAAK,CAAC,SAAS;4BACjC,UAAU,EAAE,MAAM,CAAC,KAAK,CAAC,UAAU;yBACnC;wBACD,SAAS,EAAE,SAAS;wBACpB,QAAQ;wBACR,GAAG;qBACH;oBACD,OAAO,EAAE,SAAS;oBAClB,KAAK,EAAE,MAAM,CAAC,YAAY,IAAI,MAAM,CAAC,UAAU,IAAI,SAAS;oBAC5D,OAAO,EAAE,UAAU;iBACnB,CAAC,CAAC;YACJ,CAAC;iBAAM,CAAC;gBACP,UAAU,CAAC,EAAE,IAAI,EAAE,yBAAyB,EAAE,MAAM,EAAE,aAAa,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,CAAC;YAC5F,CAAC;QACF,CAAC;QACD,kEAAkE;QAClE,UAAU,CAAC,GAAG,EAAE;YACf,MAAM;YACN,UAAU,EAAE,iBAAiB;YAC7B,eAAe;YACf,MAAM,EAAE,KAAK;YACb,MAAM,EAAE,WAAW;YACnB,SAAS,EAAE,SAAS;YACpB,OAAO,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;SACjC,CAAC,CAAC;QACH,OAAO;YACN,IAAI,EAAE,QAAQ;YACd,MAAM,EAAE,EAAE,MAAM,EAAE,WAAW,EAAE,cAAc,EAAE,iBAAiB,EAAE,eAAe,EAAE;SACnF,CAAC;IACH,CAAC;IAED,iEAAiE;IACjE,IAAI,MAAM,CAAC,QAAQ,KAAK,CAAC,EAAE,CAAC;QAC3B,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,4BAA4B,KAAK,CAAC,IAAI,iBAAiB,MAAM,CAAC,QAAQ,GAAG;YACxE,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,CAAC,KAAK,MAAM,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;YACvD,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,KAAK,MAAM,CAAC,UAAU,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,EACrD,OAAO,CACP,CAAC;QACF,eAAe,CAAC,QAAQ,CAAC,CAAC;QAC1B,4EAA4E;QAC5E,CAAC;YACA,MAAM,YAAY,GAAG,cAAc,CAAC,MAAM,EAAE,QAAQ,EAAE,GAAG,CAAC,EAAE,QAAQ,CAAC;YACrE,IAAI,YAAY,EAAE,CAAC;gBAClB,wBAAwB,CAAC;oBACxB,OAAO,EAAE;wBACR,UAAU,EAAE,MAAM;wBAClB,MAAM;wBACN,QAAQ,EAAE,YAAY;wBACtB,KAAK;wBACL,SAAS,EAAE,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC;wBACjD,OAAO,EAAE,UAAU;wBACnB,KAAK,EAAE,IAAI,CAAC,GAAG,EAAE;wBACjB,KAAK,EAAE,MAAM,CAAC,KAAK,IAAI,SAAS;wBAChC,QAAQ,EAAE,MAAM,CAAC,QAAQ,IAAI,SAAS;wBACtC,KAAK,EAAE;4BACN,KAAK,EAAE,MAAM,CAAC,KAAK,CAAC,KAAK;4BACzB,MAAM,EAAE,MAAM,CAAC,KAAK,CAAC,MAAM;4BAC3B,SAAS,EAAE,MAAM,CAAC,KAAK,CAAC,SAAS;4BACjC,UAAU,EAAE,MAAM,CAAC,KAAK,CAAC,UAAU;yBACnC;wBACD,SAAS,EAAE,SAAS;wBACpB,QAAQ;wBACR,GAAG;qBACH;oBACD,OAAO,EAAE,QAAQ;oBACjB,KAAK,EAAE,MAAM,CAAC,YAAY,IAAI,MAAM,CAAC,UAAU,IAAI,SAAS;oBAC5D,OAAO,EAAE,UAAU;iBACnB,CAAC,CAAC;YACJ,CAAC;iBAAM,CAAC;gBACP,UAAU,CAAC,EAAE,IAAI,EAAE,yBAAyB,EAAE,MAAM,EAAE,aAAa,EAAE,OAAO,EAAE,QAAQ,EAAE,CAAC,CAAC;YAC3F,CAAC;QACF,CAAC;QACD,UAAU,CAAC,GAAG,EAAE;YACf,MAAM;YACN,UAAU,EAAE,iBAAiB;YAC7B,eAAe;YACf,MAAM,EAAE,IAAI;YACZ,SAAS,EAAE,MAAM,CAAC,YAAY,IAAI,MAAM,CAAC,UAAU,IAAI,wBAAwB;YAC/E,OAAO,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;SACjC,CAAC,CAAC;QACH,OAAO;YACN,IAAI,EAAE,QAAQ;YACd,MAAM,EAAE;gBACP,MAAM,EAAE,QAAQ;gBAChB,cAAc,EAAE,iBAAiB;gBACjC,eAAe;gBACf,SAAS,EAAE,MAAM,CAAC,YAAY,IAAI,MAAM,CAAC,UAAU,IAAI,wBAAwB;aAC/E;SACD,CAAC;IACH,CAAC;IAED,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,MAAM,EAAE,eAAe,EAAE,QAAQ,EAAE,UAAU,EAAE,UAAU,EAAE,CAAC;AAClF,CAAC"}

package/dist/extensions/forgecli/orchestrators/task/task-phases.d.ts

@@ -0,0 +1,17 @@
+export interface PhaseDescriptor {
+    /** Workflow role name (also used as key for summaries and iteration tracking). */
+    role: string;
+    /** Filename under .forge/workflows/ (without extension). */
+    workflowFile: string;
+    /** Persona noun passed to loadForgePersona. */
+    personaNoun: string;
+    /** When true: read summaries.<role>.verdict after dispatch. */
+    isReview: boolean;
+    /** Max revision iterations before escalation. */
+    maxIterations: number;
+}
+export declare const PHASES: PhaseDescriptor[];
+export declare const SUMMARY_KEY_BY_ROLE: Record<string, string | null>;
+export declare const PHASE_PRE_STATUS: Record<string, string>;
+/** Index of a phase in the PHASES table by role, or -1 if unknown. */
+export declare function phaseIndexByRole(role: string): number;

package/dist/extensions/forgecli/orchestrators/task/task-phases.js

@@ -0,0 +1,48 @@
+// task-phases.ts — phase descriptor table for the /forge:run-task pipeline.
+// Extracted from run-task.ts (no logic changes). run-task.ts re-exports these.
+export const PHASES = [
+    { role: "plan", workflowFile: "plan_task", personaNoun: "engineer", isReview: false, maxIterations: 1 },
+    { role: "review-plan", workflowFile: "review_plan", personaNoun: "supervisor", isReview: true, maxIterations: 3 },
+    { role: "implement", workflowFile: "implement_plan", personaNoun: "engineer", isReview: false, maxIterations: 1 },
+    { role: "review-code", workflowFile: "review_code", personaNoun: "supervisor", isReview: true, maxIterations: 3 },
+    { role: "validate", workflowFile: "validate_task", personaNoun: "qa-engineer", isReview: true, maxIterations: 3 },
+    { role: "approve", workflowFile: "architect_approve", personaNoun: "architect", isReview: true, maxIterations: 3 },
+    { role: "writeback", workflowFile: "collator_agent", personaNoun: "collator", isReview: false, maxIterations: 1 },
+    { role: "commit", workflowFile: "commit_task", personaNoun: "engineer", isReview: false, maxIterations: 1 },
+];
+// Map phase.role → canonical summary key written by base-pack workflows
+// (see forge/forge/tools/store-cli.cjs VALID_SUMMARY_PHASES). Phases whose
+// workflows do not write a summaries entry (e.g. approve, which transitions
+// task.status=approved instead) map to null and are verdict-checked via
+// task status rather than the summaries map.
+export const SUMMARY_KEY_BY_ROLE = {
+    plan: "plan",
+    "review-plan": "review_plan",
+    implement: "implementation",
+    "review-code": "code_review",
+    validate: "validation",
+    approve: null,
+};
+// FEAT-009 (halt-recovery UX): the task status a record must hold for a given
+// phase to (re-)run — i.e. the status `resetPipelineState` sets when rewinding
+// the pipeline to that phase. Each value is within the documented step-0b
+// "Allowed states for this phase" set of the corresponding workflow
+// (.forge/workflows/<workflowFile>.md), so the phase's own guard accepts it:
+//   plan/review-plan → planned   implement → plan-approved
+//   review-code → implemented     validate/approve → review-approved
+//   writeback/commit → approved
+export const PHASE_PRE_STATUS = {
+    plan: "planned",
+    "review-plan": "planned",
+    implement: "plan-approved",
+    "review-code": "implemented",
+    validate: "review-approved",
+    approve: "review-approved",
+    writeback: "approved",
+    commit: "approved",
+};
+/** Index of a phase in the PHASES table by role, or -1 if unknown. */
+export function phaseIndexByRole(role) {
+    return PHASES.findIndex((p) => p.role === role);
+}
+//# sourceMappingURL=task-phases.js.map

package/dist/extensions/forgecli/orchestrators/task/task-phases.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"task-phases.js","sourceRoot":"","sources":["../../../../../src/extensions/forgecli/orchestrators/task/task-phases.ts"],"names":[],"mappings":"AAAA,4EAA4E;AAC5E,+EAA+E;AAoB/E,MAAM,CAAC,MAAM,MAAM,GAAsB;IACxC,EAAE,IAAI,EAAE,MAAM,EAAE,YAAY,EAAE,WAAW,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,EAAE;IACvG,EAAE,IAAI,EAAE,aAAa,EAAE,YAAY,EAAE,aAAa,EAAE,WAAW,EAAE,YAAY,EAAE,QAAQ,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,EAAE;IACjH,EAAE,IAAI,EAAE,WAAW,EAAE,YAAY,EAAE,gBAAgB,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,EAAE;IACjH,EAAE,IAAI,EAAE,aAAa,EAAE,YAAY,EAAE,aAAa,EAAE,WAAW,EAAE,YAAY,EAAE,QAAQ,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,EAAE;IACjH,EAAE,IAAI,EAAE,UAAU,EAAE,YAAY,EAAE,eAAe,EAAE,WAAW,EAAE,aAAa,EAAE,QAAQ,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,EAAE;IACjH,EAAE,IAAI,EAAE,SAAS,EAAE,YAAY,EAAE,mBAAmB,EAAE,WAAW,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,EAAE;IAClH,EAAE,IAAI,EAAE,WAAW,EAAE,YAAY,EAAE,gBAAgB,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,EAAE;IACjH,EAAE,IAAI,EAAE,QAAQ,EAAE,YAAY,EAAE,aAAa,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,EAAE;CAC3G,CAAC;AAEF,wEAAwE;AACxE,2EAA2E;AAC3E,4EAA4E;AAC5E,wEAAwE;AACxE,6CAA6C;AAC7C,MAAM,CAAC,MAAM,mBAAmB,GAAkC;IACjE,IAAI,EAAE,MAAM;IACZ,aAAa,EAAE,aAAa;IAC5B,SAAS,EAAE,gBAAgB;IAC3B,aAAa,EAAE,aAAa;IAC5B,QAAQ,EAAE,YAAY;IACtB,OAAO,EAAE,IAAI;CACb,CAAC;AAEF,8EAA8E;AAC9E,+EAA+E;AAC/E,0EAA0E;AAC1E,oEAAoE;AACpE,6EAA6E;AAC7E,2DAA2D;AAC3D,qEAAqE;AACrE,gCAAgC;AAChC,MAAM,CAAC,MAAM,gBAAgB,GAA2B;IACvD,IAAI,EAAE,SAAS;IACf,aAAa,EAAE,SAAS;IACxB,SAAS,EAAE,eAAe;IAC1B,aAAa,EAAE,aAAa;IAC5B,QAAQ,EAAE,iBAAiB;IAC3B,OAAO,EAAE,iBAAiB;IAC1B,SAAS,EAAE,UAAU;IACrB,MAAM,EAAE,UAAU;CAClB,CAAC;AAEF,sEAAsE;AACtE,MAAM,UAAU,gBAAgB,CAAC,IAAY;IAC5C,OAAO,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC;AACjD,CAAC"}

package/dist/extensions/forgecli/orchestrators/task/task-record.d.ts

@@ -0,0 +1,9 @@
+type Verdict = "approved" | "revision" | "n/a" | "missing";
+export declare function readVerdict(taskId: string, phaseRole: string, storeCli: string, cwd: string): Verdict;
+export interface TaskRecord {
+    sprintId?: string;
+    status?: string;
+    summaries?: Record<string, unknown>;
+}
+export declare function readTaskRecord(taskId: string, storeCli: string, cwd: string): TaskRecord | null;
+export {};

package/dist/extensions/forgecli/orchestrators/task/task-record.js

@@ -0,0 +1,58 @@
+// task-record.ts — store-cli verdict + task-record reads for the run-task
+// pipeline. Extracted from run-task.ts (no logic changes). run-task.ts
+// re-exports these.
+import { spawnSync } from "node:child_process";
+import { SUMMARY_KEY_BY_ROLE } from "./task-phases.js";
+export function readVerdict(taskId, phaseRole, storeCli, cwd) {
+    const result = spawnSync("node", [storeCli, "read", "task", taskId], { cwd, encoding: "utf8" });
+    if (result.status !== 0)
+        return "missing";
+    try {
+        const raw = typeof result.stdout === "string" ? result.stdout : String(result.stdout);
+        const record = JSON.parse(raw);
+        // Phases like `approve` do not write a summaries entry; they
+        // transition task.status to "approved" instead. For those, the
+        // verdict source is task.status.
+        const summaryKey = SUMMARY_KEY_BY_ROLE[phaseRole];
+        if (summaryKey === null) {
+            return record.status === "approved" ? "approved" : "missing";
+        }
+        // Verdict lookup with three fallbacks:
+        //   1. Canonical mapped summary key (e.g. "code_review" for review-code).
+        //   2. Underscore-swapped phase role ("review_code") — legacy/defensive.
+        //   3. Raw hyphenated phase role ("review-code") — defensive only.
+        const summaries = record.summaries ?? {};
+        const underscoreKey = phaseRole.replace(/-/g, "_");
+        const candidates = [summaryKey ?? "", underscoreKey, phaseRole].filter(Boolean);
+        let verdict;
+        for (const k of candidates) {
+            if (summaries[k]?.verdict) {
+                verdict = summaries[k].verdict;
+                break;
+            }
+        }
+        if (!verdict)
+            return "missing";
+        if (verdict === "approved")
+            return "approved";
+        if (verdict === "revision")
+            return "revision";
+        return "missing";
+    }
+    catch {
+        return "missing";
+    }
+}
+export function readTaskRecord(taskId, storeCli, cwd) {
+    const result = spawnSync("node", [storeCli, "read", "task", taskId], { cwd, encoding: "utf8" });
+    if (result.status !== 0)
+        return null;
+    try {
+        const raw = typeof result.stdout === "string" ? result.stdout : String(result.stdout);
+        return JSON.parse(raw);
+    }
+    catch {
+        return null;
+    }
+}
+//# sourceMappingURL=task-record.js.map

package/dist/extensions/forgecli/orchestrators/task/task-record.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"task-record.js","sourceRoot":"","sources":["../../../../../src/extensions/forgecli/orchestrators/task/task-record.ts"],"names":[],"mappings":"AAAA,0EAA0E;AAC1E,uEAAuE;AACvE,oBAAoB;AAEpB,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAE/C,OAAO,EAAE,mBAAmB,EAAE,MAAM,kBAAkB,CAAC;AAMvD,MAAM,UAAU,WAAW,CAAC,MAAc,EAAE,SAAiB,EAAE,QAAgB,EAAE,GAAW;IAC3F,MAAM,MAAM,GAAG,SAAS,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,EAAE,GAAG,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;IAChG,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,SAAS,CAAC;IAC1C,IAAI,CAAC;QACJ,MAAM,GAAG,GAAW,OAAO,MAAM,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QAC9F,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,GAAG,CAG5B,CAAC;QAEF,6DAA6D;QAC7D,+DAA+D;QAC/D,iCAAiC;QACjC,MAAM,UAAU,GAAG,mBAAmB,CAAC,SAAS,CAAC,CAAC;QAClD,IAAI,UAAU,KAAK,IAAI,EAAE,CAAC;YACzB,OAAO,MAAM,CAAC,MAAM,KAAK,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,CAAC;QAC9D,CAAC;QAED,uCAAuC;QACvC,0EAA0E;QAC1E,yEAAyE;QACzE,mEAAmE;QACnE,MAAM,SAAS,GAAG,MAAM,CAAC,SAAS,IAAI,EAAE,CAAC;QACzC,MAAM,aAAa,GAAG,SAAS,CAAC,OAAO,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC;QACnD,MAAM,UAAU,GAAG,CAAC,UAAU,IAAI,EAAE,EAAE,aAAa,EAAE,SAAS,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;QAChF,IAAI,OAA2B,CAAC;QAChC,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;YAC5B,IAAI,SAAS,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,CAAC;gBAC3B,OAAO,GAAG,SAAS,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC;gBAC/B,MAAM;YACP,CAAC;QACF,CAAC;QACD,IAAI,CAAC,OAAO;YAAE,OAAO,SAAS,CAAC;QAC/B,IAAI,OAAO,KAAK,UAAU;YAAE,OAAO,UAAU,CAAC;QAC9C,IAAI,OAAO,KAAK,UAAU;YAAE,OAAO,UAAU,CAAC;QAC9C,OAAO,SAAS,CAAC;IAClB,CAAC;IAAC,MAAM,CAAC;QACR,OAAO,SAAS,CAAC;IAClB,CAAC;AACF,CAAC;AAUD,MAAM,UAAU,cAAc,CAAC,MAAc,EAAE,QAAgB,EAAE,GAAW;IAC3E,MAAM,MAAM,GAAG,SAAS,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,CAAC,EAAE,EAAE,GAAG,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;IAChG,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IACrC,IAAI,CAAC;QACJ,MAAM,GAAG,GAAW,OAAO,MAAM,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QAC9F,OAAO,IAAI,CAAC,KAAK,CAAC,GAAG,CAAe,CAAC;IACtC,CAAC;IAAC,MAAM,CAAC;QACR,OAAO,IAAI,CAAC;IACb,CAAC;AACF,CAAC"}

package/dist/extensions/forgecli/orchestrators/task/task-state.d.ts

@@ -0,0 +1,14 @@
+export interface RunTaskState {
+    taskId: string;
+    phaseIndex: number;
+    iterationCounts: Record<string, number>;
+    halted: boolean;
+    /** Set on cancellation so the resume prompt can say "cancelled" vs "halted". */
+    status?: "cancelled" | "halted" | "running";
+    lastError?: string;
+    savedAt: string;
+}
+export declare function readState(cwd: string, taskId: string): RunTaskState | null;
+export declare function writeState(cwd: string, state: RunTaskState): void;
+export declare function deleteState(cwd: string, taskId: string): void;
+export declare function isStateStale(state: RunTaskState): boolean;

package/dist/extensions/forgecli/orchestrators/task/task-state.js

@@ -0,0 +1,35 @@
+// task-state.ts — run-task state persistence. Extracted from run-task.ts
+// (no logic changes). run-task.ts re-exports these; run-sprint.ts imports
+// readState as readTaskState from the barrel.
+import * as fs from "node:fs";
+import { isStateStale as isJsonStateStale, readJsonState, taskStateFilePath, writeJsonState, } from "../../lib/state-helpers.js";
+import { validateId } from "../common/orchestrator-misc.js";
+// FORGE-S25-T16 (N-H-B): state helpers delegate to lib/state-helpers.ts.
+// Public API (readState, writeState, deleteState, isStateStale) is preserved —
+// run-sprint.ts imports readState as readTaskState from this file.
+function stateFilePath(cwd, taskId) {
+    if (!validateId(taskId)) {
+        throw new Error(`Invalid taskId for state file path: ${taskId}`);
+    }
+    return taskStateFilePath(cwd, taskId);
+}
+export function readState(cwd, taskId) {
+    return readJsonState(stateFilePath(cwd, taskId));
+}
+export function writeState(cwd, state) {
+    writeJsonState(stateFilePath(cwd, state.taskId), state);
+}
+export function deleteState(cwd, taskId) {
+    const fp = stateFilePath(cwd, taskId);
+    try {
+        if (fs.existsSync(fp))
+            fs.unlinkSync(fp);
+    }
+    catch {
+        // non-fatal
+    }
+}
+export function isStateStale(state) {
+    return isJsonStateStale(state.savedAt);
+}
+//# sourceMappingURL=task-state.js.map

package/dist/extensions/forgecli/orchestrators/task/task-state.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"task-state.js","sourceRoot":"","sources":["../../../../../src/extensions/forgecli/orchestrators/task/task-state.ts"],"names":[],"mappings":"AAAA,yEAAyE;AACzE,0EAA0E;AAC1E,8CAA8C;AAE9C,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAE9B,OAAO,EACN,YAAY,IAAI,gBAAgB,EAChC,aAAa,EACb,iBAAiB,EACjB,cAAc,GACd,MAAM,4BAA4B,CAAC;AACpC,OAAO,EAAE,UAAU,EAAE,MAAM,gCAAgC,CAAC;AAe5D,yEAAyE;AACzE,+EAA+E;AAC/E,mEAAmE;AAEnE,SAAS,aAAa,CAAC,GAAW,EAAE,MAAc;IACjD,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,EAAE,CAAC;QACzB,MAAM,IAAI,KAAK,CAAC,uCAAuC,MAAM,EAAE,CAAC,CAAC;IAClE,CAAC;IACD,OAAO,iBAAiB,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;AACvC,CAAC;AAED,MAAM,UAAU,SAAS,CAAC,GAAW,EAAE,MAAc;IACpD,OAAO,aAAa,CAAe,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC,CAAC;AAChE,CAAC;AAED,MAAM,UAAU,UAAU,CAAC,GAAW,EAAE,KAAmB;IAC1D,cAAc,CAAC,aAAa,CAAC,GAAG,EAAE,KAAK,CAAC,MAAM,CAAC,EAAE,KAAK,CAAC,CAAC;AACzD,CAAC;AAED,MAAM,UAAU,WAAW,CAAC,GAAW,EAAE,MAAc;IACtD,MAAM,EAAE,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;IACtC,IAAI,CAAC;QACJ,IAAI,EAAE,CAAC,UAAU,CAAC,EAAE,CAAC;YAAE,EAAE,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;IAC1C,CAAC;IAAC,MAAM,CAAC;QACR,YAAY;IACb,CAAC;AACF,CAAC;AAED,MAAM,UAAU,YAAY,CAAC,KAAmB;IAC/C,OAAO,gBAAgB,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;AACxC,CAAC"}

package/dist/extensions/forgecli/orchestrators/task/task-verdict-loop.d.ts

@@ -0,0 +1,36 @@
+import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
+import type { MergedConfig } from "../../config/config-layer.js";
+import type { OrchestratorTranscriptWriter } from "../../subagent/orchestrator-transcript.js";
+import { type PhaseDescriptor } from "./task-phases.js";
+import type { RunTaskPipelineResult } from "./run-task-types.js";
+export type VerdictLoopOutcome = {
+    kind: "advance";
+} | {
+    kind: "loopback";
+    toIndex: number;
+} | {
+    kind: "return";
+    result: RunTaskPipelineResult;
+};
+export interface VerdictLoopParams {
+    phase: PhaseDescriptor;
+    taskId: string;
+    storeCli: string;
+    cwd: string;
+    forgeRoot: string;
+    iterationCounts: Record<string, number>;
+    currentPhaseIndex: number;
+    modelRoutingConfig: MergedConfig;
+    ctx: ExtensionCommandContext;
+    orchTranscript: OrchestratorTranscriptWriter;
+    /** Closure that finalizes this dispatch's OrchestratorTree node. */
+    finishPhaseNode: (status: "completed" | "failed" | "escalated") => void;
+    /** Per-phase completion-recovery guard (forge-engineering#41) — roles that
+     *  already consumed their one set-summary recovery attempt this run. */
+    recoveredPhases: Set<string>;
+}
+/**
+ * Evaluate the review-phase verdict and decide the loop's next move.
+ * Mirrors the inline block that previously lived in runTaskPipelineInner.
+ */
+export declare function handleReviewVerdict(p: VerdictLoopParams): Promise<VerdictLoopOutcome>;