@entelligentsia/forgecli 1.0.21 → 1.0.36

package/dist/extensions/forgecli/orchestrators/bug/bug-phases.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"bug-phases.js","sourceRoot":"","sources":["../../../../../src/extensions/forgecli/orchestrators/bug/bug-phases.ts"],"names":[],"mappings":"AAAA,8EAA8E;AAC9E,+EAA+E;AAC/E,6EAA6E;AAI7E,+EAA+E;AAC/E,EAAE;AACF,6EAA6E;AAC7E,wEAAwE;AACxE,mDAAmD;AAEnD,uEAAuE;AACvE,uEAAuE;AAEvE,MAAM,CAAC,MAAM,UAAU,GAAsB;IAC5C,8EAA8E;IAC9E,sEAAsE;IACtE,uEAAuE;IACvE,0EAA0E;IAC1E,kEAAkE;IAClE,uEAAuE;IACvE,2BAA2B;IAC3B,EAAE,IAAI,EAAE,QAAQ,EAAE,YAAY,EAAE,QAAQ,EAAE,WAAW,EAAE,WAAW,EAAE,QAAQ,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,EAAE;IACvG,EAAE,IAAI,EAAE,UAAU,EAAE,YAAY,EAAE,WAAW,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,EAAE;IAC3G,EAAE,IAAI,EAAE,aAAa,EAAE,YAAY,EAAE,aAAa,EAAE,WAAW,EAAE,YAAY,EAAE,QAAQ,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,EAAE;IACjH,EAAE,IAAI,EAAE,WAAW,EAAE,YAAY,EAAE,gBAAgB,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,EAAE;IACjH,EAAE,IAAI,EAAE,aAAa,EAAE,YAAY,EAAE,aAAa,EAAE,WAAW,EAAE,YAAY,EAAE,QAAQ,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,EAAE;IACjH,EAAE,IAAI,EAAE,SAAS,EAAE,YAAY,EAAE,mBAAmB,EAAE,WAAW,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,EAAE;IAClH,EAAE,IAAI,EAAE,QAAQ,EAAE,YAAY,EAAE,aAAa,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,EAAE;CAC3G,CAAC;AAEF,8EAA8E;AAC9E,4EAA4E;AAC5E,+EAA+E;AAC/E,oEAAoE;AACpE,MAAM,CAAC,MAAM,eAAe,GAAmD;IAC9E,MAAM,EAAE,EAAE,IAAI,EAAE,aAAa,EAAE,IAAI,EAAE,aAAa,EAAE;IACpD,UAAU,EAAE,EAAE,IAAI,EAAE,aAAa,EAAE,IAAI,EAAE,aAAa,EAAE;IACxD,aAAa,EAAE,EAAE,IAAI,EAAE,mBAAmB,EAAE,IAAI,EAAE,mBAAmB,EAAE;IACvE,SAAS,EAAE,EAAE,IAAI,EAAE,iBAAiB,EAAE,IAAI,EAAE,iBAAiB,EAAE;IAC/D,aAAa,EAAE,EAAE,IAAI,EAAE,wBAAwB,EAAE,IAAI,EAAE,wBAAwB,EAAE;IACjF,OAAO,EAAE,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,wBAAwB,EAAE;IACjE,MAAM,EAAE,EAAE,IAAI,EAAE,eAAe,EAAE,IAAI,EAAE,mBAAmB,EAAE;CAC5D,CAAC;AAEF,8EAA8E;AAC9E,wDAAwD;AACxD,sEAAsE;AACtE,+DAA+D;AAE/D,MAAM,CAAC,MAAM,mBAAmB,GAAG,IAAI,GAAG,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC;AAEtD,wEAAwE;AACxE,oEAAoE;AACpE,qEAAqE;AACrE,0EAA0E;AAC1E,yEAAyE;AACzE,wEAAwE;AACxE,wEAAwE;AACxE,iEAAiE;AACjE,MAAM,UAAU,qBAAqB,CAAC,MAA0B;IAC/D,IAAI,MAAM,KAAK,UAAU;QAAE,OAAO,CAAC,SAAS,EAAE,aAAa,CAAC,CAAC;IAC7D,IAAI,MAAM,KAAK,SAAS;QAAE,OAAO,CAAC,aAAa,CAAC,CAAC;IACjD,OAAO,EAAE,CAAC;AACX,CAAC"}

package/dist/extensions/forgecli/orchestrators/bug/bug-state.d.ts

@@ -0,0 +1,14 @@
+export interface RunBugState {
+    bugId: string;
+    phaseIndex: number;
+    iterationCounts: Record<string, number>;
+    halted: boolean;
+    /** Set on cancellation so the resume prompt says "cancelled" vs "halted". */
+    status?: "cancelled" | "halted" | "running";
+    lastError?: string;
+    savedAt: string;
+}
+export declare function readBugState(cwd: string, bugId: string, sessionId?: string): RunBugState | null;
+export declare function writeBugState(cwd: string, state: RunBugState): void;
+export declare function deleteBugState(cwd: string, bugId: string): void;
+export declare function isBugStateStale(state: RunBugState): boolean;

package/dist/extensions/forgecli/orchestrators/bug/bug-state.js

@@ -0,0 +1,100 @@
+// bug-state.ts — bug-pipeline state persistence (RunBugState + the cache-file
+// read/write/delete/stale helpers). Extracted VERBATIM from fix-bug.ts
+// (FORGE-S31 file-size refactor); no logic changes.
+import * as fs from "node:fs";
+import * as path from "node:path";
+import { validateId } from "../common/orchestrator-misc.js";
+function bugStateFilePath(cwd, bugId, sessionId) {
+    if (!validateId(bugId)) {
+        throw new Error(`Invalid bugId for state file path: ${bugId}`);
+    }
+    const suffix = sessionId ?? process.env.FORGE_SESSION_ID ?? `${process.pid}`;
+    return path.join(cwd, ".forge", "cache", `fix-bug-state-${bugId}-${suffix}.json`);
+}
+export function readBugState(cwd, bugId, sessionId) {
+    // If a specific session ID is given, read that file directly.
+    if (sessionId || process.env.FORGE_SESSION_ID) {
+        const fp = bugStateFilePath(cwd, bugId, sessionId);
+        try {
+            if (!fs.existsSync(fp))
+                return null;
+            const raw = fs.readFileSync(fp, "utf8");
+            return JSON.parse(raw);
+        }
+        catch {
+            return null;
+        }
+    }
+    // No specific session — glob for the most recent matching state file.
+    // Single-writer assumption: normally only one session per bug.
+    const cacheDir = path.join(cwd, ".forge", "cache");
+    const prefix = `fix-bug-state-${bugId}-`;
+    let bestFile = null;
+    let bestMtime = 0;
+    try {
+        const entries = fs.readdirSync(cacheDir);
+        for (const entry of entries) {
+            if (!entry.startsWith(prefix) || !entry.endsWith(".json"))
+                continue;
+            const fp = path.join(cacheDir, entry);
+            try {
+                const st = fs.statSync(fp);
+                if (st.mtimeMs > bestMtime) {
+                    bestMtime = st.mtimeMs;
+                    bestFile = fp;
+                }
+            }
+            catch { }
+        }
+    }
+    catch {
+        return null;
+    }
+    if (!bestFile)
+        return null;
+    try {
+        const raw = fs.readFileSync(bestFile, "utf8");
+        return JSON.parse(raw);
+    }
+    catch {
+        return null;
+    }
+}
+export function writeBugState(cwd, state) {
+    // Guard: never write state for PENDING bugIds — wait for real bugId capture.
+    if (state.bugId.startsWith("PENDING-"))
+        return;
+    const fp = bugStateFilePath(cwd, state.bugId);
+    const dir = path.dirname(fp);
+    fs.mkdirSync(dir, { recursive: true });
+    fs.writeFileSync(fp, JSON.stringify(state, null, 2), "utf8");
+}
+export function deleteBugState(cwd, bugId) {
+    // Clean up all state files for this bug (all sessions)
+    const cacheDir = path.join(cwd, ".forge", "cache");
+    const statePrefix = `fix-bug-state-${bugId}-`;
+    const debugPrefix = `fix-bug-debug-${bugId}`;
+    try {
+        const entries = fs.readdirSync(cacheDir);
+        for (const entry of entries) {
+            if ((entry.startsWith(statePrefix) && entry.endsWith(".json")) || entry.startsWith(debugPrefix)) {
+                try {
+                    fs.unlinkSync(path.join(cacheDir, entry));
+                }
+                catch {
+                    /* non-fatal */
+                }
+            }
+        }
+    }
+    catch {
+        // non-fatal
+    }
+}
+export function isBugStateStale(state) {
+    const savedAt = new Date(state.savedAt).getTime();
+    const ageMs = Date.now() - savedAt;
+    const sevenDaysMs = 7 * 24 * 60 * 60 * 1000;
+    return ageMs > sevenDaysMs;
+}
+//# sourceMappingURL=bug-state.js.map

package/dist/extensions/forgecli/orchestrators/bug/bug-state.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"bug-state.js","sourceRoot":"","sources":["../../../../../src/extensions/forgecli/orchestrators/bug/bug-state.ts"],"names":[],"mappings":"AAAA,8EAA8E;AAC9E,uEAAuE;AACvE,oDAAoD;AAEpD,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAC9B,OAAO,KAAK,IAAI,MAAM,WAAW,CAAC;AAElC,OAAO,EAAE,UAAU,EAAE,MAAM,gCAAgC,CAAC;AAe5D,SAAS,gBAAgB,CAAC,GAAW,EAAE,KAAa,EAAE,SAAkB;IACvE,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;QACxB,MAAM,IAAI,KAAK,CAAC,sCAAsC,KAAK,EAAE,CAAC,CAAC;IAChE,CAAC;IACD,MAAM,MAAM,GAAG,SAAS,IAAI,OAAO,CAAC,GAAG,CAAC,gBAAgB,IAAI,GAAG,OAAO,CAAC,GAAG,EAAE,CAAC;IAC7E,OAAO,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,EAAE,iBAAiB,KAAK,IAAI,MAAM,OAAO,CAAC,CAAC;AACnF,CAAC;AAED,MAAM,UAAU,YAAY,CAAC,GAAW,EAAE,KAAa,EAAE,SAAkB;IAC1E,8DAA8D;IAC9D,IAAI,SAAS,IAAI,OAAO,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QAC/C,MAAM,EAAE,GAAG,gBAAgB,CAAC,GAAG,EAAE,KAAK,EAAE,SAAS,CAAC,CAAC;QACnD,IAAI,CAAC;YACJ,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,EAAE,CAAC;gBAAE,OAAO,IAAI,CAAC;YACpC,MAAM,GAAG,GAAG,EAAE,CAAC,YAAY,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC;YACxC,OAAO,IAAI,CAAC,KAAK,CAAC,GAAG,CAAgB,CAAC;QACvC,CAAC;QAAC,MAAM,CAAC;YACR,OAAO,IAAI,CAAC;QACb,CAAC;IACF,CAAC;IACD,sEAAsE;IACtE,+DAA+D;IAC/D,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,MAAM,GAAG,iBAAiB,KAAK,GAAG,CAAC;IACzC,IAAI,QAAQ,GAAkB,IAAI,CAAC;IACnC,IAAI,SAAS,GAAG,CAAC,CAAC;IAClB,IAAI,CAAC;QACJ,MAAM,OAAO,GAAG,EAAE,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC;QACzC,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;YAC7B,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,OAAO,CAAC;gBAAE,SAAS;YACpE,MAAM,EAAE,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC;YACtC,IAAI,CAAC;gBACJ,MAAM,EAAE,GAAG,EAAE,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC;gBAC3B,IAAI,EAAE,CAAC,OAAO,GAAG,SAAS,EAAE,CAAC;oBAC5B,SAAS,GAAG,EAAE,CAAC,OAAO,CAAC;oBACvB,QAAQ,GAAG,EAAE,CAAC;gBACf,CAAC;YACF,CAAC;YAAC,MAAM,CAAC,CAAA,CAAC;QACX,CAAC;IACF,CAAC;IAAC,MAAM,CAAC;QACR,OAAO,IAAI,CAAC;IACb,CAAC;IACD,IAAI,CAAC,QAAQ;QAAE,OAAO,IAAI,CAAC;IAC3B,IAAI,CAAC;QACJ,MAAM,GAAG,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QAC9C,OAAO,IAAI,CAAC,KAAK,CAAC,GAAG,CAAgB,CAAC;IACvC,CAAC;IAAC,MAAM,CAAC;QACR,OAAO,IAAI,CAAC;IACb,CAAC;AACF,CAAC;AAED,MAAM,UAAU,aAAa,CAAC,GAAW,EAAE,KAAkB;IAC5D,6EAA6E;IAC7E,IAAI,KAAK,CAAC,KAAK,CAAC,UAAU,CAAC,UAAU,CAAC;QAAE,OAAO;IAC/C,MAAM,EAAE,GAAG,gBAAgB,CAAC,GAAG,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;IAC9C,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAC7B,EAAE,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;IACvC,EAAE,CAAC,aAAa,CAAC,EAAE,EAAE,IAAI,CAAC,SAAS,CAAC,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;AAC9D,CAAC;AAED,MAAM,UAAU,cAAc,CAAC,GAAW,EAAE,KAAa;IACxD,uDAAuD;IACvD,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,WAAW,GAAG,iBAAiB,KAAK,GAAG,CAAC;IAC9C,MAAM,WAAW,GAAG,iBAAiB,KAAK,EAAE,CAAC;IAC7C,IAAI,CAAC;QACJ,MAAM,OAAO,GAAG,EAAE,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC;QACzC,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;YAC7B,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,WAAW,CAAC,IAAI,KAAK,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,IAAI,KAAK,CAAC,UAAU,CAAC,WAAW,CAAC,EAAE,CAAC;gBACjG,IAAI,CAAC;oBACJ,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC,CAAC;gBAC3C,CAAC;gBAAC,MAAM,CAAC;oBACR,eAAe;gBAChB,CAAC;YACF,CAAC;QACF,CAAC;IACF,CAAC;IAAC,MAAM,CAAC;QACR,YAAY;IACb,CAAC;AACF,CAAC;AAED,MAAM,UAAU,eAAe,CAAC,KAAkB;IACjD,MAAM,OAAO,GAAG,IAAI,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,CAAC;IAClD,MAAM,KAAK,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,OAAO,CAAC;IACnC,MAAM,WAAW,GAAG,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,EAAE,GAAG,IAAI,CAAC;IAC5C,OAAO,KAAK,GAAG,WAAW,CAAC;AAC5B,CAAC"}

package/dist/extensions/forgecli/orchestrators/bug/bug-triage-routing.d.ts

@@ -0,0 +1,72 @@
+import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
+import type { PhaseDescriptor } from "../run-task.js";
+import type { BugRecord } from "./bug-id.js";
+import type { RunBugPipelineResult } from "./run-bug-types.js";
+export interface MaybeSkipParams {
+    phase: PhaseDescriptor;
+    bugId: string;
+    cwd: string;
+    ctx: ExtensionCommandContext;
+    storeCli: string;
+    /** Bug record read at the top of §6a (same read the caller already did). */
+    bugNow: BugRecord | null;
+    summaryKeyByRole: Record<string, string | null>;
+}
+/**
+ * §6a — decide whether the current phase should be skipped because the bug is
+ * already in a done state. When skipping, writes a synthetic summary so
+ * downstream `after <phase>` verdict checks succeed. Returns true when the
+ * caller should `currentPhaseIndex++; continue;`.
+ */
+export declare function maybeSkipPhase(p: MaybeSkipParams): boolean;
+export interface CaptureTriageBugIdParams {
+    bugId: string;
+    cwd: string;
+    ctx: ExtensionCommandContext;
+    storeCli: string;
+    currentPhaseIndex: number;
+    iterationCounts: Record<string, number>;
+    debugLogDisabled: boolean;
+    toolExecutionEvents: Array<{
+        toolName?: string;
+        result?: unknown;
+    }>;
+}
+export type CaptureTriageBugIdOutcome = {
+    kind: "return";
+    result: RunBugPipelineResult;
+} | {
+    kind: "ok";
+    bugId: string;
+    debugLogPath: string | null;
+    writeDebug: (rec: Record<string, unknown>) => void;
+};
+/**
+ * Post-triage bugId capture: for new bugs the triage subagent creates the bug
+ * record via store-cli; capture the real id by scanning tool_execution_end
+ * events, with a list-and-filter fallback. On success re-initializes the debug
+ * log under the real id and returns the updated locals. Preserves the PENDING-
+ * nuance: the orchestrator transcript writer keeps the PENDING entityId — this
+ * only updates the loop's local bugId.
+ */
+export declare function captureTriageBugId(p: CaptureTriageBugIdParams, writeDebug: (rec: Record<string, unknown>) => void, debugLogPath: string | null): CaptureTriageBugIdOutcome;
+export interface RouteAfterTriageParams {
+    bugId: string;
+    cwd: string;
+    ctx: ExtensionCommandContext;
+    storeCli: string;
+    currentPhaseIndex: number;
+}
+export type RouteAfterTriageOutcome = {
+    kind: "jump";
+    toIndex: number;
+} | {
+    kind: "advance";
+};
+/**
+ * §6c — orchestrator-owned post-triage status transitions, then the Path A/B
+ * branch read from bug.summaries.triage.route. Path A skips plan-fix +
+ * review-plan (jumps to implement); Path B / missing / any other value advances
+ * normally.
+ */
+export declare function routeAfterTriage(p: RouteAfterTriageParams): RouteAfterTriageOutcome;

package/dist/extensions/forgecli/orchestrators/bug/bug-triage-routing.js

@@ -0,0 +1,204 @@
+// bug-triage-routing.ts — bug-specific control flow extracted VERBATIM from
+// fix-bug.ts's phase loop (FORGE-S31 file-size refactor). Two self-contained
+// blocks, each a pure-ish helper the pipeline switches on:
+//
+//   1. maybeSkipPhase   — the state-aware phase-skip heuristic (§6a): skip a
+//      non-review phase whose output is already reflected in the bug status,
+//      writing a synthetic summary so downstream predecessor-verdict checks pass.
+//   2. captureTriageBugId — post-triage bugId capture (§ bugId capture): read the
+//      real FORGE-BUG-NNN from triage events, fall back to a list-and-filter,
+//      then re-initialize the debug log under the real id. Preserves the
+//      PENDING- nuance exactly — the transcript writer keeps the PENDING entityId.
+//   3. routeAfterTriage — the orchestrator-owned post-triage status transitions
+//      (§6c) followed by the Path A/B branch read from bug.summaries.triage.route.
+//      The source-introspection contract test scans the `postTriageTransitions`
+//      wiring here.
+//
+// No logic changes; the inline `continue` / `return` paths are surfaced as small
+// discriminated results.
+import { spawnSync } from "node:child_process";
+import * as fs from "node:fs";
+import * as path from "node:path";
+import { loadGovernorProjectConfig } from "../../governor-config.js";
+import { BUG_PHASES, postTriageTransitions } from "./bug-phases.js";
+import { extractBugIdFromEvents, readBugRecord } from "./bug-id.js";
+// ── 6a. Phase skip (state-aware, defense-in-depth) ─────────────
+// Belt-and-suspenders alongside the explicit summaries.triage.route
+// branch (handled in routeAfterTriage below). Some subagents in some
+// runtimes still go end-to-end during triage instead of just triaging
+// — rather than roll back the work they did, skip non-review phases
+// whose output is already reflected in the bug status. Review phases
+// are never skipped — they are quality gates that must always run.
+//
+// Post-v0.44.0: terminal status is `fixed` only. `approved` and
+// `verified` are no longer valid bug status values; references removed.
+const PHASE_SKIP_STATES = {
+    "plan-fix": new Set(["fixed"]),
+    implement: new Set(["fixed"]),
+    commit: new Set(["fixed"]), // commit writes the terminal status; skip if already there
+};
+/**
+ * §6a — decide whether the current phase should be skipped because the bug is
+ * already in a done state. When skipping, writes a synthetic summary so
+ * downstream `after <phase>` verdict checks succeed. Returns true when the
+ * caller should `currentPhaseIndex++; continue;`.
+ */
+export function maybeSkipPhase(p) {
+    const { phase, bugId, cwd, ctx, storeCli, bugNow, summaryKeyByRole } = p;
+    const skipStates = PHASE_SKIP_STATES[phase.role];
+    if (!(skipStates && bugNow?.status && skipStates.has(bugNow.status) && !phase.isReview)) {
+        return false;
+    }
+    ctx.ui.notify(`⊘ forge:fix-bug — skipping ${phase.role}: bug ${bugId} is already '${bugNow.status}' (work already done).`, "info");
+    // Write a synthetic "approved" summary so downstream `after` predecessor
+    // verdict checks find a verdict and don't block review phases.
+    const summaryKey = summaryKeyByRole[phase.role];
+    if (summaryKey) {
+        const synthSummary = {
+            objective: `Phase ${phase.role} skipped — bug already ${bugNow.status}`,
+            findings: ["Subagent completed fix during triage (Path A); phase output implicitly satisfied."],
+            // Non-review phases should have verdict "n/a" — the phase
+            // didn't produce a gate verdict. This matches the `after
+            // <phase> = n/a` preflight gate contract. Review phases
+            // use "approved" since they are gate phases.
+            verdict: phase.isReview ? "approved" : "n/a",
+            written_at: new Date().toISOString(),
+        };
+        const synthFile = path.join(cwd, ".forge", "cache", `synthetic-summary-${bugId}-${summaryKey}.json`);
+        fs.writeFileSync(synthFile, JSON.stringify(synthSummary, null, 2), "utf8");
+        const synthResult = spawnSync("node", [storeCli, "set-bug-summary", bugId, summaryKey, synthFile], {
+            cwd,
+            encoding: "utf8",
+        });
+        if (synthResult.status !== 0) {
+            ctx.ui.notify(`⚠ forge:fix-bug — synthetic summary write failed for ${phase.role}: ${String(synthResult.stderr).trim()}`, "warning");
+        }
+        try {
+            fs.unlinkSync(synthFile);
+        }
+        catch {
+            /* non-fatal */
+        }
+    }
+    return true;
+}
+/**
+ * Post-triage bugId capture: for new bugs the triage subagent creates the bug
+ * record via store-cli; capture the real id by scanning tool_execution_end
+ * events, with a list-and-filter fallback. On success re-initializes the debug
+ * log under the real id and returns the updated locals. Preserves the PENDING-
+ * nuance: the orchestrator transcript writer keeps the PENDING entityId — this
+ * only updates the loop's local bugId.
+ */
+export function captureTriageBugId(p, writeDebug, debugLogPath) {
+    const { cwd, ctx, storeCli, currentPhaseIndex, iterationCounts, debugLogDisabled, toolExecutionEvents } = p;
+    let bugId = p.bugId;
+    const capturedBugId = extractBugIdFromEvents(toolExecutionEvents, loadGovernorProjectConfig(cwd).prefix);
+    if (capturedBugId) {
+        ctx.ui.notify(`forge:fix-bug — captured bug ID: ${capturedBugId}`, "info");
+        bugId = capturedBugId;
+    }
+    else {
+        // Fallback: list bugs and find the most recent one created after pipeline start.
+        const listResult = spawnSync("node", [storeCli, "list", "bug", "--json"], { cwd, encoding: "utf8" });
+        if (listResult.status === 0 && listResult.stdout) {
+            try {
+                const bugs = JSON.parse(listResult.stdout);
+                if (Array.isArray(bugs)) {
+                    // Find most recent bug whose reportedAt is after the pipeline start
+                    const pipelineStartIso = new Date(parseInt(bugId.replace("PENDING-", ""))).toISOString();
+                    const recent = bugs
+                        .filter((b) => b.reportedAt && b.reportedAt >= pipelineStartIso)
+                        .sort((a, b) => String(b.reportedAt).localeCompare(String(a.reportedAt)))[0];
+                    if (recent &&
+                        recent.bugId &&
+                        typeof recent.bugId === "string" &&
+                        recent.bugId.startsWith("FORGE-BUG-")) {
+                        bugId = recent.bugId;
+                        ctx.ui.notify(`forge:fix-bug — captured bug ID via store fallback: ${bugId}`, "info");
+                    }
+                }
+            }
+            catch {
+                /* parse failure — fall through to assertion */
+            }
+        }
+    }
+    // Defensive guard: if bugId is still PENDING after triage, pipeline cannot proceed.
+    if (bugId.startsWith("PENDING-")) {
+        ctx.ui.notify("× forge:fix-bug — failed to capture real bug ID after triage. Cannot proceed with PENDING placeholder.", "error");
+        return {
+            kind: "return",
+            result: {
+                status: "failed",
+                lastPhaseIndex: currentPhaseIndex,
+                iterationCounts,
+                lastError: "bugId still PENDING after triage",
+            },
+        };
+    }
+    // Re-initialize debug log now that real bugId is available.
+    if (!debugLogDisabled) {
+        debugLogPath = path.join(cwd, ".forge", "cache", `fix-bug-debug-${bugId}.jsonl`);
+        const capturedPath = debugLogPath;
+        writeDebug = (rec) => {
+            try {
+                fs.mkdirSync(path.dirname(capturedPath), { recursive: true });
+                try {
+                    const st = fs.statSync(capturedPath);
+                    if (st.size > 10 * 1024 * 1024) {
+                        const all = fs.readFileSync(capturedPath, "utf8");
+                        const lines = all.split("\n");
+                        const keep = Math.floor(lines.length * 0.8);
+                        fs.writeFileSync(capturedPath, lines.slice(-keep).join("\n"), "utf8");
+                    }
+                }
+                catch {
+                    /* file may not exist yet */
+                }
+                fs.appendFileSync(capturedPath, `${JSON.stringify({ ts: new Date().toISOString(), phase: "triage", ...rec })}\n`, "utf8");
+            }
+            catch {
+                // non-fatal
+            }
+        };
+        writeDebug({ kind: "bugid_captured", bugId });
+    }
+    return { kind: "ok", bugId, debugLogPath, writeDebug };
+}
+/**
+ * §6c — orchestrator-owned post-triage status transitions, then the Path A/B
+ * branch read from bug.summaries.triage.route. Path A skips plan-fix +
+ * review-plan (jumps to implement); Path B / missing / any other value advances
+ * normally.
+ */
+export function routeAfterTriage(p) {
+    const { bugId, cwd, ctx, storeCli, currentPhaseIndex } = p;
+    const bugAfterTriage = readBugRecord(bugId, storeCli, cwd);
+    // Orchestrator-owned post-triage transitions (meta-fix-bug.md
+    // step 2). Two sequential writes through store-cli (the FSM
+    // authority); failure warns but does not halt — the commit
+    // phase's status guard is the backstop.
+    for (const target of postTriageTransitions(bugAfterTriage?.status)) {
+        const upd = spawnSync("node", [storeCli, "update-status", "bug", bugId, "status", target], {
+            cwd,
+            encoding: "utf8",
+        });
+        if (upd.status !== 0) {
+            ctx.ui.notify(`⚠ forge:fix-bug — post-triage transition to '${target}' failed: ${(upd.stderr ?? "").toString().trim()}`, "warning");
+            break;
+        }
+    }
+    const triageSummary = bugAfterTriage?.summaries?.triage;
+    const route = triageSummary?.route;
+    if (route === "A") {
+        const skipUntilIndex = BUG_PHASES.findIndex((ph) => ph.role === "implement");
+        if (skipUntilIndex > currentPhaseIndex + 1) {
+            ctx.ui.notify(`⊘ forge:fix-bug — Path A selected by triage; skipping plan-fix and review-plan.`, "info");
+            return { kind: "jump", toIndex: skipUntilIndex };
+        }
+    }
+    // route === "B", missing, or any other value → fall through to standard advance
+    return { kind: "advance" };
+}
+//# sourceMappingURL=bug-triage-routing.js.map

package/dist/extensions/forgecli/orchestrators/bug/bug-triage-routing.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"bug-triage-routing.js","sourceRoot":"","sources":["../../../../../src/extensions/forgecli/orchestrators/bug/bug-triage-routing.ts"],"names":[],"mappings":"AAAA,4EAA4E;AAC5E,6EAA6E;AAC7E,2DAA2D;AAC3D,EAAE;AACF,6EAA6E;AAC7E,6EAA6E;AAC7E,kFAAkF;AAClF,kFAAkF;AAClF,8EAA8E;AAC9E,yEAAyE;AACzE,mFAAmF;AACnF,gFAAgF;AAChF,mFAAmF;AACnF,gFAAgF;AAChF,oBAAoB;AACpB,EAAE;AACF,iFAAiF;AACjF,yBAAyB;AAEzB,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAC/C,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAC9B,OAAO,KAAK,IAAI,MAAM,WAAW,CAAC;AAIlC,OAAO,EAAE,yBAAyB,EAAE,MAAM,0BAA0B,CAAC;AAErE,OAAO,EAAE,UAAU,EAAE,qBAAqB,EAAE,MAAM,iBAAiB,CAAC;AACpE,OAAO,EAAE,sBAAsB,EAAE,aAAa,EAAE,MAAM,aAAa,CAAC;AAIpE,kEAAkE;AAClE,oEAAoE;AACpE,qEAAqE;AACrE,sEAAsE;AACtE,oEAAoE;AACpE,qEAAqE;AACrE,mEAAmE;AACnE,EAAE;AACF,gEAAgE;AAChE,wEAAwE;AACxE,MAAM,iBAAiB,GAAgC;IACtD,UAAU,EAAE,IAAI,GAAG,CAAC,CAAC,OAAO,CAAC,CAAC;IAC9B,SAAS,EAAE,IAAI,GAAG,CAAC,CAAC,OAAO,CAAC,CAAC;IAC7B,MAAM,EAAE,IAAI,GAAG,CAAC,CAAC,OAAO,CAAC,CAAC,EAAE,2DAA2D;CACvF,CAAC;AAaF;;;;;GAKG;AACH,MAAM,UAAU,cAAc,CAAC,CAAkB;IAChD,MAAM,EAAE,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,GAAG,EAAE,QAAQ,EAAE,MAAM,EAAE,gBAAgB,EAAE,GAAG,CAAC,CAAC;IACzE,MAAM,UAAU,GAAG,iBAAiB,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACjD,IAAI,CAAC,CAAC,UAAU,IAAI,MAAM,EAAE,MAAM,IAAI,UAAU,CAAC,GAAG,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAC;QACzF,OAAO,KAAK,CAAC;IACd,CAAC;IACD,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,8BAA8B,KAAK,CAAC,IAAI,SAAS,KAAK,gBAAgB,MAAM,CAAC,MAAM,wBAAwB,EAC3G,MAAM,CACN,CAAC;IACF,yEAAyE;IACzE,+DAA+D;IAC/D,MAAM,UAAU,GAAG,gBAAgB,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAChD,IAAI,UAAU,EAAE,CAAC;QAChB,MAAM,YAAY,GAAG;YACpB,SAAS,EAAE,SAAS,KAAK,CAAC,IAAI,0BAA0B,MAAM,CAAC,MAAM,EAAE;YACvE,QAAQ,EAAE,CAAC,mFAAmF,CAAC;YAC/F,0DAA0D;YAC1D,yDAAyD;YACzD,wDAAwD;YACxD,6CAA6C;YAC7C,OAAO,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,KAAK;YAC5C,UAAU,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;SACpC,CAAC;QACF,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,EAAE,qBAAqB,KAAK,IAAI,UAAU,OAAO,CAAC,CAAC;QACrG,EAAE,CAAC,aAAa,CAAC,SAAS,EAAE,IAAI,CAAC,SAAS,CAAC,YAAY,EAAE,IAAI,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC;QAC3E,MAAM,WAAW,GAAG,SAAS,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE,iBAAiB,EAAE,KAAK,EAAE,UAAU,EAAE,SAAS,CAAC,EAAE;YAClG,GAAG;YACH,QAAQ,EAAE,MAAM;SAChB,CAAC,CAAC;QACH,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC9B,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,wDAAwD,KAAK,CAAC,IAAI,KAAK,MAAM,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,EAC1G,SAAS,CACT,CAAC;QACH,CAAC;QACD,IAAI,CAAC;YACJ,EAAE,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC;QAC1B,CAAC;QAAC,MAAM,CAAC;YACR,eAAe;QAChB,CAAC;IACF,CAAC;IACD,OAAO,IAAI,CAAC;AACb,CAAC;AAwBD;;;;;;;GAOG;AACH,MAAM,UAAU,kBAAkB,CACjC,CAA2B,EAC3B,UAAkD,EAClD,YAA2B;IAE3B,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,QAAQ,EAAE,iBAAiB,EAAE,eAAe,EAAE,gBAAgB,EAAE,mBAAmB,EAAE,GAAG,CAAC,CAAC;IAC5G,IAAI,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC;IAEpB,MAAM,aAAa,GAAG,sBAAsB,CAAC,mBAAmB,EAAE,yBAAyB,CAAC,GAAG,CAAC,CAAC,MAAM,CAAC,CAAC;IACzG,IAAI,aAAa,EAAE,CAAC;QACnB,GAAG,CAAC,EAAE,CAAC,MAAM,CAAC,oCAAoC,aAAa,EAAE,EAAE,MAAM,CAAC,CAAC;QAC3E,KAAK,GAAG,aAAa,CAAC;IACvB,CAAC;SAAM,CAAC;QACP,iFAAiF;QACjF,MAAM,UAAU,GAAG,SAAS,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,QAAQ,CAAC,EAAE,EAAE,GAAG,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QACrG,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,IAAI,UAAU,CAAC,MAAM,EAAE,CAAC;YAClD,IAAI,CAAC;gBACJ,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;gBAC3C,IAAI,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;oBACzB,oEAAoE;oBACpE,MAAM,gBAAgB,GAAG,IAAI,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,OAAO,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE,CAAC;oBACzF,MAAM,MAAM,GAAG,IAAI;yBACjB,MAAM,CAAC,CAAC,CAA0B,EAAE,EAAE,CAAC,CAAC,CAAC,UAAU,IAAI,CAAC,CAAC,UAAU,IAAI,gBAAgB,CAAC;yBACxF,IAAI,CAAC,CAAC,CAA0B,EAAE,CAA0B,EAAE,EAAE,CAChE,MAAM,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,aAAa,CAAC,MAAM,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CACxD,CAAC,CAAC,CAAC,CAAC;oBACN,IACC,MAAM;wBACN,MAAM,CAAC,KAAK;wBACZ,OAAO,MAAM,CAAC,KAAK,KAAK,QAAQ;wBAChC,MAAM,CAAC,KAAK,CAAC,UAAU,CAAC,YAAY,CAAC,EACpC,CAAC;wBACF,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC;wBACrB,GAAG,CAAC,EAAE,CAAC,MAAM,CAAC,uDAAuD,KAAK,EAAE,EAAE,MAAM,CAAC,CAAC;oBACvF,CAAC;gBACF,CAAC;YACF,CAAC;YAAC,MAAM,CAAC;gBACR,+CAA+C;YAChD,CAAC;QACF,CAAC;IACF,CAAC;IAED,oFAAoF;IACpF,IAAI,KAAK,CAAC,UAAU,CAAC,UAAU,CAAC,EAAE,CAAC;QAClC,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,wGAAwG,EACxG,OAAO,CACP,CAAC;QACF,OAAO;YACN,IAAI,EAAE,QAAQ;YACd,MAAM,EAAE;gBACP,MAAM,EAAE,QAAQ;gBAChB,cAAc,EAAE,iBAAiB;gBACjC,eAAe;gBACf,SAAS,EAAE,kCAAkC;aAC7C;SACD,CAAC;IACH,CAAC;IAED,4DAA4D;IAC5D,IAAI,CAAC,gBAAgB,EAAE,CAAC;QACvB,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,QAAQ,EAAE,OAAO,EAAE,iBAAiB,KAAK,QAAQ,CAAC,CAAC;QACjF,MAAM,YAAY,GAAG,YAAY,CAAC;QAClC,UAAU,GAAG,CAAC,GAA4B,EAAE,EAAE;YAC7C,IAAI,CAAC;gBACJ,EAAE,CAAC,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,YAAY,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;gBAC9D,IAAI,CAAC;oBACJ,MAAM,EAAE,GAAG,EAAE,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC;oBACrC,IAAI,EAAE,CAAC,IAAI,GAAG,EAAE,GAAG,IAAI,GAAG,IAAI,EAAE,CAAC;wBAChC,MAAM,GAAG,GAAG,EAAE,CAAC,YAAY,CAAC,YAAY,EAAE,MAAM,CAAC,CAAC;wBAClD,MAAM,KAAK,GAAG,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;wBAC9B,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,MAAM,GAAG,GAAG,CAAC,CAAC;wBAC5C,EAAE,CAAC,aAAa,CAAC,YAAY,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,MAAM,CAAC,CAAC;oBACvE,CAAC;gBACF,CAAC;gBAAC,MAAM,CAAC;oBACR,4BAA4B;gBAC7B,CAAC;gBACD,EAAE,CAAC,cAAc,CAChB,YAAY,EACZ,GAAG,IAAI,CAAC,SAAS,CAAC,EAAE,EAAE,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,KAAK,EAAE,QAAQ,EAAE,GAAG,GAAG,EAAE,CAAC,IAAI,EAChF,MAAM,CACN,CAAC;YACH,CAAC;YAAC,MAAM,CAAC;gBACR,YAAY;YACb,CAAC;QACF,CAAC,CAAC;QACF,UAAU,CAAC,EAAE,IAAI,EAAE,gBAAgB,EAAE,KAAK,EAAE,CAAC,CAAC;IAC/C,CAAC;IAED,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,YAAY,EAAE,UAAU,EAAE,CAAC;AACxD,CAAC;AAcD;;;;;GAKG;AACH,MAAM,UAAU,gBAAgB,CAAC,CAAyB;IACzD,MAAM,EAAE,KAAK,EAAE,GAAG,EAAE,GAAG,EAAE,QAAQ,EAAE,iBAAiB,EAAE,GAAG,CAAC,CAAC;IAC3D,MAAM,cAAc,GAAG,aAAa,CAAC,KAAK,EAAE,QAAQ,EAAE,GAAG,CAAC,CAAC;IAE3D,8DAA8D;IAC9D,4DAA4D;IAC5D,2DAA2D;IAC3D,wCAAwC;IACxC,KAAK,MAAM,MAAM,IAAI,qBAAqB,CAAC,cAAc,EAAE,MAA4B,CAAC,EAAE,CAAC;QAC1F,MAAM,GAAG,GAAG,SAAS,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE,eAAe,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,MAAM,CAAC,EAAE;YAC1F,GAAG;YACH,QAAQ,EAAE,MAAM;SAChB,CAAC,CAAC;QACH,IAAI,GAAG,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACtB,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,gDAAgD,MAAM,aAAa,CAAC,GAAG,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC,QAAQ,EAAE,CAAC,IAAI,EAAE,EAAE,EACzG,SAAS,CACT,CAAC;YACF,MAAM;QACP,CAAC;IACF,CAAC;IAED,MAAM,aAAa,GAAG,cAAc,EAAE,SAAS,EAAE,MAAyC,CAAC;IAC3F,MAAM,KAAK,GAAG,aAAa,EAAE,KAAK,CAAC;IACnC,IAAI,KAAK,KAAK,GAAG,EAAE,CAAC;QACnB,MAAM,cAAc,GAAG,UAAU,CAAC,SAAS,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,IAAI,KAAK,WAAW,CAAC,CAAC;QAC7E,IAAI,cAAc,GAAG,iBAAiB,GAAG,CAAC,EAAE,CAAC;YAC5C,GAAG,CAAC,EAAE,CAAC,MAAM,CAAC,iFAAiF,EAAE,MAAM,CAAC,CAAC;YACzG,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,cAAc,EAAE,CAAC;QAClD,CAAC;IACF,CAAC;IACD,gFAAgF;IAChF,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC;AAC5B,CAAC"}

package/dist/extensions/forgecli/orchestrators/bug/bug-verdict-loop.d.ts

@@ -0,0 +1,38 @@
+import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
+import type { MergedConfig } from "../../config/config-layer.js";
+import type { OrchestratorTranscriptWriter } from "../../subagent/orchestrator-transcript.js";
+import { type PhaseDescriptor } from "../run-task.js";
+import type { RunBugPipelineResult } from "./run-bug-types.js";
+export type BugVerdictLoopOutcome = {
+    kind: "advance";
+} | {
+    kind: "loopback";
+    toIndex: number;
+} | {
+    kind: "return";
+    result: RunBugPipelineResult;
+};
+export interface BugVerdictLoopParams {
+    phase: PhaseDescriptor;
+    bugId: string;
+    storeCli: string;
+    cwd: string;
+    forgeRoot: string;
+    iterationCounts: Record<string, number>;
+    currentPhaseIndex: number;
+    modelRoutingConfig: MergedConfig;
+    ctx: ExtensionCommandContext;
+    orchTranscript: OrchestratorTranscriptWriter;
+    /** Per-role phase-summary key map (BUG_SUMMARY_KEY_BY_ROLE). */
+    summaryKeyByRole: Record<string, string | null>;
+    /** Closure that finalizes this dispatch's OrchestratorTree node. */
+    finishPhaseNode: (status: "completed" | "failed" | "escalated") => void;
+    /** Per-phase completion-recovery guard (forge-engineering#41) — roles that
+     *  already consumed their one set-bug-summary recovery attempt this run. */
+    recoveredPhases: Set<string>;
+}
+/**
+ * Evaluate the review-phase verdict and decide the loop's next move.
+ * Mirrors the inline block that previously lived in runBugPipelineInner.
+ */
+export declare function handleBugReviewVerdict(p: BugVerdictLoopParams): BugVerdictLoopOutcome;

package/dist/extensions/forgecli/orchestrators/bug/bug-verdict-loop.js

@@ -0,0 +1,166 @@
+// bug-verdict-loop.ts — review-phase verdict + revision/loopback handling for
+// the fix-bug pipeline. Extracted VERBATIM from fix-bug.ts's phase loop
+// (FORGE-S31 file-size refactor) as a pure decision function: it performs the
+// same store reads, ctx.ui notifications, state writes, transcript records,
+// tree-node finalization, status-reset transition, and halt-advisor dispatch the
+// inline block did, and returns a small discriminated result the caller's loop
+// switches on.
+//
+// Behavior-preserving: no logic changes. The only structural change is that the
+// inline `return {...}` paths now return `{ kind: "return"; result }`, the
+// `continue` path returns `{ kind: "loopback"; toIndex }`, and the fall-through
+// (approved) path returns `{ kind: "advance" }`.
+import { spawnSync } from "node:child_process";
+import { resolveAdvisorModel, runHaltAdvisor } from "../halt-advisor.js";
+import { recoverPhaseSummary } from "../common/summary-recovery.js";
+import { findPredecessorIndex } from "../run-task.js";
+import { BUG_PHASES } from "./bug-phases.js";
+import { readBugRecord } from "./bug-id.js";
+import { writeBugState } from "./bug-state.js";
+import { readBugVerdict } from "./bug-verdict.js";
+/**
+ * Evaluate the review-phase verdict and decide the loop's next move.
+ * Mirrors the inline block that previously lived in runBugPipelineInner.
+ */
+export function handleBugReviewVerdict(p) {
+    const { phase, bugId, storeCli, cwd, forgeRoot, iterationCounts, currentPhaseIndex, modelRoutingConfig, ctx } = p;
+    const { orchTranscript, finishPhaseNode, summaryKeyByRole, recoveredPhases } = p;
+    // Re-read bug record for latest status after subagent ran
+    const updatedBugRecord = readBugRecord(bugId, storeCli, cwd);
+    let verdict = readBugVerdict(updatedBugRecord, phase.role, summaryKeyByRole);
+    // Completion recovery (forge-engineering#41): a clean stop with no verdict in
+    // the store is most often the subagent writing the {PHASE}-SUMMARY.json
+    // sidecar but eliding the set-bug-summary that registers it. Register the
+    // sidecar ourselves (once per phase), then re-read. Phases whose verdict comes
+    // from bug.status (e.g. commit → summaryKey null) are not recoverable this way.
+    if (verdict === "missing") {
+        const summaryKey = summaryKeyByRole[phase.role];
+        if (summaryKey && !recoveredPhases.has(phase.role)) {
+            recoveredPhases.add(phase.role);
+            const rec = recoverPhaseSummary({
+                storeCli,
+                entityId: bugId,
+                summaryKey,
+                cwd,
+                summaryVerb: "set-bug-summary",
+            });
+            if (rec.ok) {
+                const recheck = readBugVerdict(readBugRecord(bugId, storeCli, cwd), phase.role, summaryKeyByRole);
+                if (recheck !== "missing") {
+                    ctx.ui.notify(`⟳ forge:fix-bug — ${phase.role}: subagent skipped set-bug-summary; orchestrator registered ` +
+                        `the '${summaryKey}' sidecar and the verdict is now present.`, "info");
+                    verdict = recheck;
+                }
+            }
+        }
+    }
+    if (verdict === "missing") {
+        ctx.ui.notify(`× forge:fix-bug — verdict missing for phase ${phase.role} after subagent completed. Halting for advisory.`, "error");
+        finishPhaseNode("failed");
+        writeBugState(cwd, {
+            bugId,
+            phaseIndex: currentPhaseIndex,
+            iterationCounts,
+            halted: true,
+            lastError: `verdict missing for ${phase.role}`,
+            savedAt: new Date().toISOString(),
+        });
+        // A missing verdict IS a postflight-outputs failure: the canonical
+        // phase summary the subagent must write (e.g. summaries.code_review,
+        // linked via set-bug-summary) was never recorded, so there is no
+        // verdict to route on. Route it through the halt-recovery advisor
+        // (FORGE-S26-T18) — the same hand-off the preflight/postflight gate
+        // failures use — instead of a bare escalation. Best-effort, non-fatal.
+        const advisorModel = resolveAdvisorModel(modelRoutingConfig, ctx.model);
+        void runHaltAdvisor({
+            gateFailure: {
+                phase: phase.role,
+                reasonCode: "verdict-missing",
+                detail: `Phase '${phase.role}' completed but no verdict was found in the store. ` +
+                    "The canonical phase summary was not written, so the orchestrator has no verdict to route on.",
+                remediation: "Re-run the phase and ensure the subagent's forge_store set-bug-summary call " +
+                    'uses args:["<bugId>", "<phaseKey>"] with the literal phase key as args[1] ' +
+                    "(e.g. code_review), and that the call exits zero before the subagent returns.",
+            },
+            advisorModel,
+            taskId: bugId,
+            cwd,
+            ctx: { ui: ctx.ui },
+            forgeRoot,
+        });
+        return {
+            kind: "return",
+            result: {
+                status: "halted",
+                lastPhaseIndex: currentPhaseIndex,
+                iterationCounts,
+                lastError: `verdict missing for ${phase.role}`,
+            },
+        };
+    }
+    if (verdict === "revision") {
+        iterationCounts[phase.role] = (iterationCounts[phase.role] ?? 0) + 1;
+        if (iterationCounts[phase.role] >= phase.maxIterations) {
+            ctx.ui.notify(`× forge:fix-bug — revision cap reached for phase ${phase.role} ` +
+                `(${iterationCounts[phase.role]}/${phase.maxIterations} iterations). Escalating.`, "error");
+            finishPhaseNode("escalated");
+            writeBugState(cwd, {
+                bugId,
+                phaseIndex: currentPhaseIndex,
+                iterationCounts,
+                halted: true,
+                lastError: `revision cap reached for ${phase.role}`,
+                savedAt: new Date().toISOString(),
+            });
+            return {
+                kind: "return",
+                result: {
+                    status: "escalated",
+                    lastPhaseIndex: currentPhaseIndex,
+                    iterationCounts,
+                    lastError: `revision cap reached for ${phase.role}`,
+                },
+            };
+        }
+        // Transition bug back to in-progress before re-dispatching implement.
+        // This is required for review-code → implement and approve → implement loops.
+        const currentBugStatus = updatedBugRecord?.status;
+        if (currentBugStatus === "fixed" || currentBugStatus === "approved") {
+            const transitionResult = spawnSync("node", [storeCli, "update-status", "bug", bugId, "status", "in-progress"], { cwd, encoding: "utf8" });
+            if (transitionResult.status !== 0) {
+                ctx.ui.notify(`⚠ forge:fix-bug — failed to transition bug ${bugId} from ${currentBugStatus} to in-progress: ${transitionResult.stderr ?? "unknown"}`, "warning");
+            }
+            else {
+                ctx.ui.notify(`⟳ forge:fix-bug — transitioned bug ${bugId}: ${currentBugStatus} → in-progress`, "info");
+            }
+        }
+        // The review subagent itself finished cleanly — `revision`
+        // is its verdict, not a failure — so its node closes as
+        // completed before the predecessor re-dispatches under a
+        // fresh node ID.
+        finishPhaseNode("completed");
+        const predIndex = findPredecessorIndex(BUG_PHASES, currentPhaseIndex);
+        ctx.ui.notify(`⟳ forge:fix-bug — ${phase.role} returned revision; looping to ${BUG_PHASES[predIndex]?.role ?? predIndex} ` +
+            `(attempt ${iterationCounts[phase.role]}/${phase.maxIterations})`, "info");
+        orchTranscript.record({
+            kind: "phase-loopback",
+            ts: new Date().toISOString(),
+            fromPhase: phase.role,
+            toPhase: BUG_PHASES[predIndex]?.role ?? String(predIndex),
+            fromPhaseIndex: currentPhaseIndex,
+            toPhaseIndex: predIndex,
+            reason: `${phase.role} returned revision (attempt ${iterationCounts[phase.role]}/${phase.maxIterations})`,
+        });
+        writeBugState(cwd, {
+            bugId,
+            phaseIndex: predIndex,
+            iterationCounts,
+            halted: false,
+            savedAt: new Date().toISOString(),
+        });
+        return { kind: "loopback", toIndex: predIndex };
+    }
+    // verdict === "approved": fall through to advance
+    return { kind: "advance" };
+}
+//# sourceMappingURL=bug-verdict-loop.js.map

package/dist/extensions/forgecli/orchestrators/bug/bug-verdict-loop.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"bug-verdict-loop.js","sourceRoot":"","sources":["../../../../../src/extensions/forgecli/orchestrators/bug/bug-verdict-loop.ts"],"names":[],"mappings":"AAAA,8EAA8E;AAC9E,wEAAwE;AACxE,8EAA8E;AAC9E,4EAA4E;AAC5E,iFAAiF;AACjF,+EAA+E;AAC/E,eAAe;AACf,EAAE;AACF,gFAAgF;AAChF,2EAA2E;AAC3E,gFAAgF;AAChF,iDAAiD;AAEjD,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAM/C,OAAO,EAAE,mBAAmB,EAAE,cAAc,EAAE,MAAM,oBAAoB,CAAC;AACzE,OAAO,EAAE,mBAAmB,EAAE,MAAM,+BAA+B,CAAC;AACpE,OAAO,EAAE,oBAAoB,EAAwB,MAAM,gBAAgB,CAAC;AAC5E,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAC7C,OAAO,EAAE,aAAa,EAAE,MAAM,aAAa,CAAC;AAC5C,OAAO,EAAE,aAAa,EAAE,MAAM,gBAAgB,CAAC;AAC/C,OAAO,EAAE,cAAc,EAAE,MAAM,kBAAkB,CAAC;AA4BlD;;;GAGG;AACH,MAAM,UAAU,sBAAsB,CAAC,CAAuB;IAC7D,MAAM,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,GAAG,EAAE,SAAS,EAAE,eAAe,EAAE,iBAAiB,EAAE,kBAAkB,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC;IAClH,MAAM,EAAE,cAAc,EAAE,eAAe,EAAE,gBAAgB,EAAE,eAAe,EAAE,GAAG,CAAC,CAAC;IAEjF,0DAA0D;IAC1D,MAAM,gBAAgB,GAAG,aAAa,CAAC,KAAK,EAAE,QAAQ,EAAE,GAAG,CAAC,CAAC;IAC7D,IAAI,OAAO,GAAG,cAAc,CAAC,gBAAgB,EAAE,KAAK,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC;IAE7E,8EAA8E;IAC9E,wEAAwE;IACxE,0EAA0E;IAC1E,+EAA+E;IAC/E,gFAAgF;IAChF,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;QAC3B,MAAM,UAAU,GAAG,gBAAgB,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAChD,IAAI,UAAU,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC;YACpD,eAAe,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;YAChC,MAAM,GAAG,GAAG,mBAAmB,CAAC;gBAC/B,QAAQ;gBACR,QAAQ,EAAE,KAAK;gBACf,UAAU;gBACV,GAAG;gBACH,WAAW,EAAE,iBAAiB;aAC9B,CAAC,CAAC;YACH,IAAI,GAAG,CAAC,EAAE,EAAE,CAAC;gBACZ,MAAM,OAAO,GAAG,cAAc,CAAC,aAAa,CAAC,KAAK,EAAE,QAAQ,EAAE,GAAG,CAAC,EAAE,KAAK,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC;gBAClG,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;oBAC3B,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,qBAAqB,KAAK,CAAC,IAAI,8DAA8D;wBAC5F,QAAQ,UAAU,2CAA2C,EAC9D,MAAM,CACN,CAAC;oBACF,OAAO,GAAG,OAAO,CAAC;gBACnB,CAAC;YACF,CAAC;QACF,CAAC;IACF,CAAC;IAED,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;QAC3B,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,+CAA+C,KAAK,CAAC,IAAI,kDAAkD,EAC3G,OAAO,CACP,CAAC;QACF,eAAe,CAAC,QAAQ,CAAC,CAAC;QAC1B,aAAa,CAAC,GAAG,EAAE;YAClB,KAAK;YACL,UAAU,EAAE,iBAAiB;YAC7B,eAAe;YACf,MAAM,EAAE,IAAI;YACZ,SAAS,EAAE,uBAAuB,KAAK,CAAC,IAAI,EAAE;YAC9C,OAAO,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;SACjC,CAAC,CAAC;QACH,mEAAmE;QACnE,qEAAqE;QACrE,iEAAiE;QACjE,kEAAkE;QAClE,oEAAoE;QACpE,uEAAuE;QACvE,MAAM,YAAY,GAAG,mBAAmB,CAAC,kBAAkB,EAAE,GAAG,CAAC,KAAY,CAAC,CAAC;QAC/E,KAAK,cAAc,CAAC;YACnB,WAAW,EAAE;gBACZ,KAAK,EAAE,KAAK,CAAC,IAAI;gBACjB,UAAU,EAAE,iBAAiB;gBAC7B,MAAM,EACL,UAAU,KAAK,CAAC,IAAI,qDAAqD;oBACzE,8FAA8F;gBAC/F,WAAW,EACV,8EAA8E;oBAC9E,4EAA4E;oBAC5E,+EAA+E;aAChF;YACD,YAAY;YACZ,MAAM,EAAE,KAAK;YACb,GAAG;YACH,GAAG,EAAE,EAAE,EAAE,EAAE,GAAG,CAAC,EAAS,EAAE;YAC1B,SAAS;SACT,CAAC,CAAC;QACH,OAAO;YACN,IAAI,EAAE,QAAQ;YACd,MAAM,EAAE;gBACP,MAAM,EAAE,QAAQ;gBAChB,cAAc,EAAE,iBAAiB;gBACjC,eAAe;gBACf,SAAS,EAAE,uBAAuB,KAAK,CAAC,IAAI,EAAE;aAC9C;SACD,CAAC;IACH,CAAC;IAED,IAAI,OAAO,KAAK,UAAU,EAAE,CAAC;QAC5B,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;QAErE,IAAI,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,aAAa,EAAE,CAAC;YACxD,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,oDAAoD,KAAK,CAAC,IAAI,GAAG;gBAChE,IAAI,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,aAAa,2BAA2B,EAClF,OAAO,CACP,CAAC;YACF,eAAe,CAAC,WAAW,CAAC,CAAC;YAC7B,aAAa,CAAC,GAAG,EAAE;gBAClB,KAAK;gBACL,UAAU,EAAE,iBAAiB;gBAC7B,eAAe;gBACf,MAAM,EAAE,IAAI;gBACZ,SAAS,EAAE,4BAA4B,KAAK,CAAC,IAAI,EAAE;gBACnD,OAAO,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;aACjC,CAAC,CAAC;YACH,OAAO;gBACN,IAAI,EAAE,QAAQ;gBACd,MAAM,EAAE;oBACP,MAAM,EAAE,WAAW;oBACnB,cAAc,EAAE,iBAAiB;oBACjC,eAAe;oBACf,SAAS,EAAE,4BAA4B,KAAK,CAAC,IAAI,EAAE;iBACnD;aACD,CAAC;QACH,CAAC;QAED,sEAAsE;QACtE,8EAA8E;QAC9E,MAAM,gBAAgB,GAAG,gBAAgB,EAAE,MAAM,CAAC;QAClD,IAAI,gBAAgB,KAAK,OAAO,IAAI,gBAAgB,KAAK,UAAU,EAAE,CAAC;YACrE,MAAM,gBAAgB,GAAG,SAAS,CACjC,MAAM,EACN,CAAC,QAAQ,EAAE,eAAe,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,aAAa,CAAC,EAClE,EAAE,GAAG,EAAE,QAAQ,EAAE,MAAM,EAAE,CACzB,CAAC;YACF,IAAI,gBAAgB,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gBACnC,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,8CAA8C,KAAK,SAAS,gBAAgB,oBAAoB,gBAAgB,CAAC,MAAM,IAAI,SAAS,EAAE,EACtI,SAAS,CACT,CAAC;YACH,CAAC;iBAAM,CAAC;gBACP,GAAG,CAAC,EAAE,CAAC,MAAM,CAAC,sCAAsC,KAAK,KAAK,gBAAgB,gBAAgB,EAAE,MAAM,CAAC,CAAC;YACzG,CAAC;QACF,CAAC;QAED,2DAA2D;QAC3D,wDAAwD;QACxD,yDAAyD;QACzD,iBAAiB;QACjB,eAAe,CAAC,WAAW,CAAC,CAAC;QAC7B,MAAM,SAAS,GAAG,oBAAoB,CAAC,UAAU,EAAE,iBAAiB,CAAC,CAAC;QACtE,GAAG,CAAC,EAAE,CAAC,MAAM,CACZ,qBAAqB,KAAK,CAAC,IAAI,kCAAkC,UAAU,CAAC,SAAS,CAAC,EAAE,IAAI,IAAI,SAAS,GAAG;YAC3G,YAAY,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,aAAa,GAAG,EAClE,MAAM,CACN,CAAC;QACF,cAAc,CAAC,MAAM,CAAC;YACrB,IAAI,EAAE,gBAAgB;YACtB,EAAE,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;YAC5B,SAAS,EAAE,KAAK,CAAC,IAAI;YACrB,OAAO,EAAE,UAAU,CAAC,SAAS,CAAC,EAAE,IAAI,IAAI,MAAM,CAAC,SAAS,CAAC;YACzD,cAAc,EAAE,iBAAiB;YACjC,YAAY,EAAE,SAAS;YACvB,MAAM,EAAE,GAAG,KAAK,CAAC,IAAI,+BAA+B,eAAe,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,aAAa,GAAG;SACzG,CAAC,CAAC;QACH,aAAa,CAAC,GAAG,EAAE;YAClB,KAAK;YACL,UAAU,EAAE,SAAS;YACrB,eAAe;YACf,MAAM,EAAE,KAAK;YACb,OAAO,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;SACjC,CAAC,CAAC;QACH,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC;IACjD,CAAC;IAED,kDAAkD;IAClD,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC;AAC5B,CAAC"}

package/dist/extensions/forgecli/orchestrators/bug/bug-verdict.d.ts

@@ -0,0 +1,3 @@
+import type { BugRecord } from "./bug-id.js";
+export type BugVerdict = "approved" | "revision" | "n/a" | "missing";
+export declare function readBugVerdict(bugRecord: BugRecord | null, phaseRole: string, summaryKeyByRole: Record<string, string | null>): BugVerdict;