@entelligentsia/forgecli 1.0.20 → 1.0.21

package/dist/extensions/forgecli/skill-curation/friction-emit.js

@@ -0,0 +1,245 @@
+// Auto-emit friction events with 5 skill subkinds — FORGE-S24-T11.
+//
+// At task close, the orchestrator hands a snapshot of {retrieved skills,
+// usage verdicts (T09), task outcome, observed tool errors, per-skill
+// historical "unused" counts, pairwise retrieval overlaps} to this module.
+// `computeFrictionSignals` is a pure classifier; `emitFrictionEvents` writes
+// one `friction` event per signal via `node <storeCli> emit <sprintId> …`.
+//
+// Gating logic (acceptance criteria FORGE-S24-T11):
+//   - skill_unused     : retrieved && !used && task.success
+//   - skill_failed     : retrieved && used  && !task.success
+//   - skill_missing    : !retrieved && task.success && tool_errors ≥ 2
+//   - skill_stale      : retrieved && !used across 3 consecutive sprints
+//   - skill_redundant  : two skills' retrieval overlap > 0.8 in this task
+//
+// Each event carries `{type: "friction", workflow, persona, issue, subkind,
+// skillId, evidence, …runtime attribution}`. The required-trio
+// `{workflow, persona, issue}` is what the event schema (plugin v0.45.x)
+// enforces for `type === "friction"`.
+//
+// Telemetry-actor split (IL10):
+//   - Orchestrator owns emission. Subagents never call this module directly.
+//   - Runtime attribution (model/provider/timestamps/durationMinutes) is
+//     SUPPLIED by the orchestrator — never fabricated here.
+//
+// Iron Laws (forge-cli-engineer):
+//   IL1  — code only under forge-cli/src/extensions/forgecli/
+//   IL2  — TypeScript + TypeBox. Runtime inputs validated via Value.Parse.
+//   IL6  — argv-array spawn. No shell-string interpolation.
+//   IL7  — failures surface in the returned counter and stderrs[]; nothing
+//          is silently swallowed.
+//   IL10 — orchestrator-side emission only; subagent never invokes.
+//
+// Scope boundary: this module classifies and emits. It does NOT crawl
+// the trajectory, decide what counts as a "tool error", or compute
+// retrieval overlaps. The caller (orchestrator handler in run-task.ts /
+// fix-bug.ts, gated by FORGE-S24-T12 flag) does that and passes the
+// shaped inputs in.
+import { Type } from "typebox";
+import { Value } from "typebox/value";
+import { spawnStoreCliEmit } from "../lib/spawn-store-cli.js";
+import { isSkillCurationEnabled } from "./skill-curation-flag.js";
+// ── Public schemas ──────────────────────────────────────────────────────────
+/**
+ * One retrieved-and-classified skill for the closed task. `retrieved`
+ * comes from T08 (skill-retriever); `used` from T09 (skill-usage-tracker).
+ * `retrievalScore` is the T08 score (informational — surfaces in evidence).
+ */
+export const RetrievedSkillSignalSchema = Type.Object({
+    skillId: Type.String({ minLength: 1 }),
+    retrieved: Type.Boolean(),
+    used: Type.Boolean(),
+    retrievalScore: Type.Number({ minimum: 0, maximum: 1 }),
+});
+/** Per-skill historical signal — supplied by caller from sprint history. */
+export const SkillHistorySchema = Type.Object({
+    consecutiveUnusedSprints: Type.Integer({ minimum: 0 }),
+});
+/** One pairwise retrieval-overlap measurement for the closed task. */
+export const PairwiseOverlapSchema = Type.Object({
+    skillA: Type.String({ minLength: 1 }),
+    skillB: Type.String({ minLength: 1 }),
+    overlap: Type.Number({ minimum: 0, maximum: 1 }),
+});
+export const FrictionInputsSchema = Type.Object({
+    retrievedSkills: Type.Array(RetrievedSkillSignalSchema),
+    taskSuccess: Type.Boolean(),
+    toolErrorCount: Type.Integer({ minimum: 0 }),
+    history: Type.Record(Type.String(), SkillHistorySchema),
+    pairwiseRetrievalOverlap: Type.Optional(Type.Array(PairwiseOverlapSchema)),
+});
+// FORGE-S25-T27: FRICTION_SUBKINDS and FrictionSubkind are now canonical in
+// lib/catalog-types.ts (single source of truth). Re-exported here for backward
+// compatibility — all existing imports of FRICTION_SUBKINDS from this module continue to work.
+// Source of truth: event.schema.json subkind pattern (skill_unused|skill_failed|…).
+import { FRICTION_SUBKINDS } from "../lib/catalog-types.js";
+export { FRICTION_SUBKINDS };
+/** Runtime attribution supplied by the orchestrator (IL10). */
+export const FrictionEmitRuntimeSchema = Type.Object({
+    storeCli: Type.String({ minLength: 1 }),
+    cwd: Type.String({ minLength: 1 }),
+    sprintId: Type.String({ minLength: 1 }),
+    taskId: Type.String({ minLength: 1 }),
+    /** Orchestrator phase role. @see RoleKind from lib/catalog-types.ts */
+    role: Type.String({ minLength: 1 }),
+    /** Orchestrator phase action. @see ActionKind from lib/catalog-types.ts */
+    action: Type.String({ minLength: 1 }),
+    workflow: Type.String({ minLength: 1 }),
+    persona: Type.String({ minLength: 1 }),
+    phase: Type.Optional(Type.String()),
+    iteration: Type.Optional(Type.Integer({ minimum: 1 })),
+    startTimestamp: Type.String({ format: "date-time" }),
+    endTimestamp: Type.String({ format: "date-time" }),
+    durationMinutes: Type.Number({ minimum: 0 }),
+    model: Type.String({ minLength: 1 }),
+    provider: Type.String({ minLength: 1 }),
+});
+// ── Classification ──────────────────────────────────────────────────────────
+const STALE_THRESHOLD_SPRINTS = 3;
+const REDUNDANCY_OVERLAP_FLOOR = 0.8;
+const MISSING_TOOL_ERROR_FLOOR = 2;
+/**
+ * Apply the five gating rules and return one signal per matching emit.
+ * Pure: no IO, no subprocess. Caller decides whether/when to emit.
+ *
+ * The `skill_unused` and `skill_failed` gates are mutually exclusive by
+ * design — on a failed task we emit `skill_failed` (when used) rather
+ * than `skill_unused`, so the two signals never double-count the same
+ * outcome.
+ */
+export function computeFrictionSignals(inputs) {
+    Value.Parse(FrictionInputsSchema, inputs);
+    const signals = [];
+    for (const s of inputs.retrievedSkills) {
+        // skill_unused — retrieved, not used, task succeeded.
+        if (s.retrieved && !s.used && inputs.taskSuccess) {
+            signals.push({
+                subkind: "skill_unused",
+                skillId: s.skillId,
+                evidence: {
+                    retrievalScore: s.retrievalScore,
+                    taskSuccess: true,
+                },
+            });
+        }
+        // skill_failed — retrieved, used, task failed.
+        if (s.retrieved && s.used && !inputs.taskSuccess) {
+            signals.push({
+                subkind: "skill_failed",
+                skillId: s.skillId,
+                evidence: {
+                    retrievalScore: s.retrievalScore,
+                    toolErrorCount: inputs.toolErrorCount,
+                },
+            });
+        }
+        // skill_stale — retrieved, not used, and the same {retrieved && !used}
+        // pattern has held across STALE_THRESHOLD_SPRINTS consecutive sprints.
+        if (s.retrieved && !s.used) {
+            const hist = inputs.history[s.skillId];
+            if (hist && hist.consecutiveUnusedSprints >= STALE_THRESHOLD_SPRINTS) {
+                signals.push({
+                    subkind: "skill_stale",
+                    skillId: s.skillId,
+                    evidence: {
+                        consecutiveUnusedSprints: hist.consecutiveUnusedSprints,
+                    },
+                });
+            }
+        }
+    }
+    // skill_missing — no skill retrieved AND task succeeded AND ≥2 tool errors.
+    // Emitted once per task (no skillId — there's nothing to attribute).
+    if (inputs.retrievedSkills.length === 0 && inputs.taskSuccess && inputs.toolErrorCount >= MISSING_TOOL_ERROR_FLOOR) {
+        signals.push({
+            subkind: "skill_missing",
+            skillId: undefined,
+            evidence: {
+                toolErrorCount: inputs.toolErrorCount,
+            },
+        });
+    }
+    // skill_redundant — pairwise retrieval overlap strictly > 0.8. Emit one
+    // signal per pair, attributed to the FIRST skill in the pair (skillA).
+    for (const p of inputs.pairwiseRetrievalOverlap ?? []) {
+        if (p.overlap > REDUNDANCY_OVERLAP_FLOOR) {
+            signals.push({
+                subkind: "skill_redundant",
+                skillId: p.skillA,
+                evidence: {
+                    pairedWith: p.skillB,
+                    overlap: p.overlap,
+                },
+            });
+        }
+    }
+    return signals;
+}
+// ── Emission ────────────────────────────────────────────────────────────────
+/** ISO-compact timestamp segment for eventId composition. */
+function isoCompact(iso) {
+    return iso.replace(/[-:.]/g, "").replace(/Z$/, "Z");
+}
+/**
+ * Emit one `friction` event per signal via
+ * `node <storeCli> emit <sprintId> <json>`. Runtime attribution
+ * (model/provider/timestamps/eventId) is supplied by the caller — never
+ * fabricated. Failures surface in the result counter; nothing is thrown
+ * for subprocess failure.
+ */
+export function emitFrictionEvents(signals, runtime) {
+    // FORGE-S24-T12 — gated rollout. Default off ⇒ no friction events
+    // for the five SKILL-CURATION subkinds (skill_unused, skill_failed,
+    // skill_missing, skill_stale, skill_redundant). Note: this gate
+    // applies to the auto-emit module landed in FORGE-S24-T11. The
+    // existing orchestrator friction channel (non-skill subkinds) goes
+    // through `forge/tools/friction-emit.cjs` and is not gated here.
+    if (!isSkillCurationEnabled(runtime.cwd)) {
+        return { emitted: 0, failed: 0, stderrs: [] };
+    }
+    Value.Parse(FrictionEmitRuntimeSchema, runtime);
+    let emitted = 0;
+    let failed = 0;
+    const stderrs = [];
+    for (let i = 0; i < signals.length; i++) {
+        const sig = signals[i];
+        const idTail = sig.skillId ?? "none";
+        const eventId = `${isoCompact(runtime.startTimestamp)}_${runtime.taskId}_friction_${sig.subkind}_${i}_${idTail}`;
+        const event = {
+            eventId,
+            sprintId: runtime.sprintId,
+            taskId: runtime.taskId,
+            role: runtime.role,
+            action: runtime.action,
+            startTimestamp: runtime.startTimestamp,
+            endTimestamp: runtime.endTimestamp,
+            durationMinutes: runtime.durationMinutes,
+            model: runtime.model,
+            provider: runtime.provider,
+            type: "friction",
+            workflow: runtime.workflow,
+            persona: runtime.persona,
+            issue: sig.subkind,
+            subkind: sig.subkind,
+            evidence: sig.evidence,
+        };
+        if (sig.skillId !== undefined)
+            event.skillId = sig.skillId;
+        if (runtime.phase !== undefined)
+            event.phase = runtime.phase;
+        if (runtime.iteration !== undefined)
+            event.iteration = runtime.iteration;
+        // FORGE-S25-T17: adopt spawnStoreCliEmit; adds missing 10 s timeout (N-C-A).
+        const emitResult = spawnStoreCliEmit(runtime.storeCli, runtime.sprintId, event, runtime.cwd);
+        if (emitResult.ok) {
+            emitted++;
+        }
+        else {
+            failed++;
+            stderrs.push(emitResult.stderr);
+        }
+    }
+    return { emitted, failed, stderrs };
+}
+//# sourceMappingURL=friction-emit.js.map

package/dist/extensions/forgecli/skill-curation/friction-emit.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"friction-emit.js","sourceRoot":"","sources":["../../../../src/extensions/forgecli/skill-curation/friction-emit.ts"],"names":[],"mappings":"AAAA,mEAAmE;AACnE,EAAE;AACF,yEAAyE;AACzE,sEAAsE;AACtE,2EAA2E;AAC3E,6EAA6E;AAC7E,2EAA2E;AAC3E,EAAE;AACF,oDAAoD;AACpD,4DAA4D;AAC5D,6DAA6D;AAC7D,uEAAuE;AACvE,yEAAyE;AACzE,0EAA0E;AAC1E,EAAE;AACF,4EAA4E;AAC5E,+DAA+D;AAC/D,yEAAyE;AACzE,sCAAsC;AACtC,EAAE;AACF,gCAAgC;AAChC,6EAA6E;AAC7E,yEAAyE;AACzE,4DAA4D;AAC5D,EAAE;AACF,kCAAkC;AAClC,8DAA8D;AAC9D,2EAA2E;AAC3E,4DAA4D;AAC5D,2EAA2E;AAC3E,kCAAkC;AAClC,oEAAoE;AACpE,EAAE;AACF,sEAAsE;AACtE,mEAAmE;AACnE,wEAAwE;AACxE,oEAAoE;AACpE,oBAAoB;AAEpB,OAAO,EAAe,IAAI,EAAE,MAAM,SAAS,CAAC;AAC5C,OAAO,EAAE,KAAK,EAAE,MAAM,eAAe,CAAC;AACtC,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAC;AAC9D,OAAO,EAAE,sBAAsB,EAAE,MAAM,0BAA0B,CAAC;AAElE,+EAA+E;AAE/E;;;;GAIG;AACH,MAAM,CAAC,MAAM,0BAA0B,GAAG,IAAI,CAAC,MAAM,CAAC;IACrD,OAAO,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACtC,SAAS,EAAE,IAAI,CAAC,OAAO,EAAE;IACzB,IAAI,EAAE,IAAI,CAAC,OAAO,EAAE;IACpB,cAAc,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,CAAC;CACvD,CAAC,CAAC;AAGH,4EAA4E;AAC5E,MAAM,CAAC,MAAM,kBAAkB,GAAG,IAAI,CAAC,MAAM,CAAC;IAC7C,wBAAwB,EAAE,IAAI,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,CAAC;CACtD,CAAC,CAAC;AAGH,sEAAsE;AACtE,MAAM,CAAC,MAAM,qBAAqB,GAAG,IAAI,CAAC,MAAM,CAAC;IAChD,MAAM,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACrC,MAAM,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACrC,OAAO,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,CAAC;CAChD,CAAC,CAAC;AAGH,MAAM,CAAC,MAAM,oBAAoB,GAAG,IAAI,CAAC,MAAM,CAAC;IAC/C,eAAe,EAAE,IAAI,CAAC,KAAK,CAAC,0BAA0B,CAAC;IACvD,WAAW,EAAE,IAAI,CAAC,OAAO,EAAE;IAC3B,cAAc,EAAE,IAAI,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,CAAC;IAC5C,OAAO,EAAE,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,kBAAkB,CAAC;IACvD,wBAAwB,EAAE,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,qBAAqB,CAAC,CAAC;CAC1E,CAAC,CAAC;AAGH,4EAA4E;AAC5E,+EAA+E;AAC/E,+FAA+F;AAC/F,oFAAoF;AACpF,OAAO,EAAE,iBAAiB,EAAwB,MAAM,yBAAyB,CAAC;AAElF,OAAO,EAAE,iBAAiB,EAAwB,CAAC;AAYnD,+DAA+D;AAC/D,MAAM,CAAC,MAAM,yBAAyB,GAAG,IAAI,CAAC,MAAM,CAAC;IACpD,QAAQ,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACvC,GAAG,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IAClC,QAAQ,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACvC,MAAM,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACrC,uEAAuE;IACvE,IAAI,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACnC,2EAA2E;IAC3E,MAAM,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACrC,QAAQ,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACvC,OAAO,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACtC,KAAK,EAAE,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC;IACnC,SAAS,EAAE,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,CAAC,CAAC;IACtD,cAAc,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,MAAM,EAAE,WAAW,EAAE,CAAC;IACpD,YAAY,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,MAAM,EAAE,WAAW,EAAE,CAAC;IAClD,eAAe,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,CAAC;IAC5C,KAAK,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACpC,QAAQ,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;CACvC,CAAC,CAAC;AASH,+EAA+E;AAE/E,MAAM,uBAAuB,GAAG,CAAC,CAAC;AAClC,MAAM,wBAAwB,GAAG,GAAG,CAAC;AACrC,MAAM,wBAAwB,GAAG,CAAC,CAAC;AAEnC;;;;;;;;GAQG;AACH,MAAM,UAAU,sBAAsB,CAAC,MAAsB;IAC5D,KAAK,CAAC,KAAK,CAAC,oBAAoB,EAAE,MAAM,CAAC,CAAC;IAE1C,MAAM,OAAO,GAAqB,EAAE,CAAC;IAErC,KAAK,MAAM,CAAC,IAAI,MAAM,CAAC,eAAe,EAAE,CAAC;QACxC,sDAAsD;QACtD,IAAI,CAAC,CAAC,SAAS,IAAI,CAAC,CAAC,CAAC,IAAI,IAAI,MAAM,CAAC,WAAW,EAAE,CAAC;YAClD,OAAO,CAAC,IAAI,CAAC;gBACZ,OAAO,EAAE,cAAc;gBACvB,OAAO,EAAE,CAAC,CAAC,OAAO;gBAClB,QAAQ,EAAE;oBACT,cAAc,EAAE,CAAC,CAAC,cAAc;oBAChC,WAAW,EAAE,IAAI;iBACjB;aACD,CAAC,CAAC;QACJ,CAAC;QAED,+CAA+C;QAC/C,IAAI,CAAC,CAAC,SAAS,IAAI,CAAC,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,WAAW,EAAE,CAAC;YAClD,OAAO,CAAC,IAAI,CAAC;gBACZ,OAAO,EAAE,cAAc;gBACvB,OAAO,EAAE,CAAC,CAAC,OAAO;gBAClB,QAAQ,EAAE;oBACT,cAAc,EAAE,CAAC,CAAC,cAAc;oBAChC,cAAc,EAAE,MAAM,CAAC,cAAc;iBACrC;aACD,CAAC,CAAC;QACJ,CAAC;QAED,uEAAuE;QACvE,uEAAuE;QACvE,IAAI,CAAC,CAAC,SAAS,IAAI,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;YAC5B,MAAM,IAAI,GAAG,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC;YACvC,IAAI,IAAI,IAAI,IAAI,CAAC,wBAAwB,IAAI,uBAAuB,EAAE,CAAC;gBACtE,OAAO,CAAC,IAAI,CAAC;oBACZ,OAAO,EAAE,aAAa;oBACtB,OAAO,EAAE,CAAC,CAAC,OAAO;oBAClB,QAAQ,EAAE;wBACT,wBAAwB,EAAE,IAAI,CAAC,wBAAwB;qBACvD;iBACD,CAAC,CAAC;YACJ,CAAC;QACF,CAAC;IACF,CAAC;IAED,4EAA4E;IAC5E,qEAAqE;IACrE,IAAI,MAAM,CAAC,eAAe,CAAC,MAAM,KAAK,CAAC,IAAI,MAAM,CAAC,WAAW,IAAI,MAAM,CAAC,cAAc,IAAI,wBAAwB,EAAE,CAAC;QACpH,OAAO,CAAC,IAAI,CAAC;YACZ,OAAO,EAAE,eAAe;YACxB,OAAO,EAAE,SAAS;YAClB,QAAQ,EAAE;gBACT,cAAc,EAAE,MAAM,CAAC,cAAc;aACrC;SACD,CAAC,CAAC;IACJ,CAAC;IAED,wEAAwE;IACxE,uEAAuE;IACvE,KAAK,MAAM,CAAC,IAAI,MAAM,CAAC,wBAAwB,IAAI,EAAE,EAAE,CAAC;QACvD,IAAI,CAAC,CAAC,OAAO,GAAG,wBAAwB,EAAE,CAAC;YAC1C,OAAO,CAAC,IAAI,CAAC;gBACZ,OAAO,EAAE,iBAAiB;gBAC1B,OAAO,EAAE,CAAC,CAAC,MAAM;gBACjB,QAAQ,EAAE;oBACT,UAAU,EAAE,CAAC,CAAC,MAAM;oBACpB,OAAO,EAAE,CAAC,CAAC,OAAO;iBAClB;aACD,CAAC,CAAC;QACJ,CAAC;IACF,CAAC;IAED,OAAO,OAAO,CAAC;AAChB,CAAC;AAED,+EAA+E;AAE/E,6DAA6D;AAC7D,SAAS,UAAU,CAAC,GAAW;IAC9B,OAAO,GAAG,CAAC,OAAO,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC;AACrD,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,kBAAkB,CACjC,OAAkC,EAClC,OAA4B;IAE5B,kEAAkE;IAClE,oEAAoE;IACpE,gEAAgE;IAChE,+DAA+D;IAC/D,mEAAmE;IACnE,iEAAiE;IACjE,IAAI,CAAC,sBAAsB,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC;QAC1C,OAAO,EAAE,OAAO,EAAE,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,EAAE,CAAC;IAC/C,CAAC;IAED,KAAK,CAAC,KAAK,CAAC,yBAAyB,EAAE,OAAO,CAAC,CAAC;IAEhD,IAAI,OAAO,GAAG,CAAC,CAAC;IAChB,IAAI,MAAM,GAAG,CAAC,CAAC;IACf,MAAM,OAAO,GAAa,EAAE,CAAC;IAE7B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACzC,MAAM,GAAG,GAAG,OAAO,CAAC,CAAC,CAAC,CAAC;QAEvB,MAAM,MAAM,GAAG,GAAG,CAAC,OAAO,IAAI,MAAM,CAAC;QACrC,MAAM,OAAO,GAAG,GAAG,UAAU,CAAC,OAAO,CAAC,cAAc,CAAC,IAAI,OAAO,CAAC,MAAM,aAAa,GAAG,CAAC,OAAO,IAAI,CAAC,IAAI,MAAM,EAAE,CAAC;QAEjH,MAAM,KAAK,GAA4B;YACtC,OAAO;YACP,QAAQ,EAAE,OAAO,CAAC,QAAQ;YAC1B,MAAM,EAAE,OAAO,CAAC,MAAM;YACtB,IAAI,EAAE,OAAO,CAAC,IAAI;YAClB,MAAM,EAAE,OAAO,CAAC,MAAM;YACtB,cAAc,EAAE,OAAO,CAAC,cAAc;YACtC,YAAY,EAAE,OAAO,CAAC,YAAY;YAClC,eAAe,EAAE,OAAO,CAAC,eAAe;YACxC,KAAK,EAAE,OAAO,CAAC,KAAK;YACpB,QAAQ,EAAE,OAAO,CAAC,QAAQ;YAC1B,IAAI,EAAE,UAAU;YAChB,QAAQ,EAAE,OAAO,CAAC,QAAQ;YAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;YACxB,KAAK,EAAE,GAAG,CAAC,OAAO;YAClB,OAAO,EAAE,GAAG,CAAC,OAAO;YACpB,QAAQ,EAAE,GAAG,CAAC,QAAQ;SACtB,CAAC;QACF,IAAI,GAAG,CAAC,OAAO,KAAK,SAAS;YAAE,KAAK,CAAC,OAAO,GAAG,GAAG,CAAC,OAAO,CAAC;QAC3D,IAAI,OAAO,CAAC,KAAK,KAAK,SAAS;YAAE,KAAK,CAAC,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC;QAC7D,IAAI,OAAO,CAAC,SAAS,KAAK,SAAS;YAAE,KAAK,CAAC,SAAS,GAAG,OAAO,CAAC,SAAS,CAAC;QAEzE,6EAA6E;QAC7E,MAAM,UAAU,GAAG,iBAAiB,CAAC,OAAO,CAAC,QAAQ,EAAE,OAAO,CAAC,QAAQ,EAAE,KAAK,EAAE,OAAO,CAAC,GAAG,CAAC,CAAC;QAC7F,IAAI,UAAU,CAAC,EAAE,EAAE,CAAC;YACnB,OAAO,EAAE,CAAC;QACX,CAAC;aAAM,CAAC;YACP,MAAM,EAAE,CAAC;YACT,OAAO,CAAC,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;QACjC,CAAC;IACF,CAAC;IAED,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,OAAO,EAAE,CAAC;AACrC,CAAC"}

package/dist/extensions/forgecli/skill-curation/skill-curation-flag.d.ts

@@ -0,0 +1,21 @@
+/**
+ * Parse an env flag value to a tri-state: true / false / null (absent or
+ * unrecognised). Unrecognised values fall through to the disk layers — we
+ * do NOT throw or coerce to false silently.
+ */
+declare function parseEnvFlag(raw: string | undefined): boolean | null;
+/**
+ * Resolve the SKILL-CURATION feature flag for the given working directory.
+ *
+ * Default OFF — the helper returns true only when an explicit `true` value
+ * is found in the env override or one of the config layers.
+ *
+ * `cwd` defaults to `process.cwd()` for production call sites; tests pass
+ * a temp dir to isolate filesystem state.
+ */
+export declare function isSkillCurationEnabled(cwd?: string): boolean;
+export declare const _internal: {
+    parseEnvFlag: typeof parseEnvFlag;
+    ENV_FLAG: string;
+};
+export {};

package/dist/extensions/forgecli/skill-curation/skill-curation-flag.js

@@ -0,0 +1,71 @@
+// Skill-curation feature flag — FORGE-S24-T12.
+//
+// Single source of truth for resolving `forgeCli.skillCuration.enabled`
+// from the layered config. The four SKILL-CURATION emission modules
+// (T08 skill-retriever, T09 skill-usage-tracker, T10 skill-curator-subagent,
+// T11 friction-emit) call `isSkillCurationEnabled()` at the top of their
+// public emission / dispatch entry points and no-op when it returns false.
+//
+// Resolution order (first match wins):
+//   1. Env override `FORGE_CLI_SKILL_CURATION_ENABLED` — accepts "1"/"true"
+//      (case-insensitive) for on, "0"/"false" for off. Provided primarily
+//      for unit tests and one-shot operator overrides; takes precedence
+//      over disk config so a poisoned config never blocks an operator
+//      from turning the flag on or off for a single session.
+//   2. Project config (`<cwd>/.pi/forge-cli/config.json`): `forgeCli.skillCuration.enabled`.
+//   3. Global config (`~/.pi/forge-cli/config.json`): `forgeCli.skillCuration.enabled`.
+//   4. Default: false (Iron Law — gated rollout per FORGE-S24-T12 AC2).
+//
+// Iron Laws (forge-cli-engineer):
+//   IL1  — code only under forge-cli/src/extensions/forgecli/
+//   IL2  — TypeScript; no runtime cast. The layered loader has already
+//          Ajv-validated the JSON against forge-cli-schema.json before
+//          we read it.
+//   IL7  — no silent continuation past failures: schema errors at the
+//          layered-config level are surfaced by orchestrator and TUI callers
+//          upstream of this helper (see doc/decisions/layered-config-error-policy.md).
+//          This function only reads `.project`/`.global` layers; its resilience
+//          to absent layers is intentional — missing means "no opinion".
+import { loadLayeredConfig } from "../config/config-layer.js";
+const ENV_FLAG = "FORGE_CLI_SKILL_CURATION_ENABLED";
+/**
+ * Parse an env flag value to a tri-state: true / false / null (absent or
+ * unrecognised). Unrecognised values fall through to the disk layers — we
+ * do NOT throw or coerce to false silently.
+ */
+function parseEnvFlag(raw) {
+    if (raw === undefined)
+        return null;
+    const normalised = raw.trim().toLowerCase();
+    if (normalised === "1" || normalised === "true")
+        return true;
+    if (normalised === "0" || normalised === "false")
+        return false;
+    return null;
+}
+/**
+ * Resolve the SKILL-CURATION feature flag for the given working directory.
+ *
+ * Default OFF — the helper returns true only when an explicit `true` value
+ * is found in the env override or one of the config layers.
+ *
+ * `cwd` defaults to `process.cwd()` for production call sites; tests pass
+ * a temp dir to isolate filesystem state.
+ */
+export function isSkillCurationEnabled(cwd = process.cwd()) {
+    const envValue = parseEnvFlag(process.env[ENV_FLAG]);
+    if (envValue !== null)
+        return envValue;
+    const layered = loadLayeredConfig(cwd);
+    const projectFlag = layered.project?.forgeCli?.skillCuration?.enabled;
+    if (typeof projectFlag === "boolean")
+        return projectFlag;
+    const globalFlag = layered.global?.forgeCli?.skillCuration?.enabled;
+    if (typeof globalFlag === "boolean")
+        return globalFlag;
+    return false;
+}
+// Exposed for unit tests that want to assert env-parsing behaviour
+// without touching the disk layers.
+export const _internal = { parseEnvFlag, ENV_FLAG };
+//# sourceMappingURL=skill-curation-flag.js.map

package/dist/extensions/forgecli/skill-curation/skill-curation-flag.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-curation-flag.js","sourceRoot":"","sources":["../../../../src/extensions/forgecli/skill-curation/skill-curation-flag.ts"],"names":[],"mappings":"AAAA,+CAA+C;AAC/C,EAAE;AACF,wEAAwE;AACxE,oEAAoE;AACpE,6EAA6E;AAC7E,yEAAyE;AACzE,2EAA2E;AAC3E,EAAE;AACF,uCAAuC;AACvC,4EAA4E;AAC5E,0EAA0E;AAC1E,wEAAwE;AACxE,sEAAsE;AACtE,6DAA6D;AAC7D,6FAA6F;AAC7F,wFAAwF;AACxF,wEAAwE;AACxE,EAAE;AACF,kCAAkC;AAClC,8DAA8D;AAC9D,uEAAuE;AACvE,uEAAuE;AACvE,uBAAuB;AACvB,sEAAsE;AACtE,6EAA6E;AAC7E,uFAAuF;AACvF,gFAAgF;AAChF,yEAAyE;AAEzE,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAC;AAE9D,MAAM,QAAQ,GAAG,kCAAkC,CAAC;AAEpD;;;;GAIG;AACH,SAAS,YAAY,CAAC,GAAuB;IAC5C,IAAI,GAAG,KAAK,SAAS;QAAE,OAAO,IAAI,CAAC;IACnC,MAAM,UAAU,GAAG,GAAG,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;IAC5C,IAAI,UAAU,KAAK,GAAG,IAAI,UAAU,KAAK,MAAM;QAAE,OAAO,IAAI,CAAC;IAC7D,IAAI,UAAU,KAAK,GAAG,IAAI,UAAU,KAAK,OAAO;QAAE,OAAO,KAAK,CAAC;IAC/D,OAAO,IAAI,CAAC;AACb,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,UAAU,sBAAsB,CAAC,MAAc,OAAO,CAAC,GAAG,EAAE;IACjE,MAAM,QAAQ,GAAG,YAAY,CAAC,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC;IACrD,IAAI,QAAQ,KAAK,IAAI;QAAE,OAAO,QAAQ,CAAC;IAEvC,MAAM,OAAO,GAAG,iBAAiB,CAAC,GAAG,CAAC,CAAC;IAEvC,MAAM,WAAW,GAAG,OAAO,CAAC,OAAO,EAAE,QAAQ,EAAE,aAAa,EAAE,OAAO,CAAC;IACtE,IAAI,OAAO,WAAW,KAAK,SAAS;QAAE,OAAO,WAAW,CAAC;IAEzD,MAAM,UAAU,GAAG,OAAO,CAAC,MAAM,EAAE,QAAQ,EAAE,aAAa,EAAE,OAAO,CAAC;IACpE,IAAI,OAAO,UAAU,KAAK,SAAS;QAAE,OAAO,UAAU,CAAC;IAEvD,OAAO,KAAK,CAAC;AACd,CAAC;AAED,mEAAmE;AACnE,oCAAoC;AACpC,MAAM,CAAC,MAAM,SAAS,GAAG,EAAE,YAAY,EAAE,QAAQ,EAAE,CAAC"}

package/dist/extensions/forgecli/skill-curation/skill-curator-subagent.d.ts

@@ -0,0 +1,102 @@
+import { type Static, Type } from "typebox";
+import { type ForgePersona } from "../forge-subagent.js";
+import type { ForgeToolDefs } from "../forge-tools.js";
+/**
+ * One retrieved skill (T08 output) supplied to the curator as context.
+ * `body` is the actual SKILL.md text the agent was shown during the task —
+ * the curator reads it to decide whether the skill needs updating.
+ */
+export declare const RetrievedSkillBodySchema: Type.TObject<{
+    skillId: Type.TString;
+    name: Type.TString;
+    body: Type.TString;
+}>;
+export type RetrievedSkillBody = Static<typeof RetrievedSkillBodySchema>;
+export declare const TaskOutcomeSchema: Type.TObject<{
+    verdict: Type.TUnion<[Type.TLiteral<"approved">, Type.TLiteral<"revision">, Type.TLiteral<"failed">, Type.TLiteral<"aborted">]>;
+    notes: Type.TOptional<Type.TString>;
+}>;
+export type TaskOutcome = Static<typeof TaskOutcomeSchema>;
+export declare const CuratorInputSchema: Type.TObject<{
+    sprintId: Type.TString;
+    taskId: Type.TString;
+    cwd: Type.TString;
+    ts: Type.TString;
+    trajectorySummary: Type.TString;
+    retrievedSkills: Type.TArray<Type.TObject<{
+        skillId: Type.TString;
+        name: Type.TString;
+        body: Type.TString;
+    }>>;
+    outcome: Type.TObject<{
+        verdict: Type.TUnion<[Type.TLiteral<"approved">, Type.TLiteral<"revision">, Type.TLiteral<"failed">, Type.TLiteral<"aborted">]>;
+        notes: Type.TOptional<Type.TString>;
+    }>;
+}>;
+export type CuratorInput = Static<typeof CuratorInputSchema>;
+/**
+ * The enhancement proposal schema accepted by this module — mirrors
+ * `forge/forge/schemas/proposal.schema.json` (the queue-drain contract).
+ * `op` is restricted to the canonical three-op enum; other fields are
+ * passed through verbatim if present.
+ *
+ * Strict on required keys (so malformed items are dropped), permissive on
+ * optional keys (so the curator can supply rationale, sourceFrictionIds,
+ * generated_at, etc., without us re-enumerating the entire schema here).
+ */
+declare const ProposalSchema: Type.TObject<{
+    op: Type.TUnion<[Type.TLiteral<"insert_skill">, Type.TLiteral<"update_skill">, Type.TLiteral<"delete_skill">]>;
+    target_path: Type.TString;
+    diff_body: Type.TString;
+    rationale: Type.TOptional<Type.TString>;
+    sourceFrictionIds: Type.TOptional<Type.TArray<Type.TString>>;
+    generated_at: Type.TOptional<Type.TString>;
+    sprintId: Type.TOptional<Type.TString>;
+    proposalId: Type.TOptional<Type.TString>;
+}>;
+export type Proposal = Static<typeof ProposalSchema>;
+export interface CuratorResult {
+    exitCode: 0 | 1;
+    written: number;
+    queueFile?: string;
+    errorMessage?: string;
+}
+/**
+ * Compose the first user message for the curator subagent. The body embeds
+ * the trajectory summary, retrieved-skill bodies, and task outcome, and
+ * instructs the curator to return zero or more proposals in a fenced JSON
+ * block. The schema is described inline so the curator does not need to
+ * read an external file.
+ */
+export declare function composeCuratorTask(input: CuratorInput): string;
+/**
+ * Pull zero or more proposals from the curator's final assistant text.
+ * Strategy: try fenced ```json blocks first (the requested format), then
+ * fall back to a bare JSON array scan. Items that fail TypeBox validation
+ * are dropped — the failure mode for ill-formed proposals is silent
+ * exclusion, not exception, because the curator's output is best-effort.
+ */
+export declare function parseProposalsFromOutput(text: string): Proposal[];
+/**
+ * Inline curator persona. We do NOT add a file under
+ * `forge/forge/meta/personas/` (Iron Law 1 — forge-cli only). The persona
+ * system prompt is small and self-contained; it tells the LLM to act as a
+ * skill curator and reiterates the output format and the no-write rule.
+ *
+ * The persona is exported so tests can introspect it; in production the
+ * defaultCuratorPersona() factory is consumed by runSkillCurator.
+ */
+export declare function defaultCuratorPersona(): ForgePersona;
+/**
+ * Run the per-task curator subagent and write its proposals to the
+ * enhancement-proposals queue. Always returns a typed result; never throws
+ * on subagent failure (IL7).
+ *
+ * Caller (orchestrator) is responsible for:
+ *   - assembling `retrievedSkills` from the T08 retriever's output;
+ *   - assembling `trajectorySummary` from the task transcript;
+ *   - emitting the canonical phase event AFTER this call returns,
+ *     using its own captured runtime telemetry (Slice 2 contract).
+ */
+export declare function runSkillCurator(input: CuratorInput, forgeToolDefs?: ForgeToolDefs): Promise<CuratorResult>;
+export {};