@enricai/barnacle 1.12.81 → 1.12.82

package/dist/scraper/flow-runner.js

@@ -78,6 +78,7 @@ exports.verifyFillReadback = verifyFillReadback;
 exports.verifyPromptSelectorCommitted = verifyPromptSelectorCommitted;
 exports.tailRetargetPhrasesForStep = tailRetargetPhrasesForStep;
 exports.stepQuotesValueNotControlName = stepQuotesValueNotControlName;
+exports.waitForUploadNetworkSignal = waitForUploadNetworkSignal;
 exports.isUploadAffordanceLabel = isUploadAffordanceLabel;
 exports.writeFixtureToTempFile = writeFixtureToTempFile;
 exports.attachToSurfacedInput = attachToSurfacedInput;
@@ -393,6 +394,8 @@ function wireSignalCapture(page, params) {
                 method: capture.method,
                 status: capture.status,
                 url: capture.url,
+                hasBody: (req.requestPostData ?? "").length > 0,
+                multipart: /^multipart\//i.test(requestContentType(req.requestHeaders)),
             });
             if (recentCaptureMeta.length > RECENT_CAPTURES_WINDOW) {
                 recentCaptureMeta.splice(0, recentCaptureMeta.length - RECENT_CAPTURES_WINDOW);
@@ -1156,13 +1159,60 @@ function fieldValuesAtFailureExpr() {
     return out;
   })()`;
 }
+/**
+ * Reads the in-page quiescence probe as a typed, non-null value. A detached
+ * frame or malformed probe result reads as idle so settle consumes the reader
+ * directly and needs no guard of its own.
+ */
+async function readPageQuiescence(target) {
+    const idle = { pending: 0, mutations: 0 };
+    const result = await Promise.resolve(target.evaluate(click_settle_1.QUIESCENCE_PROBE_EXPR)).catch(() => idle);
+    if (result === null || typeof result !== "object")
+        return idle;
+    const { pending, mutations } = result;
+    return typeof pending === "number" && typeof mutations === "number"
+        ? { pending, mutations }
+        : idle;
+}
+/**
+ * Reads only the visible-text signature settle polls on. Going through
+ * {@link snapshotPage} also read the frame URL, which rejects once a submit
+ * detaches the OOPIF and would abort the settle mid-poll; a failed read here
+ * degrades to the empty signature like the snapshot's own text read does.
+ */
+async function readSettleTextSignature(target) {
+    const result = await Promise.resolve(target.evaluate(DOM_SNAPSHOT_EXPR)).catch(() => null);
+    if (result === null || typeof result !== "object")
+        return "";
+    const { text } = result;
+    return typeof text === "string" ? text : "";
+}
 /**
  * Settles after a click using the target's own text signature and in-page
  * quiescence reader, so every post-click site decides from the same settle
  * signal instead of hand-building the readers.
  */
-async function settleWithPageQuiescence(page, target, signalCounter, preNetworkCount, submitShaped, preVisibleTextSignature) {
-    await (0, click_settle_1.settleAfterClick)(page, signalCounter, preNetworkCount, submitShaped, async () => (await snapshotPage(target, signalCounter)).visibleTextSignature, preVisibleTextSignature, async () => target.evaluate(click_settle_1.QUIESCENCE_PROBE_EXPR));
+async function settleWithPageQuiescence(page, target, signalCounter, preNetworkCount, submitShaped, preVisibleTextSignature, advanced) {
+    await (0, click_settle_1.settleAfterClick)(page, signalCounter, preNetworkCount, submitShaped, () => readSettleTextSignature(target), preVisibleTextSignature, () => readPageQuiescence(target), advanced);
+}
+/**
+ * Builds the "has the page finished advancing" test a mid-flow submit settles
+ * against. It is the body-swap half of the {@link hasPageAdvanced} the phantom
+ * classifier credits with, so a header that flipped before its body re-rendered
+ * keeps settle polling while the classifier still credits whatever is left once
+ * the wait is spent.
+ * Undefined for any other step, which keeps the plain quiet-window settle.
+ */
+function pageAdvancedSince(preVisibleTextSignature, midFlowSubmit) {
+    if (!midFlowSubmit)
+        return undefined;
+    const pre = {
+        networkCount: 0,
+        url: "",
+        bodyHtmlLength: 0,
+        visibleTextSignature: preVisibleTextSignature,
+    };
+    return (visibleTextSignature) => (0, phantom_click_1.hasPageBodySwapped)(pre, { ...pre, visibleTextSignature });
 }
 /**
  * Captures the pre/post signal triple the submit-verify cascade diffs.
@@ -2915,10 +2965,18 @@ async function judgeStepOutcome(params) {
             captureFn,
         });
     }
-    await (0, click_settle_1.settleAfterClick)(params.page, params.signalCounter, params.preNetworkCount, isStepSettleWaitShaped({ step, submitStep: false, isFinalStep, flowHasSubmitSemantics: false }), async () => {
-        const text = await probeRawVisibleText(target);
-        return `${text.length}:${text.slice(0, 200)}`;
-    }, params.preVisibleTextSignature, async () => target.evaluate(click_settle_1.QUIESCENCE_PROBE_EXPR));
+    await settleWithPageQuiescence(params.page, target, params.signalCounter, params.preNetworkCount, isStepSettleWaitShaped({
+        step,
+        submitStep: params.submitStep,
+        isFinalStep,
+        flowHasSubmitSemantics: params.flowHasSubmitSemantics,
+    }) || params.elementSubmitShaped === true, params.preVisibleTextSignature, pageAdvancedSince(params.preVisibleTextSignature, isMidFlowSubmitShapedStep({
+        step,
+        submitStep: params.submitStep,
+        isFinalStep,
+        flowHasSubmitSemantics: params.flowHasSubmitSemantics,
+        elementSubmitShaped: params.elementSubmitShaped,
+    })));
     const colon = params.preVisibleTextSignature.indexOf(":");
     const beforeText = (colon === -1 ? params.preVisibleTextSignature : params.preVisibleTextSignature.slice(colon + 1))
         .replace(/\s+/g, " ")
@@ -4523,12 +4581,17 @@ const UPLOAD_URL_PATTERNS = [
     "/media",
     "/import",
 ];
+/** Case-insensitive Content-Type lookup; CDP preserves the page's header casing. */
+function requestContentType(headers) {
+    const key = Object.keys(headers).find((k) => k.toLowerCase() === "content-type");
+    return key ? (headers[key] ?? "") : "";
+}
 /**
  * Poll the recent-capture window for an upload-related POST after a file has
  * been attached. Extracted from `tryUploadPrimitive` so the raw-input path,
  * the click-to-surface path, and the CDP native-chooser path all verify the
- * same way. Returns true as soon as a non-GET capture whose URL matches
- * {@link UPLOAD_URL_PATTERNS} lands; false if the timeout elapses first.
+ * same way. Returns true as soon as a non-GET capture that is multipart, or is not
+ * known to be body-less and has a URL matching {@link UPLOAD_URL_PATTERNS}, lands; false if the timeout elapses first.
  */
 async function waitForUploadNetworkSignal(params) {
     const { page, fixture, logger, signalCounter, recentCaptureMeta, stopWhen } = params;
@@ -4541,6 +4604,10 @@ async function waitForUploadNetworkSignal(params) {
             const uploadCapture = newCaptures.find((cap) => {
                 if (cap.method === "GET")
                     return false;
+                if (cap.multipart)
+                    return true;
+                if (cap.hasBody === false)
+                    return false;
                 const lowerUrl = cap.url.toLowerCase();
                 return UPLOAD_URL_PATTERNS.some((p) => lowerUrl.includes(p));
             });
@@ -4672,8 +4739,9 @@ async function tryUploadPrimitive(params) {
  * Attach the fixture to an already-surfaced `<input type=file>` (raw or freshly
  * mounted after a click) and verify. Extracted verbatim from the original
  * `tryUploadPrimitive` body so the raw-input path and the click-to-surface
- * path share one setInputFiles + framework-change-dispatch + network/DOM verify
- * + drag-drop-fallback implementation.
+ * path share one setInputFiles + framework-change-dispatch + network/DOM verify implementation.
+ * Returns true only on a verified signal
+ * (upload POST or populated `.files`).
  */
 async function attachToSurfacedInput(params) {
     const { page, target, fixture, logger, signalCounter, recentCaptureMeta } = params;
@@ -4740,18 +4808,10 @@ async function attachToSurfacedInput(params) {
         .evaluate("(() => { const els = document.querySelectorAll('input[type=file]'); for (const el of els) { if (el.files && el.files.length > 0) return el.files.length; } return 0; })()")
         .catch(() => 0);
     if (typeof attachedLength !== "number" || attachedLength === 0) {
-        logger.warn("upload primitive: no network activity within timeout and no file attached in DOM; attempting drag-drop fallback");
-        // K'4: fall back to simulated drag-drop on the most-likely drop zone.
-        // Some custom upload widgets (Material Dropzone, react-dropzone, custom
-        // <uapp-upload> wrappers) only register files when a `drop` event with
-        // a DataTransfer fires on the visible drop area — they don't observe
-        // the hidden input's `files[]` mutations even with synthetic `change`
-        // dispatches. This is the documented Playwright community workaround.
-        const dragDropOk = await simulateDragDropUpload(target, fixture, logger);
-        if (dragDropOk) {
-            logger.info(`upload primitive: drag-drop fallback succeeded (name=${fixture.name}, size=${fixture.buffer.length}b)`);
-            return true;
-        }
+        // A dispatched drop is unverified (no network signal, no .files), so it is
+        // not success here: return false and let surfaceAndUpload run the verified
+        // drop and the trusted-click/chooser routes.
+        logger.warn("upload primitive: no network activity within timeout and no file attached in DOM; deferring to surface-and-upload");
         return false;
     }
     logger.info(`upload primitive: file attached in DOM after setInputFiles (deferred-upload widget; name=${fixture.name}, filesLength=${attachedLength})`);
@@ -6220,9 +6280,9 @@ function isNavigatingEvaluateRejection(error) {
  * wait and the phantom classifier decide from the same reader and baseline.
  * Without a page there is nothing to wait on and the snapshot is taken as-is.
  */
-async function settleAndSnapshotPostClick(target, signalCounter, page, pre) {
+async function settleAndSnapshotPostClick(target, signalCounter, page, pre, midFlowSubmit = false) {
     if (page)
-        await settleWithPageQuiescence(page, target, signalCounter, pre.networkCount, true, pre.visibleTextSignature);
+        await settleWithPageQuiescence(page, target, signalCounter, pre.networkCount, true, pre.visibleTextSignature, pageAdvancedSince(pre.visibleTextSignature, midFlowSubmit));
     return snapshotPage(target, signalCounter, page);
 }
 /**
@@ -6532,7 +6592,7 @@ async function submitCaptchaGatedForm(target, responseField = "h-captcha-respons
         if (clickResult.clicked) {
             if (!pre || !verification)
                 return true;
-            const post = await settleAndSnapshotPostClick(target, verification.signalCounter, verification.page, pre);
+            const post = await settleAndSnapshotPostClick(target, verification.signalCounter, verification.page, pre, verification.isMidFlowSubmitStep);
             const verdict = (0, phantom_click_1.classifyPhantomClick)({
                 actResultSuccess: true,
                 pre,
@@ -6553,7 +6613,7 @@ async function submitCaptchaGatedForm(target, responseField = "h-captcha-respons
                     throw err;
                 });
                 if (runnerUpClickResult.clicked) {
-                    const runnerUpPost = await settleAndSnapshotPostClick(target, verification.signalCounter, verification.page, post);
+                    const runnerUpPost = await settleAndSnapshotPostClick(target, verification.signalCounter, verification.page, post, verification.isMidFlowSubmitStep);
                     const runnerUpVerdict = (0, phantom_click_1.classifyPhantomClick)({
                         actResultSuccess: true,
                         pre: post,
@@ -8766,6 +8826,9 @@ async function hasUnfilledRequiredControlForStep(target, instruction) {
  * upload/dropzone/file-related class or tag names. Tries multiple
  * candidates in order. Returns true on first success.
  *
+ * Dispatch-only: a true return means the drop events fired, not that the
+ * widget accepted the file; callers must verify.
+ *
  * Site-agnostic — DataTransfer + DragEvent dispatch is universal HTML5
  * drag-and-drop API. Works on react-dropzone, Material Dropzone, custom
  * <uapp-upload>/<app-upload>, and any other drop-zone-based upload UI.
@@ -9873,11 +9936,7 @@ async function probeChildFrameSubmitFallback(params) {
         const clickResult = (await Promise.resolve(target.evaluate((0, submit_control_1.buildClickByDeepIndexExpr)(top.deepIndex))).catch(() => ({ clicked: false })));
         if (!clickResult.clicked)
             continue;
-        await (0, click_settle_1.settleAfterClick)(page, signalCounter, pre.networkCount, true, async () => {
-            const snap = await snapshotPage(target, signalCounter);
-            return snap.visibleTextSignature;
-        }, pre.visibleTextSignature, async () => target.evaluate(click_settle_1.QUIESCENCE_PROBE_EXPR));
-        const post = await snapshotPage(target, signalCounter, page);
+        const post = await settleAndSnapshotPostClick(target, signalCounter, page, pre, isMidFlowSubmitStep);
         const verdict = (0, phantom_click_1.classifyPhantomClick)({
             actResultSuccess: true,
             pre,
@@ -9894,11 +9953,7 @@ async function probeChildFrameSubmitFallback(params) {
         const runnerUpClickResult = (await Promise.resolve(target.evaluate((0, submit_control_1.buildClickByDeepIndexExpr)(runnerUp.deepIndex))).catch(() => ({ clicked: false })));
         if (!runnerUpClickResult.clicked)
             continue;
-        await (0, click_settle_1.settleAfterClick)(page, signalCounter, post.networkCount, true, async () => {
-            const snap = await snapshotPage(target, signalCounter);
-            return snap.visibleTextSignature;
-        }, post.visibleTextSignature, async () => target.evaluate(click_settle_1.QUIESCENCE_PROBE_EXPR));
-        const runnerUpPost = await snapshotPage(target, signalCounter, page);
+        const runnerUpPost = await settleAndSnapshotPostClick(target, signalCounter, page, post, isMidFlowSubmitStep);
         const runnerUpVerdict = (0, phantom_click_1.classifyPhantomClick)({
             actResultSuccess: true,
             pre,
@@ -11308,14 +11363,14 @@ async function executeStepWithHealing(params) {
                         const runnerUp = ranked[1];
                         if (runnerUp) {
                             const midTarget = frameTarget ?? (0, frame_target_1.mainFrameTarget)(page);
-                            const midPost = await (0, click_settle_1.settleAndSnapshot)({
-                                page,
-                                counter: signalCounter,
-                                pre,
-                                submitShaped: true,
-                                snapshot: (withPage) => snapshotPage(midTarget, signalCounter, withPage ? page : undefined),
-                                readQuiescence: async () => midTarget.evaluate(click_settle_1.QUIESCENCE_PROBE_EXPR),
+                            const deepMidFlowSubmit = isMidFlowSubmitShapedStep({
+                                step,
+                                submitStep,
+                                isFinalStep,
+                                flowHasSubmitSemantics: flowHasSubmitSemanticsFlag,
+                                elementSubmitShaped: !stepDeclaredNonSubmit,
                             });
+                            const midPost = await settleAndSnapshotPostClick(midTarget, signalCounter, page, pre, deepMidFlowSubmit);
                             const topVerdict = (0, phantom_click_1.classifyPhantomClick)({
                                 actResultSuccess: true,
                                 pre,
@@ -11324,20 +11379,8 @@ async function executeStepWithHealing(params) {
                                 // stray selection flip must not mask a top-pick phantom and skip
                                 // the runner-up retry.
                                 isSubmitShapedStep: true,
-                                isMidFlowSubmitStep: isMidFlowSubmitShapedStep({
-                                    step,
-                                    submitStep,
-                                    isFinalStep,
-                                    flowHasSubmitSemantics: flowHasSubmitSemanticsFlag,
-                                }),
-                                destinationPlausible: (0, phantom_click_1.isPlausibleStepDestination)(step, midPost.url, isMidFlowSubmitShapedStep({
-                                    step,
-                                    submitStep,
-                                    isFinalStep,
-                                    flowHasSubmitSemantics: flowHasSubmitSemanticsFlag,
-                                })
-                                    ? pre.url
-                                    : undefined),
+                                isMidFlowSubmitStep: deepMidFlowSubmit,
+                                destinationPlausible: (0, phantom_click_1.isPlausibleStepDestination)(step, midPost.url, deepMidFlowSubmit ? pre.url : undefined),
                             });
                             if (topVerdict === "phantom") {
                                 logger.info(`${formatStepPrefix(stepIndex, totalSteps)} deep-submit-locator top pick (${top.tag} "${top.accessibleName}") phantom-clicked; retrying runner-up ${runnerUp.tag} "${runnerUp.accessibleName}" (tier ${runnerUp.tier})`);
@@ -12068,6 +12111,24 @@ async function executeStepWithHealing(params) {
         }
         // A fill/select/type action cannot open a tab, so skip the discovery wait for it.
         await adoptOpenedPage(resolvedAction && STATE_CLASS_METHODS.has(resolvedAction.method ?? "") ? 0 : undefined);
+        const isClick = resolvedAction !== null && resolvedAction.method === "click";
+        // Attribute-based submit-shape read of the resolved click target itself —
+        // independent of the flow-authored `submitStep` flag. Read before the
+        // settle: a view swap removes the clicked control, so a post-swap read
+        // would blind the mid-flow exemption on exactly the case it exists for.
+        // See resolvedClickTargetIsSubmitShaped's doc comment.
+        const resolvedElementIsSubmitShaped = isClick && !stepDeclaredNonSubmit && resolvedAction?.selector
+            ? await resolvedClickTargetIsSubmitShaped(frameTarget ?? (0, frame_target_1.mainFrameTarget)(page), resolvedAction.selector)
+            : false;
+        // Computed once: gates every credit signal that takes no post-click URL
+        // (network, DOM read-back) and classifyPhantomClick's destinationPlausible.
+        const stepIsMidFlowSubmit = isMidFlowSubmitShapedStep({
+            step,
+            submitStep,
+            isFinalStep,
+            flowHasSubmitSemantics: flowHasSubmitSemanticsFlag,
+            elementSubmitShaped: resolvedElementIsSubmitShaped,
+        });
         await page.waitForTimeout(STEP_PAUSE_MS);
         // A successful act that reported no actions still ran a click-class action;
         // judging it before its round-trip lands would cascade onto the advanced page.
@@ -12076,7 +12137,7 @@ async function executeStepWithHealing(params) {
             : !STATE_CLASS_METHODS.has(resolvedAction.method ?? "");
         if (mayTriggerRoundTrip) {
             const settleTarget = frameTarget ?? (0, frame_target_1.mainFrameTarget)(page);
-            await settleWithPageQuiescence(page, settleTarget, signalCounter, pre.networkCount, isSettleWaitStep, pre.visibleTextSignature);
+            await settleWithPageQuiescence(page, settleTarget, signalCounter, pre.networkCount, isSettleWaitStep || resolvedElementIsSubmitShaped, pre.visibleTextSignature, pageAdvancedSince(pre.visibleTextSignature, stepIsMidFlowSubmit));
         }
         const post = await snapshotPage(frameTarget ?? (0, frame_target_1.mainFrameTarget)(page), signalCounter, page);
         record.post = post;
@@ -12085,18 +12146,9 @@ async function executeStepWithHealing(params) {
             record.resolvedArguments = (resolvedAction.arguments ?? []).map(String);
         }
         const networkFired = post.networkCount > pre.networkCount;
-        // Computed once: gates every credit signal that takes no post-click URL
-        // (network, DOM read-back) and classifyPhantomClick's destinationPlausible.
-        const stepIsMidFlowSubmit = isMidFlowSubmitShapedStep({
-            step,
-            submitStep,
-            isFinalStep,
-            flowHasSubmitSemantics: flowHasSubmitSemanticsFlag,
-        });
         const destinationPlausible = (0, phantom_click_1.isPlausibleStepDestination)(step, post.url, stepIsMidFlowSubmit ? pre.url : undefined);
         const urlChanged = (0, phantom_click_1.hasOriginOrPathChanged)(pre.url, post.url) && destinationPlausible;
         const isStateClass = resolvedAction !== null && STATE_CLASS_METHODS.has(resolvedAction.method ?? "");
-        const isClick = resolvedAction !== null && resolvedAction.method === "click";
         // State-class actions (fill/check/etc.) never move the network counter or URL,
         // so the legacy heuristic false-negatived every form fill. Re-read DOM state
         // for those; keep the navigation signal authoritative for clicks/links —
@@ -12193,12 +12245,6 @@ async function executeStepWithHealing(params) {
         const clickedElementStillPresent = isClick && resolvedAction?.selector
             ? await resolvedClickTargetStillPresent(frameTarget ?? (0, frame_target_1.mainFrameTarget)(page), resolvedAction.selector)
             : true;
-        // Attribute-based submit-shape read of the resolved click target itself —
-        // independent of the flow-authored `submitStep` flag. See
-        // resolvedClickTargetIsSubmitShaped's doc comment.
-        const resolvedElementIsSubmitShaped = isClick && !stepDeclaredNonSubmit && resolvedAction?.selector
-            ? await resolvedClickTargetIsSubmitShaped(frameTarget ?? (0, frame_target_1.mainFrameTarget)(page), resolvedAction.selector)
-            : false;
         // Client-side view-swap gate: credit a click that produces substantial
         // DOM growth (≥5KB) with zero network when it's NOT a submit/final step
         // and NOT an advance-pattern step. Fixes the top-window site "Manual Application"
@@ -12499,6 +12545,9 @@ async function executeStepWithHealing(params) {
                 captureFn,
                 step,
                 isFinalStep,
+                submitStep,
+                flowHasSubmitSemantics: flowHasSubmitSemanticsFlag,
+                elementSubmitShaped: resolvedElementIsSubmitShaped,
                 page,
                 target: frameTarget ?? (0, frame_target_1.mainFrameTarget)(page),
                 signalCounter,
@@ -12740,7 +12789,13 @@ async function executeStepWithHealing(params) {
                         probeResult.checked === true &&
                         (probeResult.ariaManaged === true || !ancestorStillInvalid);
                     await page.waitForTimeout(STEP_PAUSE_MS);
-                    await settleWithPageQuiescence(page, frameTarget ?? (0, frame_target_1.mainFrameTarget)(page), signalCounter, pre.networkCount, isSettleWaitStep, pre.visibleTextSignature);
+                    await settleWithPageQuiescence(page, frameTarget ?? (0, frame_target_1.mainFrameTarget)(page), signalCounter, pre.networkCount, isSettleWaitStep || retryResolvedElementIsSubmitShaped, pre.visibleTextSignature, pageAdvancedSince(pre.visibleTextSignature, isMidFlowSubmitShapedStep({
+                        step,
+                        submitStep,
+                        isFinalStep,
+                        flowHasSubmitSemantics: flowHasSubmitSemanticsFlag,
+                        elementSubmitShaped: retryResolvedElementIsSubmitShaped,
+                    })));
                     const retryPost = await snapshotPage(frameTarget ?? (0, frame_target_1.mainFrameTarget)(page), signalCounter, page);
                     const retryNetworkFired = retryPost.networkCount > pre.networkCount;
                     const retryMidFlowSubmit = isMidFlowSubmitShapedStep({
@@ -13092,6 +13147,9 @@ async function executeStepWithHealing(params) {
                             captureFn,
                             step,
                             isFinalStep,
+                            submitStep,
+                            flowHasSubmitSemantics: flowHasSubmitSemanticsFlag,
+                            elementSubmitShaped: resolvedElementIsSubmitShaped,
                             page,
                             target: frameTarget ?? (0, frame_target_1.mainFrameTarget)(page),
                             signalCounter,