@enormora/eslint-config-base 0.0.8 → 0.0.9

package/base.js

@@ -4,7 +4,7 @@ import noSecretsPlugin from 'eslint-plugin-no-secrets';
 import codeSpellChecker from '@cspell/eslint-plugin';
 import { stylisticRuleSet } from './rule-sets/stylistic.js';
 import { bestPracticesRuleSet } from './rule-sets/best-practices.js';
-import { ecmaVersion, indentSize, javascriptExtensions } from './constants.js';
+import { ecmaVersion, javascriptExtensions } from './constants.js';
 
 export const baseConfig = {
     languageOptions: {
@@ -43,13 +43,13 @@ export const baseConfig = {
         ...bestPracticesRuleSet.rules,
 
         'array-callback-return': 'error',
+        camelcase: 'off',
         'no-array-constructor': 'error',
         'no-bitwise': 'error',
         'no-caller': 'error',
         'no-case-declarations': 'error',
         'no-class-assign': 'error',
         'no-cond-assign': 'error',
-        'no-confusing-arrow': 'error',
         'no-console': 'error',
         'no-const-assign': 'error',
         'no-constant-condition': 'error',
@@ -76,10 +76,7 @@ export const baseConfig = {
         'no-extra-bind': 'error',
         'no-extra-boolean-cast': 'error',
         'no-extra-label': 'error',
-        'no-extra-parens': 'error',
-        'no-extra-semi': 'error',
         'no-fallthrough': 'error',
-        'no-floating-decimal': 'error',
         'no-func-assign': 'error',
         'no-implicit-coercion': 'error',
         'no-implicit-globals': 'error',
@@ -95,21 +92,17 @@ export const baseConfig = {
         'no-lone-blocks': 'error',
         'no-lonely-if': 'error',
         'no-loop-func': 'error',
-        'no-mixed-spaces-and-tabs': 'error',
         'no-new-native-nonconstructor': 'error',
-        'linebreak-style': ['error', 'unix'],
-        'no-multi-spaces': 'error',
         'no-multi-str': 'error',
-        'no-multiple-empty-lines': ['error', { max: 1 }],
         'no-global-assign': 'error',
         'no-negated-condition': 'off',
         'no-nested-ternary': 'error',
         'no-new': 'error',
         'no-new-func': 'error',
-        'no-new-object': 'error',
         'no-new-symbol': 'error',
         'no-new-wrappers': 'error',
         'no-obj-calls': 'error',
+        'no-object-constructor': 'error',
         'no-octal': 'error',
         'no-octal-escape': 'error',
         'no-param-reassign': ['error', { props: true }],
@@ -126,9 +119,7 @@ export const baseConfig = {
         'no-shadow': ['error', { builtinGlobals: true }],
         'no-shadow-restricted-names': 'error',
         'no-sparse-arrays': 'error',
-        'no-tabs': 'error',
         'no-ternary': 'off',
-        'no-trailing-spaces': 'error',
         'no-this-before-super': 'error',
         'no-throw-literal': 'error',
         'no-undef': ['error', { typeof: true }],
@@ -160,7 +151,6 @@ export const baseConfig = {
         'no-useless-constructor': 'error',
         'no-useless-escape': 'error',
         'no-useless-rename': 'error',
-        'no-whitespace-before-property': 'error',
         'no-void': 'error',
         'prefer-const': [
             'error',
@@ -190,19 +180,7 @@ export const baseConfig = {
                 ignore: [-1, 0, 1]
             }
         ],
-        'no-mixed-operators': 'off',
-        'array-bracket-spacing': ['error', 'never'],
-        'array-bracket-newline': ['error', 'consistent'],
-        'array-element-newline': ['error', 'consistent'],
         'arrow-body-style': ['error', 'always'],
-        'arrow-parens': ['error', 'always'],
-        'arrow-spacing': [
-            'error',
-            {
-                before: true,
-                after: true
-            }
-        ],
         'accessor-pairs': [
             'error',
             {
@@ -210,66 +188,24 @@ export const baseConfig = {
             }
         ],
         'block-scoped-var': 'off',
-        'block-spacing': 'off',
-        'brace-style': ['error', '1tbs', { allowSingleLine: false }],
-        camelcase: 'off',
-        'comma-dangle': ['error', 'never'],
-        'comma-spacing': [
-            'error',
-            {
-                before: false,
-                after: true
-            }
-        ],
-        'comma-style': ['error', 'last'],
         complexity: ['error', { max: 6 }],
-        'computed-property-spacing': [
-            'error',
-            'never',
-            {
-                enforceForClassMembers: true
-            }
-        ],
         'consistent-return': 'error',
         'consistent-this': ['error', 'self'],
         'constructor-super': 'error',
-        'generator-star-spacing': ['error', { before: false, after: true }],
         curly: ['error', 'all'],
         'default-case': 'error',
-        'dot-location': ['error', 'property'],
         'dot-notation': 'error',
-        'eol-last': 'error',
         eqeqeq: 'error',
         'func-names': 'off',
         'func-style': 'off',
         'guard-for-in': 'error',
         'id-length': ['error', { min: 2, properties: 'never' }],
-        indent: [
-            'error',
-            indentSize,
-            {
-                SwitchCase: 1,
-                VariableDeclarator: 1,
-                MemberExpression: 1
-            }
-        ],
         'init-declarations': ['error', 'always'],
-        'jsx-quotes': 'off',
-        'key-spacing': [
-            'error',
-            {
-                beforeColon: false,
-                afterColon: true
-            }
-        ],
-        'lines-around-comment': 'off',
         'max-depth': ['error', { max: 5 }],
         'max-lines': ['error', { max: 500, skipBlankLines: true, skipComments: true }],
         'max-nested-callbacks': ['error', { max: 4 }],
         'max-params': ['error', { max: 4 }],
         'max-statements': ['error', { max: 10 }],
-        'multiline-ternary': 'off',
-        'max-statements-per-line': ['error', { max: 1 }],
         'new-cap': [
             'error',
             {
@@ -277,23 +213,9 @@ export const baseConfig = {
                 capIsNew: true
             }
         ],
-        'new-parens': 'error',
-        'newline-per-chained-call': 'off',
-        'object-curly-newline': 'off',
-        'object-curly-spacing': ['error', 'always'],
-        'object-property-newline': 'off',
         'object-shorthand': ['error', 'always'],
         'one-var': ['error', 'never'],
-        'one-var-declaration-per-line': 'error',
         'operator-assignment': ['error', 'always'],
-        'operator-linebreak': ['error', 'after', { overrides: { '?': 'before', ':': 'before' } }],
-        'padded-blocks': [
-            'error',
-            'never',
-            {
-                allowSingleLineBlocks: false
-            }
-        ],
         'prefer-arrow-callback': [
             'error',
             {
@@ -301,69 +223,19 @@ export const baseConfig = {
             }
         ],
         'prefer-rest-params': 'error',
-        'quote-props': ['error', 'as-needed'],
-        quotes: ['error', 'single', { avoidEscape: true }],
         radix: 'error',
         'id-match': 'off',
         'require-yield': 'error',
-        'rest-spread-spacing': ['error', 'never'],
-        semi: ['error', 'always'],
-        'semi-spacing': [
-            'error',
-            {
-                before: false,
-                after: true
-            }
-        ],
         'sort-vars': 'off',
-        'keyword-spacing': [
-            'error',
-            {
-                before: true,
-                after: true
-            }
-        ],
-        'space-before-blocks': ['error', 'always'],
-        'space-before-function-paren': [
-            'error',
-            {
-                anonymous: 'always',
-                named: 'never',
-                asyncArrow: 'always'
-            }
-        ],
-        'space-in-parens': ['error', 'never'],
-        'space-infix-ops': 'error',
-        'space-unary-ops': 'error',
-        'spaced-comment': [
-            'error',
-            'always',
-            {
-                line: {
-                    exceptions: ['-', '+', '*'],
-                    markers: ['!', '/', '=>']
-                },
-                block: {
-                    exceptions: ['-', '+', '*'],
-                    markers: ['!', '*'],
-                    balanced: true
-                }
-            }
-        ],
         'sort-imports': 'off',
         strict: ['error', 'safe'],
-        'template-curly-spacing': 'error',
         'unicode-bom': ['error', 'never'],
         'use-isnan': 'error',
         'valid-typeof': 'error',
         'vars-on-top': 'error',
-        'wrap-iife': ['error', 'inside'],
-        'wrap-regex': 'off',
-        'yield-star-spacing': ['error', { before: false, after: true }],
         yoda: ['error', 'never'],
         'capitalized-comments': 'off',
         'class-methods-use-this': 'error',
-        'func-call-spacing': ['error', 'never'],
         'func-name-matching': 'off',
         'line-comment-position': 'off',
         'no-await-in-loop': 'off',
@@ -373,7 +245,6 @@ export const baseConfig = {
         'no-template-curly-in-string': 'error',
         'no-unsafe-negation': 'error',
         'no-useless-return': 'error',
-        'nonblock-statement-body-position': 'off',
         'prefer-destructuring': [
             'error',
             {
@@ -400,54 +271,22 @@ export const baseConfig = {
         'require-await': 'off',
         'sort-keys': 'off',
         'symbol-description': 'error',
-        'template-tag-spacing': ['error', 'never'],
         'for-direction': 'off',
-        'padding-line-between-statements': [
-            'error',
-            {
-                blankLine: 'always',
-                prev: 'directive',
-                next: '*'
-            },
-            {
-                blankLine: 'any',
-                prev: 'directive',
-                next: 'directive'
-            }
-        ],
-        'semi-style': ['error', 'last'],
-        'switch-colon-spacing': [
-            'error',
-            {
-                after: true,
-                before: false
-            }
-        ],
-        'function-paren-newline': 'off',
         'getter-return': [
             'error',
             {
                 allowImplicit: false
             }
         ],
-        'implicit-arrow-linebreak': 'off',
-        'lines-between-class-members': [
-            'error',
-            'always',
-            {
-                exceptAfterSingleLine: true
-            }
-        ],
         'multiline-comment-style': 'off',
         'max-classes-per-file': 'off',
-        'max-lines-per-function': ['error', { max: 75, skipBlankLines: true, skipComments: true }],
+        'max-lines-per-function': 'off',
         'prefer-object-spread': 'error',
         'no-async-promise-executor': 'error',
         'no-misleading-character-class': 'error',
         'default-param-last': 'error',
         'prefer-regex-literals': 'error',
         'require-unicode-regexp': 'off',
-        'function-call-argument-newline': ['error', 'consistent'],
         'no-useless-catch': 'error',
         'prefer-named-capture-group': 'error',
         'no-import-assign': 'error',
@@ -458,19 +297,6 @@ export const baseConfig = {
         'no-alert': 'off',
         'no-script-url': 'off',
         'no-restricted-globals': 'off',
-        'max-len': [
-            'error',
-            {
-                code: 120,
-                tabWidth: indentSize,
-                ignoreComments: true,
-                ignoreTrailingComments: true,
-                ignoreUrls: true,
-                ignoreStrings: false,
-                ignoreTemplateLiterals: false,
-                ignoreRegExpLiterals: true
-            }
-        ],
 
         'grouped-accessor-pairs': 'off',
         'no-constructor-return': 'error',

package/package.json

@@ -1,15 +1,16 @@
 {
     "dependencies": {
-        "@cspell/eslint-plugin": "7.3.6",
+        "@cspell/eslint-plugin": "8.1.3",
+        "@stylistic/eslint-plugin": "1.5.1",
         "eslint-plugin-array-func": "4.0.0",
         "eslint-plugin-destructuring": "2.2.1",
         "eslint-plugin-eslint-comments": "3.2.0",
-        "eslint-plugin-import": "2.28.1",
+        "eslint-plugin-import": "2.29.0",
         "eslint-plugin-no-secrets": "0.8.9",
-        "eslint-plugin-prettier": "5.0.0",
+        "eslint-plugin-prettier": "5.0.1",
         "eslint-plugin-promise": "6.1.1",
-        "eslint-plugin-sonarjs": "0.21.0",
-        "eslint-plugin-unicorn": "^48.0.1"
+        "eslint-plugin-sonarjs": "0.23.0",
+        "eslint-plugin-unicorn": "49.0.0"
     },
     "license": "MIT",
     "main": "base.js",
@@ -19,5 +20,5 @@
         "url": "git://github.com/enormora/eslint-config.git"
     },
     "type": "module",
-    "version": "0.0.8"
+    "version": "0.0.9"
 }

package/rule-sets/stylistic.js

@@ -1,10 +1,13 @@
 import prettierPlugin from 'eslint-plugin-prettier';
 import destructuringPlugin from 'eslint-plugin-destructuring';
+import stylisticPlugin from '@stylistic/eslint-plugin';
+import { indentSize } from '../constants.js';
 
 export const stylisticRuleSet = {
     plugins: {
         prettier: prettierPlugin,
-        destructuring: destructuringPlugin
+        destructuring: destructuringPlugin,
+        '@stylistic': stylisticPlugin
     },
 
     settings: {},
@@ -14,6 +17,218 @@ export const stylisticRuleSet = {
 
         'destructuring/in-methods-params': 'error',
         'destructuring/in-params': ['error', { 'max-params': 0 }],
-        'destructuring/no-rename': 'off'
+        'destructuring/no-rename': 'off',
+
+        '@stylistic/array-bracket-newline': ['error', 'consistent'],
+        '@stylistic/array-bracket-spacing': ['error', 'never'],
+        '@stylistic/array-element-newline': ['error', 'consistent'],
+        '@stylistic/arrow-parens': ['error', 'always'],
+        '@stylistic/arrow-spacing': [
+            'error',
+            {
+                before: true,
+                after: true
+            }
+        ],
+        '@stylistic/block-spacing': 'off',
+        '@stylistic/brace-style': ['error', '1tbs', { allowSingleLine: false }],
+        '@stylistic/comma-dangle': ['error', 'never'],
+        '@stylistic/comma-spacing': [
+            'error',
+            {
+                before: false,
+                after: true
+            }
+        ],
+        '@stylistic/comma-style': ['error', 'last'],
+        '@stylistic/computed-property-spacing': [
+            'error',
+            'never',
+            {
+                enforceForClassMembers: true
+            }
+        ],
+        '@stylistic/dot-location': ['error', 'property'],
+        '@stylistic/eol-last': 'error',
+        '@stylistic/func-call-spacing': ['error', 'never'],
+        '@stylistic/function-call-spacing': ['error', 'never'],
+        '@stylistic/function-call-argument-newline': ['error', 'consistent'],
+        '@stylistic/function-paren-newline': 'off',
+        '@stylistic/generator-star-spacing': ['error', { before: false, after: true }],
+        '@stylistic/indent-binary-ops': ['error', indentSize],
+        '@stylistic/implicit-arrow-linebreak': 'off',
+        '@stylistic/indent': [
+            'error',
+            indentSize,
+            {
+                SwitchCase: 1,
+                VariableDeclarator: 1,
+                MemberExpression: 1
+            }
+        ],
+        '@stylistic/jsx-child-element-spacing': 'off',
+        '@stylistic/jsx-closing-bracket-location': 'off',
+        '@stylistic/jsx-closing-tag-location': 'off',
+        '@stylistic/jsx-curly-brace-presence': 'off',
+        '@stylistic/jsx-curly-newline': 'off',
+        '@stylistic/jsx-curly-spacing': 'off',
+        '@stylistic/jsx-equals-spacing': 'off',
+        '@stylistic/jsx-first-prop-new-line': 'off',
+        '@stylistic/jsx-indent': 'off',
+        '@stylistic/jsx-indent-props': 'off',
+        '@stylistic/jsx-max-props-per-line': 'off',
+        '@stylistic/jsx-newline': 'off',
+        '@stylistic/jsx-one-expression-per-line': 'off',
+        '@stylistic/jsx-props-no-multi-spaces': 'off',
+        '@stylistic/jsx-self-closing-comp': 'off',
+        '@stylistic/jsx-sort-props': 'off',
+        '@stylistic/jsx-tag-spacing': 'off',
+        '@stylistic/jsx-quotes': 'off',
+        '@stylistic/jsx-wrap-multilines': 'off',
+        '@stylistic/key-spacing': [
+            'error',
+            {
+                beforeColon: false,
+                afterColon: true
+            }
+        ],
+        '@stylistic/keyword-spacing': [
+            'error',
+            {
+                before: true,
+                after: true
+            }
+        ],
+        '@stylistic/linebreak-style': ['error', 'unix'],
+        '@stylistic/lines-between-class-members': [
+            'error',
+            'always',
+            {
+                exceptAfterSingleLine: true
+            }
+        ],
+        '@stylistic/lines-around-comment': 'off',
+        '@stylistic/max-len': [
+            'error',
+            {
+                code: 120,
+                tabWidth: indentSize,
+                ignoreComments: true,
+                ignoreTrailingComments: true,
+                ignoreUrls: true,
+                ignoreStrings: false,
+                ignoreTemplateLiterals: false,
+                ignoreRegExpLiterals: true
+            }
+        ],
+        '@stylistic/max-statements-per-line': ['error', { max: 1 }],
+        '@stylistic/member-delimiter-style': [
+            'error',
+            {
+                multiline: {
+                    delimiter: 'semi',
+                    requireLast: true
+                },
+                singleline: {
+                    delimiter: 'semi',
+                    requireLast: false
+                }
+            }
+        ],
+        '@stylistic/multiline-ternary': 'off',
+        '@stylistic/new-parens': 'error',
+        '@stylistic/newline-per-chained-call': 'off',
+        '@stylistic/no-confusing-arrow': 'error',
+        // Currently this rule conflicts with prettier, because in some cases prettier adds unnecessary extra parens. Unfortunately there is no way to turn this off yet. We should re-enable this rule once this has been fixed in prettier or once there is a better formatter that doesn’t add unnecessary parens. See https://github.com/prettier/prettier/issues/3089
+        '@stylistic/no-extra-parens': 'off',
+        '@stylistic/no-extra-semi': 'error',
+        '@stylistic/no-floating-decimal': 'error',
+        '@stylistic/no-mixed-operators': 'off',
+        '@stylistic/no-mixed-spaces-and-tabs': 'error',
+        '@stylistic/no-multi-spaces': 'error',
+        '@stylistic/no-multiple-empty-lines': ['error', { max: 1 }],
+        '@stylistic/no-tabs': 'error',
+        '@stylistic/no-trailing-spaces': 'error',
+        '@stylistic/no-whitespace-before-property': 'error',
+        '@stylistic/nonblock-statement-body-position': 'off',
+        '@stylistic/object-curly-newline': 'off',
+        '@stylistic/object-curly-spacing': ['error', 'always'],
+        '@stylistic/object-property-newline': 'off',
+        '@stylistic/one-var-declaration-per-line': 'error',
+        '@stylistic/operator-linebreak': ['error', 'after', { overrides: { '?': 'before', ':': 'before' } }],
+        '@stylistic/padded-blocks': [
+            'error',
+            'never',
+            {
+                allowSingleLineBlocks: false
+            }
+        ],
+        '@stylistic/padding-line-between-statements': [
+            'error',
+            {
+                blankLine: 'always',
+                prev: 'directive',
+                next: '*'
+            },
+            {
+                blankLine: 'any',
+                prev: 'directive',
+                next: 'directive'
+            }
+        ],
+        '@stylistic/quote-props': ['error', 'as-needed'],
+        '@stylistic/quotes': ['error', 'single', { avoidEscape: true }],
+        '@stylistic/rest-spread-spacing': ['error', 'never'],
+        '@stylistic/semi': ['error', 'always'],
+        '@stylistic/semi-spacing': [
+            'error',
+            {
+                before: false,
+                after: true
+            }
+        ],
+        '@stylistic/semi-style': ['error', 'last'],
+        '@stylistic/space-before-blocks': ['error', 'always'],
+        '@stylistic/space-before-function-paren': [
+            'error',
+            {
+                anonymous: 'always',
+                named: 'never',
+                asyncArrow: 'always'
+            }
+        ],
+        '@stylistic/space-in-parens': ['error', 'never'],
+        '@stylistic/space-infix-ops': 'error',
+        '@stylistic/space-unary-ops': 'error',
+        '@stylistic/spaced-comment': [
+            'error',
+            'always',
+            {
+                line: {
+                    exceptions: ['-', '+', '*'],
+                    markers: ['!', '/', '=>']
+                },
+                block: {
+                    exceptions: ['-', '+', '*'],
+                    markers: ['!', '*'],
+                    balanced: true
+                }
+            }
+        ],
+        '@stylistic/switch-colon-spacing': [
+            'error',
+            {
+                after: true,
+                before: false
+            }
+        ],
+        '@stylistic/template-curly-spacing': 'error',
+        '@stylistic/template-tag-spacing': ['error', 'never'],
+        '@stylistic/type-annotation-spacing': 'error',
+        '@stylistic/type-generic-spacing': 'error',
+        '@stylistic/type-named-tuple-spacing': 'error',
+        '@stylistic/wrap-iife': ['error', 'inside'],
+        '@stylistic/wrap-regex': 'off',
+        '@stylistic/yield-star-spacing': ['error', { before: false, after: true }]
     }
 };