@engineeros/connector 0.8.8 → 0.9.0

package/src/runner.mjs

@@ -12,6 +12,7 @@ import path from "node:path";
 import { promisify } from "node:util";
 import { deflateRaw } from "node:zlib";
 import { launchAcpAgent } from "./acp-client.mjs";
+import { buildAgentHarnessPrompt } from "./agent-harness.mjs";
 
 const deflate = promisify(deflateRaw);
 const MAX_ARCHIVE_BYTES = 25 * 1024 * 1024;
@@ -117,7 +118,15 @@ export async function executeAssignment(assignment, config, callbacks) {
   );
   const verifier = launchAgentProcess(
     runWorkspace,
-    verificationPrompt(assignment, committed.revision, committed.changedFiles),
+    buildAgentHarnessPrompt({
+      agentRole: "verification",
+      prompt: verificationPrompt(
+        assignment,
+        committed.revision,
+        committed.changedFiles,
+      ),
+      sandboxMode: "read-only",
+    }),
     "read-only",
     config,
     callbacks,
@@ -485,7 +494,12 @@ export async function executeConnectedPrompt(assignment, config, callbacks) {
     callbacks,
     execution.profile,
     previousSessionId,
+    {
+      persistentAcp: true,
+      sessionKey: execution.sessionKey,
+    },
   );
+  callbacks.onController?.(controller);
   callbacks.onProcess?.(controller.child);
   const completed = await controller.completed;
   const content = completed.finalMessage.trim();
@@ -510,7 +524,7 @@ export async function inspectCodingAgent(config, workspace = process.cwd()) {
     return {
       protocol: "acp",
       name: config.agent_name || path.basename(config.agent_command),
-      version: "ACP v1",
+      version: config.agent_version || "ACP v1",
     };
   }
   const codex = await inspectCodexCli(workspace);
@@ -595,17 +609,35 @@ export function promptProgressMessage(event) {
   return null;
 }
 
-export function promptQueueMessage(activeKind) {
-  if (activeKind === "assessment") {
-    return "Queued: agent is finishing the workspace assessment";
+export function promptStreamEvent(event) {
+  if (!event || typeof event !== "object") return null;
+  if (
+    event.type === "acp.agent_message_chunk" &&
+    event.update?.content?.type === "text"
+  ) {
+    return { kind: "message", delta: event.update.content.text };
+  }
+  if (event.type === "acp.agent_thought_chunk") {
+    return {
+      kind: "thought",
+      message: "Agent is reasoning through the request",
+    };
   }
-  if (activeKind === "goal") {
-    return "Queued: agent is finishing an active Goal";
+  if (event.type === "acp.plan") {
+    return { kind: "plan", message: "Agent updated the working plan" };
   }
-  if (activeKind === "prompt") {
-    return "Queued: agent is finishing another request";
+  if (event.type === "acp.tool_call" || event.type === "acp.tool_call_update") {
+    return {
+      kind: "tool",
+      message: event.update?.title || "Agent is inspecting the workspace",
+      status: event.update?.status,
+    };
   }
-  return "Agent accepted the request";
+  if (event.type === "item.completed" && event.item?.type === "agent_message") {
+    return { kind: "message", delta: event.item.text };
+  }
+  const message = promptProgressMessage(event);
+  return message ? { kind: "status", message } : null;
 }
 
 function assessmentCommandMilestone(command) {
@@ -633,8 +665,8 @@ function assessmentCommandMilestone(command) {
 }
 
 export function connectorExecution(assignment) {
-  const prompt = assignment?.prompt_markdown;
-  if (typeof prompt !== "string" || !prompt.trim()) {
+  const rawPrompt = assignment?.prompt_markdown;
+  if (typeof rawPrompt !== "string" || !rawPrompt.trim()) {
     throw new Error("EngineerOS assignment is missing prompt_markdown.");
   }
   const sandboxMode = assignment?.sandbox_mode;
@@ -653,13 +685,26 @@ export function connectorExecution(assignment) {
       "EngineerOS assignment has an unsupported reasoning effort.",
     );
   }
+  const agentRole = assignment?.agent_role;
+  const prompt = buildAgentHarnessPrompt({
+    agentRole,
+    prompt: rawPrompt,
+    sandboxMode,
+  });
   return {
     prompt,
+    agentRole,
     sandboxMode,
     sessionKey:
-      typeof assignment.session_key === "string" && assignment.session_key.trim()
+      typeof assignment.session_key === "string" &&
+      assignment.session_key.trim()
         ? assignment.session_key.trim()
-        : `project-${String(assignment.purpose || "general").toLowerCase().replace(/[^a-z0-9]+/g, "-").slice(0, 80)}`,
+        : `project-${String(agentRole)}-${String(
+            assignment.purpose || "general",
+          )
+            .toLowerCase()
+            .replace(/[^a-z0-9]+/g, "-")
+            .slice(0, 80)}`,
     profile: {
       ...(model ? { model } : {}),
       ...(reasoningEffort ? { reasoning_effort: reasoningEffort } : {}),
@@ -830,7 +875,10 @@ function launchCodexProcess(
       if (!line.trim()) continue;
       try {
         const event = JSON.parse(line);
-        if (event.type === "thread.started" && typeof event.thread_id === "string") {
+        if (
+          event.type === "thread.started" &&
+          typeof event.thread_id === "string"
+        ) {
           sessionId = event.thread_id;
         }
         if (
@@ -860,8 +908,14 @@ function launchCodexProcess(
   const completed = new Promise((resolve, reject) => {
     child.once("error", reject);
     child.once("close", (code) => {
-      if (code === 0 && sessionId) resolve({ output: output.slice(-20_000), finalMessage, sessionId });
-      else if (code === 0) reject(new Error("Codex completed without announcing a resumable session id."));
+      if (code === 0 && sessionId)
+        resolve({ output: output.slice(-20_000), finalMessage, sessionId });
+      else if (code === 0)
+        reject(
+          new Error(
+            "Codex completed without announcing a resumable session id.",
+          ),
+        );
       else reject(new Error(codexFailureMessage(output, code)));
     });
   });
@@ -937,12 +991,13 @@ function launchAgentProcess(
   mcpContext,
 ) {
   if (config.agent_protocol === "acp") {
-    if (profile.model || profile.reasoning_effort) {
-      throw new Error(
-        "This ACP coding agent does not advertise execution-profile support.",
-      );
-    }
-    return launchAcpAgent(workspace, prompt, config, callbacks);
+    return launchAcpAgent(workspace, prompt, config, callbacks, {
+      persistent: mcpContext?.persistentAcp === true,
+      sessionKey: mcpContext?.sessionKey,
+      previousSessionId,
+      sandbox,
+      profile,
+    });
   }
   return launchCodexProcess(
     workspace,

package/src/skills/change-planning/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: change-planning
+description: Produce a decision-complete implementation plan grounded in the connected repository.
+---
+
+# Change Planning
+
+1. Inspect current behavior, ownership boundaries, call paths, tests, and project instructions before proposing changes.
+2. Define the intended outcome, affected components, non-goals, risks, and proof of completion.
+3. Resolve questions answerable from the repository. Label only genuinely unavailable facts as assumptions.
+4. Sequence bounded implementation steps with the files or symbols each step affects and the verification it requires.
+5. Stay read-only and hand off a plan that an implementation Agent can execute without rediscovering the problem.

package/src/skills/change-verification/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: change-verification
+description: Independently verify a completed change against its explicit proof contract.
+---
+
+# Change Verification
+
+1. Inspect the exact supplied revision, changed paths, Goal boundaries, constraints, and every Proof item.
+2. Run or inspect each check independently; do not rely on the implementation Agent's claims.
+3. Stay read-only. Do not repair failures, edit files, install dependencies, commit, or push.
+4. Mark a check passed only when directly observed evidence matches its expected result.
+5. Return the requested structured verification report with concise commands, exit codes, and evidence.

package/src/skills/codebase-research/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: codebase-research
+description: Investigate a connected repository and answer from directly observed evidence.
+---
+
+# Codebase Research
+
+1. Define the exact question and inspect the smallest relevant surface first.
+2. Trace callers, dependencies, data flow, configuration, and tests when they materially affect the answer.
+3. Separate observed facts from inferences and cite concrete repository paths for important claims.
+4. Stay read-only. Do not install, generate, edit, delete, commit, or start long-running services.
+5. Return the answer first, followed by supporting evidence and unresolved gaps only when they matter.

package/src/skills/goal-execution/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: goal-execution
+description: Implement one bounded EngineerOS Goal and prove the resulting behavior.
+---
+
+# Goal Execution
+
+1. Read the complete Goal packet, repository instructions, current Git state, and relevant implementation paths.
+2. Implement the smallest coherent change that satisfies the included outcome and constraints.
+3. Preserve unrelated user changes and stay inside the stated boundary; stop only for a genuine missing authority or prerequisite.
+4. Run focused checks while working, then the proportionate final tests, lint, type checks, or build required by the Goal.
+5. Do not commit or push. EngineerOS creates the isolated run commit after the implementation completes.