@engineeros/connector 0.13.1 → 0.13.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@engineeros/connector",
-  "version": "0.13.1",
+  "version": "0.13.2",
   "description": "Connect a local coding agent to EngineerOS, using ACP when supported.",
   "private": false,
   "type": "module",

package/src/acp-client.mjs

@@ -5,7 +5,7 @@ import * as acp from "@agentclientprotocol/sdk";
 const RUNTIME_IDLE_MS = 30 * 60 * 1_000;
 const runtimes = new Map();
 
-export function permissionOutcome(options = [], allow = false) {
+export function permissionOutcome(options = [], allow = false) {
   if (!allow) return { outcome: { outcome: "cancelled" } };
   const selected =
     options.find((option) => option.kind === "allow_once") ??
@@ -13,9 +13,9 @@ export function permissionOutcome(options = [], allow = false) {
   return selected
     ? { outcome: { outcome: "selected", optionId: selected.optionId } }
     : { outcome: { outcome: "cancelled" } };
-}
-
-export function launchAcpAgent(
+}
+
+export function launchAcpAgent(
   workspace,
   prompt,
   config,
@@ -39,7 +39,7 @@ export function launchAcpAgent(
     if (runtimeKey) runtimes.set(runtimeKey, runtime);
   }
   const sessionKey = options.sessionKey || `isolated-${crypto.randomUUID()}`;
-  const completed = runtime
+  const completed = runtime
     .prompt({
       sessionKey,
       prompt,
@@ -49,9 +49,10 @@ export function launchAcpAgent(
       callbacks,
     })
     .finally(async () => {
-      if (!persistent) await runtime.dispose();
-    });
-  return {
+      if (!persistent) await runtime.dispose();
+    });
+  runtime.child.engineerOsCancel = () => runtime.dispose();
+  return {
     child: runtime.child,
     completed,
     cancel: () => runtime.cancel(sessionKey),
@@ -117,18 +118,19 @@ class AcpRuntime {
     this.stderr = "";
     this.disposed = false;
     this.idleTimer = null;
-    this.child = spawn(
-      config.agent_command,
-      Array.isArray(config.agent_args) ? config.agent_args : [],
-      {
-        cwd: workspace,
-        env: { ...process.env, ...(config.agent_env || {}) },
-        shell:
-          process.platform === "win32" &&
-          /\.(cmd|bat)$/i.test(config.agent_command),
-        stdio: ["pipe", "pipe", "pipe"],
-      },
-    );
+    this.child = spawn(
+      config.agent_command,
+      Array.isArray(config.agent_args) ? config.agent_args : [],
+      {
+        cwd: workspace,
+        env: { ...process.env, ...(config.agent_env || {}) },
+        windowsHide: true,
+        shell:
+          process.platform === "win32" &&
+          /\.(cmd|bat)$/i.test(config.agent_command),
+        stdio: ["pipe", "pipe", "pipe"],
+      },
+    );
     this.child.stderr.setEncoding("utf8");
     this.child.stderr.on("data", (chunk) => {
       this.stderr = `${this.stderr}${chunk}`.slice(-4_000);

package/src/runner.mjs

@@ -1007,10 +1007,13 @@ export function connectorExecution(assignment, options = {}) {
   };
 }
 
-export async function stopProcess(child) {
-  if (!child || child.exitCode !== null) return;
-  await child.engineerOsCancel?.();
-  if (process.platform === "win32") {
+export async function stopProcess(child) {
+  if (!child || child.exitCode !== null) return;
+  if (typeof child.engineerOsCancel === "function") {
+    await child.engineerOsCancel();
+    return;
+  }
+  if (process.platform === "win32") {
     await run(
       "taskkill",
       ["/pid", String(child.pid), "/t", "/f"],