@energy8platform/shell 0.7.0 → 0.7.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@energy8platform/shell",
-  "version": "0.7.0",
+  "version": "0.7.2",
   "description": "Energy8 branded game shell — one logic core, pluggable html/pixi renderers behind a stable contract.",
   "type": "module",
   "main": "./dist/index.cjs.js",

package/src/core/format.ts

@@ -8,15 +8,19 @@ import type { CurrencyConfig } from './types';
  *  trailing zeros are trimmed down to (but never past) `minDecimals`, so small wins keep their
  *  significant digits. Balance / bet / prices stay fixed at `minDecimals`.
  *
+ *  Separators default to the platform convention — `.` decimal, `,` thousands (`€1,234.50`).
+ *  A comma decimal is NOT safe as a default: players read "2,50" as 250 and believe they were
+ *  paid far more than they were. Games that need another convention pass `currency.separator`.
+ *
  *  Example with `maxDecimals: 4, minDecimals: 2`:
- *    fixed    → 0.0673 → 0,07     0.3 → 0,30
- *    variable → 0.0673 → 0,0673   0.067 → 0,067   0.3 → 0,30   0 → 0,00
+ *    fixed    → 0.0673 → 0.07     0.3 → 0.30
+ *    variable → 0.0673 → 0.0673   0.067 → 0.067   0.3 → 0.30   0 → 0.00
  */
 export function formatCurrency(value: number, currency: CurrencyConfig, variableDecimals = false): string {
   const maxDecimals = currency.maxDecimals ?? 2;
   const minDecimals = Math.max(0, Math.min(maxDecimals, currency.minDecimals ?? maxDecimals));
-  const thousands = currency.separator?.thousands ?? '.';
-  const decimal = currency.separator?.decimal ?? ',';
+  const thousands = currency.separator?.thousands ?? ',';
+  const decimal = currency.separator?.decimal ?? '.';
   const safe = Number.isFinite(value) ? value : 0;
 
   // fixed callers round at minDecimals; variable callers round at maxDecimals then trim back down.

package/src/core/types.ts

@@ -20,6 +20,9 @@ export interface CurrencyConfig {
    *  trimmed down to this many places so small wins keep their significant digits (e.g. 0.0673)
    *  while round amounts stay compact (e.g. 0.30). Everything else is shown at exactly this many. */
   minDecimals?: number;
+  /** Defaults to the platform convention: `{ thousands: ',', decimal: '.' }` → `€1,234.50`.
+   *  Override only for a jurisdiction that requires another convention — a comma decimal reads
+   *  as a thousands group to most players and inflates the perceived payout. */
   separator?: { thousands?: string; decimal?: string };
 }
 

package/src/core/version.ts

@@ -1,3 +1,3 @@
 // AUTO-GENERATED by scripts/gen-version.mjs — do not edit. Mirrors package.json "version".
 /** The @energy8platform/shell package version, stamped into the game-info footer. */
-export const PACKAGE_VERSION = '0.7.0';
+export const PACKAGE_VERSION = '0.7.2';

package/src/ui/pixi/motion-pixi.ts

@@ -9,7 +9,22 @@ export interface TweenOpts {
   onComplete?: () => void;
 }
 
-/** Tween 0→1 on the Pixi ticker. Returns a canceler. Skips to the end when motion is reduced. */
+/**
+ * Tween 0→1 on the Pixi ticker. Returns a canceler. Skips to the end when motion is reduced.
+ *
+ * CONTRACT — when motion is reduced (or `duration <= 0`) this tween does NOT animate: it applies
+ * the final value and calls `onComplete` SYNCHRONOUSLY, before returning. Callers depend on that
+ * (`PixiRenderer.destroy` resolves its teardown promise from `onComplete`, and must not wait on a
+ * ticker that may already be stopped), so it must stay synchronous.
+ *
+ * The consequence for callers: `onComplete` is NOT an async boundary. An `onComplete` that starts
+ * another tween is then direct recursion with no unwind — tween → onComplete → tween → … until
+ * `RangeError: Maximum call stack size exceeded`. That shipped once: the CTA pulse loop
+ * (`widgets.ts` startPulse) restarted itself from `onComplete`, so every player running the OS
+ * "reduce motion" setting crashed the instant the buy-bonus panel painted its hovered CTA. Any
+ * looping animation must therefore check `prefersReducedMotion()` and not loop — which is also
+ * what reduced motion is asking for.
+ */
 export function tween(ticker: Ticker, opts: TweenOpts): () => void {
   const ease = opts.ease ?? easeOutCubic;
   if (prefersReducedMotion() || opts.duration <= 0) {

package/src/ui/pixi/primitives/widgets.ts

@@ -4,6 +4,7 @@ import type { IconName } from '../icons';
 import { makeIcon, IconView } from '../pixi-icon';
 import { makeText, setText, NUM_FONT_FAMILY, NUM_FONT_SCALE } from '../text';
 import { tween, type TweenOpts } from '../motion-pixi';
+import { prefersReducedMotion } from '@/core/motion';
 import { FlexBox, type Sizable } from './flex';
 
 // Shared interactive primitives, ported from the DOM shell's CSS rules. Each widget reproduces
@@ -620,6 +621,14 @@ export class BuyBonusBadge extends Container implements Sizable {
 
   private startPulse(): void {
     if (this.pulseCancel) return;
+    // A pulse is exactly the kind of looping decoration "reduce motion" asks us to drop — and
+    // under it `tween` has nothing to animate anyway: it snaps to the end and calls `onComplete`
+    // SYNCHRONOUSLY (see its contract), which this loop would answer by starting another one, and
+    // another, with no unwind — `RangeError: Maximum call stack size exceeded`. That was a live
+    // Stake crash: with the OS "reduce motion" setting on, opening the buy-bonus panel painted its
+    // hovered CTA and killed the game, so the player could never buy. Now the button simply sits
+    // still at scale 1.
+    if (prefersReducedMotion()) return;
     // both the label (anchor 0.5) and the icon (pivot centred) scale around their centre
     const loop = (): void => {
       this.pulseCancel = tween(this.ticker, {