@enbox/dwn-sdk-js 0.3.6 → 0.3.7

package/dist/types/src/handlers/records-write.d.ts

@@ -15,6 +15,7 @@ export declare class RecordsWriteHandler implements MethodHandler {
      */
     cloneAndAddEncodedData(message: RecordsWriteMessage, dataBytes: Uint8Array): Promise<RecordsQueryReplyEntry>;
     private processMessageWithDataStream;
+    private existingInitialWriteLacksData;
     private processMessageWithoutDataStream;
     /**
      * Validates the expected `dataCid` and `dataSize` in the descriptor vs the received data.

package/dist/types/src/handlers/records-write.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"records-write.d.ts","sourceRoot":"","sources":["../../../../src/handlers/records-write.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,2BAA2B,CAAC;AAErE,OAAO,KAAK,EAAE,mBAAmB,EAAE,aAAa,EAAE,MAAM,4BAA4B,CAAC;AACrF,OAAO,KAAK,EAAE,sBAAsB,EAAE,mBAAmB,EAAE,MAAM,2BAA2B,CAAC;AAqB7F,KAAK,WAAW,GAAG;IAAE,MAAM,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,mBAAmB,CAAC;IAAC,UAAU,CAAC,EAAE,cAAc,CAAC,UAAU,CAAC,CAAA;CAAC,CAAC;AAE5G,qBAAa,mBAAoB,YAAW,aAAa;IAE3C,OAAO,CAAC,QAAQ,CAAC,IAAI;gBAAJ,IAAI,EAAE,mBAAmB;IAEzC,MAAM,CAAC,EAClB,MAAM,EACN,OAAO,EACP,UAAU,EACX,EAAE,WAAW,GAAG,OAAO,CAAC,mBAAmB,CAAC;IAwM7C;;OAEG;IACU,sBAAsB,CAAC,OAAO,EAAE,mBAAmB,EAAE,SAAS,EAAE,UAAU,GAAE,OAAO,CAAC,sBAAsB,CAAC;YAM1G,4BAA4B;YA8C5B,+BAA+B;IAyC7C;;;;;;;OAOG;IACH,OAAO,CAAC,MAAM,CAAC,qBAAqB;IAqBpC;;;;;;OAMG;YACW,qBAAqB;YA4ErB,qBAAqB;CAqCpC"}
+{"version":3,"file":"records-write.d.ts","sourceRoot":"","sources":["../../../../src/handlers/records-write.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,2BAA2B,CAAC;AAErE,OAAO,KAAK,EAAE,mBAAmB,EAAE,aAAa,EAAE,MAAM,4BAA4B,CAAC;AACrF,OAAO,KAAK,EAAE,sBAAsB,EAAE,mBAAmB,EAAE,MAAM,2BAA2B,CAAC;AAqB7F,KAAK,WAAW,GAAG;IAAE,MAAM,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,mBAAmB,CAAC;IAAC,UAAU,CAAC,EAAE,cAAc,CAAC,UAAU,CAAC,CAAA;CAAC,CAAC;AAE5G,qBAAa,mBAAoB,YAAW,aAAa;IAE3C,OAAO,CAAC,QAAQ,CAAC,IAAI;gBAAJ,IAAI,EAAE,mBAAmB;IAEzC,MAAM,CAAC,EAClB,MAAM,EACN,OAAO,EACP,UAAU,EACX,EAAE,WAAW,GAAG,OAAO,CAAC,mBAAmB,CAAC;IA+N7C;;OAEG;IACU,sBAAsB,CAAC,OAAO,EAAE,mBAAmB,EAAE,SAAS,EAAE,UAAU,GAAE,OAAO,CAAC,sBAAsB,CAAC;YAM1G,4BAA4B;YA8C5B,6BAA6B;YA2B7B,+BAA+B;IAyC7C;;;;;;;OAOG;IACH,OAAO,CAAC,MAAM,CAAC,qBAAqB;IAqBpC;;;;;;OAMG;YACW,qBAAqB;YA4ErB,qBAAqB;CAqCpC"}

package/dist/types/tests/handlers/records-write.spec.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"records-write.spec.d.ts","sourceRoot":"","sources":["../../../../tests/handlers/records-write.spec.ts"],"names":[],"mappings":"AAmDA,wBAAgB,uBAAuB,IAAI,IAAI,CA2/I9C"}
+{"version":3,"file":"records-write.spec.d.ts","sourceRoot":"","sources":["../../../../tests/handlers/records-write.spec.ts"],"names":[],"mappings":"AAmDA,wBAAgB,uBAAuB,IAAI,IAAI,CA6gJ9C"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@enbox/dwn-sdk-js",
-  "version": "0.3.6",
+  "version": "0.3.7",
   "description": "A reference implementation of https://identity.foundation/decentralized-web-node/spec/",
   "repository": {
     "type": "git",

package/src/handlers/records-write.ts

@@ -58,6 +58,31 @@ export class RecordsWriteHandler implements MethodHandler {
     };
     const { messages: existingMessages } = await this.deps.messageStore.query(tenant, [ query ]);
 
+    // If the exact same message already exists, return 409 immediately.
+    // This prevents duplicate delivery races from re-processing large data
+    // streams and hitting unique constraints in SQL-backed data stores.
+    //
+    // Exception: an initial write may have been stored earlier without data
+    // (204). A later delivery of the same message with data must be allowed
+    // to complete the record.
+    const incomingCid = await Message.getCid(message);
+    for (const existingMessage of existingMessages) {
+      if (await Message.getCid(existingMessage) !== incomingCid) {
+        continue;
+      }
+
+      const canCompleteMissingData = await this.existingInitialWriteLacksData(
+        tenant,
+        existingMessage as RecordsWriteMessage,
+        message,
+        dataStream !== undefined,
+      );
+
+      if (!canCompleteMissingData) {
+        return { status: { code: 409, detail: 'Conflict' } };
+      }
+    }
+
     // if the incoming write is not the initial write, then it must not modify any immutable properties defined by the initial write
     const newMessageIsInitialWrite = await recordsWrite.isInitialWrite();
     let initialWrite: RecordsWriteMessage | undefined;
@@ -101,15 +126,13 @@ export class RecordsWriteHandler implements MethodHandler {
       // message is an initial write that lacks both inline encodedData and
       // DataStore data — indicating it was stored without data.
       let existingLacksData = false;
-      if (newestExistingMessage !== undefined && dataStream !== undefined) {
-        const isInitial = await RecordsWrite.isInitialWrite(newestExistingMessage);
-        if (isInitial) {
-          const hasInlineData = !!(newestExistingMessage as any).encodedData;
-          const hasStoredData = this.deps.dataStore
-            ? !!(await this.deps.dataStore.get(tenant, recordsWrite.message.recordId, message.descriptor.dataCid))
-            : false;
-          existingLacksData = !hasInlineData && !hasStoredData;
-        }
+      if (newestExistingMessage) {
+        existingLacksData = await this.existingInitialWriteLacksData(
+          tenant,
+          newestExistingMessage as RecordsWriteMessage,
+          message,
+          dataStream !== undefined,
+        );
       }
 
       if (!existingLacksData) {
@@ -288,6 +311,33 @@ export class RecordsWriteHandler implements MethodHandler {
     return messageWithOptionalEncodedData;
   }
 
+  private async existingInitialWriteLacksData(
+    tenant: string,
+    existingMessage: RecordsWriteMessage,
+    incomingMessage: RecordsWriteMessage,
+    incomingHasData: boolean,
+  ): Promise<boolean> {
+    if (!incomingHasData) {
+      return false;
+    }
+
+    const isInitial = await RecordsWrite.isInitialWrite(existingMessage);
+    if (!isInitial) {
+      return false;
+    }
+
+    const hasInlineData = !!(existingMessage as RecordsQueryReplyEntry).encodedData;
+    const hasStoredData = this.deps.dataStore
+      ? !!(await this.deps.dataStore.get(
+        tenant,
+        existingMessage.recordId,
+        incomingMessage.descriptor.dataCid,
+      ))
+      : false;
+
+    return !hasInlineData && !hasStoredData;
+  }
+
   private async processMessageWithoutDataStream(
     tenant: string,
     message: RecordsWriteMessage,