@enact/cli 5.0.0-alpha.1 → 5.0.0-alpha.4

package/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,28 @@
+### Checklist
+
+* [ ] I have read and understand the [contribution guide](http://enactjs.com/docs/developer-guide/contributing/)
+* [ ] A [CHANGELOG entry](http://enactjs.com/docs/developer-guide/contributing/changelogs/) is included
+* [ ] At least one test case is included for this feature or bug fix
+* [ ] Documentation was added or is not needed
+* [ ] This is an API breaking change
+
+### Issue Resolved / Feature Added
+[//]: # (Describe the issue resolved or feature added by this pull request)
+
+
+### Resolution
+[//]: # (Does the code work as intended?)
+[//]: # (What is the impact of this change and *why* was it made?)
+
+
+### Additional Considerations
+[//]: # (How should the change be tested?)
+[//]: # (Are there any outstanding questions?)
+[//]: # (Were any side-effects caused by the change?)
+
+
+### Links
+[//]: # (Related issues, references)
+
+
+### Comments

package/CHANGELOG.md

@@ -1,3 +1,30 @@
+## 5.0.0-alpha.3 (April 28, 2022)
+
+### pack
+
+* Fixed `enact pack` fails on windows by excluding unnecessary file emitting from `html-webpack-plugin`.
+
+### test
+
+* Fixed `enact test` fails on windows by modifying glob patterns.
+* Removed `enzyme` and related modules.
+
+## 5.0.0-alpha.3 (April 22, 2022)
+
+### lint
+
+* Fixed `enact lint` is not working on node 16 by moving ESLint plugins to dependencies.
+
+### test
+
+* Fixed `--watch` option is not working by fixing the version of `jest-watch-typeahead` to `0.6.5`.
+
+## 5.0.0-alpha.2 (April 15, 2022)
+
+### create, template
+
+* Updated `@enact/template-sandstone` dependency.
+
 ## 5.0.0-alpha.1 (April 11, 2022)
 
 ### pack

package/commands/test.js

@@ -151,11 +151,6 @@ function assignOverrides(config) {
 function api(args = []) {
 	const config = require('../config/jest/jest.config');
 
-	// Notify users that Enzyme is deprecated and will be removed in Enact CLI 5.0.0.
-	console.warn(
-		"\nWarning: 'enzyme' support is deprecated and will be removed in Enact CLI 5.0.0. Consider using '@testing-library/react' instead."
-	);
-
 	// @TODO: readd dotenv parse support
 
 	// Watch unless on CI, in coverage mode, or explicitly running all tests

package/config/jest/jest.config.js

@@ -67,7 +67,7 @@ module.exports = {
 	setupFilesAfterEnv: [require.resolve('./setupTests'), userSetupFile].filter(Boolean),
 	testMatch: [
 		'<rootDir>/**/__tests__/**/*.{js,jsx,ts,tsx}',
-		'<rootDir>/**/?(*.)+(spec|test).[jt]s?(x)',
+		'<rootDir>/**/*.+(spec|test).{js,jsx,ts,tsx}',
 		'<rootDir>/**/*-specs.{js,jsx,ts,tsx}'
 	],
 	testPathIgnorePatterns: ignorePatterns,
@@ -85,7 +85,6 @@ module.exports = {
 	],
 	moduleNameMapper: {
 		'^.+\\.module\\.(css|less)$': require.resolve('identity-obj-proxy'),
-		'^enzyme$': require.resolve('enzyme'),
 		'^@testing-library/jest-dom$': require.resolve('@testing-library/jest-dom'),
 		'^@testing-library/react$': require.resolve('@testing-library/react'),
 		'^@testing-library/react-hooks$': require.resolve('@testing-library/react-hooks'),

package/config/jest/setupTests.js

@@ -1,8 +1,6 @@
 /* eslint-env jest */
 const fs = require('fs');
 const path = require('path');
-const enzyme = require('enzyme');
-const Adapter = require('@wojtekmaj/enzyme-adapter-react-17');
 const {packageRoot} = require('@enact/dev-utils');
 
 const filters = [
@@ -46,10 +44,6 @@ afterEach(() => {
 	expect(actual).toHaveLength(expected);
 });
 
-// Configure Enzyme to use React16 adapter.
-
-enzyme.configure({adapter: new Adapter()});
-
 // Set initial resolution to VGA, similar to PhantomJS.
 // Will ideally want to use a more modern resolution later.
 

package/config/webpack.config.js

@@ -354,7 +354,7 @@ module.exports = function (env, ilibAdditionalResourcesPath) {
 							// by webpacks internal loaders.
 							// Exclude `ejs` HTML templating language as that's handled by
 							// the HtmlWebpackPlugin.
-							exclude: [/\.(js|mjs|jsx|ts|tsx)$/, /\.html$/, /\.ejs$/, /\.json$/],
+							exclude: [/^$/, /\.(js|mjs|jsx|ts|tsx)$/, /\.html$/, /\.ejs$/, /\.json$/],
 							type: 'asset/resource'
 						}
 						// ** STOP ** Are you adding a new loader?

package/docs/building-apps.md

@@ -33,7 +33,7 @@ By default, projects will build in development mode. When you're code is ready f
 ## Browser Support & Polyfills
 The Enact CLI is designed to be compatible with a wide array of browsers and devices. [Browserslist standard](https://github.com/browserslist/browserslist) is used to handle targeting, with Enact's defaults being:
 
-* >1%
+* \>1%
 * last 2 versions
 * last 5 Chrome versions
 * last 5 Firefox versions
@@ -105,7 +105,7 @@ npm install --save typescript @types/react @types/react-dom @types/jest
 Optionally, [ESLint](https://eslint.org) can be installed globally or locally and configured within a project to enable linting support within the `enact lint` command.
 
 ## Isomorphic Support & Prerendering
-By using the isomorphic code layout option, your project bundle will be outputted in a versatile universal code format allowing potential usage outside the browser. The Enact CLI takes advantage of this mode by additionally generating an HTML output of your project and embedding it directly with the resulting **index.html**. By default, isomorphic mode will attempt to prerender only `en-US`, however with the `--locales` option, a wade variety of locales can be specified and prerendered. More details on isomorphic support and its limitations can be found [here](./isomorphic-support.md).
+By using the isomorphic code layout option, your project bundle will be outputted in a versatile universal code format allowing potential usage outside the browser. The Enact CLI takes advantage of this mode by additionally generating an HTML output of your project and embedding it directly with the resulting **index.html**. By default, isomorphic mode will attempt to prerender only `en-US`, however with the `--locales` option, a wide variety of locales can be specified and prerendered. More details on isomorphic support and its limitations can be found [here](./isomorphic-support.md).
 
 ## V8 Snapshot Generation
 The v8 snapshot blob creation feature is highly experimental and temperamental depending on your code. It is considered an extension of the isomorphic code layout, bringing along all the same requirements. Given the highly-specific nature of a v8 snapshot blob being tied to particular versions of Chrome/Chromium/Electron/etc., developers must provide their own copy of the `mksnapshot` binary and have its filepath set to the `V8_MKSNAPSHOT` environment variable.

package/docs/installation.md

@@ -18,9 +18,3 @@ All releases are published, with the default (and `latest` tag) being the curren
 ### Linux Notes
 
 When installing under Linux, it may be necessary to prefix the install command with `sudo`.
-Additionally, if you receive an error when the install process attempts to install PhantomJS, try
-the following:
-
-```bash
-sudo npm install -g --unsafe-perm @enact/cli
-```

package/docs/testing-apps.md

@@ -15,7 +15,6 @@ order: 7
 The `enact test` command (aliased as `npm run test`) will activate a [Jest](https://jestjs.io/) test runner on all discovered *-specs.js files. All the complicated configuration is hidden away within Enact CLI to avoid any confusion or additional difficulty in testing source code.
 
 Internally Enact CLI supports [React Testing Library](https://testing-library.com/docs/react-testing-library/intro) out of the box, so there's no need to install them locally on your project. Simply import/require it within specs files and it'll be there. You will want to familiarize yourself with React Testing Library's utilities in order to write more complex tests.
-Enzyme support is deprecated and will be removed in a future major release.
 
 To create a test please create a ***-specs.js** file in the folder of the component you wish to test.