@empyria/restate 0.4.6 → 0.4.8

package/lib/Admin.js

@@ -157,7 +157,8 @@ export async function queryRestate({ restateAdminURL, sql }) {
 }
 
 /**
- * Force-deletes a deployment from Restate, draining any in-flight invocations.
+ * Force-deletes a deployment from Restate, draining any in-flight invocations. A deployment Restate no
+ * longer knows (404) counts as deleted: the goal is that it is gone, so the call is safe to repeat.
  * @param {string} restateAdminURL
  * @param {string} deploymentId
  * @returns {Promise<void>}
@@ -166,7 +167,7 @@ export async function deleteDeployment(restateAdminURL, deploymentId) {
 	const response = await fetch(`${restateAdminURL}/deployments/${deploymentId}?force=true`, {
 		method: 'DELETE',
 	})
-	if (!response.ok) {
+	if (!response.ok && response.status !== 404) {
 		throw new restate.TerminalError(
 			`Failed to delete deployment: ${response.status} ${response.statusText}`,
 			{ errorCode: ERROR_INFRASTRUCTURE },
@@ -408,6 +409,44 @@ export async function pollInvocation({ restateURL, invocationId, intervalMs = 25
 	}
 }
 
+/**
+ * Looks once, without waiting, at the result of an invocation (the `/output` endpoint).
+ *
+ * - `running`: no result yet
+ * - `done`: it finished; `output` is its result
+ * - `failed`: it ended in an error; `code` and `message` come from Restate
+ * - `unknown`: Restate has no such invocation (never existed, or its result was kept long enough and is gone)
+ * @param {{restateURL: string, invocationId: string}} params
+ * @returns {Promise<{state: 'running'}|{state: 'done', output: unknown}|{state: 'failed', code: number, message: string}|{state: 'unknown'}>}
+ */
+export async function getInvocationOutput({ restateURL, invocationId }) {
+	const response = await fetch(`${restateURL}/restate/invocation/${invocationId}/output`)
+	if (response.status === 470) return { state: 'running' }
+
+	const text = await response.text()
+	let body
+	try {
+		body = text ? JSON.parse(text) : undefined
+	} catch {
+		body = undefined
+	}
+
+	if (response.ok) return { state: 'done', output: body }
+	// An error of the invocation itself carries `source: 'invocation'`; anything else is the ingress saying it
+	// does not know the invocation, or could not look.
+	if (body?.source === 'invocation') {
+		return {
+			state: 'failed',
+			code: Number(body.code ?? response.status),
+			message: String(body.message ?? response.statusText),
+		}
+	}
+	if (response.status === 400 || response.status === 404) return { state: 'unknown' }
+	throw new Error(
+		`Unexpected status ${response.status} reading invocation '${invocationId}': ${response.statusText}`,
+	)
+}
+
 /**
  * Request headers for an ingress call, adding Restate's `idempotency-key` when given.
  * @param {string} [idempotencyKey]
@@ -790,6 +829,7 @@ export const sendMessageAsynSafe = async ({ restateURL, callerParams, timeout })
  * @property {() => (message: WorkflowMessage) => Promise<InvocationSubmission>} submitWorkflowDiscovery
  * @property {(params: {invocationId: string}) => Promise<*>} waitForInvocation
  * @property {(params: {invocationId: string, intervalMs?: number}) => Promise<*>} pollInvocation
+ * @property {(params: {invocationId: string}) => Promise<Awaited<ReturnType<typeof getInvocationOutput>>>} getInvocationOutput
  * @property {(params: Omit<ServiceMessage, 'restateURL'>) => Promise<*>} sendMessage
  * @property {(params: Omit<ServiceMessage, 'restateURL'>) => Promise<InvocationSubmission>} sendMessageAsync
  * @property {() => (message: ServiceMessage) => Promise<*>} sendMessageWithDiscovery
@@ -832,6 +872,8 @@ export function createRestateAdmin({ restateAdminURL, restateURL }) {
 		pollInvocation: ({ invocationId, intervalMs }) =>
 			pollInvocation({ restateURL, invocationId, intervalMs }),
 
+		getInvocationOutput: ({ invocationId }) => getInvocationOutput({ restateURL, invocationId }),
+
 		sendMessage: ({ name, message, key, payload, idempotencyKey }) =>
 			sendMessage({ restateURL, name, message, key, payload, idempotencyKey }),
 		sendMessageAsync: ({ name, message, key, payload, idempotencyKey }) =>

package/lib/Cron.js

@@ -10,6 +10,18 @@ export const setJobStateName = (jobStateName) => {
 	return JOB_STATE_NAME
 }
 
+/**
+ * A retry policy that never gives up: it backs off to one attempt a minute and keeps trying. Restate's default
+ * stops after a few attempts and *pauses* the invocation, and a paused invocation of a virtual object holds the
+ * object's lock, so every later call queues behind it for ever. A schedule that was due while the services were
+ * down (a restart, a crash, a night off) must simply run when they are back, so jobs use this.
+ */
+export const RETRY_FOREVER = {
+	initialInterval: { seconds: 1 },
+	maxInterval: { minutes: 1 },
+	exponentiationFactor: 2,
+}
+
 export const cronJobInitiator = restate.service({
 	name: 'CronJobInitiator',
 	handlers: {
@@ -25,6 +37,7 @@ export const cronJobInitiator = restate.service({
 
 export const cronJob = restate.object({
 	name: 'CronJob',
+	options: { retryPolicy: RETRY_FOREVER },
 	handlers: {
 		initiate: async (ctx, request) => {
 			if (await ctx.get(JOB_STATE_NAME)) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@empyria/restate",
-	"version": "0.4.6",
+	"version": "0.4.8",
 	"description": "Restate.dev helpers for the Empyria nanoservice framework",
 	"license": "MIT",
 	"author": "Imre Fazekas <imre.fazekas@icloud.com>",

package/test/Admin.test.js

@@ -14,6 +14,7 @@ import {
 	submitWorkflowDiscovery,
 	waitForInvocation,
 	pollInvocation,
+	getInvocationOutput,
 	sendMessage,
 	sendMessageAsync,
 	sendMessageWithDiscovery,
@@ -229,6 +230,11 @@ describe('deleteDeployment', () => {
 		await expect(deleteDeployment('http://admin', 'dep-1')).resolves.toBeUndefined()
 	})
 
+	test('treats an unknown deployment (404) as already deleted', async () => {
+		globalThis.fetch = mock(async () => jsonResponse(null, false, 404))
+		await expect(deleteDeployment('http://admin', 'dep-1')).resolves.toBeUndefined()
+	})
+
 	test('throws on failure', async () => {
 		globalThis.fetch = mock(async () => jsonResponse(null, false))
 		await expect(deleteDeployment('http://admin', 'dep-1')).rejects.toThrow(
@@ -309,6 +315,40 @@ describe('submitWorkflowDiscovery', () => {
 	})
 })
 
+describe('getInvocationOutput', () => {
+	const look = (response) => {
+		globalThis.fetch = mock(async () => response)
+		return getInvocationOutput({ restateURL: 'http://ingress', invocationId: 'inv-1' })
+	}
+
+	test('done: returns the output', async () => {
+		expect(await look(jsonResponse({ a: 1 }))).toEqual({ state: 'done', output: { a: 1 } })
+	})
+
+	test('running: 470 means no result yet', async () => {
+		expect(await look(jsonResponse(null, false, 470))).toEqual({ state: 'running' })
+	})
+
+	test('failed: an error of the invocation itself', async () => {
+		const body = { code: 404, message: 'no such skill', source: 'invocation' }
+		expect(await look(jsonResponse(body, false, 404))).toEqual({
+			state: 'failed',
+			code: 404,
+			message: 'no such skill',
+		})
+	})
+
+	test('unknown: the ingress does not know the invocation', async () => {
+		expect(await look(jsonResponse({ message: 'x', source: 'ingress' }, false, 400))).toEqual({
+			state: 'unknown',
+		})
+	})
+
+	test('anything else is an error', async () => {
+		await expect(look(jsonResponse(null, false, 503))).rejects.toThrow('503')
+	})
+})
+
 describe('waitForInvocation / pollInvocation', () => {
 	test('waitForInvocation returns the attach result', async () => {
 		globalThis.fetch = mock(async () => jsonResponse({ done: true }))

package/test/Cron.test.js

@@ -291,3 +291,11 @@ describe('ensureCronJob', () => {
 		).rejects.toThrow('500')
 	})
 })
+
+describe('retry policy', () => {
+	test('a job never gives up: no attempt limit, so it is never paused', async () => {
+		const { RETRY_FOREVER } = await import('../lib/Cron.js')
+		expect(RETRY_FOREVER.maxAttempts).toBeUndefined()
+		expect(cronJob.options?.retryPolicy ?? cronJob.retryPolicy).toBeDefined()
+	})
+})