@empline/preflight 1.1.11 → 1.1.13

package/dist/checks/testing/data-entry-regression-required.js

@@ -0,0 +1,378 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * Data Entry Regression Requirement Preflight
+ *
+ * Goal:
+ * - If a change touches UI code that adds/changes user data entry (forms/inputs),
+ *   require at least one regression test change in the same diff.
+ *
+ * This is a pragmatic guardrail (not perfect coverage):
+ * - Works best for PRs / local diffs.
+ * - Uses git diff to detect changed files and heuristics to detect data-entry.
+ *
+ * Usage:
+ *   pnpm -s tsx scripts/active/preflights/testing/data-entry-regression-required.ts
+ *   pnpm -s tsx scripts/active/preflights/testing/data-entry-regression-required.ts --staged
+ *   pnpm -s tsx scripts/active/preflights/testing/data-entry-regression-required.ts --base origin/main
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.tags = exports.description = exports.blocking = exports.category = exports.name = exports.id = void 0;
+const child_process_1 = require("child_process");
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const console_chars_1 = require("../../utils/console-chars");
+const universal_progress_reporter_1 = require("../system/universal-progress-reporter");
+const git_diff_integration_ts_1 = require("../../utils/git-diff-integration.ts");
+// Check metadata
+exports.id = "testing/data-entry-regression-required";
+exports.name = "Data Entry Regression Required";
+exports.category = "testing";
+exports.blocking = false;
+exports.description = "Data Entry Regression Requirement Preflight";
+exports.tags = ["testing"];
+function hasArg(argv, flag) {
+    return argv.includes(flag);
+}
+function getArgValue(argv, flag) {
+    const idx = argv.indexOf(flag);
+    if (idx === -1)
+        return undefined;
+    const value = argv[idx + 1];
+    if (!value || value.startsWith("--"))
+        return undefined;
+    return value;
+}
+function inferBaseRefFromEnv() {
+    // GitHub Actions pull_request sets GITHUB_BASE_REF to the target branch name (e.g. "main")
+    const ghBase = process.env.GITHUB_BASE_REF;
+    if (ghBase)
+        return `origin/${ghBase}`;
+    // Generic CI fallbacks (best-effort)
+    const ciBase = process.env.CI_BASE_REF || process.env.BASE_REF || process.env.CHANGE_TARGET;
+    if (ciBase)
+        return ciBase.startsWith("origin/") ? ciBase : `origin/${ciBase}`;
+    return undefined;
+}
+function isCodeCandidate(filePath) {
+    return filePath.endsWith(".ts") || filePath.endsWith(".tsx");
+}
+function isTestFile(filePath) {
+    if (!filePath.startsWith("tests/"))
+        return false;
+    return /\.(spec|test)\.(ts|tsx)$/.test(filePath);
+}
+function isRegressionTestFile(filePath) {
+    if (!isTestFile(filePath))
+        return false;
+    return filePath.startsWith("tests/e2e/") || filePath.startsWith("tests/regression/");
+}
+function shouldIgnoreEnforcementForTestContent(testContent) {
+    // Escape hatch for rare cases where data-entry changes are verified indirectly
+    // (e.g., API-only flows, snapshot DB-required tests, etc.).
+    // This must be explicitly opted into in the modified regression test.
+    return /REGRESSION_OK:DATA_ENTRY_TOKEN_CHECK/.test(testContent);
+}
+function isUIFile(filePath) {
+    if (!isCodeCandidate(filePath))
+        return false;
+    if (filePath.startsWith("tests/"))
+        return false;
+    // Keep scope narrow: we care about user-facing UI entry points.
+    return filePath.startsWith("app/") || filePath.startsWith("components/");
+}
+const DIFF_DATA_ENTRY_HINTS = [
+    // Raw HTML
+    /\+.*<input\b/i,
+    /\+.*<textarea\b/i,
+    /\+.*<select\b/i,
+    // React form conventions
+    /\+.*\b(onSubmit|handleSubmit)\b/,
+    /\+.*\b(register\(|Controller\b|useForm\(|useFormContext\()/,
+    /\+.*\b(FormField|TextField|Textarea|Select|Autocomplete)\b/,
+    /\+.*\b(PriceInput|QuantityInput|SearchInput)\b/,
+    /\+.*\b(CategorySelector|ConditionSelector|GradingSelector)\b/,
+    /\+.*\b(ImageUploadZone)\b/,
+    // Server actions defined outside app/actions (Next.js "use server")
+    /\+\s*['"]use server['"];?\s*$/,
+];
+const TOKEN_EXTRACTORS = [
+    { name: "label", re: /\b(label|aria-label)\s*=\s*\"([^\"]+)\"/g },
+    { name: "placeholder", re: /\bplaceholder\s*=\s*\"([^\"]+)\"/g },
+    { name: "data-testid", re: /\bdata-testid\s*=\s*\"([^\"]+)\"/g },
+    { name: "name", re: /\bname\s*=\s*\"([^\"]+)\"/g },
+];
+function normalizePath(p) {
+    return p.replace(/\\/g, "/");
+}
+function safeExecGitDiff(args) {
+    try {
+        // Suppress noisy safecrlf warnings ("LF will be replaced by CRLF...") which are
+        // non-actionable for preflight logic and can drown out real failures.
+        return (0, child_process_1.execSync)("git -c core.safecrlf=false " + args.join(" "), {
+            encoding: "utf8",
+            stdio: ["ignore", "pipe", "ignore"],
+        });
+    }
+    catch (err) {
+        // git diff returns exit code 1 sometimes in edge cases; treat as empty.
+        return String(err?.stdout || "");
+    }
+}
+function getAddedAndRemovedLines(diff) {
+    const added = diff
+        .split("\n")
+        .filter((l) => l.startsWith("+") && !l.startsWith("+++"))
+        .join("\n");
+    const removed = diff
+        .split("\n")
+        .filter((l) => l.startsWith("-") && !l.startsWith("---"))
+        .join("\n");
+    return { added, removed };
+}
+function getFileDiff(baseRef, filePath) {
+    // Use -U0 to keep diff small and focused on changed lines.
+    // Quote file path for Windows; git still accepts forward slashes.
+    const fp = normalizePath(filePath);
+    const quoted = `\"${fp.replace(/\"/g, '\\"')}\"`;
+    // Ignore CR-at-EOL to avoid false positives from line-ending-only diffs on Windows.
+    return safeExecGitDiff(["diff", "-U0", "--ignore-cr-at-eol", baseRef, "--", quoted]);
+}
+function countRegexMatches(text, re) {
+    const m = text.match(re);
+    return m ? m.length : 0;
+}
+function diffHasDataEntrySignals(diff) {
+    // The previous broad heuristic treated *any* changed line containing form primitives
+    // as a data-entry change. That created false positives for mechanical refactors
+    // (e.g., constant inlining) and for CRLF-only diffs.
+    //
+    // New heuristic:
+    // 1) If new field tokens are introduced (label/testid/placeholder/name), enforce.
+    // 2) If data-entry primitives are added/removed (net count differs), enforce.
+    // 3) If form wiring is added (useForm/register/onSubmit/etc.), enforce.
+    const { added, removed } = getAddedAndRemovedLines(diff);
+    const addedTokens = extractAddedTokensFromDiff(diff);
+    if (addedTokens.length > 0)
+        return true;
+    const netSensitiveFieldTags = [
+        /<input\b/gi,
+        /<textarea\b/gi,
+        /<select\b/gi,
+        /<FormField\b/gi,
+        /<PriceInput\b/gi,
+        /<QuantityInput\b/gi,
+        /<SearchInput\b/gi,
+        /<CategorySelector\b/gi,
+        /<ConditionSelector\b/gi,
+        /<GradingSelector\b/gi,
+        /<ImageUploadZone\b/gi,
+    ];
+    for (const tagRe of netSensitiveFieldTags) {
+        const adds = countRegexMatches(added, tagRe);
+        const dels = countRegexMatches(removed, tagRe);
+        if (adds !== dels)
+            return true;
+    }
+    const addedWiringHints = [
+        /\b(onSubmit|handleSubmit)\b/i,
+        /\b(register\(|Controller\b|useForm\(|useFormContext\()\b/i,
+        /\+\s*['"]use server['"];?\s*$/m,
+    ];
+    if (addedWiringHints.some((re) => re.test(added)))
+        return true;
+    return false;
+}
+function extractAddedTokensFromDiff(diff) {
+    // Only look at added lines to reduce noise.
+    const addedLines = diff
+        .split("\n")
+        .filter((l) => l.startsWith("+") && !l.startsWith("+++"))
+        .join("\n");
+    const tokens = [];
+    for (const extractor of TOKEN_EXTRACTORS) {
+        let match;
+        while ((match = extractor.re.exec(addedLines)) !== null) {
+            const value = match[2] ?? match[1];
+            if (!value)
+                continue;
+            const trimmed = String(value).trim();
+            if (trimmed.length < 2)
+                continue;
+            tokens.push(trimmed);
+        }
+    }
+    return Array.from(new Set(tokens));
+}
+async function main() {
+    const reporter = (0, universal_progress_reporter_1.createUniversalProgressReporter)(path.basename(__filename, ".ts"));
+    const argv = process.argv.slice(2);
+    const verbose = hasArg(argv, "--verbose") || hasArg(argv, "-v");
+    const staged = hasArg(argv, "--staged");
+    const baseArg = getArgValue(argv, "--base");
+    const baseRef = baseArg ?? inferBaseRefFromEnv();
+    const gitDiff = new git_diff_integration_ts_1.GitDiffIntegration();
+    if (!gitDiff.isGitRepository()) {
+        console.log(`${console_chars_1.emoji.warning}  Not a git repository; skipping data entry regression enforcement`);
+        process.exit(0);
+    }
+    const branch = staged ? "HEAD" : baseRef ? `${baseRef}...HEAD` : "HEAD";
+    if (verbose) {
+        console.log(`\n${console_chars_1.emoji.testTube} DATA ENTRY REGRESSION REQUIREMENT PREFLIGHT`);
+        console.log((0, console_chars_1.createDivider)(70, "heavy"));
+        console.log(`Mode: ${staged ? "staged" : "diff"}`);
+        if (!staged)
+            console.log(`Compare: ${branch}`);
+    }
+    else {
+        console.log(`\n${console_chars_1.emoji.testTube} DATA ENTRY REGRESSION REQUIREMENT PREFLIGHT`);
+        console.log((0, console_chars_1.createDivider)(70, "heavy"));
+    }
+    const changed = await gitDiff.getChangedFiles({ staged, branch, includeUntracked: !staged });
+    const changedPaths = changed
+        .filter((f) => f.status !== "deleted")
+        .map((f) => normalizePath(f.path));
+    if (changedPaths.length === 0) {
+        console.log(`${console_chars_1.emoji.success} No changed files detected; nothing to enforce`);
+        process.exit(0);
+    }
+    const hasRegressionTestChange = changedPaths.some(isRegressionTestFile);
+    const triggeringFiles = [];
+    const issues = [];
+    for (const filePath of changedPaths) {
+        if (!isUIFile(filePath))
+            continue;
+        // Prefer diff-based detection (ahead-of-curve): trigger only when diff hunks
+        // indicate data entry changes, not just because a file contains a form.
+        const baseForDiff = staged ? "--cached" : branch;
+        const diff = staged
+            ? safeExecGitDiff(["diff", "-U0", "--ignore-cr-at-eol", "--cached", "--", `\"${filePath}\"`])
+            : getFileDiff(baseForDiff, filePath);
+        if (!diff || diff.trim().length === 0) {
+            // For untracked/new files git diff may be empty; fall back to content scan.
+            try {
+                const content = fs.readFileSync(path.resolve(process.cwd(), filePath), "utf8");
+                // Lightweight fallback: if file includes common form primitives.
+                const fallbackHit = /\b(FormField|TextField|PriceInput|QuantityInput|useForm|handleSubmit)\b/.test(content);
+                if (!fallbackHit)
+                    continue;
+                triggeringFiles.push({ file: filePath, tokens: [] });
+            }
+            catch {
+                continue;
+            }
+            continue;
+        }
+        if (diffHasDataEntrySignals(diff)) {
+            const tokens = extractAddedTokensFromDiff(diff);
+            triggeringFiles.push({ file: filePath, tokens });
+        }
+    }
+    if (triggeringFiles.length === 0) {
+        console.log(`${console_chars_1.emoji.success} No data-entry UI changes detected`);
+        process.exit(0);
+    }
+    const allTokens = Array.from(new Set(triggeringFiles.flatMap((t) => t.tokens).filter(Boolean))).filter((t) => t.length >= 2);
+    if (!hasRegressionTestChange) {
+        issues.push({
+            severity: "error",
+            message: "Data-entry UI changes detected but no regression tests changed. Add/adjust a test in tests/e2e/ or tests/regression/.",
+        });
+    }
+    // Advisory only: if we can detect specific field tokens, it is helpful for updated
+    // regression tests to reference at least one of them. This should NOT block preflights
+    // because test updates may be unrelated.
+    if (hasRegressionTestChange && allTokens.length > 0) {
+        const changedRegressionTests = changedPaths.filter(isRegressionTestFile);
+        const hasTokenReference = changedRegressionTests.some((testPath) => {
+            try {
+                const content = fs.readFileSync(path.resolve(process.cwd(), testPath), "utf8");
+                if (shouldIgnoreEnforcementForTestContent(content)) {
+                    return true;
+                }
+                // Simple substring check (fast + robust). Tokens are human strings.
+                return allTokens.some((tok) => content.includes(tok));
+            }
+            catch {
+                return false;
+            }
+        });
+        if (!hasTokenReference && verbose) {
+            console.warn(`${console_chars_1.emoji.warning}  Note: regression tests were updated, but none reference newly-detected field tokens (label/testid/placeholder/name).`);
+        }
+    }
+    if (issues.length === 0) {
+        console.log(`${console_chars_1.emoji.success} Data-entry changes (${triggeringFiles.length}) include regression test updates`);
+        if (verbose) {
+            console.log("\nTriggered by:");
+            triggeringFiles.slice(0, 20).forEach((t) => {
+                const tokenPreview = t.tokens.length > 0
+                    ? ` (tokens: ${t.tokens.slice(0, 4).join(", ")}${t.tokens.length > 4 ? ", ..." : ""})`
+                    : "";
+                console.log(`  - ${t.file}${tokenPreview}`);
+            });
+            if (triggeringFiles.length > 20)
+                console.log(`  - ...and ${triggeringFiles.length - 20} more`);
+        }
+        process.exit(0);
+    }
+    console.log(`${console_chars_1.emoji.error} FAILED (${issues.length} issue)`);
+    for (const i of issues) {
+        console.log(`- ${i.message}`);
+    }
+    console.log("\nTriggered by data-entry changes in:");
+    triggeringFiles.slice(0, 30).forEach((t) => console.log(`  - ${t.file}`));
+    if (triggeringFiles.length > 30)
+        console.log(`  - ...and ${triggeringFiles.length - 30} more`);
+    // Optional guidance: if we detected tokens that should be used in tests, print a short hint.
+    const sampleTokens = triggeringFiles.flatMap((t) => t.tokens).filter(Boolean);
+    const uniqueSampleTokens = Array.from(new Set(sampleTokens)).slice(0, 10);
+    if (uniqueSampleTokens.length > 0) {
+        console.log("\nSuggested test anchors (new labels/testids/placeholders detected):");
+        uniqueSampleTokens.forEach((tok) => console.log(`  - ${tok}`));
+    }
+    console.log("\nEscape hatch (use sparingly):");
+    console.log("  - Add 'REGRESSION_OK:DATA_ENTRY_TOKEN_CHECK' in the updated regression test file");
+    console.log("\nExpected at least one file change in:");
+    console.log("  - tests/e2e/**/*.spec.ts");
+    console.log("  - tests/regression/**/*.(test|spec).ts(x)");
+    process.exit(1);
+}
+main().catch((err) => {
+    console.error("Error:", err);
+    process.exit(1);
+});
+//# sourceMappingURL=data-entry-regression-required.js.map

package/dist/checks/testing/data-entry-regression-required.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"data-entry-regression-required.js","sourceRoot":"","sources":["../../../src/checks/testing/data-entry-regression-required.ts"],"names":[],"mappings":";;AACA;;;;;;;;;;;;;;;GAeG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAEH,iDAAyC;AACzC,uCAAyB;AACzB,2CAA6B;AAC7B,6DAAiE;AACjE,uFAAwF;AACxF,iFAAyE;AAGzE,iBAAiB;AACJ,QAAA,EAAE,GAAG,wCAAwC,CAAC;AAC9C,QAAA,IAAI,GAAG,gCAAgC,CAAC;AACxC,QAAA,QAAQ,GAAG,SAAS,CAAC;AACrB,QAAA,QAAQ,GAAG,KAAK,CAAC;AACjB,QAAA,WAAW,GAAG,6CAA6C,CAAC;AAC5D,QAAA,IAAI,GAAG,CAAC,SAAS,CAAC,CAAC;AAUhC,SAAS,MAAM,CAAC,IAAc,EAAE,IAAY;IAC1C,OAAO,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;AAC7B,CAAC;AAED,SAAS,WAAW,CAAC,IAAc,EAAE,IAAY;IAC/C,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;IAC/B,IAAI,GAAG,KAAK,CAAC,CAAC;QAAE,OAAO,SAAS,CAAC;IACjC,MAAM,KAAK,GAAG,IAAI,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC;IAC5B,IAAI,CAAC,KAAK,IAAI,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC;QAAE,OAAO,SAAS,CAAC;IACvD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,mBAAmB;IAC1B,2FAA2F;IAC3F,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,eAAe,CAAC;IAC3C,IAAI,MAAM;QAAE,OAAO,UAAU,MAAM,EAAE,CAAC;IAEtC,qCAAqC;IACrC,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,WAAW,IAAI,OAAO,CAAC,GAAG,CAAC,QAAQ,IAAI,OAAO,CAAC,GAAG,CAAC,aAAa,CAAC;IAC5F,IAAI,MAAM;QAAE,OAAO,MAAM,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,UAAU,MAAM,EAAE,CAAC;IAE9E,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,eAAe,CAAC,QAAgB;IACvC,OAAO,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;AAC/D,CAAC;AAED,SAAS,UAAU,CAAC,QAAgB;IAClC,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,KAAK,CAAC;IACjD,OAAO,0BAA0B,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;AACnD,CAAC;AAED,SAAS,oBAAoB,CAAC,QAAgB;IAC5C,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,KAAK,CAAC;IACxC,OAAO,QAAQ,CAAC,UAAU,CAAC,YAAY,CAAC,IAAI,QAAQ,CAAC,UAAU,CAAC,mBAAmB,CAAC,CAAC;AACvF,CAAC;AAED,SAAS,qCAAqC,CAAC,WAAmB;IAChE,+EAA+E;IAC/E,4DAA4D;IAC5D,sEAAsE;IACtE,OAAO,sCAAsC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;AAClE,CAAC;AAED,SAAS,QAAQ,CAAC,QAAgB;IAChC,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC;QAAE,OAAO,KAAK,CAAC;IAC7C,IAAI,QAAQ,CAAC,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO,KAAK,CAAC;IAEhD,gEAAgE;IAChE,OAAO,QAAQ,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI,QAAQ,CAAC,UAAU,CAAC,aAAa,CAAC,CAAC;AAC3E,CAAC;AAED,MAAM,qBAAqB,GAAa;IACtC,WAAW;IACX,eAAe;IACf,kBAAkB;IAClB,gBAAgB;IAEhB,yBAAyB;IACzB,iCAAiC;IACjC,4DAA4D;IAC5D,4DAA4D;IAC5D,gDAAgD;IAChD,8DAA8D;IAC9D,2BAA2B;IAE3B,oEAAoE;IACpE,+BAA+B;CAChC,CAAC;AAEF,MAAM,gBAAgB,GAAwC;IAC5D,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,EAAE,0CAA0C,EAAE;IACjE,EAAE,IAAI,EAAE,aAAa,EAAE,EAAE,EAAE,mCAAmC,EAAE;IAChE,EAAE,IAAI,EAAE,aAAa,EAAE,EAAE,EAAE,mCAAmC,EAAE;IAChE,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,4BAA4B,EAAE;CACnD,CAAC;AAEF,SAAS,aAAa,CAAC,CAAS;IAC9B,OAAO,CAAC,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;AAC/B,CAAC;AAED,SAAS,eAAe,CAAC,IAAc;IACrC,IAAI,CAAC;QACH,gFAAgF;QAChF,sEAAsE;QACtE,OAAO,IAAA,wBAAQ,EAAC,6BAA6B,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE;YAC9D,QAAQ,EAAE,MAAM;YAChB,KAAK,EAAE,CAAC,QAAQ,EAAE,MAAM,EAAE,QAAQ,CAAC;SACpC,CAAC,CAAC;IACL,CAAC;IAAC,OAAO,GAAQ,EAAE,CAAC;QAClB,wEAAwE;QACxE,OAAO,MAAM,CAAC,GAAG,EAAE,MAAM,IAAI,EAAE,CAAC,CAAC;IACnC,CAAC;AACH,CAAC;AAED,SAAS,uBAAuB,CAAC,IAAY;IAC3C,MAAM,KAAK,GAAG,IAAI;SACf,KAAK,CAAC,IAAI,CAAC;SACX,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC;SACxD,IAAI,CAAC,IAAI,CAAC,CAAC;IAEd,MAAM,OAAO,GAAG,IAAI;SACjB,KAAK,CAAC,IAAI,CAAC;SACX,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC;SACxD,IAAI,CAAC,IAAI,CAAC,CAAC;IAEd,OAAO,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC;AAC5B,CAAC;AAED,SAAS,WAAW,CAAC,OAAe,EAAE,QAAgB;IACpD,2DAA2D;IAC3D,kEAAkE;IAClE,MAAM,EAAE,GAAG,aAAa,CAAC,QAAQ,CAAC,CAAC;IACnC,MAAM,MAAM,GAAG,KAAK,EAAE,CAAC,OAAO,CAAC,KAAK,EAAE,KAAK,CAAC,IAAI,CAAC;IACjD,oFAAoF;IACpF,OAAO,eAAe,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,oBAAoB,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC;AACvF,CAAC;AAED,SAAS,iBAAiB,CAAC,IAAY,EAAE,EAAU;IACjD,MAAM,CAAC,GAAG,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;IACzB,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC;AAC1B,CAAC;AAED,SAAS,uBAAuB,CAAC,IAAY;IAC3C,qFAAqF;IACrF,gFAAgF;IAChF,qDAAqD;IACrD,EAAE;IACF,iBAAiB;IACjB,kFAAkF;IAClF,8EAA8E;IAC9E,wEAAwE;IAExE,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,GAAG,uBAAuB,CAAC,IAAI,CAAC,CAAC;IAEzD,MAAM,WAAW,GAAG,0BAA0B,CAAC,IAAI,CAAC,CAAC;IACrD,IAAI,WAAW,CAAC,MAAM,GAAG,CAAC;QAAE,OAAO,IAAI,CAAC;IAExC,MAAM,qBAAqB,GAAa;QACtC,YAAY;QACZ,eAAe;QACf,aAAa;QACb,gBAAgB;QAChB,iBAAiB;QACjB,oBAAoB;QACpB,kBAAkB;QAClB,uBAAuB;QACvB,wBAAwB;QACxB,sBAAsB;QACtB,sBAAsB;KACvB,CAAC;IAEF,KAAK,MAAM,KAAK,IAAI,qBAAqB,EAAE,CAAC;QAC1C,MAAM,IAAI,GAAG,iBAAiB,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAC7C,MAAM,IAAI,GAAG,iBAAiB,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;QAC/C,IAAI,IAAI,KAAK,IAAI;YAAE,OAAO,IAAI,CAAC;IACjC,CAAC;IAED,MAAM,gBAAgB,GAAa;QACjC,8BAA8B;QAC9B,2DAA2D;QAC3D,gCAAgC;KACjC,CAAC;IAEF,IAAI,gBAAgB,CAAC,IAAI,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IAE/D,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,0BAA0B,CAAC,IAAY;IAC9C,4CAA4C;IAC5C,MAAM,UAAU,GAAG,IAAI;SACpB,KAAK,CAAC,IAAI,CAAC;SACX,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC;SACxD,IAAI,CAAC,IAAI,CAAC,CAAC;IAEd,MAAM,MAAM,GAAa,EAAE,CAAC;IAC5B,KAAK,MAAM,SAAS,IAAI,gBAAgB,EAAE,CAAC;QACzC,IAAI,KAA6B,CAAC;QAClC,OAAO,CAAC,KAAK,GAAG,SAAS,CAAC,EAAE,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YACxD,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,CAAC,CAAC;YACnC,IAAI,CAAC,KAAK;gBAAE,SAAS;YACrB,MAAM,OAAO,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC;YACrC,IAAI,OAAO,CAAC,MAAM,GAAG,CAAC;gBAAE,SAAS;YACjC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACvB,CAAC;IACH,CAAC;IAED,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC;AACrC,CAAC;AAED,KAAK,UAAU,IAAI;IACjB,MAAM,QAAQ,GAAG,IAAA,6DAA+B,EAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC,CAAC;IACnF,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACnC,MAAM,OAAO,GAAG,MAAM,CAAC,IAAI,EAAE,WAAW,CAAC,IAAI,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IAChE,MAAM,MAAM,GAAG,MAAM,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;IAExC,MAAM,OAAO,GAAG,WAAW,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;IAC5C,MAAM,OAAO,GAAG,OAAO,IAAI,mBAAmB,EAAE,CAAC;IAEjD,MAAM,OAAO,GAAG,IAAI,4CAAkB,EAAE,CAAC;IACzC,IAAI,CAAC,OAAO,CAAC,eAAe,EAAE,EAAE,CAAC;QAC/B,OAAO,CAAC,GAAG,CACT,GAAG,qBAAK,CAAC,OAAO,oEAAoE,CACrF,CAAC;QACF,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,MAAM,MAAM,GAAG,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,GAAG,OAAO,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC;IAExE,IAAI,OAAO,EAAE,CAAC;QACZ,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,QAAQ,8CAA8C,CAAC,CAAC;QAC/E,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;QACxC,OAAO,CAAC,GAAG,CAAC,SAAS,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC;QACnD,IAAI,CAAC,MAAM;YAAE,OAAO,CAAC,GAAG,CAAC,YAAY,MAAM,EAAE,CAAC,CAAC;IACjD,CAAC;SAAM,CAAC;QACN,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,QAAQ,8CAA8C,CAAC,CAAC;QAC/E,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC1C,CAAC;IAED,MAAM,OAAO,GAAG,MAAM,OAAO,CAAC,eAAe,CAAC,EAAE,MAAM,EAAE,MAAM,EAAE,gBAAgB,EAAE,CAAC,MAAM,EAAE,CAAC,CAAC;IAC7F,MAAM,YAAY,GAAG,OAAO;SACzB,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,SAAS,CAAC;SACrC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC;IAErC,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC9B,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,OAAO,gDAAgD,CAAC,CAAC;QAC9E,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,MAAM,uBAAuB,GAAG,YAAY,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAC;IAExE,MAAM,eAAe,GAA8C,EAAE,CAAC;IACtE,MAAM,MAAM,GAAY,EAAE,CAAC;IAE3B,KAAK,MAAM,QAAQ,IAAI,YAAY,EAAE,CAAC;QACpC,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC;YAAE,SAAS;QAElC,6EAA6E;QAC7E,wEAAwE;QACxE,MAAM,WAAW,GAAG,MAAM,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,MAAM,CAAC;QACjD,MAAM,IAAI,GAAG,MAAM;YACjB,CAAC,CAAC,eAAe,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,oBAAoB,EAAE,UAAU,EAAE,IAAI,EAAE,KAAK,QAAQ,IAAI,CAAC,CAAC;YAC7F,CAAC,CAAC,WAAW,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAC;QAEvC,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACtC,4EAA4E;YAC5E,IAAI,CAAC;gBACH,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,QAAQ,CAAC,EAAE,MAAM,CAAC,CAAC;gBAC/E,iEAAiE;gBACjE,MAAM,WAAW,GACf,yEAAyE,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;gBAC1F,IAAI,CAAC,WAAW;oBAAE,SAAS;gBAC3B,eAAe,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,CAAC,CAAC;YACvD,CAAC;YAAC,MAAM,CAAC;gBACP,SAAS;YACX,CAAC;YAED,SAAS;QACX,CAAC;QAED,IAAI,uBAAuB,CAAC,IAAI,CAAC,EAAE,CAAC;YAClC,MAAM,MAAM,GAAG,0BAA0B,CAAC,IAAI,CAAC,CAAC;YAChD,eAAe,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,CAAC,CAAC;QACnD,CAAC;IACH,CAAC;IAED,IAAI,eAAe,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACjC,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,OAAO,oCAAoC,CAAC,CAAC;QAClE,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,MAAM,SAAS,GAAG,KAAK,CAAC,IAAI,CAC1B,IAAI,GAAG,CAAC,eAAe,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,CAClE,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,IAAI,CAAC,CAAC,CAAC;IAE/B,IAAI,CAAC,uBAAuB,EAAE,CAAC;QAC7B,MAAM,CAAC,IAAI,CAAC;YACV,QAAQ,EAAE,OAAO;YACjB,OAAO,EACL,uHAAuH;SAC1H,CAAC,CAAC;IACL,CAAC;IAED,mFAAmF;IACnF,uFAAuF;IACvF,yCAAyC;IACzC,IAAI,uBAAuB,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACpD,MAAM,sBAAsB,GAAG,YAAY,CAAC,MAAM,CAAC,oBAAoB,CAAC,CAAC;QAEzE,MAAM,iBAAiB,GAAG,sBAAsB,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE;YACjE,IAAI,CAAC;gBACH,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,QAAQ,CAAC,EAAE,MAAM,CAAC,CAAC;gBAC/E,IAAI,qCAAqC,CAAC,OAAO,CAAC,EAAE,CAAC;oBACnD,OAAO,IAAI,CAAC;gBACd,CAAC;gBAED,oEAAoE;gBACpE,OAAO,SAAS,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,OAAO,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC;YACxD,CAAC;YAAC,MAAM,CAAC;gBACP,OAAO,KAAK,CAAC;YACf,CAAC;QACH,CAAC,CAAC,CAAC;QAEH,IAAI,CAAC,iBAAiB,IAAI,OAAO,EAAE,CAAC;YAClC,OAAO,CAAC,IAAI,CACV,GAAG,qBAAK,CAAC,OAAO,wHAAwH,CACzI,CAAC;QACJ,CAAC;IACH,CAAC;IAED,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACxB,OAAO,CAAC,GAAG,CACT,GAAG,qBAAK,CAAC,OAAO,wBAAwB,eAAe,CAAC,MAAM,mCAAmC,CAClG,CAAC;QACF,IAAI,OAAO,EAAE,CAAC;YACZ,OAAO,CAAC,GAAG,CAAC,iBAAiB,CAAC,CAAC;YAC/B,eAAe,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE;gBACzC,MAAM,YAAY,GAChB,CAAC,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC;oBACjB,CAAC,CAAC,aAAa,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,GAAG;oBACtF,CAAC,CAAC,EAAE,CAAC;gBACT,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,IAAI,GAAG,YAAY,EAAE,CAAC,CAAC;YAC9C,CAAC,CAAC,CAAC;YACH,IAAI,eAAe,CAAC,MAAM,GAAG,EAAE;gBAC7B,OAAO,CAAC,GAAG,CAAC,cAAc,eAAe,CAAC,MAAM,GAAG,EAAE,OAAO,CAAC,CAAC;QAClE,CAAC;QACD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,KAAK,YAAY,MAAM,CAAC,MAAM,SAAS,CAAC,CAAC;IAC9D,KAAK,MAAM,CAAC,IAAI,MAAM,EAAE,CAAC;QACvB,OAAO,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;IAChC,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,uCAAuC,CAAC,CAAC;IACrD,eAAe,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAC1E,IAAI,eAAe,CAAC,MAAM,GAAG,EAAE;QAAE,OAAO,CAAC,GAAG,CAAC,cAAc,eAAe,CAAC,MAAM,GAAG,EAAE,OAAO,CAAC,CAAC;IAE/F,6FAA6F;IAC7F,MAAM,YAAY,GAAG,eAAe,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;IAC9E,MAAM,kBAAkB,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,GAAG,CAAC,YAAY,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IAC1E,IAAI,kBAAkB,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAClC,OAAO,CAAC,GAAG,CAAC,sEAAsE,CAAC,CAAC;QACpF,kBAAkB,CAAC,OAAO,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,GAAG,EAAE,CAAC,CAAC,CAAC;IACjE,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,iCAAiC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,oFAAoF,CAAC,CAAC;IAElG,OAAO,CAAC,GAAG,CAAC,yCAAyC,CAAC,CAAC;IACvD,OAAO,CAAC,GAAG,CAAC,4BAA4B,CAAC,CAAC;IAC1C,OAAO,CAAC,GAAG,CAAC,6CAA6C,CAAC,CAAC;IAE3D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;AAClB,CAAC;AAED,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,GAAG,EAAE,EAAE;IACnB,OAAO,CAAC,KAAK,CAAC,QAAQ,EAAE,GAAG,CAAC,CAAC;IAC7B,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;AAClB,CAAC,CAAC,CAAC"}

package/dist/checks/testing/e2e-best-practices.d.ts

@@ -0,0 +1,24 @@
+#!/usr/bin/env tsx
+/**
+ * E2E Best Practices Preflight
+ *
+ * Validates Playwright E2E tests follow best practices:
+ * - Proper test organization with test.describe()
+ * - Use of semantic selectors (getByRole, getByLabel, getByText)
+ * - No hardcoded waits (waitForTimeout)
+ * - Proper API stubbing for mutations
+ * - Test isolation (no shared state)
+ * - Accessibility-first selectors
+ * - Proper error handling
+ * - Mobile viewport testing
+ * - Test tagging for selective runs
+ *
+ * @see https://playwright.dev/docs/best-practices
+ */
+export declare const id = "testing/e2e-best-practices";
+export declare const name = "E2e Best Practices";
+export declare const category = "testing";
+export declare const blocking = true;
+export declare const description = "E2E Best Practices Preflight";
+export declare const tags: string[];
+//# sourceMappingURL=e2e-best-practices.d.ts.map

package/dist/checks/testing/e2e-best-practices.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"e2e-best-practices.d.ts","sourceRoot":"","sources":["../../../src/checks/testing/e2e-best-practices.ts"],"names":[],"mappings":";AACA;;;;;;;;;;;;;;;GAeG;AAUH,eAAO,MAAM,EAAE,+BAA+B,CAAC;AAC/C,eAAO,MAAM,IAAI,uBAAuB,CAAC;AACzC,eAAO,MAAM,QAAQ,YAAY,CAAC;AAClC,eAAO,MAAM,QAAQ,OAAO,CAAC;AAC7B,eAAO,MAAM,WAAW,iCAAiC,CAAC;AAC1D,eAAO,MAAM,IAAI,UAAc,CAAC"}