@empline/preflight 1.1.0

package/dist/checks/code-quality/duplicate-logic-detection.js

@@ -0,0 +1,269 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * Duplicate Logic Detection Preflight
+ *
+ * Detects common patterns of duplicated logic that should be extracted:
+ * - Repeated data fetching patterns (e.g., fetching catalog cards for listings)
+ * - Repeated mapping/transformation logic
+ * - Similar async function structures
+ *
+ * Usage:
+ *   pnpm preflight:duplicate-logic
+ *   pnpm tsx scripts/active/preflights/code-quality/duplicate-logic-detection.ts
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.DUPLICATE_PATTERNS = exports.tags = exports.description = exports.blocking = exports.category = exports.name = exports.id = void 0;
+exports.detectDuplicateLogic = detectDuplicateLogic;
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const console_chars_1 = require("../../utils/console-chars");
+const file_cache_1 = require("../../shared/file-cache");
+const glob_patterns_1 = require("../../shared/glob-patterns");
+const universal_progress_reporter_1 = require("../system/universal-progress-reporter");
+// Check metadata
+exports.id = "code-quality/duplicate-logic-detection";
+exports.name = "Duplicate Logic Detection";
+exports.category = "code-quality";
+exports.blocking = false;
+exports.description = "Duplicate Logic Detection Preflight";
+exports.tags = ["code-quality"];
+const EXCLUDED = [...glob_patterns_1.STANDARD_EXCLUDES_WITH_TESTS];
+// Patterns that indicate duplicated logic that should be extracted
+const DUPLICATE_PATTERNS = [
+    {
+        pattern: "catalog-card-fetching",
+        description: "Repeated catalog card fetching pattern",
+        regex: /const\s+(?:sportsCardIds|tcgCardIds)\s*=\s*listings[\s\S]*?\.filter\([^)]*productType\s*===\s*["'](?:SPORTS_CARD|TCG_CARD)["']/g,
+        suggestion: "Use fetchCatalogCardsForListings() from @/lib/listing-utils instead of duplicating this pattern",
+        severity: "warning",
+    },
+    {
+        pattern: "listing-enrichment",
+        description: "Repeated listing enrichment/mapping pattern",
+        regex: /listings\.map\([^)]*listing[^)]*\)\s*=>\s*\{[\s\S]*?catalogCard[\s\S]*?category[\s\S]*?graded[\s\S]*?\}/g,
+        suggestion: "Use enrichListingWithCatalogData() or fetchAndEnrichListings() from @/lib/listing-utils",
+        severity: "warning",
+    },
+    {
+        pattern: "prisma-findmany-map",
+        description: "Repeated Prisma findMany followed by Map creation",
+        regex: /prisma\.\w+\.findMany\(\{[\s\S]*?\}\)[\s\S]*?new\s+Map\([^)]*\.map\([^)]*=>\s*\[[^,]+,\s*\w+\]\)/g,
+        suggestion: "Consider extracting this fetch-and-map pattern into a reusable helper function",
+        severity: "info",
+    },
+    {
+        pattern: "any-cast-chain",
+        description: "Multiple (as any) casts in sequence",
+        regex: /\([\w.]+\s+as\s+any\)\.[\w.]+[\s\S]*?\([\w.]+\s+as\s+any\)\.[\w.]+[\s\S]*?\([\w.]+\s+as\s+any\)/g,
+        suggestion: "Define proper TypeScript types instead of using multiple (as any) casts",
+        severity: "warning",
+    },
+    {
+        pattern: "repeated-null-coalesce",
+        description: "Repeated null coalescing for same properties",
+        regex: /(\?\.\w+\s*\?\?\s*[^,;\n]+,[\s\S]*?){5,}/g,
+        suggestion: "Consider extracting property access into a typed helper function",
+        severity: "info",
+    },
+];
+exports.DUPLICATE_PATTERNS = DUPLICATE_PATTERNS;
+// Files that are known to have the shared utilities (should not be flagged)
+const UTILITY_FILES = [
+    "listing-utils.ts",
+    "listing-utils.server.ts",
+    "listing-utils-client.ts",
+    "new-listing-utils.ts",
+    "catalog-utils.ts",
+    "data-fetching.ts",
+    "normalizeListingSummary.ts",
+];
+// CACHED FILE LISTS - Scan once, use everywhere
+let _cachedAppComponentsHooksLibFiles = null;
+async function getAppComponentsHooksLibFiles() {
+    if (!_cachedAppComponentsHooksLibFiles) {
+        _cachedAppComponentsHooksLibFiles = await file_cache_1.fileCache.getAppComponentsHooksLibFiles();
+    }
+    return _cachedAppComponentsHooksLibFiles;
+}
+async function detectDuplicateLogic() {
+    const issues = [];
+    const files = await getAppComponentsHooksLibFiles();
+    for (const file of files) {
+        // Skip utility files that define the shared patterns
+        const fileName = path.basename(file);
+        if (UTILITY_FILES.some((util) => fileName === util || file.includes(util))) {
+            continue;
+        }
+        const content = fs.readFileSync(file, "utf8");
+        const lines = content.split("\n");
+        for (const pattern of DUPLICATE_PATTERNS) {
+            let match;
+            const regex = new RegExp(pattern.regex.source, pattern.regex.flags);
+            while ((match = regex.exec(content)) !== null) {
+                const matchStart = match.index;
+                const lineNumber = content.slice(0, matchStart).split("\n").length;
+                // Get a snippet of the matched code (first 100 chars)
+                const snippet = match[0].slice(0, 100).replace(/\n/g, " ").trim();
+                issues.push({
+                    file: path.relative(process.cwd(), file),
+                    line: lineNumber,
+                    pattern: pattern.pattern,
+                    severity: pattern.severity,
+                    message: pattern.description,
+                    suggestion: pattern.suggestion,
+                    codeSnippet: snippet + (match[0].length > 100 ? "..." : ""),
+                });
+            }
+        }
+    }
+    return issues;
+}
+function countSimilarFunctions(files) {
+    const functionSignatures = new Map();
+    for (const file of files) {
+        const content = fs.readFileSync(file, "utf8");
+        // Match async functions that fetch from prisma
+        const asyncFetchPattern = /async\s+function\s+(\w+)\s*\([^)]*\)\s*\{[\s\S]*?prisma\.\w+\.findMany/g;
+        let match;
+        while ((match = asyncFetchPattern.exec(content)) !== null) {
+            const funcName = match[1];
+            const funcBody = match[0];
+            // Create a normalized signature (remove variable names, whitespace)
+            const signature = funcBody
+                .replace(/\s+/g, " ")
+                .replace(/["'][^"']+["']/g, "STRING")
+                .replace(/\d+/g, "NUM")
+                .slice(0, 200);
+            if (!functionSignatures.has(signature)) {
+                functionSignatures.set(signature, []);
+            }
+            functionSignatures.get(signature).push(`${file}:${funcName}`);
+        }
+    }
+    // Return only signatures that appear in multiple files
+    const duplicates = new Map();
+    for (const [sig, locations] of functionSignatures) {
+        if (locations.length > 2) {
+            duplicates.set(sig, locations);
+        }
+    }
+    return duplicates;
+}
+async function main() {
+    const reporter = (0, universal_progress_reporter_1.createUniversalProgressReporter)(path.basename(__filename, ".ts"));
+    const args = process.argv.slice(2);
+    const showSimilar = args.includes("--show-similar") || args.includes("--verbose");
+    console.log(`\n${console_chars_1.emoji.search} DUPLICATE LOGIC DETECTION PREFLIGHT`);
+    console.log((0, console_chars_1.createDivider)(80, "heavy"));
+    const startTime = Date.now();
+    const issues = await detectDuplicateLogic();
+    // Group issues by severity
+    const errors = issues.filter((i) => i.severity === "error");
+    const warnings = issues.filter((i) => i.severity === "warning");
+    const infos = issues.filter((i) => i.severity === "info");
+    // Print results
+    if (issues.length === 0) {
+        console.log(`\n${console_chars_1.emoji.success} No duplicate logic patterns detected`);
+    }
+    else {
+        console.log(`\nFound ${issues.length} potential duplicate patterns:\n`);
+        if (errors.length > 0) {
+            console.log(`${console_chars_1.emoji.error} ERRORS (should be fixed):`);
+            errors.forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line}`);
+                console.log(`      Pattern: ${issue.pattern}`);
+                console.log(`      ${issue.message}`);
+                console.log(`      ${console_chars_1.emoji.hint} ${issue.suggestion}`);
+                if (issue.codeSnippet) {
+                    console.log(`      Code: ${issue.codeSnippet}`);
+                }
+                console.log();
+            });
+        }
+        if (warnings.length > 0) {
+            console.log(`${console_chars_1.emoji.warning}  WARNINGS (consider refactoring):`);
+            warnings.forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line}`);
+                console.log(`      Pattern: ${issue.pattern}`);
+                console.log(`      ${issue.message}`);
+                console.log(`      ${console_chars_1.emoji.hint} ${issue.suggestion}`);
+                console.log();
+            });
+        }
+        if (infos.length > 0) {
+            console.log(`${console_chars_1.emoji.info}  INFO (opportunities for improvement):`);
+            infos.forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line} - ${issue.pattern}`);
+                console.log(`      ${console_chars_1.emoji.hint} ${issue.suggestion}`);
+                console.log();
+            });
+        }
+    }
+    if (showSimilar) {
+        // Check for similar async functions across files
+        const files = await file_cache_1.fileCache.getFiles("{app,components,lib}/**/*.{ts,tsx}", { ignore: EXCLUDED });
+        const similarFunctions = countSimilarFunctions(files);
+        if (similarFunctions.size > 0) {
+            console.log(`\n${console_chars_1.emoji.clipboard} SIMILAR FUNCTIONS DETECTED (potential extraction candidates):`);
+            for (const [, locations] of similarFunctions) {
+                console.log(`   Found in: ${locations.join(", ")}`);
+            }
+        }
+    }
+    const duration = Date.now() - startTime;
+    console.log("\n" + (0, console_chars_1.createDivider)(80, "heavy"));
+    console.log(`Duration: ${(duration / 1000).toFixed(1)}s`);
+    console.log(`Errors: ${errors.length} | Warnings: ${warnings.length} | Info: ${infos.length}`);
+    // Exit with error code if there are blocking issues
+    const hasBlockingIssues = errors.length > 0;
+    if (hasBlockingIssues) {
+        console.log(`\n${console_chars_1.emoji.error} DUPLICATE LOGIC CHECK FAILED`);
+        process.exit(1);
+    }
+    else if (warnings.length > 0) {
+        console.log(`\n${console_chars_1.emoji.warning}  DUPLICATE LOGIC CHECK PASSED WITH WARNINGS`);
+        process.exit(0);
+    }
+    else {
+        console.log(`\n${console_chars_1.emoji.success} DUPLICATE LOGIC CHECK PASSED`);
+        process.exit(0);
+    }
+}
+if (require.main === module) {
+    main();
+}
+//# sourceMappingURL=duplicate-logic-detection.js.map

package/dist/checks/code-quality/duplicate-logic-detection.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"duplicate-logic-detection.js","sourceRoot":"","sources":["../../../src/checks/code-quality/duplicate-logic-detection.ts"],"names":[],"mappings":";;AACA;;;;;;;;;;;GAWG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAwRM,oDAAoB;AAtR7B,uCAAyB;AACzB,2CAA6B;AAC7B,6DAAiE;AACjE,wDAAoD;AACpD,8DAA0E;AAC1E,uFAAwF;AAGxF,iBAAiB;AACJ,QAAA,EAAE,GAAG,wCAAwC,CAAC;AAC9C,QAAA,IAAI,GAAG,2BAA2B,CAAC;AACnC,QAAA,QAAQ,GAAG,cAAc,CAAC;AAC1B,QAAA,QAAQ,GAAG,KAAK,CAAC;AACjB,QAAA,WAAW,GAAG,qCAAqC,CAAC;AACpD,QAAA,IAAI,GAAG,CAAC,cAAc,CAAC,CAAC;AAoBrC,MAAM,QAAQ,GAAG,CAAC,GAAG,4CAA4B,CAAC,CAAC;AAEnD,mEAAmE;AACnE,MAAM,kBAAkB,GAAuB;IAC7C;QACE,OAAO,EAAE,uBAAuB;QAChC,WAAW,EAAE,wCAAwC;QACrD,KAAK,EACH,iIAAiI;QACnI,UAAU,EACR,iGAAiG;QACnG,QAAQ,EAAE,SAAS;KACpB;IACD;QACE,OAAO,EAAE,oBAAoB;QAC7B,WAAW,EAAE,6CAA6C;QAC1D,KAAK,EACH,0GAA0G;QAC5G,UAAU,EACR,yFAAyF;QAC3F,QAAQ,EAAE,SAAS;KACpB;IACD;QACE,OAAO,EAAE,qBAAqB;QAC9B,WAAW,EAAE,mDAAmD;QAChE,KAAK,EACH,mGAAmG;QACrG,UAAU,EAAE,gFAAgF;QAC5F,QAAQ,EAAE,MAAM;KACjB;IACD;QACE,OAAO,EAAE,gBAAgB;QACzB,WAAW,EAAE,qCAAqC;QAClD,KAAK,EACH,kGAAkG;QACpG,UAAU,EAAE,yEAAyE;QACrF,QAAQ,EAAE,SAAS;KACpB;IACD;QACE,OAAO,EAAE,wBAAwB;QACjC,WAAW,EAAE,8CAA8C;QAC3D,KAAK,EAAE,2CAA2C;QAClD,UAAU,EAAE,kEAAkE;QAC9E,QAAQ,EAAE,MAAM;KACjB;CACF,CAAC;AAuM6B,gDAAkB;AArMjD,4EAA4E;AAC5E,MAAM,aAAa,GAAG;IACpB,kBAAkB;IAClB,yBAAyB;IACzB,yBAAyB;IACzB,sBAAsB;IACtB,kBAAkB;IAClB,kBAAkB;IAClB,4BAA4B;CAC7B,CAAC;AAEF,gDAAgD;AAEhD,IAAI,iCAAiC,GAAoB,IAAI,CAAC;AAC9D,KAAK,UAAU,6BAA6B;IAC1C,IAAI,CAAC,iCAAiC,EAAE,CAAC;QACvC,iCAAiC,GAAG,MAAM,sBAAS,CAAC,6BAA6B,EAAE,CAAC;IACtF,CAAC;IACD,OAAO,iCAAiC,CAAC;AAC3C,CAAC;AAED,KAAK,UAAU,oBAAoB;IACjC,MAAM,MAAM,GAAY,EAAE,CAAC;IAC3B,MAAM,KAAK,GAAG,MAAM,6BAA6B,EAAE,CAAC;IAEpD,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,qDAAqD;QACrD,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;QACrC,IAAI,aAAa,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,QAAQ,KAAK,IAAI,IAAI,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC;YAC3E,SAAS;QACX,CAAC;QAED,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QAC9C,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAElC,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;YACzC,IAAI,KAAK,CAAC;YACV,MAAM,KAAK,GAAG,IAAI,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,MAAM,EAAE,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;YAEpE,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;gBAC9C,MAAM,UAAU,GAAG,KAAK,CAAC,KAAK,CAAC;gBAC/B,MAAM,UAAU,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;gBAEnE,sDAAsD;gBACtD,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC;gBAElE,MAAM,CAAC,IAAI,CAAC;oBACV,IAAI,EAAE,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,IAAI,CAAC;oBACxC,IAAI,EAAE,UAAU;oBAChB,OAAO,EAAE,OAAO,CAAC,OAAO;oBACxB,QAAQ,EAAE,OAAO,CAAC,QAAQ;oBAC1B,OAAO,EAAE,OAAO,CAAC,WAAW;oBAC5B,UAAU,EAAE,OAAO,CAAC,UAAU;oBAC9B,WAAW,EAAE,OAAO,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,GAAG,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC;iBAC5D,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,MAAM,CAAC;AAChB,CAAC;AAED,SAAS,qBAAqB,CAAC,KAAe;IAC5C,MAAM,kBAAkB,GAAG,IAAI,GAAG,EAAoB,CAAC;IAEvD,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QAE9C,+CAA+C;QAC/C,MAAM,iBAAiB,GACrB,yEAAyE,CAAC;QAC5E,IAAI,KAAK,CAAC;QAEV,OAAO,CAAC,KAAK,GAAG,iBAAiB,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC1D,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YAC1B,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YAE1B,oEAAoE;YACpE,MAAM,SAAS,GAAG,QAAQ;iBACvB,OAAO,CAAC,MAAM,EAAE,GAAG,CAAC;iBACpB,OAAO,CAAC,iBAAiB,EAAE,QAAQ,CAAC;iBACpC,OAAO,CAAC,MAAM,EAAE,KAAK,CAAC;iBACtB,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;YAEjB,IAAI,CAAC,kBAAkB,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,CAAC;gBACvC,kBAAkB,CAAC,GAAG,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC;YACxC,CAAC;YACD,kBAAkB,CAAC,GAAG,CAAC,SAAS,CAAE,CAAC,IAAI,CAAC,GAAG,IAAI,IAAI,QAAQ,EAAE,CAAC,CAAC;QACjE,CAAC;IACH,CAAC;IAED,uDAAuD;IACvD,MAAM,UAAU,GAAG,IAAI,GAAG,EAAoB,CAAC;IAC/C,KAAK,MAAM,CAAC,GAAG,EAAE,SAAS,CAAC,IAAI,kBAAkB,EAAE,CAAC;QAClD,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACzB,UAAU,CAAC,GAAG,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;QACjC,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,KAAK,UAAU,IAAI;IACjB,MAAM,QAAQ,GAAG,IAAA,6DAA+B,EAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC,CAAC;IACnF,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACnC,MAAM,WAAW,GAAG,IAAI,CAAC,QAAQ,CAAC,gBAAgB,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC;IAElF,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,MAAM,sCAAsC,CAAC,CAAC;IACrE,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAExC,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IAC7B,MAAM,MAAM,GAAG,MAAM,oBAAoB,EAAE,CAAC;IAE5C,2BAA2B;IAC3B,MAAM,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC;IAC5D,MAAM,QAAQ,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC;IAChE,MAAM,KAAK,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,CAAC,CAAC;IAE1D,gBAAgB;IAChB,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACxB,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,uCAAuC,CAAC,CAAC;IACzE,CAAC;SAAM,CAAC;QACN,OAAO,CAAC,GAAG,CAAC,WAAW,MAAM,CAAC,MAAM,kCAAkC,CAAC,CAAC;QAExE,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACtB,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,KAAK,4BAA4B,CAAC,CAAC;YACxD,MAAM,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACvB,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;gBAC9C,OAAO,CAAC,GAAG,CAAC,kBAAkB,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;gBAC/C,OAAO,CAAC,GAAG,CAAC,SAAS,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;gBACtC,OAAO,CAAC,GAAG,CAAC,SAAS,qBAAK,CAAC,IAAI,IAAI,KAAK,CAAC,UAAU,EAAE,CAAC,CAAC;gBACvD,IAAI,KAAK,CAAC,WAAW,EAAE,CAAC;oBACtB,OAAO,CAAC,GAAG,CAAC,eAAe,KAAK,CAAC,WAAW,EAAE,CAAC,CAAC;gBAClD,CAAC;gBACD,OAAO,CAAC,GAAG,EAAE,CAAC;YAChB,CAAC,CAAC,CAAC;QACL,CAAC;QAED,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACxB,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,OAAO,oCAAoC,CAAC,CAAC;YAClE,QAAQ,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACzB,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;gBAC9C,OAAO,CAAC,GAAG,CAAC,kBAAkB,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;gBAC/C,OAAO,CAAC,GAAG,CAAC,SAAS,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;gBACtC,OAAO,CAAC,GAAG,CAAC,SAAS,qBAAK,CAAC,IAAI,IAAI,KAAK,CAAC,UAAU,EAAE,CAAC,CAAC;gBACvD,OAAO,CAAC,GAAG,EAAE,CAAC;YAChB,CAAC,CAAC,CAAC;QACL,CAAC;QAED,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,IAAI,yCAAyC,CAAC,CAAC;YACpE,KAAK,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACtB,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,MAAM,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;gBACjE,OAAO,CAAC,GAAG,CAAC,SAAS,qBAAK,CAAC,IAAI,IAAI,KAAK,CAAC,UAAU,EAAE,CAAC,CAAC;gBACvD,OAAO,CAAC,GAAG,EAAE,CAAC;YAChB,CAAC,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,IAAI,WAAW,EAAE,CAAC;QAChB,iDAAiD;QACjD,MAAM,KAAK,GAAG,MAAM,sBAAS,CAAC,QAAQ,CAAC,oCAAoC,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,CAAC;QACnG,MAAM,gBAAgB,GAAG,qBAAqB,CAAC,KAAK,CAAC,CAAC;QAEtD,IAAI,gBAAgB,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;YAC9B,OAAO,CAAC,GAAG,CACT,KAAK,qBAAK,CAAC,SAAS,gEAAgE,CACrF,CAAC;YACF,KAAK,MAAM,CAAC,EAAE,SAAS,CAAC,IAAI,gBAAgB,EAAE,CAAC;gBAC7C,OAAO,CAAC,GAAG,CAAC,gBAAgB,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;YACtD,CAAC;QACH,CAAC;IACH,CAAC;IAED,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;IACxC,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,aAAa,CAAC,QAAQ,GAAG,IAAI,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC;IAC1D,OAAO,CAAC,GAAG,CAAC,WAAW,MAAM,CAAC,MAAM,gBAAgB,QAAQ,CAAC,MAAM,YAAY,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC;IAE/F,oDAAoD;IACpD,MAAM,iBAAiB,GAAG,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC;IAC5C,IAAI,iBAAiB,EAAE,CAAC;QACtB,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,KAAK,+BAA+B,CAAC,CAAC;QAC7D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;SAAM,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC/B,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,8CAA8C,CAAC,CAAC;QAC9E,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;SAAM,CAAC;QACN,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,+BAA+B,CAAC,CAAC;QAC/D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;AACH,CAAC;AAED,IAAI,OAAO,CAAC,IAAI,KAAK,MAAM,EAAE,CAAC;IAC5B,IAAI,EAAE,CAAC;AACT,CAAC"}

package/dist/checks/code-quality/feature-flag-hygiene.d.ts

@@ -0,0 +1,26 @@
+#!/usr/bin/env tsx
+/**
+ * Feature Flag Hygiene Preflight (NON-BLOCKING)
+ *
+ * Detects stale or problematic feature flags that accumulate as tech debt.
+ * Feature flags should be temporary and cleaned up after rollout.
+ *
+ * Patterns detected:
+ * - Feature flags older than 90 days (based on git history)
+ * - Feature flags without corresponding env variable
+ * - Hardcoded feature flags (always true/false)
+ * - Inconsistent feature flag naming
+ * - Feature flags used but never defined
+ * - Dead feature flag code paths
+ *
+ * Usage:
+ *   pnpm preflight:feature-flag-hygiene
+ *   pnpm preflight:feature-flag-hygiene --verbose
+ */
+export declare const id = "code-quality/feature-flag-hygiene";
+export declare const name = "Feature Flag Hygiene";
+export declare const category = "code-quality";
+export declare const blocking = false;
+export declare const description = "Feature Flag Hygiene Preflight (NON-BLOCKING)";
+export declare const tags: string[];
+//# sourceMappingURL=feature-flag-hygiene.d.ts.map

package/dist/checks/code-quality/feature-flag-hygiene.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"feature-flag-hygiene.d.ts","sourceRoot":"","sources":["../../../src/checks/code-quality/feature-flag-hygiene.ts"],"names":[],"mappings":";AACA;;;;;;;;;;;;;;;;;GAiBG;AAaH,eAAO,MAAM,EAAE,sCAAsC,CAAC;AACtD,eAAO,MAAM,IAAI,yBAAyB,CAAC;AAC3C,eAAO,MAAM,QAAQ,iBAAiB,CAAC;AACvC,eAAO,MAAM,QAAQ,QAAQ,CAAC;AAC9B,eAAO,MAAM,WAAW,kDAAkD,CAAC;AAC3E,eAAO,MAAM,IAAI,UAAmB,CAAC"}

package/dist/checks/code-quality/feature-flag-hygiene.js

@@ -0,0 +1,357 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * Feature Flag Hygiene Preflight (NON-BLOCKING)
+ *
+ * Detects stale or problematic feature flags that accumulate as tech debt.
+ * Feature flags should be temporary and cleaned up after rollout.
+ *
+ * Patterns detected:
+ * - Feature flags older than 90 days (based on git history)
+ * - Feature flags without corresponding env variable
+ * - Hardcoded feature flags (always true/false)
+ * - Inconsistent feature flag naming
+ * - Feature flags used but never defined
+ * - Dead feature flag code paths
+ *
+ * Usage:
+ *   pnpm preflight:feature-flag-hygiene
+ *   pnpm preflight:feature-flag-hygiene --verbose
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.tags = exports.description = exports.blocking = exports.category = exports.name = exports.id = void 0;
+const child_process_1 = require("child_process");
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const console_chars_1 = require("../../utils/console-chars");
+const file_cache_1 = require("../../shared/file-cache");
+const glob_patterns_1 = require("../../shared/glob-patterns");
+const universal_progress_reporter_1 = require("../system/universal-progress-reporter");
+const exclusions_1 = require("../../shared/exclusions");
+// Check metadata
+exports.id = "code-quality/feature-flag-hygiene";
+exports.name = "Feature Flag Hygiene";
+exports.category = "code-quality";
+exports.blocking = false;
+exports.description = "Feature Flag Hygiene Preflight (NON-BLOCKING)";
+exports.tags = ["code-quality"];
+const issues = [];
+const foundFlags = new Map();
+// Feature flag patterns to detect
+const FLAG_PATTERNS = [
+    {
+        // Environment variable feature flags
+        regex: /process\.env\.(?:NEXT_PUBLIC_)?(?:FEATURE_|FF_|ENABLE_|DISABLE_)(\w+)/g,
+        type: "env",
+    },
+    {
+        // Feature flag constants
+        regex: /(?:const|let|var)\s+(?:FEATURE_|FF_|ENABLE_|DISABLE_|IS_)(\w+)_(?:ENABLED|DISABLED|ACTIVE)\s*=/g,
+        type: "constant",
+    },
+    {
+        // Feature flag function calls
+        regex: /(?:isFeatureEnabled|hasFeature|checkFeature|useFeatureFlag)\s*\(\s*['"`]([^'"`]+)['"`]\s*\)/g,
+        type: "function",
+    },
+    {
+        // Inline feature checks
+        regex: /(?:featureFlags|features|flags)\s*\.\s*(\w+)/g,
+        type: "inline",
+    },
+];
+// Problematic patterns
+const PROBLEM_PATTERNS = [
+    {
+        // Hardcoded true (flag should be removed)
+        regex: /(?:FEATURE_|FF_|ENABLE_)(\w+)\s*=\s*true\s*(?:;|,|\n)/g,
+        code: "HARDCODED_TRUE",
+        message: "Feature flag hardcoded to true - remove flag and dead code",
+        severity: "warning",
+    },
+    {
+        // Hardcoded false (dead code)
+        regex: /(?:FEATURE_|FF_|ENABLE_)(\w+)\s*=\s*false\s*(?:;|,|\n)/g,
+        code: "HARDCODED_FALSE",
+        message: "Feature flag hardcoded to false - remove flag and dead code",
+        severity: "warning",
+    },
+    {
+        // TODO/FIXME with feature flag
+        regex: /(?:TODO|FIXME)[^]*?(?:FEATURE_|FF_|feature.?flag)(\w*)/gi,
+        code: "TODO_FLAG",
+        message: "TODO/FIXME referencing feature flag - needs cleanup",
+        severity: "info",
+    },
+    {
+        // Inconsistent naming (camelCase vs UPPER_CASE)
+        regex: /(?:featureFlag|feature_flag)\.([a-z][a-zA-Z]+)/g,
+        code: "INCONSISTENT_NAMING",
+        message: "Inconsistent feature flag naming - use UPPER_SNAKE_CASE",
+        severity: "info",
+    },
+];
+let appExclusions = [];
+// Skip patterns
+const SKIP_PATTERNS = (0, glob_patterns_1.extendExcludes)(glob_patterns_1.STANDARD_EXCLUDES, [
+    "node_modules",
+    ".next",
+    "__mocks__",
+    "dist",
+    "coverage",
+]);
+function shouldSkip(filePath) {
+    const normalized = filePath.replace(/\\/g, "/");
+    if (SKIP_PATTERNS.some((pattern) => {
+        if (pattern.startsWith("*")) {
+            return normalized.endsWith(pattern.slice(1));
+        }
+        return normalized.includes(pattern);
+    })) {
+        return true;
+    }
+    return (0, exclusions_1.shouldExcludeFile)(filePath, appExclusions);
+}
+function getFileAge(filePath) {
+    try {
+        const result = (0, child_process_1.execSync)(`git log -1 --format=%ct -- "${filePath}"`, {
+            encoding: "utf-8",
+            stdio: ["pipe", "pipe", "ignore"],
+        }).trim();
+        if (!result)
+            return null;
+        const timestamp = parseInt(result, 10);
+        const now = Date.now() / 1000;
+        return Math.floor((now - timestamp) / (24 * 60 * 60)); // Days
+    }
+    catch {
+        return null;
+    }
+}
+function getFlagFirstCommit(flagName) {
+    try {
+        const result = (0, child_process_1.execSync)(`git log --all --format=%ct -S "${flagName}" --reverse | head -1`, {
+            encoding: "utf-8",
+            stdio: ["pipe", "pipe", "ignore"],
+        }).trim();
+        if (!result)
+            return null;
+        const timestamp = parseInt(result, 10);
+        const now = Date.now() / 1000;
+        return Math.floor((now - timestamp) / (24 * 60 * 60)); // Days
+    }
+    catch {
+        return null;
+    }
+}
+async function scanFile(filePath) {
+    if (shouldSkip(filePath))
+        return;
+    const content = fs.readFileSync(filePath, "utf-8");
+    const lines = content.split("\n");
+    // Find feature flags
+    for (const pattern of FLAG_PATTERNS) {
+        let match;
+        const regex = new RegExp(pattern.regex.source, pattern.regex.flags);
+        while ((match = regex.exec(content)) !== null) {
+            const flagName = match[1];
+            const beforeMatch = content.slice(0, match.index);
+            const lineNumber = beforeMatch.split("\n").length;
+            const flag = {
+                name: flagName,
+                file: filePath,
+                line: lineNumber,
+                type: pattern.type,
+            };
+            if (!foundFlags.has(flagName)) {
+                foundFlags.set(flagName, []);
+            }
+            foundFlags.get(flagName).push(flag);
+        }
+    }
+    // Find problematic patterns
+    for (const pattern of PROBLEM_PATTERNS) {
+        let match;
+        const regex = new RegExp(pattern.regex.source, pattern.regex.flags);
+        while ((match = regex.exec(content)) !== null) {
+            const flagName = match[1] || "unknown";
+            const beforeMatch = content.slice(0, match.index);
+            const lineNumber = beforeMatch.split("\n").length;
+            // Skip comments
+            const line = lines[lineNumber - 1] || "";
+            if (line.trim().startsWith("//") && pattern.code !== "TODO_FLAG") {
+                continue;
+            }
+            issues.push({
+                flag: flagName,
+                file: filePath,
+                line: lineNumber,
+                severity: pattern.severity,
+                code: pattern.code,
+                message: pattern.message,
+            });
+        }
+    }
+}
+async function checkEnvDefinitions() {
+    // Check if env flags are defined in .env.example
+    const envExamplePath = path.join(process.cwd(), ".env.example");
+    let envExample = "";
+    if (fs.existsSync(envExamplePath)) {
+        envExample = fs.readFileSync(envExamplePath, "utf-8");
+    }
+    for (const [flagName, usages] of Array.from(foundFlags.entries())) {
+        // Only check env-type flags
+        const envUsages = usages.filter((u) => u.type === "env");
+        if (envUsages.length === 0)
+            continue;
+        const envVarName = `FEATURE_${flagName}`;
+        const altEnvVarName = `NEXT_PUBLIC_FEATURE_${flagName}`;
+        if (!envExample.includes(envVarName) && !envExample.includes(altEnvVarName)) {
+            issues.push({
+                flag: flagName,
+                file: envUsages[0].file,
+                line: envUsages[0].line,
+                severity: "warning",
+                code: "MISSING_ENV_DEFINITION",
+                message: `Feature flag ${envVarName} used but not defined in .env.example`,
+            });
+        }
+    }
+}
+async function checkStaleFlags() {
+    const STALE_THRESHOLD_DAYS = 90;
+    for (const [flagName, usages] of Array.from(foundFlags.entries())) {
+        const age = getFlagFirstCommit(flagName);
+        if (age !== null && age > STALE_THRESHOLD_DAYS) {
+            issues.push({
+                flag: flagName,
+                file: usages[0].file,
+                line: usages[0].line,
+                severity: "info",
+                code: "STALE_FLAG",
+                message: `Feature flag is ${age} days old (>${STALE_THRESHOLD_DAYS}) - consider cleanup`,
+            });
+        }
+    }
+}
+async function main() {
+    const reporter = (0, universal_progress_reporter_1.createUniversalProgressReporter)(path.basename(__filename, ".ts"));
+    const verbose = process.argv.includes("--verbose") || process.argv.includes("-v");
+    const strict = process.argv.includes("--strict");
+    appExclusions = await (0, exclusions_1.getExclusions)(exports.id);
+    console.log(`\n${console_chars_1.emoji.flag} Feature Flag Hygiene`);
+    console.log((0, console_chars_1.createDivider)(60, "heavy"));
+    const files = await file_cache_1.fileCache.getAppCodeFiles();
+    for (const file of files) {
+        await scanFile(file);
+    }
+    // Additional checks
+    await checkEnvDefinitions();
+    await checkStaleFlags();
+    // Deduplicate
+    const seen = new Set();
+    const uniqueIssues = issues.filter((i) => {
+        const key = `${i.file}:${i.line}:${i.code}`;
+        if (seen.has(key))
+            return false;
+        seen.add(key);
+        return true;
+    });
+    const errors = uniqueIssues.filter((i) => i.severity === "error");
+    const warnings = uniqueIssues.filter((i) => i.severity === "warning");
+    const infos = uniqueIssues.filter((i) => i.severity === "info");
+    // Summary
+    console.log(`\nFeature flags found: ${foundFlags.size}`);
+    if (verbose) {
+        for (const [name, usages] of Array.from(foundFlags.entries())) {
+            console.log(`   ${name}: ${usages.length} usage(s)`);
+        }
+    }
+    if (uniqueIssues.length > 0) {
+        if (errors.length > 0) {
+            console.log(`\n${console_chars_1.emoji.error} ERRORS:`);
+            errors.forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line} [${issue.code}]`);
+                console.log(`      Flag: ${issue.flag}`);
+                console.log(`      ${issue.message}`);
+            });
+        }
+        if (warnings.length > 0) {
+            console.log(`\n${console_chars_1.emoji.warning}  WARNINGS:`);
+            warnings.slice(0, 15).forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line} [${issue.code}]`);
+                console.log(`      Flag: ${issue.flag}`);
+                console.log(`      ${issue.message}`);
+            });
+            if (warnings.length > 15) {
+                console.log(`   ... and ${warnings.length - 15} more warnings`);
+            }
+        }
+        if (verbose && infos.length > 0) {
+            console.log(`\n${console_chars_1.emoji.info} INFO:`);
+            infos.slice(0, 10).forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line} - ${issue.flag}: ${issue.message}`);
+            });
+            if (infos.length > 10) {
+                console.log(`   ... and ${infos.length - 10} more`);
+            }
+        }
+    }
+    console.log("\n" + (0, console_chars_1.createDivider)(60, "heavy"));
+    console.log(`Files scanned: ${files.length}`);
+    console.log(`Feature flags: ${foundFlags.size}`);
+    console.log(`Issues: ${uniqueIssues.length} (${errors.length} errors, ${warnings.length} warnings)`);
+    // Non-blocking by default
+    if (strict && (errors.length > 0 || warnings.length > 0)) {
+        console.log(`\n${console_chars_1.emoji.error} Feature Flag Hygiene FAILED (strict mode)`);
+        console.log("\n" + console_chars_1.emoji.hint + " Cleanup steps:");
+        console.log("  1. Remove hardcoded true/false flags");
+        console.log("  2. Delete dead code behind disabled flags");
+        console.log("  3. Add missing flags to .env.example");
+        console.log("  4. Review flags older than 90 days");
+        process.exit(1);
+    }
+    if (warnings.length > 0 || infos.length > 0) {
+        console.log(`\n${console_chars_1.emoji.warning}  Feature Flag Hygiene completed with suggestions`);
+        console.log("   Review stale flags and consider cleanup");
+    }
+    else {
+        console.log(`\n${console_chars_1.emoji.success} Feature Flag Hygiene PASSED`);
+    }
+}
+main().catch(console.error);
+//# sourceMappingURL=feature-flag-hygiene.js.map