@empiricalrun/test-gen 0.76.0 → 0.78.0

package/dist/agent/chat/utils.js

@@ -34,25 +34,32 @@ async function handleAgentError({ error, chatModel, reporter, trace, }) {
         message: error.message,
         stack: error.stack || "Stack trace not available",
         timestamp: new Date().toISOString(),
+        type: error instanceof chat_1.CanonicalError ? error.type : null,
     };
-    await reporter((0, state_1.chatStateFromModel)({
-        chatModel,
-        error: errorObject,
-    }), chatModel.getHumanReadableLatestMessage());
+    await reporter((0, state_1.chatStateFromModel)({ chatModel, error: errorObject }), chatModel.getHumanReadableLatestMessage());
     trace?.update({ output: { error: errorObject } });
     logError(error, trace);
 }
+const VALID_ATTACHMENTS = [".webm", ".png"];
+const MIME_MAP = {
+    ".webm": "video/webm",
+    ".png": "image/png",
+};
 function extractAttachments(userPrompt) {
     const attachments = [];
     const urlPattern = /\[\[(https?:\/\/[^\]]+)\]\]/g;
     let match;
     while ((match = urlPattern.exec(userPrompt)) !== null) {
         const name = match[1].split("/").pop();
-        if (!name || !name.endsWith(".webm")) {
-            throw new Error(`Invalid attachment name: ${name}. Only .webm files are supported.`);
+        const ext = name ? name.substring(name.lastIndexOf(".")) : null;
+        if (!ext) {
+            throw new Error(`Attachment URL does not have a valid file extension: ${match[1]}`);
+        }
+        if (!name || !VALID_ATTACHMENTS.some((validExt) => ext === validExt)) {
+            throw new Error(`Invalid attachment name: ${name}. Only ${VALID_ATTACHMENTS.join(", ")} files are supported.`);
         }
         attachments.push({
-            contentType: "video/webm",
+            contentType: MIME_MAP[ext],
             name,
             url: match[1],
         });

package/dist/agent/cli.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"cli.d.ts","sourceRoot":"","sources":["../../src/agent/cli.ts"],"names":[],"mappings":"AAEA,OAAO,EACL,aAAa,EAMb,mBAAmB,EACpB,MAAM,4BAA4B,CAAC;AAwCpC,wBAAsB,yBAAyB,IAAI,OAAO,CACxD,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CACvB,CAkCA;AAED,wBAAsB,kBAAkB,CAAC,EACvC,mBAAmB,EACnB,aAAa,EACb,oBAAoB,EACpB,SAAS,EACT,SAAS,EACT,UAAU,GACX,EAAE;IACD,aAAa,EAAE,mBAAmB,CAAC;IACnC,mBAAmB,EAAE,OAAO,CAAC;IAC7B,oBAAoB,EAAE,MAAM,GAAG,SAAS,CAAC;IACzC,SAAS,EAAE,aAAa,CAAC;IACzB,UAAU,EAAE,OAAO,CAAC;IACpB,SAAS,EAAE,OAAO,CAAC;CACpB,iBAoLA"}
+{"version":3,"file":"cli.d.ts","sourceRoot":"","sources":["../../src/agent/cli.ts"],"names":[],"mappings":"AACA,OAAO,EACL,aAAa,EAKb,mBAAmB,EACpB,MAAM,4BAA4B,CAAC;AA0BpC,wBAAsB,yBAAyB,IAAI,OAAO,CACxD,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CACvB,CAkCA;AAED,wBAAsB,kBAAkB,CAAC,EACvC,mBAAmB,EACnB,aAAa,EACb,oBAAoB,EACpB,SAAS,EACT,SAAS,EACT,UAAU,GACX,EAAE;IACD,aAAa,EAAE,mBAAmB,CAAC;IACnC,mBAAmB,EAAE,OAAO,CAAC;IAC7B,oBAAoB,EAAE,MAAM,GAAG,SAAS,CAAC;IACzC,SAAS,EAAE,aAAa,CAAC;IACzB,UAAU,EAAE,OAAO,CAAC;IACpB,SAAS,EAAE,OAAO,CAAC;CACpB,iBA+JA"}

package/dist/agent/cli.js

@@ -3,7 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.fetchEnvironmentVariables = fetchEnvironmentVariables;
 exports.runChatAgentForCLI = runChatAgentForCLI;
 const llm_1 = require("@empiricalrun/llm");
-const chat_1 = require("@empiricalrun/llm/chat");
 const picocolors_1 = require("picocolors");
 const client_1 = require("../dashboard/client");
 const reader_1 = require("../file-info/adapters/file-system/reader");
@@ -11,17 +10,17 @@ const human_in_the_loop_1 = require("../human-in-the-loop");
 const validation_1 = require("../recorder/validation");
 const executor_1 = require("../tools/executor");
 const git_1 = require("../tools/executor/utils/git");
-const filesystem_cache_1 = require("./chat/filesystem-cache");
 const state_1 = require("./chat/state");
 const utils_1 = require("./chat/utils");
 const index_1 = require("./index");
 function stopCriteria(userPrompt) {
     return userPrompt?.toLowerCase() === "stop";
 }
-function concludeAgent(chatModel, useDiskForChatState, selectedModel, error) {
-    console.log(`\n${(0, picocolors_1.gray)("Usage summary -> " + (0, state_1.getUsageSummary)(chatModel))}`);
+function concludeAgent(agent, useDiskForChatState) {
+    const chatState = agent.chatState;
+    console.log(`\n${(0, picocolors_1.gray)("Usage summary -> " + (0, state_1.getUsageSummary)(chatState))}`);
     if (useDiskForChatState) {
-        (0, state_1.saveToDisk)(chatModel.messages, selectedModel, chatModel.askUserForInput, error);
+        (0, state_1.saveToDisk)(chatState);
     }
 }
 async function fetchEnvironmentVariables() {
@@ -53,41 +52,23 @@ async function fetchEnvironmentVariables() {
     return envVars;
 }
 async function runChatAgentForCLI({ useDiskForChatState, selectedModel, initialPromptContent, agentMode, resetChat, useFSCache, }) {
-    let chatState;
     const enableStreaming = !useFSCache;
-    const cache = useFSCache ? new filesystem_cache_1.FilesystemLLMCache() : undefined;
-    if (resetChat) {
-        (0, state_1.clearChatState)();
-    }
-    if (useDiskForChatState) {
-        chatState = (0, state_1.loadChatState)();
-    }
+    // TODO: Implement cache support in BaseAgent
+    // const cache = useFSCache ? new FilesystemLLMCache() : undefined;
     // TODO: Store branch name in chat state so that we don't recreate it every time
     const randomId = crypto.randomUUID().substring(0, 8);
     const branchName = `branch-${randomId}`;
     await (0, git_1.checkoutBranch)(branchName, process.cwd());
-    let messagesLoadedFromDisk = chatState?.messages || [];
-    let chatModel = (0, chat_1.createChatModel)(messagesLoadedFromDisk, selectedModel, undefined, cache);
-    chatModel.validateEnvVarsForAuth();
-    if (initialPromptContent && chatModel.messages.length === 0) {
-        chatModel.pushUserMessage(initialPromptContent, []);
-    }
-    else if (initialPromptContent && chatModel.messages.length > 0) {
-        console.warn(`Ignoring initial prompt because we have existing messages.`);
-    }
-    if (chatModel.askUserForInput) {
-        // Show last message to the user for context when we loaded from disk
-        const latest = chatModel.getHumanReadableLatestMessage();
-        if (latest) {
-            console.log(`${(0, picocolors_1.blue)(latest.role)}: ${latest.textMessage}`);
-        }
+    let chatState;
+    if (useDiskForChatState) {
+        chatState = (0, state_1.loadChatState)({ resetChat });
     }
     if (chatState && chatState.error) {
         // Reset error state as we are attempting a retry
         chatState.error = null;
     }
     const handleSigInt = () => {
-        concludeAgent(chatModel, useDiskForChatState, selectedModel, null);
+        concludeAgent(agent, useDiskForChatState);
         process.exit(0);
     };
     process.once("SIGINT", handleSigInt);
@@ -95,7 +76,7 @@ async function runChatAgentForCLI({ useDiskForChatState, selectedModel, initialP
     let userPrompt;
     let reporterFunc = async (chatState, latest) => {
         if (useDiskForChatState) {
-            (0, state_1.saveToDisk)(chatState.messages, selectedModel, chatState.askUserForInput, chatState.error);
+            (0, state_1.saveToDisk)(chatState);
         }
         if (latest) {
             if (!enableStreaming) {
@@ -122,13 +103,42 @@ async function runChatAgentForCLI({ useDiskForChatState, selectedModel, initialP
     const apiClient = new client_1.DashboardAPIClient({
         authType,
     });
+    const toolExecutor = new executor_1.ToolExecutor({
+        chatSession: { branchName },
+        repoPath: process.cwd(),
+        apiClient,
+        trace,
+        featureFlags: [],
+        environmentOverrides: await fetchEnvironmentVariables(),
+    });
     const fileInfoBuilder = () => (0, reader_1.getFileInfoFromFS)(process.cwd());
     const agentParams = {
         selectedModel,
+        featureFlags: [],
+        chatState,
+        toolExecutor,
     };
-    const agent = index_1.MODE_TO_AGENT_MAP[agentMode](agentParams);
+    const agent = index_1.MODE_TO_AGENT_MAP[agentMode]({ ...agentParams });
+    // If we have an initial prompt and no existing chat state, push it to the agent
+    if (initialPromptContent && !chatState) {
+        const { text, attachments } = (0, utils_1.extractAttachments)(initialPromptContent);
+        const updatedChatState = agent.pushUserMessage([{ text, attachments }]);
+        if (useDiskForChatState) {
+            (0, state_1.saveToDisk)(updatedChatState);
+        }
+    }
+    else if (initialPromptContent && chatState) {
+        console.warn(`Ignoring initial prompt because we have existing chat state.`);
+    }
+    if (agent.askUserForInput) {
+        // Show last message to the user for context when we loaded from disk
+        const latest = agent.getHumanReadableLatestMessage();
+        if (latest) {
+            console.log(`${(0, picocolors_1.blue)(latest.role)}: ${latest.textMessage}`);
+        }
+    }
     while (!stopCriteria(userPrompt)) {
-        if (chatModel.askUserForInput) {
+        if (agent.askUserForInput) {
             try {
                 userPrompt = await human_in_the_loop_1.humanLoop.getFeedback({
                     message: "User:",
@@ -137,33 +147,19 @@ async function runChatAgentForCLI({ useDiskForChatState, selectedModel, initialP
             catch (e) {
                 // https://github.com/SBoudrias/Inquirer.js/issues/1502#issuecomment-2275991680
                 if (e instanceof Error && e.name === "ExitPromptError") {
-                    concludeAgent(chatModel, useDiskForChatState, selectedModel, null);
+                    concludeAgent(agent, useDiskForChatState);
                     process.exit(0);
                 }
-                concludeAgent(chatModel, useDiskForChatState, selectedModel, {
-                    message: e.message,
-                    stack: e.stack || "Stack trace not available",
-                    timestamp: new Date().toISOString(),
-                });
+                concludeAgent(agent, useDiskForChatState);
                 throw e;
             }
             if (!stopCriteria(userPrompt)) {
                 const { text, attachments } = (0, utils_1.extractAttachments)(userPrompt);
-                chatModel.pushUserMessage(text, attachments);
+                agent.pushUserMessage([{ text, attachments }]);
             }
         }
         else {
-            const toolExecutor = new executor_1.ToolExecutor({
-                chatSession: null,
-                branchName,
-                repoPath: process.cwd(),
-                apiClient,
-                trace,
-                featureFlags: [],
-                environmentOverrides: await fetchEnvironmentVariables(),
-            });
             await agent.runLoop({
-                messages: chatModel.messages,
                 reporter: reporterFunc,
                 streamingMessageReporter: (() => {
                     if (!enableStreaming) {
@@ -192,18 +188,13 @@ async function runChatAgentForCLI({ useDiskForChatState, selectedModel, initialP
                 trace,
                 repoInfoBuilder: fileInfoBuilder,
                 onPendingToolCall: async (toolCalls) => {
-                    const toolResults = await toolExecutor.execute(toolCalls);
-                    chatModel.pushToolResultsMessage(toolCalls, toolResults);
+                    const { toolResults, checkpoint } = await toolExecutor.execute(toolCalls);
+                    agent.processToolResults(toolCalls, toolResults, checkpoint);
                 },
             });
-            // Update the chatModel with the agent's final state for next iteration
-            if (agent.messages) {
-                chatModel = (0, chat_1.createChatModel)(agent.messages, selectedModel, undefined, cache);
-            }
         }
     }
-    trace?.update({ output: { messages: chatModel.messages } });
+    trace?.update({ output: { messages: agent.messages } });
     await llm_1.langfuseInstance?.flushAsync();
-    const usageSummary = (0, state_1.getUsageSummary)(chatModel);
-    console.log(`\n${(0, picocolors_1.gray)("Usage summary -> " + usageSummary)}`);
+    console.log(`\n${(0, picocolors_1.gray)("Usage summary -> " + (0, state_1.getUsageSummary)(agent.chatState))}`);
 }

package/dist/agent/code-review/executor/index.d.ts

@@ -0,0 +1,5 @@
+import { BaseToolExecutor, BaseToolExecutorProps } from "../../../tools/executor/base";
+export declare class CodeReviewToolExecutor extends BaseToolExecutor {
+    constructor(params: Omit<BaseToolExecutorProps, "tools">);
+}
+//# sourceMappingURL=index.d.ts.map

package/dist/agent/code-review/executor/index.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../src/agent/code-review/executor/index.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,gBAAgB,EAChB,qBAAqB,EACtB,MAAM,8BAA8B,CAAC;AAItC,qBAAa,sBAAuB,SAAQ,gBAAgB;gBAC9C,MAAM,EAAE,IAAI,CAAC,qBAAqB,EAAE,OAAO,CAAC;CAIzD"}

package/dist/agent/code-review/executor/index.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CodeReviewToolExecutor = void 0;
+const base_1 = require("../../../tools/executor/base");
+const fetch_session_diff_1 = require("../../../tools/fetch-session-diff");
+const file_operations_1 = require("../../../tools/file-operations");
+class CodeReviewToolExecutor extends base_1.BaseToolExecutor {
+    constructor(params) {
+        const tools = [fetch_session_diff_1.fetchSessionDiffTool, ...file_operations_1.viewOnlyTools];
+        super({ ...params, tools });
+    }
+}
+exports.CodeReviewToolExecutor = CodeReviewToolExecutor;

package/dist/agent/code-review/index.d.ts

@@ -1,7 +1,12 @@
-import type { ToolDefinition } from "@empiricalrun/shared-types";
+import type { ToolsForLLM } from "@empiricalrun/shared-types";
 import { BaseAgent } from "../base";
+import { type CodeReviewResultV0, type CodeReviewResultV1, type CodeReviewResultV2, CodeReviewSeverity, CodeReviewVerdict } from "./types";
+export type { CodeReviewResultV1, CodeReviewResultV0, CodeReviewResultV2 };
+export { CodeReviewVerdict, CodeReviewSeverity };
+export type CodeReviewVersionedResult = CodeReviewResultV0 | CodeReviewResultV1 | CodeReviewResultV2;
 export declare class CodeReviewAgent extends BaseAgent {
-    protected getTools(): ToolDefinition[];
-    protected buildSystemPrompt(): Promise<string>;
+    protected getTools(): ToolsForLLM;
+    getResult(): CodeReviewVersionedResult | undefined;
+    protected buildSystemPrompt(repoContext: string): Promise<string>;
 }
 //# sourceMappingURL=index.d.ts.map

package/dist/agent/code-review/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../src/agent/code-review/index.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,4BAA4B,CAAC;AAGjE,OAAO,EAAE,SAAS,EAAE,MAAM,SAAS,CAAC;AAEpC,qBAAa,eAAgB,SAAQ,SAAS;IAC5C,SAAS,CAAC,QAAQ,IAAI,cAAc,EAAE;cAItB,iBAAiB,IAAI,OAAO,CAAC,MAAM,CAAC;CAsDrD"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../src/agent/code-review/index.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAmB,WAAW,EAAE,MAAM,4BAA4B,CAAC;AAG/E,OAAO,EAAE,SAAS,EAAE,MAAM,SAAS,CAAC;AAEpC,OAAO,EACL,KAAK,kBAAkB,EACvB,KAAK,kBAAkB,EACvB,KAAK,kBAAkB,EACvB,kBAAkB,EAClB,iBAAiB,EAClB,MAAM,SAAS,CAAC;AAEjB,YAAY,EAAE,kBAAkB,EAAE,kBAAkB,EAAE,kBAAkB,EAAE,CAAC;AAC3E,OAAO,EAAE,iBAAiB,EAAE,kBAAkB,EAAE,CAAC;AAEjD,MAAM,MAAM,yBAAyB,GACjC,kBAAkB,GAClB,kBAAkB,GAClB,kBAAkB,CAAC;AAEvB,qBAAa,eAAgB,SAAQ,SAAS;IAC5C,SAAS,CAAC,QAAQ,IAAI,WAAW;IAWjC,SAAS,IAAI,yBAAyB,GAAG,SAAS;cAmBlC,iBAAiB,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC;CA0HxE"}

package/dist/agent/code-review/index.js

@@ -1,52 +1,140 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.CodeReviewAgent = void 0;
+exports.CodeReviewAgent = exports.CodeReviewSeverity = exports.CodeReviewVerdict = void 0;
 const tools_1 = require("../../tools");
+const fetch_session_diff_1 = require("../../tools/fetch-session-diff");
 const base_1 = require("../base");
+const parser_1 = require("./parser");
+const types_1 = require("./types");
+Object.defineProperty(exports, "CodeReviewSeverity", { enumerable: true, get: function () { return types_1.CodeReviewSeverity; } });
+Object.defineProperty(exports, "CodeReviewVerdict", { enumerable: true, get: function () { return types_1.CodeReviewVerdict; } });
 class CodeReviewAgent extends base_1.BaseAgent {
     getTools() {
-        return [tools_1.fetchSessionDiffTool];
+        const custom = [
+            fetch_session_diff_1.fetchSessionDiffTool,
+            ...(0, tools_1.textViewToolsForModel)(this.selectedModel),
+        ];
+        return {
+            custom,
+            builtInTextEditor: (0, tools_1.hasBuiltInTextEditor)(this.selectedModel),
+        };
     }
-    async buildSystemPrompt() {
+    getResult() {
+        const messages = this.messages || [];
+        const lastMessage = messages.length
+            ? messages[messages.length - 1]
+            : undefined;
+        const lastMessageTextPart = lastMessage
+            ? lastMessage.parts
+                .filter((p) => "text" in p)
+                .find((p) => "text" in p && !!p.text)
+            : undefined;
+        const textPart = lastMessageTextPart;
+        const text = textPart?.text.trim();
+        if (!text) {
+            return undefined;
+        }
+        return (0, parser_1.convertXmlToV2Format)(text);
+    }
+    async buildSystemPrompt(repoContext) {
         return `
 You are an expert code reviewer that specializes in reviewing Playwright test code. You are
-provided with tools to fetch diff for a code review, where a test has been added, test modified,
+provided with tools to fetch diff and pull-request metadata for a code review, where a test has been added, test modified,
 or some configuration has changed.
 
 # Your goals
-- Identify code smells in test code - see below
-- Call out test data assumptions or lack of clean up
+- Understand the purpose and scope of the code change. You can use available tools to gather context of the change.
+- Identify critical issues that must be fixed before the code can be safely merged.
+- Detect code smells, anti-patterns, and non-deterministic behaviors that reduce test reliability - see below.
+- Call out test data assumptions or lack of clean up.
+- Suggest improvements and best practices to enhance maintainability and readability.
+- Form a definite conclusion on whether the code can be merged or not.
+- Share your findings and conclusion in the structured format shared below
 
 # Output format
-- You are expected to return two sections in your response: describe_code_change and code_review_comments
-- describe_code_change: A brief summary of what the code change is doing. This should be 4-6 sentences in a bullet list.
-- code_review_comments: A bulleted list of code review comments that catch for any of the specific bits below or other
-  red flags you might see in the code. Each comment should be 1-2 sentences.
+- You are expected to return the following sections in your response: last_commit, describe_code_change, line_comments, verdict and version
+- The last commit comes from the session diff tool call along with pull request metadata -- reproduce the commit sha as it is, without any additions (ignore the last commit timestamp) or bullet points
+- describe_code_change: A brief summary of what the code change is doing. This should be 4-6 sentences in a bullet list, formatted in markdown where each bullet must begin with a hyphen followed by a space (- ). 
+  Do not use any other character for bullets.
+- line_comments: Individual comments for specific issues found in the code, attributed to one or more lines of problematic code. There can be multiple separate issues for each line, share them using separate comments of varying severity. 
+  Each comment should correspond to one issue and include the following tags:
+  - file: The relative path to the file from repository root
+  - line-start: Starting line number of the issue
+  - line-end: Ending line number of the issue (same as line-start for if issue is in a single line of code)
+  - severity: Either "merge-blocking" or "warning". It is possible to have multiple issues in the same set of lines of either nature, in that case add multiple line_comments for those lines. 
+    Here severity denotes the nature of the issue - any issue that is preventing the code from being safe to merge and should be considered high priority is "merge-blocking". Look for any of the specific
+    bits below or other red flags you might see in the code. Each comment should be 1-2 sentences. If no blocking issues are found, a review will have no "merge-blocking" line comments.
+    Alternatively, the severity should be "warning" for situations where best practices were not followed or contain minor issues or warnings that can be safely ignored ie 
+  - message: 1-2 sentences describing the specific issue and suggested fixes or improvements.
+- verdict: "Approved" if code can be merged to production ie there are no "merge-blocking" line-comments or "Rejected" if the issues cannot be safely ignored. "Approved" or
+  "Rejected" are the only two possible values for this field.
 
 Return these as XML tags with markdown inside them
 
+<last_commit>
+...
+</last_commit>
+
 <describe_code_change>
-- ...
+...
 </describe_code_change>
 
-<code_review_comments>
-- ...
-</code_review_comments>
+<line_comments>
+  <comment>
+    <file>..</file>
+    <line-start>..</line-start>
+    <line-end>..</line-end>
+    <severity>..</severity>
+    <message>..</message>
+  </comment>
+  
+  <comment>
+    <file>..</file>
+    <line-start>..</line-start>
+    <line-end>..</line-end>
+    <severity>..</severity>
+    <message>..</message>
+  </comment>
+</line_comments>
+
+<verdict>
+...
+</verdict>
 
-# Specific bits to catch in the code review
+# Severity: Merge blocking
 
-## Code smells to look for
-- Any form of try-catch or exception handling is a code smell in test code. If there's an
+## Functionality regression
+- If the change is modifying an existing test, we need to ensure the functionality of the original test
+  is maintained in the new version. No hacking our way to get a green test!
+
+## Exception handling
+  - Any form of try-catch or exception handling is a code smell in test code. If there's an
   exception, the test should fail
-- Any conditionals (if, switch, ternary) in test code is a code smell. Tests are expected to be
+
+## Conditionals
+  - Any conditionals (if, switch, ternary) in test code is a code smell. Tests are expected to be
   deterministic. If you see conditionals, check if there's a comment explaining why it's needed.
   Critically review the comment -- if it's not convincing, call it out as a code smell.
 
-## Ensure Playwright best practices
+## Playwright common mistakes
+- Don't use waitForLoadState or networkidle - these are not required since Playwright auto-waits after navigations. networkidle
+  can cause failures because modern web apps often have background network activity, which never settles.
 - Use locators instead of selectors: waitForSelector, $, $$ are bad - use locators instead (e.g. locator.waitFor)
 - If the test relies on some Playwright APIs that do not auto-wait (e.g. isVisible(), count()), we need to ensure 
   they are used AFTER some action that ensures the page has loaded. If nothing, at least it should have a waitForTimeout
-- Don't use waitForLoadState or networkidle - these are not required since Playwright auto-waits after navigations
+
+## Deprecated patterns
+- test.describe.serial(...) is not prefered: use test.describe.configure({ mode: "serial" }) if the tests need to be serial
+
+## Repo conventions
+- Tests are located in files in the tests/ directory (e.g. in tests/example.spec.ts)
+- Helper methods (that are imported in the tests) should be in pages/ directory (e.g. pages/common.ts)
+- Helper methods should be functional - not classes (conventional class-based page object models are NOT recommended - use functions!)
+
+## Common mistakes
+- Our author has a tendency to add newline characters to console logs (e.g \`console.log("\ngoing to page foo");\` ) - this should not be allowed
+
+# Severity: Warning
 
 ## Call out test data assumptions
 - If new test data is created (e.g. creating a new entity in the app, doing some actions on it) - it should be cleaned up
@@ -58,7 +146,16 @@ Return these as XML tags with markdown inside them
 - Dependency on static data that can change across environments (e.g. number of rows in a table) should be avoided.
 
 ## Remove debug artifacts
-- If there are console.logs or page.screenshot usage, call it out. They should be removed before merging.
+- If there are console.logs or page.screenshot usage, call it out.
+
+## Extra waits
+- Wait for timeout for static values are bad, but sometimes needed. Some apps are flaky and need additional waiting.
+
+## Element locators
+- CSS selectors can be brittle - prefer user facing selectors like getByRole, getByText
+
+# Repo context
+${repoContext}
 `;
     }
 }

package/dist/agent/code-review/parser.d.ts

@@ -0,0 +1,5 @@
+import { type CodeReviewResultV2 } from "./types";
+export type { CodeReviewLineComment, CodeReviewResultV0, CodeReviewResultV1, CodeReviewResultV2, } from "./types";
+export { CodeReviewSeverity, CodeReviewVerdict } from "./types";
+export declare function convertXmlToV2Format(output: string): CodeReviewResultV2;
+//# sourceMappingURL=parser.d.ts.map

package/dist/agent/code-review/parser.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"parser.d.ts","sourceRoot":"","sources":["../../../src/agent/code-review/parser.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,kBAAkB,EAGxB,MAAM,SAAS,CAAC;AAEjB,YAAY,EACV,qBAAqB,EACrB,kBAAkB,EAClB,kBAAkB,EAClB,kBAAkB,GACnB,MAAM,SAAS,CAAC;AAEjB,OAAO,EAAE,kBAAkB,EAAE,iBAAiB,EAAE,MAAM,SAAS,CAAC;AAchE,wBAAgB,oBAAoB,CAAC,MAAM,EAAE,MAAM,GAAG,kBAAkB,CAmFvE"}

package/dist/agent/code-review/parser.js

@@ -0,0 +1,70 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CodeReviewVerdict = exports.CodeReviewSeverity = void 0;
+exports.convertXmlToV2Format = convertXmlToV2Format;
+const types_1 = require("./types");
+var types_2 = require("./types");
+Object.defineProperty(exports, "CodeReviewSeverity", { enumerable: true, get: function () { return types_2.CodeReviewSeverity; } });
+Object.defineProperty(exports, "CodeReviewVerdict", { enumerable: true, get: function () { return types_2.CodeReviewVerdict; } });
+function inferVerdictFromCommentsV2(lineComments) {
+    const hasMergeBlockingIssues = lineComments.some((comment) => comment.severity === types_1.CodeReviewSeverity.MergeBlocking);
+    return hasMergeBlockingIssues
+        ? types_1.CodeReviewVerdict.Rejected
+        : types_1.CodeReviewVerdict.Approved;
+}
+function convertXmlToV2Format(output) {
+    const lastCommitMatch = output.match(/<last_commit>([\s\S]*?)<\/last_commit>/i);
+    const codeChangeMatch = output.match(/<describe_code_change>([\s\S]*?)<\/describe_code_change>/i);
+    const verdictMatch = output.match(/<verdict>([\s\S]*?)<\/verdict>/i);
+    const lineComments = [];
+    const lineCommentsMatch = output.match(/<line_comments>([\s\S]*?)<\/line_comments>/i);
+    if (lineCommentsMatch) {
+        const commentsContent = lineCommentsMatch[1];
+        const commentMatches = commentsContent.match(/<comment>([\s\S]*?)<\/comment>/gi);
+        if (commentMatches) {
+            for (const commentMatch of commentMatches) {
+                const fileMatch = commentMatch.match(/<file>([\s\S]*?)<\/file>/i);
+                const lineStartMatch = commentMatch.match(/<line-start>([\s\S]*?)<\/line-start>/i);
+                const lineEndMatch = commentMatch.match(/<line-end>([\s\S]*?)<\/line-end>/i);
+                const severityMatch = commentMatch.match(/<severity>([\s\S]*?)<\/severity>/i);
+                const messageMatch = commentMatch.match(/<message>([\s\S]*?)<\/message>/i);
+                if (fileMatch &&
+                    lineStartMatch &&
+                    lineEndMatch &&
+                    severityMatch &&
+                    messageMatch) {
+                    const severityText = severityMatch[1].trim();
+                    const severity = severityText === "merge-blocking"
+                        ? types_1.CodeReviewSeverity.MergeBlocking
+                        : severityText === "warning"
+                            ? types_1.CodeReviewSeverity.Warning
+                            : null;
+                    if (severity !== null) {
+                        lineComments.push({
+                            file: fileMatch[1].trim(),
+                            line_start: parseInt(lineStartMatch[1].trim(), 10),
+                            line_end: parseInt(lineEndMatch[1].trim(), 10),
+                            severity: severity,
+                            message: messageMatch[1].trim(),
+                        });
+                    }
+                }
+            }
+        }
+    }
+    const lastCommit = lastCommitMatch[1].trim();
+    const describeCodeChange = codeChangeMatch[1].trim();
+    const verdict = verdictMatch?.[1]?.trim();
+    const finalVerdict = verdict
+        ? verdict === types_1.CodeReviewVerdict.Approved
+            ? types_1.CodeReviewVerdict.Approved
+            : types_1.CodeReviewVerdict.Rejected
+        : inferVerdictFromCommentsV2(lineComments);
+    return {
+        version: "2.0",
+        last_commit: lastCommit,
+        describe_code_change: describeCodeChange,
+        line_comments: lineComments,
+        verdict: finalVerdict,
+    };
+}

package/dist/agent/code-review/types.d.ts

@@ -0,0 +1,36 @@
+export declare enum CodeReviewVerdict {
+    Approved = "Approved",
+    Rejected = "Rejected"
+}
+export declare enum CodeReviewSeverity {
+    MergeBlocking = "merge-blocking",
+    Warning = "warning"
+}
+export type CodeReviewLineComment = {
+    file: string;
+    line_start: number;
+    line_end: number;
+    severity: CodeReviewSeverity;
+    message: string;
+};
+export type CodeReviewResultV2 = {
+    version: "2.0";
+    last_commit: string;
+    describe_code_change: string;
+    line_comments: CodeReviewLineComment[];
+    verdict: CodeReviewVerdict;
+};
+export type CodeReviewResultV1 = {
+    version: "1.0";
+    last_commit: string | null;
+    code_review_comments: string | null;
+    describe_code_change: string | null;
+    merge_blocking_issues: string | null;
+    best_practices_and_warnings: string | null;
+    verdict: "Approved" | "Rejected" | null;
+};
+export type CodeReviewResultV0 = {
+    version: "0.1";
+    result: string;
+};
+//# sourceMappingURL=types.d.ts.map

package/dist/agent/code-review/types.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"types.d.ts","sourceRoot":"","sources":["../../../src/agent/code-review/types.ts"],"names":[],"mappings":"AAAA,oBAAY,iBAAiB;IAC3B,QAAQ,aAAa;IACrB,QAAQ,aAAa;CACtB;AAED,oBAAY,kBAAkB;IAC5B,aAAa,mBAAmB;IAChC,OAAO,YAAY;CACpB;AAED,MAAM,MAAM,qBAAqB,GAAG;IAClC,IAAI,EAAE,MAAM,CAAC;IACb,UAAU,EAAE,MAAM,CAAC;IACnB,QAAQ,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,kBAAkB,CAAC;IAC7B,OAAO,EAAE,MAAM,CAAC;CACjB,CAAC;AAEF,MAAM,MAAM,kBAAkB,GAAG;IAC/B,OAAO,EAAE,KAAK,CAAC;IACf,WAAW,EAAE,MAAM,CAAC;IACpB,oBAAoB,EAAE,MAAM,CAAC;IAC7B,aAAa,EAAE,qBAAqB,EAAE,CAAC;IACvC,OAAO,EAAE,iBAAiB,CAAC;CAC5B,CAAC;AAEF,MAAM,MAAM,kBAAkB,GAAG;IAC/B,OAAO,EAAE,KAAK,CAAC;IACf,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,oBAAoB,EAAE,MAAM,GAAG,IAAI,CAAC;IACpC,oBAAoB,EAAE,MAAM,GAAG,IAAI,CAAC;IACpC,qBAAqB,EAAE,MAAM,GAAG,IAAI,CAAC;IACrC,2BAA2B,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3C,OAAO,EAAE,UAAU,GAAG,UAAU,GAAG,IAAI,CAAC;CACzC,CAAC;AAEF,MAAM,MAAM,kBAAkB,GAAG;IAC/B,OAAO,EAAE,KAAK,CAAC;IAEf,MAAM,EAAE,MAAM,CAAC;CAChB,CAAC"}

package/dist/agent/code-review/types.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CodeReviewSeverity = exports.CodeReviewVerdict = void 0;
+var CodeReviewVerdict;
+(function (CodeReviewVerdict) {
+    CodeReviewVerdict["Approved"] = "Approved";
+    CodeReviewVerdict["Rejected"] = "Rejected";
+})(CodeReviewVerdict || (exports.CodeReviewVerdict = CodeReviewVerdict = {}));
+var CodeReviewSeverity;
+(function (CodeReviewSeverity) {
+    CodeReviewSeverity["MergeBlocking"] = "merge-blocking";
+    CodeReviewSeverity["Warning"] = "warning";
+})(CodeReviewSeverity || (exports.CodeReviewSeverity = CodeReviewSeverity = {}));

package/dist/agent/cua/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../src/agent/cua/index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAiB,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAC/D,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,MAAM,4BAA4B,CAAC;AAStE,OAAO,EAAE,IAAI,EAAE,MAAM,YAAY,CAAC;AAmClC,MAAM,MAAM,kBAAkB,GAAG,KAAK,CAClC;IACE,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;CACd,GACD;IACE,IAAI,EAAE,YAAY,CAAC;IACnB,UAAU,EAAE,iBAAiB,CAAC;CAC/B,CACJ,CAAC;AAEF,wBAAsB,+BAA+B,CAAC,EACpD,IAAI,EACJ,IAAI,EACJ,KAAK,EACL,8BAAsC,GACvC,EAAE;IACD,IAAI,EAAE,IAAI,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,CAAC,EAAE,WAAW,CAAC;IACpB,8BAA8B,CAAC,EAAE,OAAO,CAAC;CAC1C,GAAG,OAAO,CAAC;IACV,IAAI,EAAE,MAAM,CAAC;IACb,WAAW,EAAE,MAAM,EAAE,CAAC;IACtB,MAAM,EAAE,kBAAkB,CAAC;IAC3B,KAAK,EAAE,KAAK,CAAC;CACd,CAAC,CAuND"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../src/agent/cua/index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAiB,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAC/D,OAAO,EAAE,iBAAiB,EAAE,KAAK,EAAE,MAAM,4BAA4B,CAAC;AAStE,OAAO,EAAE,IAAI,EAAE,MAAM,YAAY,CAAC;AAoDlC,MAAM,MAAM,kBAAkB,GAAG,KAAK,CAClC;IACE,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;CACd,GACD;IACE,IAAI,EAAE,YAAY,CAAC;IACnB,UAAU,EAAE,iBAAiB,CAAC;CAC/B,CACJ,CAAC;AAEF,wBAAsB,+BAA+B,CAAC,EACpD,IAAI,EACJ,IAAI,EACJ,KAAK,EACL,8BAAsC,GACvC,EAAE;IACD,IAAI,EAAE,IAAI,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,CAAC,EAAE,WAAW,CAAC;IACpB,8BAA8B,CAAC,EAAE,OAAO,CAAC;CAC1C,GAAG,OAAO,CAAC;IACV,IAAI,EAAE,MAAM,CAAC;IACb,WAAW,EAAE,MAAM,EAAE,CAAC;IACtB,MAAM,EAAE,kBAAkB,CAAC;IAC3B,KAAK,EAAE,KAAK,CAAC;CACd,CAAC,CAuND"}