@empiricalrun/test-gen 0.38.7 → 0.38.8

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @empiricalrun/test-gen
 
+## 0.38.8
+
+### Patch Changes
+
+- deb93bd: fix: scroll while annotating
+
 ## 0.38.7
 
 ### Patch Changes

package/browser-injected-scripts/annotate-elements.js

@@ -24,6 +24,8 @@ function annotateClickableElements(options = {}) {
   // Check if the element is not blocked and visible for clicking
   function isElementClickNotBlocked(element, windowToAnnotate) {
     const rect = element.getBoundingClientRect();
+    const originalScrollX = windowToAnnotate.scrollX;
+    const originalScrollY = windowToAnnotate.scrollY;
 
     // Calculate the center point of the element
     const centerX = rect.left + rect.width / 2;
@@ -56,7 +58,12 @@ function annotateClickableElements(options = {}) {
       const newCenterX = newRect.left + newRect.width / 2;
       const newCenterY = newRect.top + newRect.height / 2;
       const topElement = document.elementFromPoint(newCenterX, newCenterY);
-      return element.contains(topElement);
+      const doesElementContainTopElement = element.contains(topElement);
+
+
+      // Restore the original scroll positions
+      windowToAnnotate.scrollTo(originalScrollX, originalScrollY);
+      return doesElementContainTopElement;
     }
 
     const topElement = windowToAnnotate.document.elementFromPoint(centerX, centerY);
@@ -369,7 +376,9 @@ function annotateClickableElements(options = {}) {
   
     // Filter for clickable elements
     const clickableElements = Array.from(windowToAnnotate.document.querySelectorAll("*")).filter((el) => {
-      return isElementClickable(el) && isElementClickNotBlocked(el, windowToAnnotate);
+      const isClickable = isElementClickable(el);
+      const isClickNotBlocked = isElementClickNotBlocked(el, windowToAnnotate);
+      return isClickable && isClickNotBlocked;
     });  
     // Generate hint strings for the clickable elements
     const hints = generateHintStrings(hintCharacterSet, Math.min(maxHints, clickableElements.length));

package/dist/browser-injected-scripts/annotate-elements.js

@@ -24,6 +24,8 @@ function annotateClickableElements(options = {}) {
   // Check if the element is not blocked and visible for clicking
   function isElementClickNotBlocked(element, windowToAnnotate) {
     const rect = element.getBoundingClientRect();
+    const originalScrollX = windowToAnnotate.scrollX;
+    const originalScrollY = windowToAnnotate.scrollY;
 
     // Calculate the center point of the element
     const centerX = rect.left + rect.width / 2;
@@ -56,7 +58,12 @@ function annotateClickableElements(options = {}) {
       const newCenterX = newRect.left + newRect.width / 2;
       const newCenterY = newRect.top + newRect.height / 2;
       const topElement = document.elementFromPoint(newCenterX, newCenterY);
-      return element.contains(topElement);
+      const doesElementContainTopElement = element.contains(topElement);
+
+
+      // Restore the original scroll positions
+      windowToAnnotate.scrollTo(originalScrollX, originalScrollY);
+      return doesElementContainTopElement;
     }
 
     const topElement = windowToAnnotate.document.elementFromPoint(centerX, centerY);
@@ -369,7 +376,9 @@ function annotateClickableElements(options = {}) {
   
     // Filter for clickable elements
     const clickableElements = Array.from(windowToAnnotate.document.querySelectorAll("*")).filter((el) => {
-      return isElementClickable(el) && isElementClickNotBlocked(el, windowToAnnotate);
+      const isClickable = isElementClickable(el);
+      const isClickNotBlocked = isElementClickNotBlocked(el, windowToAnnotate);
+      return isClickable && isClickNotBlocked;
     });  
     // Generate hint strings for the clickable elements
     const hints = generateHintStrings(hintCharacterSet, Math.min(maxHints, clickableElements.length));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@empiricalrun/test-gen",
-  "version": "0.38.7",
+  "version": "0.38.8",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/",
     "access": "public"