@empiricalrun/playwright-utils 0.50.1 → 0.51.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @empiricalrun/playwright-utils
 
+## 0.51.0
+
+### Minor Changes
+
+- 7584f64: fix: incremental blob reporter does not kill process group
+
 ## 0.50.1
 
 ### Patch Changes

package/dist/reporter/harness.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"harness.d.ts","sourceRoot":"","sources":["../../src/reporter/harness.ts"],"names":[],"mappings":"AAgBA,MAAM,WAAW,cAAc;IAC7B,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,MAAM,CAAC;CACjB;AAED,wBAAsB,KAAK,CAAC,EAAE,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAErD;AAED;;;GAGG;AACH,wBAAsB,YAAY,CAAC,KAAK,EAAE,MAAM,GAAG,OAAO,CAAC;IACzD,GAAG,EAAE,cAAc,CAAC;IACpB,OAAO,EAAE,MAAM,OAAO,CAAC,IAAI,CAAC,CAAC;CAC9B,CAAC,CA2BD;AAED;;GAEG;AACH,wBAAsB,kBAAkB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,IAAI,CAAC,CAI3E;AAED,MAAM,WAAW,SAAS;IACxB,MAAM,EAAE,MAAM,CAAC;IACf,MAAM,EAAE,MAAM,CAAC;CAChB;AAED,MAAM,MAAM,OAAO,GAAG,cAAc,GAAG,cAAc,CAAC;AAOtD;;;;;GAKG;AACH,wBAAsB,uBAAuB,CAC3C,GAAG,EAAE,cAAc,EACnB,IAAI,EAAE;IAAE,OAAO,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,OAAO,CAAA;CAAE,GAC1C,OAAO,CAAC,SAAS,CAAC,CAoDpB;AAED,MAAM,WAAW,SAAS;IACxB,MAAM,EAAE,MAAM,CAAC;IACf,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;CAClC;AAED;;GAEG;AACH,wBAAsB,cAAc,CAClC,GAAG,EAAE,cAAc,GAClB,OAAO,CAAC,SAAS,EAAE,CAAC,CAUtB"}
+{"version":3,"file":"harness.d.ts","sourceRoot":"","sources":["../../src/reporter/harness.ts"],"names":[],"mappings":"AAgBA,MAAM,WAAW,cAAc;IAC7B,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,MAAM,CAAC;CACjB;AAED,wBAAsB,KAAK,CAAC,EAAE,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAErD;AAED;;;GAGG;AACH,wBAAsB,YAAY,CAAC,KAAK,EAAE,MAAM,GAAG,OAAO,CAAC;IACzD,GAAG,EAAE,cAAc,CAAC;IACpB,OAAO,EAAE,MAAM,OAAO,CAAC,IAAI,CAAC,CAAC;CAC9B,CAAC,CA2BD;AAED;;GAEG;AACH,wBAAsB,kBAAkB,CAAC,GAAG,EAAE,cAAc,GAAG,OAAO,CAAC,IAAI,CAAC,CAI3E;AAED,MAAM,WAAW,SAAS;IACxB,MAAM,EAAE,MAAM,CAAC;IACf,MAAM,EAAE,MAAM,CAAC;CAChB;AAED,MAAM,MAAM,OAAO,GAAG,cAAc,GAAG,cAAc,CAAC;AAOtD;;;;;GAKG;AACH,wBAAsB,uBAAuB,CAC3C,GAAG,EAAE,cAAc,EACnB,IAAI,EAAE;IAAE,OAAO,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,OAAO,CAAA;CAAE,GAC1C,OAAO,CAAC,SAAS,CAAC,CAiDpB;AAED,MAAM,WAAW,SAAS;IACxB,MAAM,EAAE,MAAM,CAAC;IACf,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;CAClC;AAED;;GAEG;AACH,wBAAsB,cAAc,CAClC,GAAG,EAAE,cAAc,GAClB,OAAO,CAAC,SAAS,EAAE,CAAC,CAUtB"}

package/dist/reporter/harness.js

@@ -75,9 +75,6 @@ async function runPlaywrightWithSigint(ctx, opts) {
             TOTAL_SHARDS: "1",
         },
         stdio: ["pipe", "pipe", "pipe"],
-        // Must match production: detached creates a new process group so the
-        // reporter's SIGKILL on -process.pid only kills browsers + Playwright,
-        // not the test runner.
         detached: true,
     });
     let stdout = "";

package/dist/reporter/incremental-blob-reporter.d.ts

@@ -19,18 +19,19 @@ declare class IncrementalBlobReporter implements Reporter {
     private _resultIdMap;
     private _stepIdMap;
     private _uploader;
-    private _flushPromise;
     private _completedTestIds;
     private _completedResultIds;
     private _testRetries;
     private _testResults;
     private _startTime;
+    private _finalizePromise;
     constructor();
     private _sigintHandler;
     private _setupSignalHandler;
     private _removeSignalHandler;
-    private _flushAndUpload;
-    private _finalizeReportForInterrupt;
+    private _buildSyntheticResult;
+    private _finalizeAndMaybeUpload;
+    private _finalizeReport;
     private _computeCompletedSets;
     private _removeIncompleteTestArtifacts;
     private _patchProjectSuites;

package/dist/reporter/incremental-blob-reporter.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"incremental-blob-reporter.d.ts","sourceRoot":"","sources":["../../src/reporter/incremental-blob-reporter.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EACV,UAAU,EACV,UAAU,EACV,QAAQ,EACR,KAAK,EACL,QAAQ,EACR,UAAU,EACV,QAAQ,EACT,MAAM,2BAA2B,CAAC;AAuBnC;;;;;;;GAOG;AACH,MAAM,MAAM,gBAAgB,GAAG,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;AAEnD,cAAM,uBAAwB,YAAW,QAAQ;IAC/C,OAAO,CAAC,kBAAkB,CAAyB;IACnD,OAAO,CAAC,WAAW,CAIjB;IACF,OAAO,CAAC,UAAU,CAGhB;IACF,OAAO,CAAC,WAAW,CAAS;IAC5B,OAAO,CAAC,YAAY,CAAS;IAC7B,OAAO,CAAC,YAAY,CAAgB;IACpC,OAAO,CAAC,iBAAiB,CAA+B;IACxD,OAAO,CAAC,YAAY,CAAkC;IACtD,OAAO,CAAC,UAAU,CAAoC;IACtD,OAAO,CAAC,SAAS,CAAyB;IAC1C,OAAO,CAAC,aAAa,CAA8B;IACnD,OAAO,CAAC,iBAAiB,CAA0B;IACnD,OAAO,CAAC,mBAAmB,CAA0B;IACrD,OAAO,CAAC,YAAY,CAAkC;IACtD,OAAO,CAAC,YAAY,CAGN;IACd,OAAO,CAAC,UAAU,CAAsB;;IAexC,OAAO,CAAC,cAAc,CAA6B;IAEnD,OAAO,CAAC,mBAAmB;IAkC3B,OAAO,CAAC,oBAAoB;YAOd,eAAe;IAwC7B,OAAO,CAAC,2BAA2B;IAyBnC,OAAO,CAAC,qBAAqB;IAY7B,OAAO,CAAC,8BAA8B;IAStC,OAAO,CAAC,mBAAmB;IAkB3B,OAAO,KAAK,QAAQ,GAKnB;IAED,OAAO,KAAK,UAAU,GAErB;IAED,OAAO,KAAK,aAAa,GAExB;IAED,OAAO,CAAC,WAAW;IAKnB,OAAO,CAAC,YAAY;IAMpB,OAAO,CAAC,aAAa;YAUP,SAAS;IAwBvB,OAAO,CAAC,MAAM,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,GAAG,IAAI;IAgB/C,WAAW,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU,GAAG,IAAI;IAIrD,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU,GAAG,IAAI;IAyBnD,WAAW,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,QAAQ,GAAG,IAAI;IAYrE,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,QAAQ,GAAG,IAAI;IAY7D,KAAK,CAAC,MAAM,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;IAiB9C;;OAEG;IACH,gBAAgB,CAAC,SAAS,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,IAAI;IAI5D,aAAa,IAAI,OAAO;CAGzB;AAID,wBAAgB,0BAA0B,IAAI,uBAAuB,GAAG,IAAI,CAE3E;AAED,wBAAgB,kCAAkC,CAChD,QAAQ,EAAE,uBAAuB,GAChC,IAAI,CAEN;AAED,eAAe,uBAAuB,CAAC"}
+{"version":3,"file":"incremental-blob-reporter.d.ts","sourceRoot":"","sources":["../../src/reporter/incremental-blob-reporter.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EACV,UAAU,EACV,UAAU,EACV,QAAQ,EACR,KAAK,EACL,QAAQ,EACR,UAAU,EACV,QAAQ,EACT,MAAM,2BAA2B,CAAC;AAuBnC;;;;;;;GAOG;AACH,MAAM,MAAM,gBAAgB,GAAG,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;AAEnD,cAAM,uBAAwB,YAAW,QAAQ;IAC/C,OAAO,CAAC,kBAAkB,CAAyB;IACnD,OAAO,CAAC,WAAW,CAIjB;IACF,OAAO,CAAC,UAAU,CAGhB;IACF,OAAO,CAAC,WAAW,CAAS;IAC5B,OAAO,CAAC,YAAY,CAAS;IAC7B,OAAO,CAAC,YAAY,CAAgB;IACpC,OAAO,CAAC,iBAAiB,CAA+B;IACxD,OAAO,CAAC,YAAY,CAAkC;IACtD,OAAO,CAAC,UAAU,CAAoC;IACtD,OAAO,CAAC,SAAS,CAAyB;IAC1C,OAAO,CAAC,iBAAiB,CAA0B;IACnD,OAAO,CAAC,mBAAmB,CAA0B;IACrD,OAAO,CAAC,YAAY,CAAkC;IACtD,OAAO,CAAC,YAAY,CAGN;IACd,OAAO,CAAC,UAAU,CAAsB;IACxC,OAAO,CAAC,gBAAgB,CAA8B;;IAetD,OAAO,CAAC,cAAc,CAA6B;IAEnD,OAAO,CAAC,mBAAmB;IA+B3B,OAAO,CAAC,oBAAoB;IAO5B,OAAO,CAAC,qBAAqB;YASf,uBAAuB;IAqErC,OAAO,CAAC,eAAe;IAoBvB,OAAO,CAAC,qBAAqB;IAY7B,OAAO,CAAC,8BAA8B;IAStC,OAAO,CAAC,mBAAmB;IAkB3B,OAAO,KAAK,QAAQ,GAKnB;IAED,OAAO,KAAK,UAAU,GAErB;IAED,OAAO,KAAK,aAAa,GAExB;IAED,OAAO,CAAC,WAAW;IAKnB,OAAO,CAAC,YAAY;IAMpB,OAAO,CAAC,aAAa;YAUP,SAAS;IAwBvB,OAAO,CAAC,MAAM,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,GAAG,IAAI;IAgB/C,WAAW,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU,GAAG,IAAI;IAIrD,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU,GAAG,IAAI;IAyBnD,WAAW,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,QAAQ,GAAG,IAAI;IAYrE,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,QAAQ,GAAG,IAAI;IAY7D,KAAK,CAAC,MAAM,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;IAwB9C;;OAEG;IACH,gBAAgB,CAAC,SAAS,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,IAAI;IAI5D,aAAa,IAAI,OAAO;CAGzB;AAID,wBAAgB,0BAA0B,IAAI,uBAAuB,GAAG,IAAI,CAE3E;AAED,wBAAgB,kCAAkC,CAChD,QAAQ,EAAE,uBAAuB,GAChC,IAAI,CAEN;AAED,eAAe,uBAAuB,CAAC"}

package/dist/reporter/incremental-blob-reporter.js

@@ -25,12 +25,12 @@ class IncrementalBlobReporter {
     _resultIdMap = new Map(); // testId+retry -> resultId
     _stepIdMap = new Map(); // step -> stepId
     _uploader = null;
-    _flushPromise = null;
     _completedTestIds = new Set();
     _completedResultIds = new Set();
     _testRetries = new Map(); // testId → configured retries
     _testResults = new Map(); // testId → retryIndex → {resultId, status, expectedStatus}
     _startTime = Date.now();
+    _finalizePromise = null;
     constructor() {
         if (process.env.SHARD_INDEX && process.env.TOTAL_SHARDS) {
             this._shardIndex = Number.parseInt(process.env.SHARD_INDEX, 10);
@@ -47,28 +47,25 @@ class IncrementalBlobReporter {
     _sigintHandler = null;
     _setupSignalHandler() {
         this._sigintHandler = () => {
-            if ((0, reporter_state_1.isFinalized)())
+            if (this._finalizePromise || (0, reporter_state_1.isFinalized)()) {
                 return;
-            console.log("[IncrementalBlobReporter] SIGINT received, flushing and uploading...");
-            this._flushPromise = this._flushAndUpload()
+            }
+            console.log("[IncrementalBlobReporter] SIGINT received, finalizing...");
+            this._finalizePromise = this._finalizeAndMaybeUpload({
+                result: this._buildSyntheticResult("interrupted"),
+                source: "SIGINT",
+                markGlobalFinalized: true,
+                pruneIncompleteTests: true,
+                upload: true,
+            })
                 .then(() => {
-                console.log("[IncrementalBlobReporter] Flush and upload complete on SIGINT, exiting");
+                console.log("[IncrementalBlobReporter] Finalize and upload complete on SIGINT");
             })
                 .catch((err) => {
-                console.error("[IncrementalBlobReporterFailure] Flush/upload failed on SIGINT:", err);
+                console.error("[IncrementalBlobReporterFailure] Finalize/upload failed on SIGINT:", err);
             })
                 .finally(() => {
                 this._removeSignalHandler();
-                // Kill the entire process group (browsers + self) to avoid
-                // orphaned browser processes writing to test-results/ after exit.
-                // Using process.exit(0) alone only exits the Node process, leaving
-                // browser processes alive which blocks cleanup on worker warm reuse.
-                try {
-                    process.kill(-process.pid, "SIGKILL");
-                }
-                catch {
-                    process.exit(0);
-                }
             });
         };
         process.on("SIGINT", this._sigintHandler);
@@ -79,8 +76,23 @@ class IncrementalBlobReporter {
             this._sigintHandler = null;
         }
     }
-    async _flushAndUpload() {
-        (0, reporter_state_1.setFinalized)();
+    _buildSyntheticResult(status) {
+        const now = Date.now();
+        return {
+            status,
+            startTime: new Date(this._startTime),
+            duration: now - this._startTime,
+        };
+    }
+    async _finalizeAndMaybeUpload({ result, source, markGlobalFinalized, pruneIncompleteTests, upload, }) {
+        const finalizeStart = Date.now();
+        const logFinalizeComplete = () => {
+            const durationMs = Date.now() - finalizeStart;
+            console.log(`[IncrementalBlobReporter] Finalize from ${source} completed in ${durationMs}ms (${(durationMs / 1_000).toFixed(1)}s)`);
+        };
+        if (markGlobalFinalized) {
+            (0, reporter_state_1.setFinalized)();
+        }
         if (!(0, ibr_utils_1.hasValidReport)(this._reportLines)) {
             console.warn("[IncrementalBlobReporterFailure] No onBegin received, skipping upload (nothing to merge)");
             return;
@@ -89,39 +101,37 @@ class IncrementalBlobReporter {
         if (this._uploader) {
             await this._uploader.waitForUploads();
         }
-        this._finalizeReportForInterrupt();
+        this._finalizeReport(result, pruneIncompleteTests);
         await this._writeZip();
+        if (!upload) {
+            logFinalizeComplete();
+            return;
+        }
         if (!this._uploader) {
             console.warn("[IncrementalBlobReporterFailure] No uploader available, skipping upload");
+            logFinalizeComplete();
             return;
         }
         await this._uploader.uploadFile(this._zipPath, `blobs/incremental-report-${this._shardIndex}.zip`);
         await this._uploader.waitForUploads();
-        console.log("[IncrementalBlobReporter] Flush and upload complete on SIGINT");
+        console.log(`[IncrementalBlobReporter] Finalize and upload complete from ${source}`);
         if ((0, ibr_utils_1.isLocalTesting)()) {
             await (0, local_test_1.mergeForLocalTest)(this._currentWorkingDir, this._outputDir);
         }
+        logFinalizeComplete();
     }
-    _finalizeReportForInterrupt() {
-        // Determine which tests are fully complete (passed or all retries finished)
-        this._computeCompletedSets();
-        // Remove unrun tests from onProject suites
-        this._patchProjectSuites();
-        // Remove events (onTestBegin, onStepBegin, etc.) for incomplete tests
-        this._removeIncompleteTestArtifacts();
-        // Push onEnd directly (bypass _appendEvent which checks isFinalized)
-        const now = Date.now();
-        const onEndEvent = {
-            method: "onEnd",
-            params: {
-                result: {
-                    status: "interrupted",
-                    startTime: this._startTime,
-                    duration: now - this._startTime,
-                },
-            },
-        };
-        this._reportLines.push(JSON.stringify(onEndEvent));
+    _finalizeReport(result, pruneIncompleteTests) {
+        if (pruneIncompleteTests) {
+            // Determine which tests are fully complete (passed or all retries finished)
+            this._computeCompletedSets();
+            // Remove unrun tests from onProject suites
+            this._patchProjectSuites();
+            // Remove events (onTestBegin, onStepBegin, etc.) for incomplete tests
+            this._removeIncompleteTestArtifacts();
+        }
+        // Push onEnd directly. SIGINT marks the reporter finalized before this,
+        // so using _appendEvent would drop the synthetic onEnd event.
+        this._reportLines.push(JSON.stringify((0, lifecycle_events_1.buildOnEndEvent)(result)));
     }
     _computeCompletedSets() {
         for (const [testId, results] of this._testResults) {
@@ -233,14 +243,22 @@ class IncrementalBlobReporter {
     }
     async onEnd(result) {
         this._removeSignalHandler();
-        this._appendEvent((0, lifecycle_events_1.buildOnEndEvent)(result));
-        // Wait for SIGINT flush to complete if it was started
-        if (this._flushPromise) {
-            await this._flushPromise;
+        // If SIGINT already started the partial-report finalization, let that
+        // finish instead of appending a second onEnd or racing another zip write.
+        if (this._finalizePromise) {
+            await this._finalizePromise;
+            return;
         }
-        // Final zip write
-        await this._uploader?.waitForUploads();
-        await this._writeZip();
+        this._finalizePromise = this._finalizeAndMaybeUpload({
+            result,
+            source: "onEnd",
+            markGlobalFinalized: false,
+            pruneIncompleteTests: false,
+            // Normal completion already has Playwright's blob/html reporters.
+            // Only the SIGINT path uploads this incremental fallback blob.
+            upload: false,
+        });
+        await this._finalizePromise;
         console.log(`[IncrementalBlobReporter] Finished with status: ${result.status}`);
     }
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@empiricalrun/playwright-utils",
-  "version": "0.50.1",
+  "version": "0.51.0",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/",
     "access": "public"