@empiricalrun/playwright-utils 0.48.3 → 0.48.5

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @empiricalrun/playwright-utils
 
+## 0.48.5
+
+### Patch Changes
+
+- e00de0e: fix: visual assertions attachments should be path-based
+- 448e699: chore: simplify webhook assertions
+
+## 0.48.4
+
+### Patch Changes
+
+- 18aa8e1: chore: simplify webhook assertions
+
 ## 0.48.3
 
 ### Patch Changes

package/dist/overlay-tests/visual.spec.js

@@ -10,7 +10,8 @@ const expect = (0, test_1.extendExpect)(fixtures_1.expect);
     expect(pageAttachment).toBeDefined();
     expect(pageAttachment.name).toBe("toLookRight-L11-a-welcome-page-with-a-heading-and-a-paragraph-of-text");
     expect(pageAttachment.contentType).toBe("image/png");
-    expect(pageAttachment.body.length).toBeGreaterThan(0);
+    expect(pageAttachment.path).toBeDefined();
+    expect(pageAttachment.path).toMatch(/\.png$/);
 });
 (0, fixtures_1.test)("toLookRight on locator attaches screenshot", async ({ page, server, }, testInfo) => {
     await page.goto(`${server.baseURL}/visual-test.html`);
@@ -18,7 +19,8 @@ const expect = (0, test_1.extendExpect)(fixtures_1.expect);
     await expect(heading).toLookRight("A heading that says Welcome to the App");
     const locatorAttachment = testInfo.attachments.find((a) => a.name.startsWith("toLookRight-"));
     expect(locatorAttachment).toBeDefined();
-    expect(locatorAttachment.name).toBe("toLookRight-L31-a-heading-that-says-welcome-to-the-app");
+    expect(locatorAttachment.name).toBe("toLookRight-L32-a-heading-that-says-welcome-to-the-app");
     expect(locatorAttachment.contentType).toBe("image/png");
-    expect(locatorAttachment.body.length).toBeGreaterThan(0);
+    expect(locatorAttachment.path).toBeDefined();
+    expect(locatorAttachment.path).toMatch(/\.png$/);
 });

package/dist/test/expect/visual.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"visual.d.ts","sourceRoot":"","sources":["../../../src/test/expect/visual.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,OAAO,EAAE,IAAI,EAAY,MAAM,kBAAkB,CAAC;AAOhE,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,SAAS,CAAC;AA8D7C,wBAAsB,WAAW,CAC/B,MAAM,EAAE,IAAI,GAAG,OAAO,EACtB,eAAe,EAAE,MAAM,GACtB,OAAO,CAAC,aAAa,CAAC,CA2FxB"}
+{"version":3,"file":"visual.d.ts","sourceRoot":"","sources":["../../../src/test/expect/visual.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,OAAO,EAAE,IAAI,EAAY,MAAM,kBAAkB,CAAC;AAUhE,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,SAAS,CAAC;AAsE7C,wBAAsB,WAAW,CAC/B,MAAM,EAAE,IAAI,GAAG,OAAO,EACtB,eAAe,EAAE,MAAM,GACtB,OAAO,CAAC,aAAa,CAAC,CA2FxB"}

package/dist/test/expect/visual.js

@@ -1,8 +1,14 @@
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.toLookRight = toLookRight;
 const llm_1 = require("@empiricalrun/llm");
 const vision_1 = require("@empiricalrun/llm/vision");
+const fs_1 = __importDefault(require("fs"));
+const os_1 = __importDefault(require("os"));
+const path_1 = __importDefault(require("path"));
 const telemetry_1 = require("../../telemetry");
 const mouse_pointer_1 = require("../scripts/mouse-pointer");
 function getCallerLine() {
@@ -29,8 +35,13 @@ function attachScreenshot(screenshot, pageDescription) {
             .replace(/[^a-z0-9]+/g, "-")
             .replace(/(^-|-$)/g, "");
         const line = getCallerLine();
-        testInfo.attach(`toLookRight-L${line}-${slug}`, {
-            body: screenshot,
+        const attachmentName = `toLookRight-L${line}-${slug}`;
+        // Write to a temp file so the attachment has a path (required by empirical reporter).
+        // Playwright copies it into test-results/<test>/attachments/ on attach.
+        const tmpFile = path_1.default.join(os_1.default.tmpdir(), `${attachmentName}-${Date.now()}.png`);
+        fs_1.default.writeFileSync(tmpFile, screenshot);
+        testInfo.attach(attachmentName, {
+            path: tmpFile,
             contentType: "image/png",
         });
     }

package/dist/webhook.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"webhook.d.ts","sourceRoot":"","sources":["../src/webhook.ts"],"names":[],"mappings":"AAEA,MAAM,MAAM,cAAc,GAAG;IAC3B,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC,CAAC;IAClC,GAAG,EAAE,MAAM,CAAC;IACZ,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,GAAG,IAAI,CAAC;IACrC,EAAE,EAAE,MAAM,CAAC;IACX,QAAQ,EAAE,MAAM,CAAC;IACjB,UAAU,EAAE,MAAM,CAAC;IACnB,IAAI,EAAE,MAAM,CAAC;IACb,UAAU,EAAE,MAAM,CAAC;IACnB,UAAU,EAAE,MAAM,CAAC;CACpB,CAAC;AAEF,KAAK,eAAe,GAAG,OAAO,GAAG,cAAc,CAAC;AA0ShD,wBAAsB,aAAa,CACjC,OAAO,GAAE;IAAE,MAAM,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,QAAQ,CAAC,EAAE,eAAe,CAAA;CAAO,GACnE,OAAO,CAAC,MAAM,CAAC,CAMjB;AAED,wBAAsB,oBAAoB,CACxC,UAAU,EAAE,MAAM,EAClB,OAAO,EAAE,MAAM,GAAG,MAAM,EAAE,GACzB,OAAO,CAAC,cAAc,EAAE,CAAC,CAO3B"}
+{"version":3,"file":"webhook.d.ts","sourceRoot":"","sources":["../src/webhook.ts"],"names":[],"mappings":"AAEA,MAAM,MAAM,cAAc,GAAG;IAC3B,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC,CAAC;IAClC,GAAG,EAAE,MAAM,CAAC;IACZ,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,GAAG,IAAI,CAAC;IACrC,EAAE,EAAE,MAAM,CAAC;IACX,QAAQ,EAAE,MAAM,CAAC;IACjB,UAAU,EAAE,MAAM,CAAC;IACnB,IAAI,EAAE,MAAM,CAAC;IACb,UAAU,EAAE,MAAM,CAAC;IACnB,UAAU,EAAE,MAAM,CAAC;CACpB,CAAC;AAEF,KAAK,eAAe,GAAG,OAAO,GAAG,cAAc,CAAC;AAyQhD,wBAAsB,aAAa,CACjC,OAAO,GAAE;IAAE,MAAM,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,QAAQ,CAAC,EAAE,eAAe,CAAA;CAAO,GACnE,OAAO,CAAC,MAAM,CAAC,CAMjB;AAED,wBAAsB,oBAAoB,CACxC,UAAU,EAAE,MAAM,EAClB,OAAO,EAAE,MAAM,GAAG,MAAM,EAAE,GACzB,OAAO,CAAC,cAAc,EAAE,CAAC,CAO3B"}

package/dist/webhook.js

@@ -141,26 +141,15 @@ function inboxRowToWebhookRequest(row) {
     };
 }
 async function inboxGetUrl() {
-    if (process.env.EMPIRICALRUN_API_KEY) {
-        const apiClient = new dashboard_client_1.DashboardAPIClient({
-            authType: "project-api-key",
-        });
-        const result = await apiClient.request("/api/inbox/proxy", {
-            method: "POST",
-            body: { method: "POST", path: "/api/hooks/token" },
-        });
-        const tokenData = result.data;
-        return `${INBOX_WORKER_URL}/hooks/${tokenData.uuid}`;
-    }
-    const response = await fetch(`${INBOX_WORKER_URL}/api/hooks/token`, {
+    const apiClient = new dashboard_client_1.DashboardAPIClient({
+        authType: "project-api-key",
+    });
+    const result = await apiClient.request("/api/inbox/proxy", {
         method: "POST",
+        body: { method: "POST", path: "/api/hooks/token" },
     });
-    if (!response.ok) {
-        const body = await response.text().catch(() => "");
-        throw new Error(`inbox webhook error [${response.status} ${response.statusText}]: ${body}`);
-    }
-    const { uuid } = await response.json();
-    return `${INBOX_WORKER_URL}/hooks/${uuid}`;
+    const tokenData = result.data;
+    return `${INBOX_WORKER_URL}/hooks/${tokenData.uuid}`;
 }
 async function inboxQuery(token, content) {
     const terms = Array.isArray(content) ? content : [content];
@@ -172,35 +161,21 @@ async function inboxQuery(token, content) {
     for (const t of terms) {
         params.append("content", t);
     }
-    if (process.env.EMPIRICALRUN_API_KEY) {
-        const apiClient = new dashboard_client_1.DashboardAPIClient({
-            authType: "project-api-key",
-        });
-        const result = await apiClient.request("/api/inbox/proxy", {
-            method: "POST",
-            body: {
-                method: "GET",
-                path: `/api/hooks?${params.toString()}`,
-            },
-        });
-        const response = result.data;
-        if (!response || !Array.isArray(response.data)) {
-            return [];
-        }
-        return response.data.map(inboxRowToWebhookRequest);
-    }
-    const rawResponse = await fetch(`${INBOX_WORKER_URL}/api/hooks?${params.toString()}`);
-    if (!rawResponse.ok) {
-        const body = await rawResponse.text().catch(() => "");
-        throw new Error(`inbox webhook error [${rawResponse.status} ${rawResponse.statusText}]: ${body}`);
-    }
-    const json = await rawResponse.json().catch((e) => {
-        throw new Error(`inbox webhook returned invalid JSON: ${String(e)}`);
+    const apiClient = new dashboard_client_1.DashboardAPIClient({
+        authType: "project-api-key",
     });
-    if (!json || !Array.isArray(json.data)) {
+    const result = await apiClient.request("/api/inbox/proxy", {
+        method: "POST",
+        body: {
+            method: "GET",
+            path: `/api/hooks?${params.toString()}`,
+        },
+    });
+    const response = result.data;
+    if (!response || !Array.isArray(response.data)) {
         return [];
     }
-    return json.data.map(inboxRowToWebhookRequest);
+    return response.data.map(inboxRowToWebhookRequest);
 }
 // ── public API ──
 function extractToken(webhookUrl) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@empiricalrun/playwright-utils",
-  "version": "0.48.3",
+  "version": "0.48.5",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/",
     "access": "public"
@@ -43,11 +43,11 @@
     "puppeteer-extra-plugin-recaptcha": "^3.6.8",
     "rimraf": "^6.0.1",
     "ts-morph": "^23.0.0",
+    "@empiricalrun/cua": "^0.3.0",
     "@empiricalrun/dashboard-client": "^0.3.0",
-    "@empiricalrun/r2-uploader": "^0.9.1",
     "@empiricalrun/llm": "^0.26.0",
-    "@empiricalrun/reporter": "^0.28.1",
-    "@empiricalrun/cua": "^0.3.0"
+    "@empiricalrun/r2-uploader": "^0.9.1",
+    "@empiricalrun/reporter": "^0.28.1"
   },
   "scripts": {
     "dev": "tsc --build --watch",