@empiricalrun/playwright-utils 0.20.10 → 0.20.11

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @empiricalrun/playwright-utils
 
+## 0.20.11
+
+### Patch Changes
+
+- 089977f: test: added test for no overlay scenarios
+- 3ffd03c: feat: enable key moments feature flag
+
 ## 0.20.10
 
 ### Patch Changes

package/dist/overlay-tests/click.spec.js

@@ -102,3 +102,14 @@ test_1.test.beforeEach(async ({ page }) => {
     (0, test_1.expect)(firstLineThatStartsWithAt).toBeDefined();
     (0, test_1.expect)(firstLineThatStartsWithAt).toContain("overlay-tests/click.spec.ts:106");
 });
+(0, test_1.test)("should return from master agent planner", async ({ page }) => {
+    await page.goto(`http://localhost:${PORT}/no-overlay.html`);
+    try {
+        // Deliberately click on a button that doesn't exist
+        await page.getByRole("button", { name: "Login" }).click();
+    }
+    catch (e) {
+        (0, test_1.expect)(e.message).toContain("locator.apply: Timeout 5000ms exceeded");
+        (0, test_1.expect)(e.message).toContain("waiting for getByRole('button', { name: 'Login' })");
+    }
+});

package/dist/test/scripts/locator-highlights.js

@@ -19,7 +19,7 @@ exports.addLocatorHighlights = addLocatorHighlights;
 function applyHighlights(page, testFn) {
     const LocatorClass = page.locator("").constructor;
     (0, hover_1.patchHover)(LocatorClass, testFn);
-    (0, expect_1.patchExpect)(LocatorClass, testFn);
+    (0, expect_1.patchExpect)(LocatorClass);
     (0, input_value_1.patchInputValue)(LocatorClass, testFn);
     (0, is_checked_1.patchIsChecked)(LocatorClass, testFn);
     (0, is_editable_1.patchIsEditable)(LocatorClass, testFn);

package/dist/test/scripts/pw-locator-patch/highlight/expect.d.ts

@@ -1,6 +1,5 @@
 import type { Locator } from "@playwright/test";
-import { TestFn } from "../../types";
 export declare function patchExpect(LocatorClass: Function & {
     prototype: Locator;
-}, testFn: TestFn): void;
+}): void;
 //# sourceMappingURL=expect.d.ts.map

package/dist/test/scripts/pw-locator-patch/highlight/expect.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"expect.d.ts","sourceRoot":"","sources":["../../../../../src/test/scripts/pw-locator-patch/highlight/expect.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,kBAAkB,CAAC;AAEhD,OAAO,EAAE,MAAM,EAAE,MAAM,aAAa,CAAC;AAKrC,wBAAgB,WAAW,CACzB,YAAY,EAAE,QAAQ,GAAG;IAAE,SAAS,EAAE,OAAO,CAAA;CAAE,EAC/C,MAAM,EAAE,MAAM,QAkCf"}
+{"version":3,"file":"expect.d.ts","sourceRoot":"","sources":["../../../../../src/test/scripts/pw-locator-patch/highlight/expect.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,kBAAkB,CAAC;AAMhD,wBAAgB,WAAW,CAAC,YAAY,EAAE,QAAQ,GAAG;IAAE,SAAS,EAAE,OAAO,CAAA;CAAE,QAoB1E"}

package/dist/test/scripts/pw-locator-patch/highlight/expect.js

@@ -3,30 +3,20 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.patchExpect = void 0;
 const utils_1 = require("../utils");
 const isExpectPatched = new WeakMap();
-function patchExpect(LocatorClass, testFn) {
+function patchExpect(LocatorClass) {
     if (isExpectPatched.get(LocatorClass)) {
         return;
     }
     const originalExpect = LocatorClass.prototype._expect;
+    // No need to add test.step in this patch as its already an internal method and is not part of stack trace
+    // if added then its tracked as a separate step in playwright trace
     // @ts-ignore _expect is a private method in playwright
     // https://github.com/microsoft/playwright/blob/69287f26bc514b740eac40160503d6fac8185d37/packages/playwright-core/src/client/locator.ts#L352
     LocatorClass.prototype._expect = async function (expression, options) {
-        let result;
-        const stepName = `locator._expect(${(0, utils_1.description)(this)})`;
-        await testFn.step(stepName, async () => {
-            try {
-                result = await originalExpect.apply(this, [expression, options]);
-            }
-            catch (error) {
-                if (error instanceof Error) {
-                    Error.captureStackTrace(error, LocatorClass.prototype._expect);
-                }
-                throw error;
-            }
-            if (result.matches) {
-                await (0, utils_1.scrollAndHighlight)(this);
-            }
-        }, { box: true });
+        const result = await originalExpect.apply(this, [expression, options]);
+        if (result.matches) {
+            await (0, utils_1.scrollAndHighlight)(this);
+        }
         return result;
     };
     isExpectPatched.set(LocatorClass, true);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@empiricalrun/playwright-utils",
-  "version": "0.20.10",
+  "version": "0.20.11",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/",
     "access": "public"
@@ -43,8 +43,8 @@
     "puppeteer-extra-plugin-recaptcha": "^3.6.8",
     "rimraf": "^6.0.1",
     "@empiricalrun/llm": "^0.9.35",
-    "@empiricalrun/r2-uploader": "^0.3.8",
-    "@empiricalrun/test-gen": "^0.45.0"
+    "@empiricalrun/test-gen": "^0.45.0",
+    "@empiricalrun/r2-uploader": "^0.3.8"
   },
   "scripts": {
     "dev": "tsc --build --watch",