@emiliosp/pi-maestro 0.9.1 → 0.9.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +6 -0
- package/ROADMAP.md +13 -13
- package/agents/verifier.md +15 -0
- package/package.json +1 -1
package/CHANGELOG.md
CHANGED
|
@@ -2,6 +2,12 @@
|
|
|
2
2
|
|
|
3
3
|
This file summarizes meaningful changes to the codebase, including behavior, data formats, architecture, and development tools. Git tags identify version boundaries; GitHub Releases are not required. Version-only changes and routine maintenance are omitted.
|
|
4
4
|
|
|
5
|
+
## 0.9.2
|
|
6
|
+
|
|
7
|
+
1. Added code-quality review to `verifier` guidance for code affected by the approved change when applicable `AGENTS.md` directives exist. See [PR #34](https://github.com/emilioSp/pi-maestro/pull/34). All existing verification duties remain unchanged.
|
|
8
|
+
2. Required instruction-violation `findings` to identify the instruction file, quote the rule, and explain the violating code through existing evidence fields.
|
|
9
|
+
3. Skip only the added review when files or code-quality directives are absent. Missing directives and personal style preferences do not produce `findings`.
|
|
10
|
+
|
|
5
11
|
## 0.9.1
|
|
6
12
|
|
|
7
13
|
1. Added a brief introduction and an invitation to ask how `Maestro` works to the successful activation notice. See [PR #33](https://github.com/emilioSp/pi-maestro/pull/33).
|
package/ROADMAP.md
CHANGED
|
@@ -44,7 +44,7 @@ Applied glossary formatting across the documentation and recorded its exclusions
|
|
|
44
44
|
|
|
45
45
|
### R-14: Introduce Maestro at activation
|
|
46
46
|
|
|
47
|
-
Implemented in `0.9.1`.
|
|
47
|
+
Implemented in `0.9.1`. Successful activation introduces `Maestro` and invites the `owner` to ask how it works. The UI-only notice retains the configured agent details and does not add session history or start a model request.
|
|
48
48
|
|
|
49
49
|
Active instructions identify absolute paths to the installed README and documentation directory. `Maestro` reads relevant documentation on demand without automatically loading its contents.
|
|
50
50
|
|
|
@@ -62,6 +62,18 @@ Renamed `test/` to `tests/` at the owner's request. Updated imports, fixture pat
|
|
|
62
62
|
|
|
63
63
|
[Test support](tests/support/), [fixtures](tests/fixtures/), [lint configuration](biome.json), and [project instructions](AGENTS.md#tests).
|
|
64
64
|
|
|
65
|
+
### R-16: Verify code quality against AGENTS.md instructions
|
|
66
|
+
|
|
67
|
+
Implemented in `0.9.2`. `Verifier` guidance now requires code-quality review only for code affected by the approved change when applicable `AGENTS.md` directives exist. All existing duties remain unchanged, including independent verification of every `acceptance criterion`.
|
|
68
|
+
|
|
69
|
+
Instruction-violation `findings` identify the instruction file, quote the rule, and explain the violating code through existing evidence fields. Missing files or code-quality directives cause only the added review to be skipped. Personal style preferences are not requirements.
|
|
70
|
+
|
|
71
|
+
All 5 `acceptance criteria` passed through independent inspection of the written guidance, with no `verifier` `findings`. No additional model trials were performed. The saved workflow reached `candidate-ready`.
|
|
72
|
+
|
|
73
|
+
#### Evidence
|
|
74
|
+
|
|
75
|
+
[Specification](.specs/20261013-185941-verify-code-quality-against-agents-md-instructions/spec.md), [verifier report](.specs/20261013-185941-verify-code-quality-against-agents-md-instructions/handoffs/verifier/V1.json), and [merged PR #34](https://github.com/emilioSp/pi-maestro/pull/34).
|
|
76
|
+
|
|
65
77
|
## Now
|
|
66
78
|
|
|
67
79
|
## Next
|
|
@@ -167,15 +179,3 @@ Show an activity indicator in Pi's status bar while progress does not require an
|
|
|
167
179
|
#### Completed when
|
|
168
180
|
|
|
169
181
|
The status clearly distinguishes work in progress from a request for `owner` action.
|
|
170
|
-
|
|
171
|
-
### R-16: Verify code quality against AGENTS.md instructions
|
|
172
|
-
|
|
173
|
-
#### Objective
|
|
174
|
-
|
|
175
|
-
Add code-quality review against applicable `AGENTS.md` instructions as another `verifier` responsibility. Keep all existing responsibilities unchanged, including independent verification of every `acceptance criterion` in the approved `spec`. Code-quality review supplements that verification. It does not replace or reduce it.
|
|
176
|
-
|
|
177
|
-
Existing `verifier` instructions already require reading applicable `AGENTS.md` files and following technical rules. Extend that guidance to require explicit code-quality review and reporting of instruction violations. Do not introduce personal style preferences as requirements.
|
|
178
|
-
|
|
179
|
-
#### Completed when
|
|
180
|
-
|
|
181
|
-
The `verifier` performs both its existing verification duties and the additional code-quality review. Every `acceptance criterion` is still independently verified. Each code-quality `finding` about an instruction violation identifies the `AGENTS.md` file, quotes the violated instruction, and explains how the code violates it.
|
package/agents/verifier.md
CHANGED
|
@@ -63,6 +63,21 @@ Use `probeStatus: passed` when the observed result matches the expected result.
|
|
|
63
63
|
Use `failed` for an observed probe failure and `not-run` for an unexecuted probe.
|
|
64
64
|
Include every spec criterion once. Never omit unrun criteria or fabricate evidence.
|
|
65
65
|
|
|
66
|
+
## Review code quality
|
|
67
|
+
|
|
68
|
+
If applicable `AGENTS.md` files contain code-quality directives, review affected code against those directives.
|
|
69
|
+
Review only code affected by the approved change. Do not audit unrelated project code.
|
|
70
|
+
This review supplements all existing duties. Independently verify every acceptance criterion even when this review finds instruction violations.
|
|
71
|
+
Do not treat personal style preferences as requirements or report findings based only on those preferences.
|
|
72
|
+
|
|
73
|
+
For each instruction violation, use the existing finding evidence fields:
|
|
74
|
+
|
|
75
|
+
1. Identify the applicable `AGENTS.md` file in `evidence.source` and quote the violated instruction exactly in `evidence.observation`.
|
|
76
|
+
2. Identify the violating code in `evidence.source` and explain how it violates that instruction in `evidence.observation`.
|
|
77
|
+
|
|
78
|
+
If no applicable `AGENTS.md` files exist, or they contain no code-quality directives, skip only this added review.
|
|
79
|
+
Missing files or directives are not errors or findings. Do not invent directives or require those files to be created.
|
|
80
|
+
|
|
66
81
|
## Record findings, not decisions
|
|
67
82
|
|
|
68
83
|
Record technical issues supported by fresh evidence. Do not add requirements, style preferences, or unrelated improvements.
|