@ember-eui/core 4.2.2 → 4.2.3

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ### Master
 
+### 4.2.3
+🐛 Bug / Fixes
+`@ember-eui/core`
+- Cherry pick 1.6.x fix commit hash https://github.com/prysmex/ember-eui/commit/c4b8a4a259f6b86c2be516fd7427f5e48b28cecd
+- Use next for updating the attachTo for `<EuiToolTip />`
+
 ### 4.2.2
 🐛 Bug / Fixes
 `@ember-eui/core`
@@ -119,6 +125,11 @@ bump @embroider 1.3.0 regenerating yarn.lock, this finally enables staticCompone
 💥 Breaking change
 `@ember-eui/core`
 - Deprecate `ember-svg-jar` `hbs` strategy for now, just use stock `ember-svg-jar`
+
+### 1.6.10
+🐛 Bug / Fixes
+`@ember-eui/core`
+- `<EuiComboBox />` fixes to `onCreateOption`
 ### 1.6.7
 🐛 Bug / Fixes
 `@ember-eui/core`

package/addon/components/eui-combo-box/index.hbs

@@ -25,7 +25,7 @@
     singleSelection=@singleSelection
     onClose=@removeTag
     onCreateOption=(if
-      @onCreateOption (pipe this.onCreateOption @onCreateOption)
+      @onCreateOption this.onCreateOption
     )
   }}
   @matcher={{@matcher}}
@@ -75,7 +75,7 @@
     (component
       "eui-combo-box/create-option"
       customOptionText=@customOptionText
-      onCreateOption=(pipe this.onCreateOption @onCreateOption)
+      onCreateOption=this.onCreateOption
       select=this.select
     )
     (component "eui-combo-box/no-matches-message")

package/addon/components/eui-combo-box/index.ts

@@ -7,6 +7,7 @@ import { isEqual } from '@ember/utils';
 
 interface EuiComboBoxArgs {
   singleSelection: boolean;
+  onCreateOption?: (search: string) => boolean | undefined;
 }
 
 interface Select {
@@ -64,9 +65,19 @@ export default class EuiComboBoxComponent extends Component<EuiComboBoxArgs> {
 
   @action
   onCreateOption() {
-    let search = this.select.searchText;
+    let option;
+    if (
+      this.args.onCreateOption &&
+      typeof this.args.onCreateOption === 'function'
+    ) {
+      // The `onCreateOption` function can be used to sanitize the input or explicitly return `false` to reject the input
+      option = this.args.onCreateOption(this.select.searchText);
+      if (option === false) {
+        return;
+      }
+    }
+    let search = option || this.select.searchText;
     this.select.actions.search('');
-    this.select.actions.select(search);
     this.select.actions.close();
     return search;
   }

package/addon/components/eui-tool-tip/index.ts

@@ -5,7 +5,7 @@ import { uniqueId } from '../../helpers/unique-id';
 import { tracked, cached } from '@glimmer/tracking';
 import { findPopoverPosition } from '../../utils/popover';
 import { keys } from '../../utils/keys';
-import { later, cancel, scheduleOnce } from '@ember/runloop';
+import { later, cancel, scheduleOnce, next } from '@ember/runloop';
 
 export type ToolTipPositions = 'top' | 'right' | 'bottom' | 'left';
 
@@ -113,9 +113,11 @@ export default class EuiToolTip extends Component<EuiTooltipArgs> {
     }
 
     if (this.args.attachTo && this.args.attachTo !== this._attachTo) {
-      this.removeAttachToHandlers();
-      this._attachTo = this.args.attachTo;
-      this.setupAttachToHandlers();
+      next(() => {
+        this.removeAttachToHandlers();
+        this._attachTo = this.args.attachTo;
+        this.setupAttachToHandlers();
+      });
     }
   }
 
@@ -246,13 +248,16 @@ export default class EuiToolTip extends Component<EuiTooltipArgs> {
       }
     });
 
-    const windowWidth = document.documentElement.clientWidth || window.innerWidth;
+    const windowWidth =
+      document.documentElement.clientWidth || window.innerWidth;
     const useRightValue = windowWidth / 2 < left;
 
     const toolTipStyles: ToolTipStyles = {
       top: `${top}px`,
       left: useRightValue ? 'auto' : `${left}px`,
-      right: useRightValue ? `${windowWidth - left - this.popover.offsetWidth}px` : 'auto'
+      right: useRightValue
+        ? `${windowWidth - left - this.popover.offsetWidth}px`
+        : 'auto'
     };
 
     this.visible = true;
@@ -299,7 +304,8 @@ export default class EuiToolTip extends Component<EuiTooltipArgs> {
     // left the anchor for a non-child.
     if (
       this._anchor === event.relatedTarget ||
-      (this._anchor != null && !this._anchor.contains(event.relatedTarget as Node))
+      (this._anchor != null &&
+        !this._anchor.contains(event.relatedTarget as Node))
     ) {
       this.hideToolTip();
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ember-eui/core",
-  "version": "4.2.2",
+  "version": "4.2.3",
   "description": "Ember Components for Elastic UI",
   "keywords": [
     "ember-addon",
@@ -176,5 +176,5 @@
   "volta": {
     "extends": "../../package.json"
   },
-  "gitHead": "275e6432ca59bbf59d05f0dd4809238c3abaec19"
+  "gitHead": "416ebf9ca1d85d3d9404d71badda1af1db82d191"
 }