@ember-eui/core 3.0.2 → 3.1.3

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 ### Master
 
+### 3.1.0
+🚀 Enhancements
+`@ember-eui/*`
+- Embroider ready, in order to use staticComponents you need to have `@embroider` > 1.2.0
+
+🐛 Bug / Fixes
+`@ember-eui/core`
+- `<EuiMarkdownFormat />` and `<EuiMarkdownEditor />` styling bugs and double render issues fixed
+
 ### 3.0.2
 `@ember-eui/core`
 🐛 Bug / Fixes
@@ -29,6 +38,15 @@
 💥 Breaking change
 `@ember-eui/core`
 - Deprecate `ember-svg-jar` `hbs` strategy for now, just use stock `ember-svg-jar`
+### 1.6.7
+🐛 Bug / Fixes
+`@ember-eui/core`
+- `<EuiComboBox />` Call `onChange` after `onCreateOption` is triggered
+### 1.6.5
+🐛 Bug / Fixes
+`@ember-eui/core`
+- `<EuiComboBox />` hide clear button when disabled
+- `<EuiComboBox />` close options dropdown after creating option
 
 ### 1.6.3
 🐛 Bug / Fixes

package/README.md

@@ -15,6 +15,7 @@ var app = new EmberApp(defaults, {
     svgJar: {
       sourceDirs: [
         'public/assets',
+        '../node_modules/@ember-eui/core/public',
         'node_modules/@elastic/eui/lib/components/icon',
       ],
     },

package/addon/components/eui-combo-box/index.hbs

@@ -27,7 +27,6 @@
     onCreateOption=(if
       @onCreateOption (pipe this.onCreateOption @onCreateOption)
     )
-    isClearable=@isClearable
   }}
   @matcher={{@matcher}}
   @initiallyOpen={{@initiallyOpen}}
@@ -51,14 +50,13 @@
   @triggerRole={{@triggerRole}}
   @title={{@title}}
   @triggerId={{@triggerId}}
-  @allowClear={{@isClearable}}
+  @allowClear={{and
+    (arg-or-default @isClearable true)
+    (not (or @isDisabled @disabled))
+  }}
   @loadingMessage={{@loadingMessage}}
   @selectedItemComponent={{@selectedItemComponent}}
-  @beforeOptionsComponent={{if
-    @beforeOptionsComponent
-    @beforeOptionsComponent
-    null
-  }}
+  @beforeOptionsComponent={{@beforeOptionsComponent}}
   @placeholder={{@placeholder}}
   @searchPlaceholder={{@searchPlaceholder}}
   @optionsComponent={{component "eui-combo-box/options" rowHeight=@rowHeight}}

package/addon/components/eui-combo-box/index.ts

@@ -66,6 +66,8 @@ export default class EuiComboBoxComponent extends Component<EuiComboBoxArgs> {
   onCreateOption() {
     let search = this.select.searchText;
     this.select.actions.search('');
+    this.select.actions.select(search);
+    this.select.actions.close();
     return search;
   }
 

package/addon/components/eui-combo-box/options/index.hbs

@@ -1,4 +1,4 @@
-{{#let (component @groupComponent) as |Group|}}
+{{#let (component (ensure-safe-component @groupComponent)) as |Group|}}
   {{#if @select.loading}}
     <EuiText @size="xs" class="euiComboBoxOptionsList__empty">
       <EuiFlexGroup @gutterSize="s" @justifyContent="center">
@@ -23,7 +23,8 @@
       aria-controls="ember-power-select-trigger-{{@select.uniqueId}}"
       ...attributes
       {{did-insert this.addHandlers}}
-      {{will-destroy this.removeHandlers}} as |opt index|
+      {{will-destroy this.removeHandlers}}
+      as |opt index|
     >
       {{! template-lint-enable }}
       {{#if (ember-power-select-is-group opt)}}
@@ -31,10 +32,14 @@
       {{else}}
         <li
           class="euiFilterSelectItem
-            {{if (eq opt @select.highlighted) " euiFilterSelectItem-isFocused"
-            }}"
-          aria-selected="{{ember-power-select-is-selected opt @select.selected
+            {{if
+              (eq opt @select.highlighted)
+              ' euiFilterSelectItem-isFocused'
             }}"
+          aria-selected="{{ember-power-select-is-selected
+            opt
+            @select.selected
+          }}"
           aria-disabled={{if opt.disabled "true"}}
           aria-current="{{eq opt @select.highlighted}}"
           data-option-index="{{index}}"

package/addon/components/eui-combo-box/trigger/index.hbs

@@ -1,121 +1,118 @@
-{{#let (arg-or-default @isClearable true) as |isClearable|}}
-  <EuiFormControlLayout
-    @icon="arrowDown"
-    @iconSide="right"
-    @fullWidth={{@fullWidth}}
-    @compressed={{@compressed}}
-    @readOnly={{@readOnly}}
-    @clear={{if
-      (and @select.selected isClearable)
-      (fn @select.actions.select (array))
-    }}
-    @disabled={{@select.disabled}}
-  >
-    <:field>
-      {{! template-lint-disable }}
-      <ul
-        id="ember-power-select-multiple-options-{{@select.uniqueId}}"
-        class={{class-names
-          "euiComboBox__inputWrap ember-power-select-multiple-options"
-          (if @compressed "euiComboBox__inputWrap--compressed")
-          (if @fullWidth "euiComboBox__inputWrap--fullWidth")
-          (if @singleSelection "euiComboBox__inputWrap--noWrap")
-          (if @isLoading "euiComboBox__inputWrap--isLoading")
-          (if isClearable "euiComboBox__inputWrap-isClearable")
-        }}
-        ...attributes
-        {{did-update this.openChanged @select.isOpen}}
-        {{on "touchstart" this.chooseOption}}
-        {{on "mousedown" this.chooseOption}}
-      >
-        {{! template-lint-enable }}
-        {{#if
-          (or
-            (and @singleSelection (not @select.searchText))
-            (not @singleSelection)
-          )
-        }}
-          {{#each @select.selected as |opt idx|}}
-            {{#if @selectedItemComponent}}
-              {{component
-                @selectedItemComponent
-                extra=@extra
-                option=opt
-                select=@select
+<EuiFormControlLayout
+  @icon="arrowDown"
+  @iconSide="right"
+  @fullWidth={{@fullWidth}}
+  @compressed={{@compressed}}
+  @readOnly={{@readOnly}}
+  @clear={{if
+    (and @select.selected @allowClear)
+    (fn @select.actions.select (array))
+  }}
+  @disabled={{@select.disabled}}
+>
+  <:field>
+    {{! template-lint-disable }}
+    <ul
+      id="ember-power-select-multiple-options-{{@select.uniqueId}}"
+      class={{class-names
+        "euiComboBox__inputWrap ember-power-select-multiple-options"
+        (if @compressed "euiComboBox__inputWrap--compressed")
+        (if @fullWidth "euiComboBox__inputWrap--fullWidth")
+        (if @singleSelection "euiComboBox__inputWrap--noWrap")
+        (if @isLoading "euiComboBox__inputWrap--isLoading")
+        (if @allowClear "euiComboBox__inputWrap-isClearable")
+      }}
+      ...attributes
+      {{did-update this.openChanged @select.isOpen}}
+      {{on "touchstart" this.chooseOption}}
+      {{on "mousedown" this.chooseOption}}
+    >
+      {{! template-lint-enable }}
+      {{#if
+        (or
+          (and @singleSelection (not @select.searchText)) (not @singleSelection)
+        )
+      }}
+        {{#each @select.selected as |opt idx|}}
+          {{#if @selectedItemComponent}}
+            {{component
+              @selectedItemComponent
+              extra=@extra
+              option=opt
+              select=@select
+            }}
+          {{else}}
+            <EuiComboBoxPill
+              class="ember-power-select-multiple-option
+                {{if
+                  opt.disabled
+                  "ember-power-select-multiple-option--disabled"
+                }}"
+              @option={{opt}}
+              @onClose={{if
+                (or @select.disabled @singleSelection)
+                false
+                (if @onClose (fn (optional @onClose) opt) true)
               }}
-            {{else}}
-              <EuiComboBoxPill
-                class="ember-power-select-multiple-option
-                  {{if
-                    opt.disabled
-                    "ember-power-select-multiple-option--disabled"
-                  }}"
-                @option={{opt}}
-                @onClose={{if
-                  (or @select.disabled @singleSelection)
-                  false
-                  (if @onClose (fn (optional @onClose) opt) true)
-                }}
-                @dataSelectedIconIndex={{idx}}
-                @color={{opt.color}}
-                @asPlainText={{@singleSelection.asPlainText}}
-              >
-                {{yield opt @select}}
-              </EuiComboBoxPill>
-            {{/if}}
-          {{else if (and @placeholder (not @searchEnabled))}}
-            <span class="ember-power-select-placeholder">
-              {{@placeholder}}
-            </span>
-          {{/each}}
-        {{/if}}
-        {{#if @searchEnabled}}
-          {{! template-lint-disable }}
-          {{#if (and this.maybePlaceholder (not @select.searchText))}}
-            <p class="euiComboBoxPlaceholder">
-              {{this.maybePlaceholder}}
-            </p>
+              @dataSelectedIconIndex={{idx}}
+              @color={{opt.color}}
+              @asPlainText={{@singleSelection.asPlainText}}
+            >
+              {{yield opt @select}}
+            </EuiComboBoxPill>
           {{/if}}
-          <div
-            class="euiComboBox__input"
-            style="font-size: 14px; display: inline-block; position: relative;"
-          >
-            <input
-              tabindex="-1"
-              style="opacity: 0px; width:0px; height:0px; position: absolute; top: 40%; border:solid 1px transparent !important; margin:0px !important;"
-              class="fake-input-for-html-form-validity"
-              {{validatable-control @isInvalid}}
-            />
-            <input
-              class="ember-power-select-trigger-multiple-input euiComboBox__input"
-              autocomplete="off"
-              autocorrect="off"
-              autocapitalize="off"
-              spellcheck={{false}}
-              id="ember-power-select-trigger-multiple-input-{{@select.uniqueId}}"
-              value={{@select.searchText}}
-              aria-controls={{@listboxId}}
-              style={{this.triggerMultipleInputStyle}}
-              disabled={{@select.disabled}}
-              tabindex={{@tabindex}}
-              form="power-select-fake-form"
-              {{on "focus" @onFocus}}
-              {{on "blur" @onBlur}}
-              {{on "input" this.handleInput}}
-              {{on "keydown" this.handleKeydown}}
-              {{did-insert this.storeInputStyles}}
-            />
-          </div>
-          {{! template-lint-enable }}
-        {{else}}
-          {{! template-lint-disable }}
-          <div
-            class="euiComboBox__input"
-            style="font-size: 14px; display: inline-block;"
-          ></div>
-          {{! template-lint-enable }}
+        {{else if (and @placeholder (not @searchEnabled))}}
+          <span class="ember-power-select-placeholder">
+            {{@placeholder}}
+          </span>
+        {{/each}}
+      {{/if}}
+      {{#if @searchEnabled}}
+        {{! template-lint-disable }}
+        {{#if (and this.maybePlaceholder (not @select.searchText))}}
+          <p class="euiComboBoxPlaceholder">
+            {{this.maybePlaceholder}}
+          </p>
         {{/if}}
-      </ul>
-    </:field>
-  </EuiFormControlLayout>
-{{/let}}
+        <div
+          class="euiComboBox__input"
+          style="font-size: 14px; display: inline-block; position: relative;"
+        >
+          <input
+            tabindex="-1"
+            style="opacity: 0px; width:0px; height:0px; position: absolute; top: 40%; border:solid 1px transparent !important; margin:0px !important;"
+            class="fake-input-for-html-form-validity"
+            {{validatable-control @isInvalid}}
+          />
+          <input
+            class="ember-power-select-trigger-multiple-input euiComboBox__input"
+            autocomplete="off"
+            autocorrect="off"
+            autocapitalize="off"
+            spellcheck={{false}}
+            id="ember-power-select-trigger-multiple-input-{{@select.uniqueId}}"
+            value={{@select.searchText}}
+            aria-controls={{@listboxId}}
+            style={{this.triggerMultipleInputStyle}}
+            disabled={{@select.disabled}}
+            tabindex={{@tabindex}}
+            form="power-select-fake-form"
+            {{on "focus" @onFocus}}
+            {{on "blur" @onBlur}}
+            {{on "input" this.handleInput}}
+            {{on "keydown" this.handleKeydown}}
+            {{did-insert this.storeInputStyles}}
+          />
+        </div>
+        {{! template-lint-enable }}
+      {{else}}
+        {{! template-lint-disable }}
+        <div
+          class="euiComboBox__input"
+          style="font-size: 14px; display: inline-block;"
+        ></div>
+        {{! template-lint-enable }}
+      {{/if}}
+    </ul>
+  </:field>
+</EuiFormControlLayout>

package/addon/components/eui-icon/index.hbs

@@ -1,6 +1,6 @@
 {{#if @useComponent}}
   {{! has the shape of a curried component }}
-  {{#let (component this.icon) as |IconComponent|}}
+  {{#let (component (ensure-safe-component this.icon)) as |IconComponent|}}
     {{!template-lint-disable}}
     <IconComponent
       class={{class-names

package/addon/components/eui-list-group-item/index.hbs

@@ -62,6 +62,6 @@
     </span>
   {{/if}}
   {{#if @extraAction}}
-    {{component @extraAction}}
+    {{component (ensure-safe-component @extraAction)}}
   {{/if}}
 </li>

package/addon/components/eui-markdown-editor/index.ts

@@ -20,6 +20,7 @@ import {
   EuiMarkdownAstNode
 } from '../../utils/markdown/markdown-types';
 import { Processor } from 'unified';
+import { scheduleOnce } from '@ember/runloop';
 
 export interface EuiMarkdownEditorArgs {
   initialViewMode?: string;
@@ -119,7 +120,11 @@ export default class EuiMarkdownEditorComponent extends Component<EuiMarkdownEdi
       const resizedTextareaHeight =
         this.textareaRef.offsetHeight + this.editorFooterHeight;
 
-      this.currentHeight = resizedTextareaHeight;
+      const update = () => {
+        this.currentHeight = resizedTextareaHeight;
+      };
+
+      scheduleOnce('afterRender', this, update);
     }
   }
 
@@ -144,7 +149,13 @@ export default class EuiMarkdownEditorComponent extends Component<EuiMarkdownEdi
         // then add an extra pixel for safety and because the scrollHeight value is rounded
         const extraHeight = borderWidth + marginWidth + 1;
 
-        this.currentHeight = previewRef.scrollHeight + extraHeight;
+        const update = () => {
+          if (previewRef) {
+            this.currentHeight = previewRef.scrollHeight + extraHeight;
+          }
+        };
+
+        scheduleOnce('afterRender', this, update);
       }
     }
   }

package/addon/components/eui-markdown-editor-toolbar/index.hbs

@@ -20,7 +20,7 @@
           {{on "click" (fn this.handleMdButtonClick item.id)}}
           @iconType={{if
             item.iconType.component
-            (component item.iconType.component)
+            (component (ensure-safe-component item.iconType.component))
             item.iconType
           }}
           @useComponent={{item.iconType.component}}

package/addon/components/eui-markdown-format/index.hbs

@@ -1,9 +1,19 @@
 {{! This hbs was inspired by https://github.com/ampatspell/ember-cli-remark-static/blob/v3.0.5/addon/components/remark.hbs }}
-<div class="euiMarkdownFormat">
+<EuiText
+  class="euiMarkdownFormat"
+  @color={{@color}}
+  @grow={{@grow}}
+  @size={{@textSize}}
+  @textAlign={{@textAlign}}
+  ...attributes
+>
   {{this.result.element}}
   {{#each this.result.components as |CompNode|}}
     {{#in-element CompNode.element}}
-      {{#let (component CompNode.componentName) as |DynamicComponent|}}
+      {{#let
+        (component (ensure-safe-component CompNode.componentName))
+        as |DynamicComponent|
+      }}
         <DynamicComponent
           @replaceNode={{optional @replaceNode}}
           @node={{CompNode}}
@@ -11,4 +21,4 @@
       {{/let}}
     {{/in-element}}
   {{/each}}
-</div>
+</EuiText>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ember-eui/core",
-  "version": "3.0.2",
+  "version": "3.1.3",
   "description": "Ember Components for Elastic UI",
   "keywords": [
     "ember-addon",
@@ -95,6 +95,7 @@
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.6.0",
     "@embroider/test-setup": "^1.0.0",
+    "@embroider/util": "^1.2.0",
     "@glimmer/component": "^1.0.4",
     "@glimmer/tracking": "^1.0.4",
     "@types/ember": "^3.16.0",
@@ -172,5 +173,5 @@
   "volta": {
     "node": "12.22.1"
   },
-  "gitHead": "4954f174f17915ab6fa301a875071705ef3a6d0b"
+  "gitHead": "ab669b60b2132395c6a6ee54b109eca7cb7497b8"
 }

package/app/components/eui-text-field/index.js

@@ -1 +0,0 @@
-export { default } from '@ember-eui/core/components/eui-text-field';