@ember-data/store 4.4.0-alpha.8 → 4.4.0

package/addon/-private/system/store/internal-model-factory.ts

@@ -9,7 +9,6 @@ import type {
   ResourceIdentifierObject,
 } from '../../ts-interfaces/ember-data-json-api';
 import type { StableRecordIdentifier } from '../../ts-interfaces/identifier';
-import type { RecordData } from '../../ts-interfaces/record-data';
 import type { RecordInstance } from '../../ts-interfaces/record-instance';
 import constructResource from '../../utils/construct-resource';
 import type CoreStore from '../core-store';
@@ -21,19 +20,19 @@ import WeakCache from '../weak-cache';
 /**
   @module @ember-data/store
 */
+
 const FactoryCache = new WeakCache<CoreStore, InternalModelFactory>(DEBUG ? 'internal-model-factory' : '');
 FactoryCache._generator = (store: CoreStore) => {
   return new InternalModelFactory(store);
 };
 type NewResourceInfo = { type: string; id: string | null };
 
-const RecordCache = new WeakCache<RecordInstance | RecordData, StableRecordIdentifier>(DEBUG ? 'identifier' : '');
+const RecordCache = new WeakCache<RecordInstance, StableRecordIdentifier>(DEBUG ? 'identifier' : '');
 if (DEBUG) {
-  RecordCache._expectMsg = (key: RecordInstance | RecordData) =>
-    `${String(key)} is not a record instantiated by @ember-data/store`;
+  RecordCache._expectMsg = (key: RecordInstance) => `${key} is not a record instantiated by @ember-data/store`;
 }
 
-export function peekRecordIdentifier(record: RecordInstance | RecordData): StableRecordIdentifier | undefined {
+export function peekRecordIdentifier(record: any): StableRecordIdentifier | undefined {
   return RecordCache.get(record);
 }
 
@@ -61,11 +60,11 @@ export function peekRecordIdentifier(record: RecordInstance | RecordData): Stabl
   @param {Object} record a record instance previously obstained from the store.
   @returns {StableRecordIdentifier}
  */
-export function recordIdentifierFor(record: RecordInstance | RecordData): StableRecordIdentifier {
+export function recordIdentifierFor(record: RecordInstance): StableRecordIdentifier {
   return RecordCache.getWithError(record);
 }
 
-export function setRecordIdentifier(record: RecordInstance | RecordData, identifier: StableRecordIdentifier): void {
+export function setRecordIdentifier(record: RecordInstance, identifier: StableRecordIdentifier): void {
   if (DEBUG && RecordCache.has(record)) {
     throw new Error(`${record} was already assigned an identifier`);
   }
@@ -161,7 +160,7 @@ export default class InternalModelFactory {
       TODO @runspired consider adding this to make polymorphism even nicer
       if (HAS_RECORD_DATA_PACKAGE) {
         if (identifier.type !== matchedIdentifier.type) {
-          const graphFor = importSync('@ember-data/record-data/-private').graphFor;
+          const graphFor = require('@ember-data/record-data/-private').graphFor;
           graphFor(this).registerPolymorphicType(identifier.type, matchedIdentifier.type);
         }
       }

package/addon/-private/system/store/record-data-store-wrapper.ts

@@ -1,5 +1,3 @@
-import { importSync } from '@embroider/macros';
-
 import type { RelationshipDefinition } from '@ember-data/model/-private/system/relationships/relationship-meta';
 import { HAS_RECORD_DATA_PACKAGE } from '@ember-data/private-build-infra';
 
@@ -12,7 +10,6 @@ import type {
   RelationshipsSchema,
 } from '../../ts-interfaces/record-data-schemas';
 import type { RecordDataStoreWrapper as StoreWrapper } from '../../ts-interfaces/record-data-store-wrapper';
-import { RecordInstance } from '../../ts-interfaces/record-instance';
 import constructResource from '../../utils/construct-resource';
 import type CoreStore from '../core-store';
 import { internalModelFactoryFor } from './internal-model-factory';
@@ -29,9 +26,7 @@ let peekGraph;
 if (HAS_RECORD_DATA_PACKAGE) {
   let _peekGraph;
   peekGraph = (wrapper) => {
-    _peekGraph =
-      _peekGraph ||
-      (importSync('@ember-data/record-data/-private') as typeof import('@ember-data/record-data/-private')).peekGraph;
+    _peekGraph = _peekGraph || require('@ember-data/record-data/-private').peekGraph;
     return _peekGraph(wrapper);
   };
 }
@@ -225,7 +220,7 @@ export default class RecordDataStoreWrapper implements StoreWrapper {
       return false;
     }
 
-    const record = internalModel._record as RecordInstance;
+    const record = internalModel._record;
     return record && !(record.isDestroyed || record.isDestroying);
   }
 

package/addon/-private/system/store/serializer-response.js

@@ -0,0 +1,71 @@
+import { assert } from '@ember/debug';
+import { DEBUG } from '@glimmer/env';
+
+/**
+  This is a helper method that validates a JSON API top-level document
+
+  The format of a document is described here:
+  http://jsonapi.org/format/#document-top-level
+
+  @internal
+*/
+export function validateDocumentStructure(doc) {
+  let errors = [];
+  if (!doc || typeof doc !== 'object') {
+    errors.push('Top level of a JSON API document must be an object');
+  } else {
+    if (!('data' in doc) && !('errors' in doc) && !('meta' in doc)) {
+      errors.push('One or more of the following keys must be present: "data", "errors", "meta".');
+    } else {
+      if ('data' in doc && 'errors' in doc) {
+        errors.push('Top level keys "errors" and "data" cannot both be present in a JSON API document');
+      }
+    }
+    if ('data' in doc) {
+      if (!(doc.data === null || Array.isArray(doc.data) || typeof doc.data === 'object')) {
+        errors.push('data must be null, an object, or an array');
+      }
+    }
+    if ('meta' in doc) {
+      if (typeof doc.meta !== 'object') {
+        errors.push('meta must be an object');
+      }
+    }
+    if ('errors' in doc) {
+      if (!Array.isArray(doc.errors)) {
+        errors.push('errors must be an array');
+      }
+    }
+    if ('links' in doc) {
+      if (typeof doc.links !== 'object') {
+        errors.push('links must be an object');
+      }
+    }
+    if ('jsonapi' in doc) {
+      if (typeof doc.jsonapi !== 'object') {
+        errors.push('jsonapi must be an object');
+      }
+    }
+    if ('included' in doc) {
+      if (typeof doc.included !== 'object') {
+        errors.push('included must be an array');
+      }
+    }
+  }
+
+  return errors;
+}
+
+export function normalizeResponseHelper(serializer, store, modelClass, payload, id, requestType) {
+  let normalizedResponse = serializer.normalizeResponse(store, modelClass, payload, id, requestType);
+  let validationErrors = [];
+  if (DEBUG) {
+    validationErrors = validateDocumentStructure(normalizedResponse);
+  }
+  assert(
+    `normalizeResponse must return a valid JSON API document:\n\t* ${validationErrors.join('\n\t* ')}`,
+    validationErrors.length === 0
+  );
+
+  return normalizedResponse;
+}

package/addon/-private/ts-interfaces/ds-model.ts

@@ -1,20 +1,15 @@
-import type EmberObject from '@ember/object';
+import EmberObject from '@ember/object';
 
-import type { Errors } from '@ember-data/model/-private';
+import RSVP from 'rsvp';
 
-import type CoreStore from '../system/core-store';
-import type InternalModel from '../system/model/internal-model';
 import type { JsonApiValidationError } from './record-data-json-api';
-import type { AttributeSchema, RelationshipSchema, RelationshipsSchema } from './record-data-schemas';
+import type { AttributeSchema, RelationshipSchema } from './record-data-schemas';
+import { RecordInstance } from './record-instance';
 
 // Placeholder until model.js is typed
-export interface DSModel extends EmberObject {
-  constructor: DSModelSchema;
-  store: CoreStore;
-  errors: Errors;
-  _internalModel: InternalModel;
+export interface DSModel extends RecordInstance, EmberObject {
   toString(): string;
-  save(): Promise<DSModel>;
+  save(): RSVP.Promise<DSModel>;
   eachRelationship<T>(callback: (this: T, key: string, meta: RelationshipSchema) => void, binding?: T): void;
   eachAttribute<T>(callback: (this: T, key: string, meta: AttributeSchema) => void, binding?: T): void;
   invalidErrorsChanged(errors: JsonApiValidationError[]): void;
@@ -22,7 +17,7 @@ export interface DSModel extends EmberObject {
   isDeleted: boolean;
   deleteRecord(): void;
   unloadRecord(): void;
-  _notifyProperties(keys: string[]): void;
+  errors: any;
 }
 
 // Implemented by both ShimModelClass and DSModel
@@ -44,7 +39,4 @@ export interface ModelSchema {
 //  once we can type it.
 export interface DSModelSchema extends ModelSchema {
   isModel: true;
-  relationshipsObject: RelationshipsSchema;
-  extend(...mixins: unknown[]): DSModelSchema;
-  reopenClass(...mixins: unknown[]): void;
 }

package/addon/-private/ts-interfaces/ember-data-json-api.ts

@@ -125,9 +125,6 @@ export interface ExistingResourceObject extends ExistingResourceIdentifierObject
 interface Document {
   meta?: Dict<JSONValue>;
   included?: ExistingResourceObject[];
-  jsonapi?: Dict<JSONValue>;
-  links?: Dict<string | JSONValue>;
-  errors?: JSONValue[];
 }
 
 export interface EmptyResourceDocument extends Document {

package/addon/-private/ts-interfaces/minimum-adapter-interface.ts

@@ -1,3 +1,7 @@
+// the above eslint rule checks return types. This is an interface
+// and we intend Promise whether it is Native or polyfilled is of
+// no consequence.
+
 import type Store from '../system/core-store';
 import type AdapterPopulatedRecordArray from '../system/record-arrays/adapter-populated-record-array';
 import type Snapshot from '../system/snapshot';
@@ -7,12 +11,7 @@ import type { RelationshipSchema } from './record-data-schemas';
 import type { Dict } from './utils';
 
 type Group = Snapshot[];
-// TODO this should probably just alias unknown
-// since in theory a user could pass a blob or a string
-// however those deserialization cases are handled
-// far easier in the adapter itself and are unlikely
-// to be passed to the serializer today.
-export type AdapterPayload = Dict<unknown> | unknown[];
+
 /**
  * @module @ember-data/adapter
  */
@@ -27,7 +26,7 @@ export type AdapterPayload = Dict<unknown> | unknown[];
   @class MinimumAdapterInterface
   @public
 */
-export interface MinimumAdapterInterface {
+interface Adapter {
   /**
    * `adapter.findRecord` takes a request for a resource of a given `type` and `id` combination
    * and should return a `Promise` which fulfills with data for a single resource matching that
@@ -55,7 +54,7 @@ export interface MinimumAdapterInterface {
    * @param {Snapshot} snapshot
    * @return {Promise} a promise resolving with resource data to feed to the associated serializer
    */
-  findRecord(store: Store, schema: ModelSchema, id: string, snapshot: Snapshot): Promise<AdapterPayload>;
+  findRecord(store: Store, schema: ModelSchema, id: string, snapshot: Snapshot): Promise<unknown>;
 
   /**
    * `adapter.findAll` takes a request for resources of a given `type` and should return
@@ -92,7 +91,7 @@ export interface MinimumAdapterInterface {
     schema: ModelSchema,
     sinceToken: null,
     snapshotRecordArray: SnapshotRecordArray
-  ): Promise<AdapterPayload>;
+  ): Promise<unknown>;
 
   /**
    * `adapter.query` takes a request for resources of a given `type` and should return
@@ -128,10 +127,10 @@ export interface MinimumAdapterInterface {
   query(
     store: Store,
     schema: ModelSchema,
-    query: Dict<unknown>,
+    query: Dict<any>,
     recordArray: AdapterPopulatedRecordArray,
     options: { adapterOptions?: unknown }
-  ): Promise<AdapterPayload>;
+  ): Promise<unknown>;
 
   /**
    * `adapter.queryRecord` takes a request for resource of a given `type` and should return
@@ -159,9 +158,9 @@ export interface MinimumAdapterInterface {
   queryRecord(
     store: Store,
     schema: ModelSchema,
-    query: Dict<unknown>,
+    query: Dict<any>,
     options: { adapterOptions?: unknown }
-  ): Promise<AdapterPayload>;
+  ): Promise<unknown>;
 
   /**
    * `adapter.createRecord` takes a request to create a resource of a given `type` and should
@@ -214,7 +213,7 @@ export interface MinimumAdapterInterface {
    * @param {Snapshot} snapshot
    * @return {Promise} a promise resolving with resource data to feed to the associated serializer
    */
-  createRecord(store: Store, schema: ModelSchema, snapshot: Snapshot): Promise<AdapterPayload>;
+  createRecord(store: Store, schema: ModelSchema, snapshot: Snapshot): Promise<unknown>;
 
   /**
    * `adapter.updateRecord` takes a request to update a resource of a given `type` and should
@@ -266,7 +265,7 @@ export interface MinimumAdapterInterface {
    *  the type, attributes and relationships of the primary type associated with the request.
    * @param {Snapshot} snapshot
    */
-  updateRecord(store: Store, schema: ModelSchema, snapshot: Snapshot): Promise<AdapterPayload>;
+  updateRecord(store: Store, schema: ModelSchema, snapshot: Snapshot): Promise<unknown>;
 
   /**
    * `adapter.deleteRecord` takes a request to delete a resource of a given `type` and
@@ -294,7 +293,7 @@ export interface MinimumAdapterInterface {
    * @param {Snapshot} snapshot A Snapshot containing the record's current data
    * @return
    */
-  deleteRecord(store: Store, schema: ModelSchema, snapshot: Snapshot): Promise<AdapterPayload>;
+  deleteRecord(store: Store, schema: ModelSchema, snapshot: Snapshot): Promise<unknown>;
 
   /**
    * `adapter.findBelongsTo` takes a request to fetch a related resource located at a
@@ -331,7 +330,7 @@ export interface MinimumAdapterInterface {
     snapshot: Snapshot,
     relatedLink: string,
     relationship: RelationshipSchema
-  ): Promise<AdapterPayload>;
+  ): Promise<unknown>;
 
   /**
    * `adapter.findHasMany` takes a request to fetch a related resource collection located
@@ -369,7 +368,7 @@ export interface MinimumAdapterInterface {
     snapshot: Snapshot,
     relatedLink: string,
     relationship: RelationshipSchema
-  ): Promise<AdapterPayload>;
+  ): Promise<unknown>;
 
   /**
    * ⚠️ This Method is only called if `coalesceFindRequests` is `true`. The array passed to it is determined
@@ -400,7 +399,7 @@ export interface MinimumAdapterInterface {
    * @param {Array<Snapshot>} snapshots An array of snapshots of the available data for the resources to fetch
    * @return {Promise} a promise resolving with resource data to feed to the associated serializer
    */
-  findMany?(store: Store, schema: ModelSchema, ids: string[], snapshots: Snapshot[]): Promise<AdapterPayload>;
+  findMany?(store: Store, schema: ModelSchema, ids: string[], snapshots: Snapshot[]): Promise<unknown>;
 
   /**
    * This method provides the ability to generate an ID to assign to a new record whenever `store.createRecord`
@@ -582,3 +581,5 @@ export interface MinimumAdapterInterface {
    */
   destroy?(): void;
 }
+
+export default Adapter;

package/addon/-private/ts-interfaces/minimum-serializer-interface.ts

@@ -4,21 +4,10 @@ import type Store from '../system/core-store';
 import type Snapshot from '../system/snapshot';
 import type { ModelSchema } from './ds-model';
 import type { JsonApiDocument, SingleResourceDocument } from './ember-data-json-api';
-import type { AdapterPayload } from './minimum-adapter-interface';
 import type { Dict } from './utils';
 
-export type OptionsHash = Dict<unknown>;
-export type RequestType =
-  | 'findRecord'
-  | 'queryRecord'
-  | 'findAll'
-  | 'findBelongsTo'
-  | 'findHasMany'
-  | 'findMany'
-  | 'query'
-  | 'createRecord'
-  | 'deleteRecord'
-  | 'updateRecord';
+type OptionsHash = Dict<any>;
+
 /**
   @module @ember-data/serializer
  */
@@ -33,7 +22,7 @@ export type RequestType =
   @class MinimumSerializerInterface
   @public
 */
-export interface MinimumSerializerInterface {
+interface Serializer {
   /**
    * This method is responsible for normalizing the value resolved from the promise returned
    * by an Adapter request into the format expected by the `Store`.
@@ -67,7 +56,7 @@ export interface MinimumSerializerInterface {
   normalizeResponse(
     store: Store,
     schema: ModelSchema,
-    rawPayload: AdapterPayload,
+    rawPayload: JSONObject,
     id: string | null,
     requestType:
       | 'findRecord'
@@ -242,16 +231,6 @@ export interface MinimumSerializerInterface {
    * @returns {void}
    */
   pushPayload?(store: Store, rawPayload: JSONObject): void;
-
-  /**
-   * In some situations the serializer may need to perform cleanup when destroyed,
-   * that cleanup can be done in `destroy`.
-   *
-   * If not implemented, the store does not inform the serializer of destruction.
-   *
-   * @method destroy [OPTIONAL]
-   * @public
-   * @optional
-   */
-  destroy?(): void;
 }
+
+export default Serializer;

package/addon/-private/ts-interfaces/record-data.ts

@@ -12,10 +12,7 @@ export interface ChangedAttributesHash {
 
 export interface RecordData {
   getResourceIdentifier(): RecordIdentifier | undefined;
-
-  pushData(data: JsonApiResource, calculateChange: true): string[];
-  pushData(data: JsonApiResource, calculateChange?: false): void;
-  pushData(data: JsonApiResource, calculateChange?: boolean): string[] | void;
+  pushData(data: JsonApiResource, calculateChange?: boolean): void;
   clientDidCreate(): void;
   willCommit(): void;
 

package/addon/-private/ts-interfaces/record-instance.ts

@@ -1,5 +1,3 @@
-import type { DSModel } from './ds-model';
-import type { Dict } from './utils';
 /**
   @module @ember-data/store
 */
@@ -15,4 +13,4 @@ import type { Dict } from './utils';
   The type belows allows for anything extending object.
 */
 
-export type RecordInstance = DSModel | Dict<unknown>;
+export type RecordInstance = Object;

package/addon/-private/ts-interfaces/store.ts

@@ -6,5 +6,4 @@ export interface FindOptions {
   include?: string;
   adapterOptions?: Dict<unknown>;
   preload?: Dict<unknown>;
-  isReloading?: boolean;
 }

package/addon/-private/utils/promise-record.ts

@@ -1,7 +1,7 @@
 import type InternalModel from '../system/model/internal-model';
-import type { PromiseObject } from '../system/promise-proxies';
 import { promiseObject } from '../system/promise-proxies';
-import type { RecordInstance } from '../ts-interfaces/record-instance';
+import type { DSModel } from '../ts-interfaces/ds-model';
+import type { PromiseProxy } from '../ts-interfaces/promise-proxies';
 
 /**
   @module @ember-data/store
@@ -18,7 +18,7 @@ import type { RecordInstance } from '../ts-interfaces/record-instance';
 export default function promiseRecord(
   internalModelPromise: Promise<InternalModel>,
   label: string
-): PromiseObject<RecordInstance> {
+): PromiseProxy<DSModel> {
   let toReturn = internalModelPromise.then((internalModel) => internalModel.getRecord());
 
   return promiseObject(toReturn, label);

package/index.js

@@ -35,9 +35,6 @@ module.exports = Object.assign({}, addonBaseConfig, {
       '@ember/test',
       '@ember/utils',
 
-      '@embroider/macros/es-compat',
-      '@embroider/macros/runtime',
-
       'ember-inflector',
       'ember',
       'rsvp',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ember-data/store",
-  "version": "4.4.0-alpha.8",
+  "version": "4.4.0",
   "description": "The default blueprint for ember-cli addons.",
   "keywords": [
     "ember-addon"
@@ -17,10 +17,9 @@
     "start": "ember serve"
   },
   "dependencies": {
-    "@ember-data/canary-features": "4.4.0-alpha.8",
-    "@ember-data/private-build-infra": "4.4.0-alpha.8",
+    "@ember-data/canary-features": "4.4.0",
+    "@ember-data/private-build-infra": "4.4.0",
     "@ember/string": "^3.0.0",
-    "@embroider/macros": "^1.2.0",
     "@glimmer/tracking": "^1.0.4",
     "ember-auto-import": "^2.2.4",
     "ember-cached-decorator-polyfill": "^0.1.4",
@@ -29,13 +28,13 @@
     "ember-cli-typescript": "^5.0.0"
   },
   "devDependencies": {
-    "@ember-data/unpublished-test-infra": "4.4.0-alpha.8",
+    "@ember-data/unpublished-test-infra": "4.4.0",
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.6.0",
     "@types/ember": "^4.0.0",
     "@types/rsvp": "^4.0.4",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-cli": "~4.2.0",
+    "ember-cli": "~4.3.0",
     "ember-cli-dependency-checker": "^3.2.0",
     "ember-cli-htmlbars": "^6.0.1",
     "ember-cli-inject-live-reload": "^2.0.2",
@@ -47,7 +46,7 @@
     "ember-maybe-import-regenerator": "^1.0.0",
     "ember-qunit": "^5.1.5",
     "ember-resolver": "^8.0.3",
-    "ember-source": "~4.3.0",
+    "ember-source": "~4.4.0",
     "ember-source-channel-url": "^3.0.0",
     "ember-try": "^2.0.0",
     "loader.js": "^4.7.0",

package/addon/-private/system/promise-proxy-base.js

@@ -1,7 +0,0 @@
-import ArrayProxy from '@ember/array/proxy';
-import PromiseProxyMixin from '@ember/object/promise-proxy-mixin';
-import ObjectProxy from '@ember/object/proxy';
-
-export const PromiseArrayProxy = ArrayProxy.extend(PromiseProxyMixin);
-
-export const PromiseObjectProxy = ObjectProxy.extend(PromiseProxyMixin);

package/addon/-private/system/record-arrays/adapter-populated-record-array.ts

@@ -1,129 +0,0 @@
-import type NativeArray from '@ember/array/-private/native-array';
-import { assert } from '@ember/debug';
-
-import type { PromiseArray, RecordArrayManager } from 'ember-data/-private';
-
-import type { CollectionResourceDocument, Links, Meta, PaginationLinks } from '../../ts-interfaces/ember-data-json-api';
-import type { StableRecordIdentifier } from '../../ts-interfaces/identifier';
-import type { RecordInstance } from '../../ts-interfaces/record-instance';
-import type { FindOptions } from '../../ts-interfaces/store';
-import type { Dict } from '../../ts-interfaces/utils';
-import type CoreStore from '../core-store';
-import { promiseArray } from '../promise-proxies';
-import SnapshotRecordArray from '../snapshot-record-array';
-import RecordArray from './record-array';
-
-export interface AdapterPopulatedRecordArrayCreateArgs {
-  modelName: string;
-  store: CoreStore;
-  manager: RecordArrayManager;
-  content: NativeArray<StableRecordIdentifier>;
-  isLoaded: boolean;
-  query?: Dict<unknown>;
-  meta?: Meta;
-  links?: Links | PaginationLinks | null;
-}
-
-/**
-  @module @ember-data/store
-*/
-
-/**
-  Represents an ordered list of records whose order and membership is
-  determined by the adapter. For example, a query sent to the adapter
-  may trigger a search on the server, whose results would be loaded
-  into an instance of the `AdapterPopulatedRecordArray`.
-
-  This class should not be imported and instantiated by consuming applications.
-
-  ---
-
-  If you want to update the array and get the latest records from the
-  adapter, you can invoke [`update()`](AdapterPopulatedRecordArray/methods/update?anchor=update):
-
-  Example
-
-  ```javascript
-  // GET /users?isAdmin=true
-  store.query('user', { isAdmin: true }).then(function(admins) {
-
-    admins.then(function() {
-      console.log(admins.get("length")); // 42
-    });
-
-    // somewhere later in the app code, when new admins have been created
-    // in the meantime
-    //
-    // GET /users?isAdmin=true
-    admins.update().then(function() {
-      admins.get('isUpdating'); // false
-      console.log(admins.get("length")); // 123
-    });
-
-    admins.get('isUpdating'); // true
-  }
-  ```
-
-  @class AdapterPopulatedRecordArray
-  @public
-  @extends RecordArray
-*/
-export default class AdapterPopulatedRecordArray extends RecordArray {
-  declare links: Links | PaginationLinks | null;
-  declare meta: Dict<unknown> | null;
-  declare query: Dict<unknown> | null;
-
-  init(props?: AdapterPopulatedRecordArrayCreateArgs) {
-    assert(`Cannot initialize AdapterPopulatedRecordArray with isUpdating`, !props || !('isUpdating' in props));
-    super.init();
-    this.query = this.query || null;
-    this.links = this.links || null;
-    this.meta = this.meta || null;
-  }
-
-  replace() {
-    throw new Error(`The result of a server query (on ${this.modelName}) is immutable.`);
-  }
-
-  _update(): PromiseArray<RecordInstance, AdapterPopulatedRecordArray> {
-    const { store, query } = this;
-
-    // TODO save options from initial request?
-    return promiseArray(store._query(this.modelName, query, this, {}));
-  }
-
-  _setObjects(identifiers: StableRecordIdentifier[], payload: CollectionResourceDocument) {
-    // TODO: initial load should not cause change events at all, only
-    // subsequent. This requires changing the public api of adapter.query, but
-    // hopefully we can do that soon.
-    this.content.setObjects(identifiers);
-
-    this.setProperties({
-      isLoaded: true,
-      isUpdating: false,
-      // TODO this assign kills the root reference but a deep-copy would be required
-      // for both meta and links to actually not be by-ref. We whould likely change
-      // this to a dev-only deep-freeze.
-      meta: Object.assign({}, payload.meta),
-      links: Object.assign({}, payload.links),
-    });
-
-    this.manager._associateWithRecordArray(identifiers, this);
-  }
-
-  _createSnapshot(options: FindOptions) {
-    // this is private for users, but public for ember-data internals
-    // meta will only be present for an AdapterPopulatedRecordArray
-    return new SnapshotRecordArray(this, this.meta, options);
-  }
-
-  /**
-    @method _setIdentifiers
-    @param {StableRecordIdentifier[]} identifiers
-    @param {Object} payload normalized payload
-    @private
-  */
-  _setIdentifiers(identifiers: StableRecordIdentifier[], payload: CollectionResourceDocument): void {
-    this._setObjects(identifiers, payload);
-  }
-}