@ember-data/store 4.4.0-alpha.8 → 4.4.0-alpha.9

package/addon/-private/system/core-store.ts

@@ -174,6 +174,12 @@ export interface CreateRecordProperties {
 
 abstract class CoreStore extends Service {
   /**
+   * Ember Data uses several specialized micro-queues for organizing
+    and coalescing similar async work.
+
+    These queues are currently controlled by a flush scheduled into
+    ember-data's custom backburner instance.
+   *
    * EmberData specific backburner instance
    * @property _backburner
    * @private
@@ -186,17 +192,6 @@ abstract class CoreStore extends Service {
   declare _adapterCache: Dict<MinimumAdapterInterface & { store: CoreStore }>;
   declare _serializerCache: Dict<MinimumSerializerInterface & { store: CoreStore }>;
   declare _storeWrapper: RecordDataStoreWrapper;
-
-  /*
-    Ember Data uses several specialized micro-queues for organizing
-    and coalescing similar async work.
-
-    These queues are currently controlled by a flush scheduled into
-    ember-data's custom backburner instance.
-    */
-  // used for coalescing internal model updates
-  declare _updatedInternalModels: InternalModel[];
-
   declare _fetchManager: FetchManager;
   declare _schemaDefinitionService: SchemaDefinitionService;
 
@@ -259,7 +254,6 @@ abstract class CoreStore extends Service {
     this._storeWrapper = new RecordDataStoreWrapper(this);
     this._backburner = edBackburner;
     this.recordArrayManager = new RecordArrayManager({ store: this });
-    this._updatedInternalModels = [];
 
     RECORD_REFERENCES._generator = (identifier) => {
       return new RecordReference(this, identifier);
@@ -3220,24 +3214,6 @@ abstract class CoreStore extends Service {
       }
     }
   }
-
-  _updateInternalModel(internalModel: InternalModel) {
-    if (this._updatedInternalModels.push(internalModel) !== 1) {
-      return;
-    }
-
-    emberBackburner.schedule('actions', this, this._flushUpdatedInternalModels);
-  }
-
-  _flushUpdatedInternalModels() {
-    let updated = this._updatedInternalModels;
-
-    for (let i = 0, l = updated.length; i < l; i++) {
-      updated[i]._triggerDeferredTriggers();
-    }
-
-    updated.length = 0;
-  }
 }
 
 export default CoreStore;

package/addon/-private/system/model/internal-model.ts

@@ -137,7 +137,6 @@ export default class InternalModel {
   declare _record: RecordInstance | null;
   declare _scheduledDestroy: any;
   declare _modelClass: any;
-  declare _deferredTriggers: any;
   declare __recordArrays: any;
   declare references: any;
   declare _recordReference: RecordReference;
@@ -195,7 +194,6 @@ export default class InternalModel {
     this._relationshipPromisesCache = Object.create(null);
     this._relationshipProxyCache = Object.create(null);
     this.references = Object.create(null);
-    this._deferredTriggers = [];
     this.currentState = RootState.empty;
   }
 
@@ -306,7 +304,6 @@ export default class InternalModel {
         this.identifier,
         properties
       );
-      this._triggerDeferredTriggers();
     }
 
     return record;
@@ -362,7 +359,6 @@ export default class InternalModel {
           // destroyRecord follows up deleteRecord with save(). This prevents an unecessary save for a new record
           this._deletedRecordWasNew = true;
           this.send('deleteRecord');
-          this._triggerDeferredTriggers();
           this.unloadRecord();
         } else {
           this.send('deleteRecord');
@@ -959,35 +955,6 @@ export default class InternalModel {
     throw new EmberError(errorMessage);
   }
 
-  triggerLater(...args) {
-    if (this._deferredTriggers.push(args) !== 1) {
-      return;
-    }
-
-    this.store._updateInternalModel(this);
-  }
-
-  _triggerDeferredTriggers() {
-    //TODO: Before 1.0 we want to remove all the events that happen on the pre materialized record,
-    //but for now, we queue up all the events triggered before the record was materialized, and flush
-    //them once we have the record
-    if (!this.hasRecord) {
-      return;
-    }
-    let triggers = this._deferredTriggers;
-    let record = this._record as DSModel;
-    let trigger = record.trigger;
-    // TODO Igor make nicer check
-    if (trigger && typeof trigger === 'function') {
-      for (let i = 0, l = triggers.length; i < l; i++) {
-        let eventName = triggers[i];
-        trigger.apply(record, eventName);
-      }
-    }
-
-    triggers.length = 0;
-  }
-
   removeFromInverseRelationships() {
     if (this.__recordData) {
       this.store._backburner.join(() => {

package/addon/-private/system/model/states.js

@@ -262,7 +262,6 @@ const DirtyState = {
 
     rolledBack(internalModel) {
       internalModel.transitionTo('loaded.saved');
-      internalModel.triggerLater('rolledBack');
     },
 
     becameInvalid(internalModel) {
@@ -271,7 +270,6 @@ const DirtyState = {
 
     rollback(internalModel) {
       internalModel.rollbackAttributes();
-      internalModel.triggerLater('ready');
     },
   },
 
@@ -297,9 +295,7 @@ const DirtyState = {
       internalModel.send('invokeLifecycleCallbacks', this.dirtyType);
     },
 
-    rolledBack(internalModel) {
-      internalModel.triggerLater('rolledBack');
-    },
+    rolledBack() {},
 
     becameInvalid(internalModel) {
       internalModel.transitionTo('invalid');
@@ -308,7 +304,6 @@ const DirtyState = {
 
     becameError(internalModel) {
       internalModel.transitionTo('uncommitted');
-      internalModel.triggerLater('becameError', internalModel);
     },
   },
 
@@ -345,16 +340,13 @@ const DirtyState = {
     rolledBack(internalModel) {
       clearErrorMessages(internalModel);
       internalModel.transitionTo('loaded.saved');
-      internalModel.triggerLater('ready');
     },
 
     becameValid(internalModel) {
       internalModel.transitionTo('uncommitted');
     },
 
-    invokeLifecycleCallbacks(internalModel) {
-      internalModel.triggerLater('becameInvalid', internalModel);
-    },
+    invokeLifecycleCallbacks() {},
   },
 };
 
@@ -403,12 +395,10 @@ const createdState = dirtyState({
 
 createdState.invalid.rolledBack = function (internalModel) {
   internalModel.transitionTo('deleted.saved');
-  internalModel.triggerLater('rolledBack');
 };
 
 createdState.uncommitted.rolledBack = function (internalModel) {
   internalModel.transitionTo('deleted.saved');
-  internalModel.triggerLater('rolledBack');
 };
 
 const updatedState = dirtyState({
@@ -433,7 +423,6 @@ createdState.uncommitted.pushedData = function (internalModel) {
   // TODO @runspired consider where to do this once we kill off state machine
   internalModel.store._notificationManager.notify(internalModel.identifier, 'identity');
   internalModel.transitionTo('loaded.updated.uncommitted');
-  internalModel.triggerLater('didLoad');
 };
 
 createdState.uncommitted.propertyWasReset = function () {};
@@ -458,7 +447,6 @@ updatedState.uncommitted.deleteRecord = function (internalModel) {
 updatedState.invalid.rolledBack = function (internalModel) {
   clearErrorMessages(internalModel);
   internalModel.transitionTo('loaded.saved');
-  internalModel.triggerLater('rolledBack');
 };
 
 const RootState = {
@@ -500,13 +488,10 @@ const RootState = {
 
     loadedData(internalModel) {
       internalModel.transitionTo('loaded.created.uncommitted');
-      internalModel.triggerLater('ready');
     },
 
     pushedData(internalModel) {
       internalModel.transitionTo('loaded.saved');
-      internalModel.triggerLater('didLoad');
-      internalModel.triggerLater('ready');
     },
 
     // Record is already in an empty state, triggering transition to empty here
@@ -533,15 +518,11 @@ const RootState = {
     // EVENTS
     pushedData(internalModel) {
       internalModel.transitionTo('loaded.saved');
-      internalModel.triggerLater('didLoad');
-      internalModel.triggerLater('ready');
       //TODO this seems out of place here
       internalModel.didCleanError();
     },
 
-    becameError(internalModel) {
-      internalModel.triggerLater('becameError', internalModel);
-    },
+    becameError() {},
 
     notFound(internalModel) {
       internalModel.transitionTo('empty');
@@ -640,7 +621,6 @@ const RootState = {
 
       rollback(internalModel) {
         internalModel.rollbackAttributes();
-        internalModel.triggerLater('ready');
       },
 
       pushedData() {},
@@ -649,8 +629,6 @@ const RootState = {
 
       rolledBack(internalModel) {
         internalModel.transitionTo('loaded.saved');
-        internalModel.triggerLater('ready');
-        internalModel.triggerLater('rolledBack');
       },
     },
 
@@ -676,12 +654,10 @@ const RootState = {
 
       becameError(internalModel) {
         internalModel.transitionTo('uncommitted');
-        internalModel.triggerLater('becameError', internalModel);
       },
 
       becameInvalid(internalModel) {
         internalModel.transitionTo('invalid');
-        internalModel.triggerLater('becameInvalid', internalModel);
       },
     },
 
@@ -696,10 +672,7 @@ const RootState = {
         internalModel.removeFromInverseRelationships();
       },
 
-      invokeLifecycleCallbacks(internalModel) {
-        internalModel.triggerLater('didDelete', internalModel);
-        internalModel.triggerLater('didCommit', internalModel);
-      },
+      invokeLifecycleCallbacks() {},
 
       willCommit() {},
       didCommit() {},
@@ -727,7 +700,6 @@ const RootState = {
       rolledBack(internalModel) {
         clearErrorMessages(internalModel);
         internalModel.transitionTo('loaded.saved');
-        internalModel.triggerLater('ready');
       },
 
       becameValid(internalModel) {
@@ -736,15 +708,7 @@ const RootState = {
     },
   },
 
-  invokeLifecycleCallbacks(internalModel, dirtyType) {
-    if (dirtyType === 'created') {
-      internalModel.triggerLater('didCreate', internalModel);
-    } else {
-      internalModel.triggerLater('didUpdate', internalModel);
-    }
-
-    internalModel.triggerLater('didCommit', internalModel);
-  },
+  invokeLifecycleCallbacks() {},
 };
 
 function wireState(object, parent, name) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ember-data/store",
-  "version": "4.4.0-alpha.8",
+  "version": "4.4.0-alpha.9",
   "description": "The default blueprint for ember-cli addons.",
   "keywords": [
     "ember-addon"
@@ -17,8 +17,8 @@
     "start": "ember serve"
   },
   "dependencies": {
-    "@ember-data/canary-features": "4.4.0-alpha.8",
-    "@ember-data/private-build-infra": "4.4.0-alpha.8",
+    "@ember-data/canary-features": "4.4.0-alpha.9",
+    "@ember-data/private-build-infra": "4.4.0-alpha.9",
     "@ember/string": "^3.0.0",
     "@embroider/macros": "^1.2.0",
     "@glimmer/tracking": "^1.0.4",
@@ -29,14 +29,14 @@
     "ember-cli-typescript": "^5.0.0"
   },
   "devDependencies": {
-    "@ember-data/unpublished-test-infra": "4.4.0-alpha.8",
+    "@ember-data/unpublished-test-infra": "4.4.0-alpha.9",
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "^2.6.0",
     "@types/ember": "^4.0.0",
     "@types/rsvp": "^4.0.4",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-cli": "~4.2.0",
-    "ember-cli-dependency-checker": "^3.2.0",
+    "ember-cli": "~4.3.0",
+    "ember-cli-dependency-checker": "^3.3.1",
     "ember-cli-htmlbars": "^6.0.1",
     "ember-cli-inject-live-reload": "^2.0.2",
     "ember-cli-sri": "^2.1.1",