@ember-data/model 4.8.0-alpha.3 → 4.8.0-alpha.6

package/addon/-private/references/has-many.ts

@@ -1,3 +1,4 @@
+import { deprecate } from '@ember/debug';
 import { dependentKeyCompat } from '@ember/object/compat';
 import { DEBUG } from '@glimmer/env';
 import { cached, tracked } from '@glimmer/tracking';
@@ -7,12 +8,13 @@ import { resolve } from 'rsvp';
 
 import { ManyArray } from 'ember-data/-private';
 
-import type { ManyRelationship } from '@ember-data/record-data/-private';
+import { DEPRECATE_PROMISE_PROXIES } from '@ember-data/private-build-infra/deprecations';
+import type { Graph } from '@ember-data/record-data/-private/graph';
+import type ManyRelationship from '@ember-data/record-data/-private/relationships/state/has-many';
 import type Store from '@ember-data/store';
 import { recordIdentifierFor } from '@ember-data/store';
 import { assertPolymorphicType } from '@ember-data/store/-debug';
 import type { NotificationType } from '@ember-data/store/-private/managers/record-notification-manager';
-import type { DebugWeakCache } from '@ember-data/store/-private/utils/weak-cache';
 import type {
   CollectionResourceDocument,
   CollectionResourceRelationship,
@@ -53,48 +55,51 @@ function isResourceIdentiferWithRelatedLinks(
  @extends Reference
  */
 export default class HasManyReference {
+  declare graph: Graph;
   declare key: string;
   declare hasManyRelationship: ManyRelationship;
   declare type: string;
   declare store: Store;
 
   // unsubscribe tokens given to us by the notification manager
-  #token!: Object;
-  #identifier: StableRecordIdentifier;
-  #relatedTokenMap!: Map<StableRecordIdentifier, Object>;
+  ___token!: Object;
+  ___identifier: StableRecordIdentifier;
+  ___relatedTokenMap!: Map<StableRecordIdentifier, Object>;
 
   @tracked _ref = 0;
 
   constructor(
     store: Store,
+    graph: Graph,
     parentIdentifier: StableRecordIdentifier,
     hasManyRelationship: ManyRelationship,
     key: string
   ) {
+    this.graph = graph;
     this.key = key;
     this.hasManyRelationship = hasManyRelationship;
     this.type = hasManyRelationship.definition.type;
 
     this.store = store;
-    this.#identifier = parentIdentifier;
-    this.#token = store._notificationManager.subscribe(
+    this.___identifier = parentIdentifier;
+    this.___token = store._notificationManager.subscribe(
       parentIdentifier,
       (_: StableRecordIdentifier, bucket: NotificationType, notifiedKey?: string) => {
-        if ((bucket === 'relationships' || bucket === 'property') && notifiedKey === key) {
+        if (bucket === 'relationships' && notifiedKey === key) {
           this._ref++;
         }
       }
     );
-    this.#relatedTokenMap = new Map();
+    this.___relatedTokenMap = new Map();
     // TODO inverse
   }
 
   destroy() {
-    this.store._notificationManager.unsubscribe(this.#token);
-    this.#relatedTokenMap.forEach((token) => {
+    this.store._notificationManager.unsubscribe(this.___token);
+    this.___relatedTokenMap.forEach((token) => {
       this.store._notificationManager.unsubscribe(token);
     });
-    this.#relatedTokenMap.clear();
+    this.___relatedTokenMap.clear();
   }
 
   @cached
@@ -104,34 +109,44 @@ export default class HasManyReference {
 
     let resource = this._resource();
 
-    this.#relatedTokenMap.forEach((token) => {
-      this.store._notificationManager.unsubscribe(token);
-    });
-    this.#relatedTokenMap.clear();
+    let map = this.___relatedTokenMap;
+    this.___relatedTokenMap = new Map();
 
     if (resource && resource.data) {
       return resource.data.map((resourceIdentifier) => {
         const identifier = this.store.identifierCache.getOrCreateRecordIdentifier(resourceIdentifier);
-        const token = this.store._notificationManager.subscribe(
-          identifier,
-          (_: StableRecordIdentifier, bucket: NotificationType, notifiedKey?: string) => {
-            if (bucket === 'identity' || ((bucket === 'attributes' || bucket === 'property') && notifiedKey === 'id')) {
-              this._ref++;
+        let token = map.get(identifier);
+
+        if (token) {
+          map.delete(identifier);
+        } else {
+          token = this.store._notificationManager.subscribe(
+            identifier,
+            (_: StableRecordIdentifier, bucket: NotificationType, notifiedKey?: string) => {
+              if (bucket === 'identity' || (bucket === 'attributes' && notifiedKey === 'id')) {
+                this._ref++;
+              }
             }
-          }
-        );
-
-        this.#relatedTokenMap.set(identifier, token);
+          );
+        }
+        this.___relatedTokenMap.set(identifier, token);
 
         return identifier;
       });
     }
 
+    map.forEach((token) => {
+      this.store._notificationManager.unsubscribe(token);
+    });
+    map.clear();
+
     return [];
   }
 
   _resource() {
-    return this.store._instanceCache.getRecordData(this.#identifier).getHasMany(this.key);
+    return this.store._instanceCache
+      .getRecordData(this.___identifier)
+      .getRelationship(this.___identifier, this.key) as CollectionResourceRelationship;
   }
 
   /**
@@ -145,7 +160,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -194,7 +209,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -234,7 +249,7 @@ export default class HasManyReference {
    // models/blog.js
    import Model, { belongsTo } from '@ember-data/model';
    export default Model.extend({
-      user: belongsTo({ async: true })
+      user: belongsTo('user', { async: true, inverse: null })
     });
 
    let blog = store.push({
@@ -296,7 +311,7 @@ export default class HasManyReference {
    // models/blog.js
    import Model, { hasMany } from '@ember-data/model';
    export default Model.extend({
-      users: hasMany({ async: true })
+      users: hasMany('user', { async: true, inverse: null })
     });
 
    let blog = store.push({
@@ -347,7 +362,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -384,7 +399,25 @@ export default class HasManyReference {
   async push(
     objectOrPromise: ExistingResourceObject[] | CollectionResourceDocument | { data: SingleResourceDocument[] }
   ): Promise<ManyArray> {
-    const payload = await resolve(objectOrPromise);
+    let payload = objectOrPromise;
+    if (DEPRECATE_PROMISE_PROXIES && (objectOrPromise as unknown as { then: unknown }).then) {
+      payload = await resolve(objectOrPromise);
+      if (payload !== objectOrPromise) {
+        deprecate(
+          `You passed in a Promise to a Reference API that now expects a resolved value. await the value before setting it.`,
+          false,
+          {
+            id: 'ember-data:deprecate-promise-proxies',
+            until: '5.0',
+            since: {
+              enabled: '4.8',
+              available: '4.8',
+            },
+            for: 'ember-data',
+          }
+        );
+      }
+    }
     let array: Array<ExistingResourceObject | SingleResourceDocument>;
 
     if (!Array.isArray(payload) && typeof payload === 'object' && Array.isArray(payload.data)) {
@@ -414,9 +447,9 @@ export default class HasManyReference {
       return recordIdentifierFor(record);
     });
 
-    const { graph, identifier } = this.hasManyRelationship;
-    store._backburner.join(() => {
-      graph.push({
+    const { identifier } = this.hasManyRelationship;
+    store._join(() => {
+      this.graph.push({
         op: 'replaceRelatedRecords',
         record: identifier,
         field: this.key,
@@ -433,9 +466,9 @@ export default class HasManyReference {
       return false;
     }
 
-    let members = this.hasManyRelationship.currentState;
+    let localState = this.hasManyRelationship.localState;
 
-    return members.every((identifier) => {
+    return localState.every((identifier) => {
       return this.store._instanceCache.recordIsLoaded(identifier, true) === true;
     });
   }
@@ -453,7 +486,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -482,9 +515,9 @@ export default class HasManyReference {
    @return {ManyArray}
    */
   value() {
-    const support: LegacySupport = (
-      LEGACY_SUPPORT as DebugWeakCache<StableRecordIdentifier, LegacySupport>
-    ).getWithError(this.#identifier);
+    const support: LegacySupport = (LEGACY_SUPPORT as Map<StableRecordIdentifier, LegacySupport>).get(
+      this.___identifier
+    )!;
 
     return this._isLoaded() ? support.getManyArray(this.key) : null;
   }
@@ -501,7 +534,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -554,9 +587,9 @@ export default class HasManyReference {
    this has-many relationship.
    */
   async load(options?: FindOptions): Promise<ManyArray> {
-    const support: LegacySupport = (
-      LEGACY_SUPPORT as DebugWeakCache<StableRecordIdentifier, LegacySupport>
-    ).getWithError(this.#identifier);
+    const support: LegacySupport = (LEGACY_SUPPORT as Map<StableRecordIdentifier, LegacySupport>).get(
+      this.___identifier
+    )!;
     return support.getHasMany(this.key, options) as Promise<ManyArray> | ManyArray; // this cast is necessary because typescript does not work properly with custom thenables;
   }
 
@@ -570,7 +603,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -611,9 +644,9 @@ export default class HasManyReference {
    @return {Promise} a promise that resolves with the ManyArray in this has-many relationship.
    */
   reload(options?: FindOptions) {
-    const support: LegacySupport = (
-      LEGACY_SUPPORT as DebugWeakCache<StableRecordIdentifier, LegacySupport>
-    ).getWithError(this.#identifier);
+    const support: LegacySupport = (LEGACY_SUPPORT as Map<StableRecordIdentifier, LegacySupport>).get(
+      this.___identifier
+    )!;
     return support.reloadHasMany(this.key, options);
   }
 }

package/addon/-private/relationship-meta.ts

@@ -6,10 +6,6 @@ import { singularize } from 'ember-inflector';
 import type Store from '@ember-data/store';
 import type { RelationshipSchema } from '@ember-data/types/q/record-data-schemas';
 
-/**
-  @module @ember-data/store
-*/
-
 function typeForRelationshipMeta(meta) {
   let modelName = dasherize(meta.type || meta.key);
 
@@ -25,10 +21,9 @@ function shouldFindInverse(relationshipMeta) {
   return !(options && options.inverse === null);
 }
 
-export class RelationshipDefinition implements RelationshipSchema {
+class RelationshipDefinition implements RelationshipSchema {
   declare _type: string;
   declare __inverseKey: string;
-  declare __inverseIsAsync: boolean;
   declare __hasCalculatedInverse: boolean;
   declare parentModelName: string;
   declare inverseIsAsync: string | null;
@@ -37,7 +32,6 @@ export class RelationshipDefinition implements RelationshipSchema {
   constructor(meta: any) {
     this._type = '';
     this.__inverseKey = '';
-    this.__inverseIsAsync = true;
     this.__hasCalculatedInverse = false;
     this.parentModelName = meta.parentModelName;
     this.meta = meta;
@@ -74,16 +68,9 @@ export class RelationshipDefinition implements RelationshipSchema {
     return this.__inverseKey;
   }
 
-  _inverseIsAsync(store: Store, modelClass): boolean {
-    if (this.__hasCalculatedInverse === false) {
-      this._calculateInverse(store, modelClass);
-    }
-    return this.__inverseIsAsync;
-  }
-
   _calculateInverse(store: Store, modelClass): void {
     this.__hasCalculatedInverse = true;
-    let inverseKey, inverseIsAsync;
+    let inverseKey;
     let inverse: any = null;
 
     if (shouldFindInverse(this.meta)) {
@@ -94,20 +81,13 @@ export class RelationshipDefinition implements RelationshipSchema {
 
     if (inverse) {
       inverseKey = inverse.name;
-      inverseIsAsync = isRelationshipAsync(inverse);
     } else {
       inverseKey = null;
-      inverseIsAsync = false;
     }
     this.__inverseKey = inverseKey;
-    this.__inverseIsAsync = inverseIsAsync;
   }
 }
-
-function isRelationshipAsync(meta: RelationshipSchema): boolean {
-  let inverseAsync = meta.options && meta.options.async;
-  return typeof inverseAsync === 'undefined' ? true : inverseAsync;
-}
+export type { RelationshipDefinition };
 
 export function relationshipFromMeta(meta: RelationshipSchema): RelationshipDefinition {
   return new RelationshipDefinition(meta);

package/index.js

@@ -20,6 +20,8 @@ module.exports = Object.assign({}, addonBaseConfig, {
       '@ember/string',
       '@embroider/macros/es-compat',
 
+      '@ember/object/proxy',
+      '@ember/object/promise-proxy-mixin',
       '@ember/application',
       '@ember/array',
       '@ember/array/mutable',

package/package.json

@@ -1,11 +1,15 @@
 {
   "name": "@ember-data/model",
-  "version": "4.8.0-alpha.3",
-  "description": "The default blueprint for ember-cli addons.",
+  "version": "4.8.0-alpha.6",
+  "description": "A presentation layer for apps built with @ember-data/store",
   "keywords": [
     "ember-addon"
   ],
-  "repository": "https://github.com/emberjs/data/tree/master/packages/model",
+  "repository": {
+    "type": "git",
+    "url": "git+ssh://git@github.com:emberjs/data.git",
+    "directory": "packages/model"
+  },
   "license": "MIT",
   "author": "",
   "directories": {
@@ -18,9 +22,9 @@
     "test:node": "mocha"
   },
   "dependencies": {
-    "@ember-data/canary-features": "4.8.0-alpha.3",
-    "@ember-data/private-build-infra": "4.8.0-alpha.3",
-    "@ember-data/store": "4.8.0-alpha.3",
+    "@ember-data/canary-features": "4.8.0-alpha.6",
+    "@ember-data/private-build-infra": "4.8.0-alpha.6",
+    "@ember-data/store": "4.8.0-alpha.6",
     "@ember/edition-utils": "^1.2.0",
     "@ember/string": "^3.0.0",
     "@embroider/macros": "^1.8.3",
@@ -34,7 +38,7 @@
     "inflection": "~1.13.2"
   },
   "devDependencies": {
-    "@ember-data/unpublished-test-infra": "4.8.0-alpha.3",
+    "@ember-data/unpublished-test-infra": "4.8.0-alpha.6",
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "~2.7.0",
     "broccoli-asset-rev": "^3.0.0",
@@ -67,7 +71,7 @@
     "configPath": "tests/dummy/config"
   },
   "volta": {
-    "node": "16.16.0",
+    "node": "16.17.0",
     "yarn": "1.22.19"
   }
 }