@ember-data/model 4.8.0-alpha.3 → 4.8.0-alpha.4

package/addon/-private/record-state.ts

@@ -247,10 +247,6 @@ export default class RecordState {
             this.notify('isEmpty');
             this.notify('isDirty');
             break;
-          case 'unload':
-            this.notify('isNew');
-            this.notify('isDeleted');
-            break;
           case 'errors':
             this.updateInvalidErrors(this.record.errors);
             this.notify('isValid');
@@ -326,7 +322,7 @@ export default class RecordState {
     let rd = this.recordData;
     if (this.isDeleted) {
       assert(`Expected RecordData to implement isDeletionCommitted()`, rd.isDeletionCommitted);
-      return rd.isDeletionCommitted();
+      return rd.isDeletionCommitted(this.identifier);
     }
     if (this.isNew || this.isEmpty || !this.isValid || this.isDirty || this.isLoading) {
       return false;
@@ -340,21 +336,21 @@ export default class RecordState {
     // TODO this is not actually an RFC'd concept. Determine the
     // correct heuristic to replace this with.
     assert(`Expected RecordData to implement isEmpty()`, rd.isEmpty);
-    return !this.isNew && rd.isEmpty();
+    return !this.isNew && rd.isEmpty(this.identifier);
   }
 
   @tagged
   get isNew() {
     let rd = this.recordData;
     assert(`Expected RecordData to implement isNew()`, rd.isNew);
-    return rd.isNew();
+    return rd.isNew(this.identifier);
   }
 
   @tagged
   get isDeleted() {
     let rd = this.recordData;
     assert(`Expected RecordData to implement isDeleted()`, rd.isDeleted);
-    return rd.isDeleted();
+    return rd.isDeleted(this.identifier);
   }
 
   @tagged
@@ -365,12 +361,10 @@ export default class RecordState {
   @tagged
   get isDirty() {
     let rd = this.recordData;
-    assert(`Expected RecordData to implement hasChangedAttributes()`, rd.hasChangedAttributes);
-    assert(`Expected RecordData to implement isDeletionCommitted()`, rd.isDeletionCommitted);
-    if (rd.isDeletionCommitted() || (this.isDeleted && this.isNew)) {
+    if (rd.isDeletionCommitted(this.identifier) || (this.isDeleted && this.isNew)) {
       return false;
     }
-    return this.isNew || rd.hasChangedAttributes();
+    return this.isNew || rd.hasChangedAttrs(this.identifier);
   }
 
   @tagged

package/addon/-private/references/belongs-to.ts

@@ -52,12 +52,12 @@ export default class BelongsToReference {
   declare key: string;
   declare belongsToRelationship: BelongsToRelationship;
   declare type: string;
-  #identifier: StableRecordIdentifier;
+  ___identifier: StableRecordIdentifier;
   declare store: Store;
 
   // unsubscribe tokens given to us by the notification manager
-  #token!: Object;
-  #relatedToken: Object | null = null;
+  ___token!: object;
+  ___relatedToken: object | null = null;
 
   @tracked _ref = 0;
 
@@ -71,12 +71,12 @@ export default class BelongsToReference {
     this.belongsToRelationship = belongsToRelationship;
     this.type = belongsToRelationship.definition.type;
     this.store = store;
-    this.#identifier = parentIdentifier;
+    this.___identifier = parentIdentifier;
 
-    this.#token = store._notificationManager.subscribe(
+    this.___token = store._notificationManager.subscribe(
       parentIdentifier,
       (_: StableRecordIdentifier, bucket: NotificationType, notifiedKey?: string) => {
-        if ((bucket === 'relationships' || bucket === 'property') && notifiedKey === key) {
+        if (bucket === 'relationships' && notifiedKey === key) {
           this._ref++;
         }
       }
@@ -88,9 +88,11 @@ export default class BelongsToReference {
   destroy() {
     // TODO @feature we need the notification manager often enough
     // we should potentially just expose it fully public
-    this.store._notificationManager.unsubscribe(this.#token);
-    if (this.#relatedToken) {
-      this.store._notificationManager.unsubscribe(this.#relatedToken);
+    this.store._notificationManager.unsubscribe(this.___token);
+    this.___token = null as unknown as object;
+    if (this.___relatedToken) {
+      this.store._notificationManager.unsubscribe(this.___relatedToken);
+      this.___relatedToken = null;
     }
   }
 
@@ -98,17 +100,18 @@ export default class BelongsToReference {
   @dependentKeyCompat
   get _relatedIdentifier(): StableRecordIdentifier | null {
     this._ref; // consume the tracked prop
-    if (this.#relatedToken) {
-      this.store._notificationManager.unsubscribe(this.#relatedToken);
+    if (this.___relatedToken) {
+      this.store._notificationManager.unsubscribe(this.___relatedToken);
+      this.___relatedToken = null;
     }
 
     let resource = this._resource();
     if (resource && resource.data) {
       const identifier = this.store.identifierCache.getOrCreateRecordIdentifier(resource.data);
-      this.#relatedToken = this.store._notificationManager.subscribe(
+      this.___relatedToken = this.store._notificationManager.subscribe(
         identifier,
         (_: StableRecordIdentifier, bucket: NotificationType, notifiedKey?: string) => {
-          if (bucket === 'identity' || ((bucket === 'attributes' || bucket === 'property') && notifiedKey === 'id')) {
+          if (bucket === 'identity' || (bucket === 'attributes' && notifiedKey === 'id')) {
             this._ref++;
           }
         }
@@ -134,7 +137,7 @@ export default class BelongsToReference {
    import Model, { belongsTo } from '@ember-data/model';
 
    export default class BlogModel extends Model {
-    @belongsTo({ async: true }) user;
+    @belongsTo('user', { async: true, inverse: null }) user;
    }
 
    let blog = store.push({
@@ -174,7 +177,7 @@ export default class BelongsToReference {
    // models/blog.js
    import Model, { belongsTo } from '@ember-data/model';
    export default Model.extend({
-      user: belongsTo({ async: true })
+      user: belongsTo('user', { async: true, inverse: null })
     });
 
    let blog = store.push({
@@ -236,7 +239,7 @@ export default class BelongsToReference {
    // models/blog.js
    import Model, { belongsTo } from '@ember-data/model';
    export default Model.extend({
-      user: belongsTo({ async: true })
+      user: belongsTo('user', { async: true, inverse: null })
     });
 
    let blog = store.push({
@@ -277,7 +280,9 @@ export default class BelongsToReference {
   }
 
   _resource() {
-    return this.store._instanceCache.getRecordData(this.#identifier).getBelongsTo(this.key);
+    return this.store._instanceCache
+      .getRecordData(this.___identifier)
+      .getRelationship(this.___identifier, this.key) as SingleResourceRelationship;
   }
 
   /**
@@ -291,7 +296,7 @@ export default class BelongsToReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -341,7 +346,7 @@ export default class BelongsToReference {
    import Model, { belongsTo } from '@ember-data/model';
 
    export default class BlogModel extends Model {
-      @belongsTo({ async: true }) user;
+      @belongsTo('user', { async: true, inverse: null }) user;
     }
 
    let blog = store.push({
@@ -416,7 +421,7 @@ export default class BelongsToReference {
    import Model, { belongsTo } from '@ember-data/model';
 
    export default class BlogModel extends Model {
-     @belongsTo({ async: true }) user;
+     @belongsTo('user', { async: true, inverse: null }) user;
    }
 
    let blog = store.push({
@@ -469,7 +474,7 @@ export default class BelongsToReference {
    import Model, { belongsTo } from '@ember-data/model';
 
    export default class BlogModel extends Model {
-     @belongsTo({ async: true }) user;
+     @belongsTo('user', { async: true, inverse: null }) user;
    }
 
    let blog = store.push({
@@ -522,7 +527,7 @@ export default class BelongsToReference {
   load(options?: Dict<unknown>) {
     const support: LegacySupport = (
       LEGACY_SUPPORT as DebugWeakCache<StableRecordIdentifier, LegacySupport>
-    ).getWithError(this.#identifier);
+    ).getWithError(this.___identifier);
     return support.getBelongsTo(this.key, options);
   }
 
@@ -539,7 +544,7 @@ export default class BelongsToReference {
    import Model, { belongsTo } from '@ember-data/model';
 
    export default class BlogModel extends Model {
-     @belongsTo({ async: true }) user;
+     @belongsTo('user', { async: true, inverse: null }) user;
    }
 
    let blog = store.push({
@@ -579,7 +584,7 @@ export default class BelongsToReference {
   reload(options?: Dict<unknown>) {
     const support: LegacySupport = (
       LEGACY_SUPPORT as DebugWeakCache<StableRecordIdentifier, LegacySupport>
-    ).getWithError(this.#identifier);
+    ).getWithError(this.___identifier);
     return support.reloadBelongsTo(this.key, options).then(() => this.value());
   }
 }

package/addon/-private/references/has-many.ts

@@ -59,9 +59,9 @@ export default class HasManyReference {
   declare store: Store;
 
   // unsubscribe tokens given to us by the notification manager
-  #token!: Object;
-  #identifier: StableRecordIdentifier;
-  #relatedTokenMap!: Map<StableRecordIdentifier, Object>;
+  ___token!: Object;
+  ___identifier: StableRecordIdentifier;
+  ___relatedTokenMap!: Map<StableRecordIdentifier, Object>;
 
   @tracked _ref = 0;
 
@@ -76,25 +76,25 @@ export default class HasManyReference {
     this.type = hasManyRelationship.definition.type;
 
     this.store = store;
-    this.#identifier = parentIdentifier;
-    this.#token = store._notificationManager.subscribe(
+    this.___identifier = parentIdentifier;
+    this.___token = store._notificationManager.subscribe(
       parentIdentifier,
       (_: StableRecordIdentifier, bucket: NotificationType, notifiedKey?: string) => {
-        if ((bucket === 'relationships' || bucket === 'property') && notifiedKey === key) {
+        if (bucket === 'relationships' && notifiedKey === key) {
           this._ref++;
         }
       }
     );
-    this.#relatedTokenMap = new Map();
+    this.___relatedTokenMap = new Map();
     // TODO inverse
   }
 
   destroy() {
-    this.store._notificationManager.unsubscribe(this.#token);
-    this.#relatedTokenMap.forEach((token) => {
+    this.store._notificationManager.unsubscribe(this.___token);
+    this.___relatedTokenMap.forEach((token) => {
       this.store._notificationManager.unsubscribe(token);
     });
-    this.#relatedTokenMap.clear();
+    this.___relatedTokenMap.clear();
   }
 
   @cached
@@ -104,34 +104,44 @@ export default class HasManyReference {
 
     let resource = this._resource();
 
-    this.#relatedTokenMap.forEach((token) => {
-      this.store._notificationManager.unsubscribe(token);
-    });
-    this.#relatedTokenMap.clear();
+    let map = this.___relatedTokenMap;
+    this.___relatedTokenMap = new Map();
 
     if (resource && resource.data) {
       return resource.data.map((resourceIdentifier) => {
         const identifier = this.store.identifierCache.getOrCreateRecordIdentifier(resourceIdentifier);
-        const token = this.store._notificationManager.subscribe(
-          identifier,
-          (_: StableRecordIdentifier, bucket: NotificationType, notifiedKey?: string) => {
-            if (bucket === 'identity' || ((bucket === 'attributes' || bucket === 'property') && notifiedKey === 'id')) {
-              this._ref++;
+        let token = map.get(identifier);
+
+        if (token) {
+          map.delete(identifier);
+        } else {
+          token = this.store._notificationManager.subscribe(
+            identifier,
+            (_: StableRecordIdentifier, bucket: NotificationType, notifiedKey?: string) => {
+              if (bucket === 'identity' || (bucket === 'attributes' && notifiedKey === 'id')) {
+                this._ref++;
+              }
             }
-          }
-        );
-
-        this.#relatedTokenMap.set(identifier, token);
+          );
+        }
+        this.___relatedTokenMap.set(identifier, token);
 
         return identifier;
       });
     }
 
+    map.forEach((token) => {
+      this.store._notificationManager.unsubscribe(token);
+    });
+    map.clear();
+
     return [];
   }
 
   _resource() {
-    return this.store._instanceCache.getRecordData(this.#identifier).getHasMany(this.key);
+    return this.store._instanceCache
+      .getRecordData(this.___identifier)
+      .getRelationship(this.___identifier, this.key) as CollectionResourceRelationship;
   }
 
   /**
@@ -145,7 +155,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -194,7 +204,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -234,7 +244,7 @@ export default class HasManyReference {
    // models/blog.js
    import Model, { belongsTo } from '@ember-data/model';
    export default Model.extend({
-      user: belongsTo({ async: true })
+      user: belongsTo('user', { async: true, inverse: null })
     });
 
    let blog = store.push({
@@ -296,7 +306,7 @@ export default class HasManyReference {
    // models/blog.js
    import Model, { hasMany } from '@ember-data/model';
    export default Model.extend({
-      users: hasMany({ async: true })
+      users: hasMany('user', { async: true, inverse: null })
     });
 
    let blog = store.push({
@@ -347,7 +357,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -453,7 +463,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -484,7 +494,7 @@ export default class HasManyReference {
   value() {
     const support: LegacySupport = (
       LEGACY_SUPPORT as DebugWeakCache<StableRecordIdentifier, LegacySupport>
-    ).getWithError(this.#identifier);
+    ).getWithError(this.___identifier);
 
     return this._isLoaded() ? support.getManyArray(this.key) : null;
   }
@@ -501,7 +511,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -556,7 +566,7 @@ export default class HasManyReference {
   async load(options?: FindOptions): Promise<ManyArray> {
     const support: LegacySupport = (
       LEGACY_SUPPORT as DebugWeakCache<StableRecordIdentifier, LegacySupport>
-    ).getWithError(this.#identifier);
+    ).getWithError(this.___identifier);
     return support.getHasMany(this.key, options) as Promise<ManyArray> | ManyArray; // this cast is necessary because typescript does not work properly with custom thenables;
   }
 
@@ -570,7 +580,7 @@ export default class HasManyReference {
    import Model, { hasMany } from '@ember-data/model';
 
    export default class PostModel extends Model {
-     @hasMany({ async: true }) comments;
+     @hasMany('comment', { async: true, inverse: null }) comments;
    }
    ```
 
@@ -613,7 +623,7 @@ export default class HasManyReference {
   reload(options?: FindOptions) {
     const support: LegacySupport = (
       LEGACY_SUPPORT as DebugWeakCache<StableRecordIdentifier, LegacySupport>
-    ).getWithError(this.#identifier);
+    ).getWithError(this.___identifier);
     return support.reloadHasMany(this.key, options);
   }
 }

package/addon/-private/relationship-meta.ts

@@ -6,10 +6,6 @@ import { singularize } from 'ember-inflector';
 import type Store from '@ember-data/store';
 import type { RelationshipSchema } from '@ember-data/types/q/record-data-schemas';
 
-/**
-  @module @ember-data/store
-*/
-
 function typeForRelationshipMeta(meta) {
   let modelName = dasherize(meta.type || meta.key);
 
@@ -25,10 +21,9 @@ function shouldFindInverse(relationshipMeta) {
   return !(options && options.inverse === null);
 }
 
-export class RelationshipDefinition implements RelationshipSchema {
+class RelationshipDefinition implements RelationshipSchema {
   declare _type: string;
   declare __inverseKey: string;
-  declare __inverseIsAsync: boolean;
   declare __hasCalculatedInverse: boolean;
   declare parentModelName: string;
   declare inverseIsAsync: string | null;
@@ -37,7 +32,6 @@ export class RelationshipDefinition implements RelationshipSchema {
   constructor(meta: any) {
     this._type = '';
     this.__inverseKey = '';
-    this.__inverseIsAsync = true;
     this.__hasCalculatedInverse = false;
     this.parentModelName = meta.parentModelName;
     this.meta = meta;
@@ -74,16 +68,9 @@ export class RelationshipDefinition implements RelationshipSchema {
     return this.__inverseKey;
   }
 
-  _inverseIsAsync(store: Store, modelClass): boolean {
-    if (this.__hasCalculatedInverse === false) {
-      this._calculateInverse(store, modelClass);
-    }
-    return this.__inverseIsAsync;
-  }
-
   _calculateInverse(store: Store, modelClass): void {
     this.__hasCalculatedInverse = true;
-    let inverseKey, inverseIsAsync;
+    let inverseKey;
     let inverse: any = null;
 
     if (shouldFindInverse(this.meta)) {
@@ -94,20 +81,13 @@ export class RelationshipDefinition implements RelationshipSchema {
 
     if (inverse) {
       inverseKey = inverse.name;
-      inverseIsAsync = isRelationshipAsync(inverse);
     } else {
       inverseKey = null;
-      inverseIsAsync = false;
     }
     this.__inverseKey = inverseKey;
-    this.__inverseIsAsync = inverseIsAsync;
   }
 }
-
-function isRelationshipAsync(meta: RelationshipSchema): boolean {
-  let inverseAsync = meta.options && meta.options.async;
-  return typeof inverseAsync === 'undefined' ? true : inverseAsync;
-}
+export type { RelationshipDefinition };
 
 export function relationshipFromMeta(meta: RelationshipSchema): RelationshipDefinition {
   return new RelationshipDefinition(meta);

package/package.json

@@ -1,11 +1,15 @@
 {
   "name": "@ember-data/model",
-  "version": "4.8.0-alpha.3",
-  "description": "The default blueprint for ember-cli addons.",
+  "version": "4.8.0-alpha.4",
+  "description": "A presentation layer for apps built with @ember-data/store",
   "keywords": [
     "ember-addon"
   ],
-  "repository": "https://github.com/emberjs/data/tree/master/packages/model",
+  "repository": {
+    "type": "git",
+    "url": "git+ssh://git@github.com:emberjs/data.git",
+    "directory": "packages/model"
+  },
   "license": "MIT",
   "author": "",
   "directories": {
@@ -18,9 +22,9 @@
     "test:node": "mocha"
   },
   "dependencies": {
-    "@ember-data/canary-features": "4.8.0-alpha.3",
-    "@ember-data/private-build-infra": "4.8.0-alpha.3",
-    "@ember-data/store": "4.8.0-alpha.3",
+    "@ember-data/canary-features": "4.8.0-alpha.4",
+    "@ember-data/private-build-infra": "4.8.0-alpha.4",
+    "@ember-data/store": "4.8.0-alpha.4",
     "@ember/edition-utils": "^1.2.0",
     "@ember/string": "^3.0.0",
     "@embroider/macros": "^1.8.3",
@@ -34,7 +38,7 @@
     "inflection": "~1.13.2"
   },
   "devDependencies": {
-    "@ember-data/unpublished-test-infra": "4.8.0-alpha.3",
+    "@ember-data/unpublished-test-infra": "4.8.0-alpha.4",
     "@ember/optional-features": "^2.0.0",
     "@ember/test-helpers": "~2.7.0",
     "broccoli-asset-rev": "^3.0.0",