@ember-data/model 4.10.0-beta.2 → 4.10.0

package/addon/-private/legacy-relationships-support.ts

@@ -749,7 +749,7 @@ function anyUnloaded(store: Store, relationship: ManyRelationship) {
   return unloaded || false;
 }
 
-export function areAllInverseRecordsLoaded(store: Store, resource: JsonApiRelationship): boolean {
+function areAllInverseRecordsLoaded(store: Store, resource: JsonApiRelationship): boolean {
   const instanceCache = store._instanceCache;
   const identifiers = resource.data;
 

package/addon/-private/promise-belongs-to.ts

@@ -2,7 +2,6 @@ import { assert } from '@ember/debug';
 import { computed } from '@ember/object';
 import type PromiseProxyMixin from '@ember/object/promise-proxy-mixin';
 import type ObjectProxy from '@ember/object/proxy';
-import { cached } from '@glimmer/tracking';
 
 import type Store from '@ember-data/store';
 import type { RecordInstance } from '@ember-data/types/q/record-instance';
@@ -10,7 +9,6 @@ import type { Dict } from '@ember-data/types/q/utils';
 
 import { LegacySupport } from './legacy-relationships-support';
 import { PromiseObject } from './promise-proxy-base';
-import type BelongsToReference from './references/belongs-to';
 
 export interface BelongsToProxyMeta {
   key: string;
@@ -47,15 +45,6 @@ const Extended: PromiseObjectType<RecordInstance> = PromiseObject as unknown as
 */
 class PromiseBelongsTo extends Extended<RecordInstance> {
   declare _belongsToState: BelongsToProxyMeta;
-
-  @cached
-  get id() {
-    const { key, legacySupport } = this._belongsToState;
-    const ref = legacySupport.referenceFor('belongsTo', key) as BelongsToReference;
-
-    return ref.id();
-  }
-
   // we don't proxy meta because we would need to proxy it to the relationship state container
   //  however, meta on relationships does not trigger change notifications.
   //  if you need relationship meta, you should do `record.belongsTo(relationshipName).meta()`

package/addon/-private/references/belongs-to.ts

@@ -23,7 +23,7 @@ import type { RecordInstance } from '@ember-data/types/q/record-instance';
 import type { Dict } from '@ember-data/types/q/utils';
 
 import { assertPolymorphicType } from '../debug/assert-polymorphic-type';
-import { areAllInverseRecordsLoaded, LegacySupport } from '../legacy-relationships-support';
+import type { LegacySupport } from '../legacy-relationships-support';
 import { LEGACY_SUPPORT } from '../model';
 
 /**
@@ -112,6 +112,7 @@ export default class BelongsToReference {
   @cached
   @dependentKeyCompat
   get identifier(): StableRecordIdentifier | null {
+    this._ref; // consume the tracked prop
     if (this.___relatedToken) {
       this.store._notificationManager.unsubscribe(this.___relatedToken);
       this.___relatedToken = null;
@@ -292,7 +293,6 @@ export default class BelongsToReference {
   }
 
   _resource() {
-    this._ref; // subscribe
     return this.store._instanceCache
       .getRecordData(this.___identifier)
       .getRelationship(this.___identifier, this.key) as SingleResourceRelationship;
@@ -562,11 +562,7 @@ export default class BelongsToReference {
     const support: LegacySupport = (LEGACY_SUPPORT as Map<StableRecordIdentifier, LegacySupport>).get(
       this.___identifier
     )!;
-    const fetchSyncRel =
-      !this.belongsToRelationship.definition.isAsync && !areAllInverseRecordsLoaded(this.store, this._resource());
-    return fetchSyncRel
-      ? support.reloadBelongsTo(this.key, options).then(() => this.value())
-      : support.getBelongsTo(this.key, options);
+    return support.getBelongsTo(this.key, options);
   }
 
   /**

package/addon/-private/references/has-many.ts

@@ -28,7 +28,7 @@ import type { FindOptions } from '@ember-data/types/q/store';
 import type { Dict } from '@ember-data/types/q/utils';
 
 import { assertPolymorphicType } from '../debug/assert-polymorphic-type';
-import { areAllInverseRecordsLoaded, LegacySupport } from '../legacy-relationships-support';
+import type { LegacySupport } from '../legacy-relationships-support';
 import { LEGACY_SUPPORT } from '../model';
 
 /**
@@ -607,11 +607,7 @@ export default class HasManyReference {
     const support: LegacySupport = (LEGACY_SUPPORT as Map<StableRecordIdentifier, LegacySupport>).get(
       this.___identifier
     )!;
-    const fetchSyncRel =
-      !this.hasManyRelationship.definition.isAsync && !areAllInverseRecordsLoaded(this.store, this._resource());
-    return fetchSyncRel
-      ? (support.reloadHasMany(this.key, options) as Promise<ManyArray>)
-      : (support.getHasMany(this.key, options) as Promise<ManyArray> | ManyArray); // this cast is necessary because typescript does not work properly with custom thenables;
+    return support.getHasMany(this.key, options) as Promise<ManyArray> | ManyArray; // this cast is necessary because typescript does not work properly with custom thenables;
   }
 
   /**

package/index.js

@@ -27,7 +27,6 @@ module.exports = Object.assign({}, addonBaseConfig, {
       '@ember/array/mutable',
       '@ember/array/proxy',
       '@ember/debug',
-      '@ember/error',
       '@ember/object',
       '@ember/object/compat',
       '@ember/object/computed',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ember-data/model",
-  "version": "4.10.0-beta.2",
+  "version": "4.10.0",
   "description": "A presentation layer for apps built with @ember-data/store",
   "keywords": [
     "ember-addon"
@@ -14,10 +14,10 @@
   "author": "",
   "directories": {},
   "peerDependencies": {
-    "@ember-data/record-data": "4.10.0-beta.2",
-    "@ember-data/store": "4.10.0-beta.2",
-    "@ember-data/tracking": "4.10.0-beta.2",
-    "@ember/string": "^3.0.0",
+    "@ember-data/record-data": "4.10.0",
+    "@ember-data/store": "4.10.0",
+    "@ember-data/tracking": "4.10.0",
+    "@ember/string": "^3.0.1",
     "ember-inflector": "^4.0.2"
   },
   "peerDependenciesMeta": {
@@ -34,11 +34,11 @@
     }
   },
   "dependencies": {
-    "@ember-data/canary-features": "4.10.0-beta.2",
-    "@ember-data/private-build-infra": "4.10.0-beta.2",
+    "@ember-data/canary-features": "4.10.0",
+    "@ember-data/private-build-infra": "4.10.0",
     "@ember/edition-utils": "^1.2.0",
     "@embroider/macros": "^1.10.0",
-    "ember-auto-import": "^2.5.0",
+    "ember-auto-import": "^2.4.3",
     "ember-cached-decorator-polyfill": "^1.0.1",
     "ember-cli-babel": "^7.26.11",
     "ember-cli-string-utils": "^1.1.0",
@@ -59,6 +59,6 @@
   "volta": {
     "extends": "../../package.json"
   },
-  "packageManager": "pnpm@7.18.0",
+  "packageManager": "pnpm@7.15.0",
   "scripts": {}
 }