@embeddable.com/sdk-react 2.2.24 → 2.2.25

package/lib/index.js

@@ -530,8 +530,15 @@ const componentMetaSchema = zod.z
     }
 });
 
+const getObjectProperty = (value) => value.object.name + "." + value.property.name;
 // @ts-ignore
 const babelTraverse = traverse.default;
+const parseAndTraverse = (code, visitor) => {
+    const ast = parser.parse(code || "", {
+        sourceType: "module",
+    });
+    babelTraverse(ast, visitor);
+};
 const componentMetaValidator = (metaInfo) => {
     const result = componentMetaSchema.safeParse(metaInfo.meta);
     if (!result.success)
@@ -539,14 +546,58 @@ const componentMetaValidator = (metaInfo) => {
     let moduleNameErrors = validateModuleName(metaInfo);
     const variableErrors = validateVariables(metaInfo.meta);
     const eventErrors = validateComponentEvents(metaInfo);
-    return [...moduleNameErrors, ...variableErrors, ...eventErrors];
+    const loadDataErrors = validateComponentProps(metaInfo);
+    return [
+        ...moduleNameErrors,
+        ...variableErrors,
+        ...eventErrors,
+        ...loadDataErrors,
+    ];
+};
+const validateComponentProps = (metaInfo) => {
+    const errors = [];
+    parseAndTraverse(metaInfo.moduleInfo.code, {
+        ExportDefaultDeclaration: (path) => {
+            var _a, _b, _c;
+            const componentConfig = path.node.declaration
+                .arguments[2];
+            const propsNode = (_a = componentConfig.properties) === null || _a === void 0 ? void 0 : _a.find((x) => { var _a; return ((_a = x.key) === null || _a === void 0 ? void 0 : _a.name) === "props"; });
+            // There is no props defined
+            if (!propsNode)
+                return;
+            const propsReturnStatement = propsNode.value.body.body.find((x) => x.type === "ReturnStatement");
+            const results = (_b = propsReturnStatement === null || propsReturnStatement === void 0 ? void 0 : propsReturnStatement.argument) === null || _b === void 0 ? void 0 : _b.properties.find((x) => { var _a; return ((_a = x === null || x === void 0 ? void 0 : x.key) === null || _a === void 0 ? void 0 : _a.name) === "results"; });
+            // There is no results defined inside props
+            if (results === undefined) {
+                return;
+            }
+            const loadDataProperties = (_c = results === null || results === void 0 ? void 0 : results.value) === null || _c === void 0 ? void 0 : _c.arguments[0].properties;
+            const dimensions = loadDataProperties.find((prop) => prop.key.name === "dimensions");
+            const timeDimensions = loadDataProperties.find((prop) => prop.key.name === "timeDimensions");
+            // There is no missuse of dimensions and timeDimensions
+            if (!dimensions || !timeDimensions)
+                return;
+            const usedDimensions = dimensions.value.elements.map((x) => getObjectProperty(x));
+            const usedTimeDimensions = timeDimensions.value.elements
+                .map((x) => x.properties)
+                .flatMap((group) => group
+                .filter((property) => property.key.name === "dimension")
+                .map((property) => getObjectProperty(property.value.object)));
+            usedDimensions.forEach((dimension) => {
+                if (usedTimeDimensions.includes(dimension)) {
+                    errors.push(`Dimension ${dimension} should not be requested as both a dimension and a timeDimension.`);
+                }
+            });
+        },
+    });
+    return errors;
 };
 const validateComponentEvents = (metaInfo) => {
     var _a, _b;
     const definedEvents = (_b = (_a = metaInfo.meta.events) === null || _a === void 0 ? void 0 : _a.map((e) => e.name)) !== null && _b !== void 0 ? _b : [];
     let implementedEvents = [];
     const errors = [];
-    babelTraverse(metaInfo.moduleInfo.ast, {
+    parseAndTraverse(metaInfo.moduleInfo.code, {
         ExportDefaultDeclaration: (path) => {
             var _a, _b, _c, _d;
             const componentConfig = path.node.declaration