@embeddable.com/sdk-core 4.1.3 → 4.1.4-next.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@embeddable.com/sdk-core",
-  "version": "4.1.3",
+  "version": "4.1.4-next.0",
   "description": "Core Embeddable SDK module responsible for web-components bundling and publishing.",
   "keywords": [
     "embeddable",
@@ -40,7 +40,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "@embeddable.com/core": "2.13.0",
+    "@embeddable.com/core": "2.13.1-next.0",
     "@embeddable.com/sdk-utils": "0.8.2",
     "@inquirer/prompts": "^7.2.1",
     "@stencil/core": "^4.23.0",

package/src/buildGlobalHooks.ts

@@ -176,7 +176,7 @@ async function generateTemporaryHookFile(
 
   const newContent = templateContent
     .replace("{{LIBRARY_THEME_IMPORTS}}", libraryThemeImports.join("\n"))
-    .replace("{{ARRAY_OF_LIBRARY_THEME_PROVIDERS}}", functionNames.join("\n"))
+    .replace("{{ARRAY_OF_LIBRARY_THEME_PROVIDERS}}", functionNames.join(",\n  "))
     .replace("{{LOCAL_THEME_IMPORT}}", repoThemeImport);
 
   // Write to temporary hook file

package/src/validate.test.ts

@@ -11,7 +11,9 @@ const startMock = {
 };
 
 vi.mock("@embeddable.com/sdk-utils", () => ({
-  errorFormatter: vi.fn(),
+  errorFormatter: vi.fn((issues) =>
+    issues.map((issue: any) => issue.message || "Validation error")
+  ),
   findFiles: vi.fn(),
 }));
 
@@ -49,6 +51,34 @@ const clientContextYaml = `
   clientContext:
     color: blue`;
 
+const clientContextWithVariablesYaml = `
+- name: US
+  clientContext:
+    theme: default
+    locale: en-US
+  variables:
+    currency: USD
+    country: United States`;
+
+const clientContextWithEmptyVariablesYaml = `
+- name: UK
+  clientContext:
+    theme: default
+    locale: en-GB
+  variables: {}`;
+
+const clientContextWithVariousVariableTypesYaml = `
+- name: Complex
+  clientContext:
+    theme: dark
+  variables:
+    stringVar: "hello"
+    numberVar: 42
+    booleanVar: true
+    arrayVar: [1, 2, 3]
+    objectVar:
+      nested: "value"`;
+
 vi.mock("ora", () => ({
   default: () => ({
     start: vi.fn().mockImplementation(() => startMock),
@@ -160,5 +190,192 @@ describe("validate", () => {
         'path/to/file: client context with name "blue" already exists',
       ]);
     });
+
+    it("should validate client context with variables field", async () => {
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return clientContextWithVariablesYaml;
+      });
+      const filesList: [string, string][] = [
+        ["valid-client-context-with-variables.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
+
+    it("should validate client context with empty variables object", async () => {
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return clientContextWithEmptyVariablesYaml;
+      });
+      const filesList: [string, string][] = [
+        ["valid-client-context-empty-variables.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
+
+    it("should validate client context with various variable types", async () => {
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return clientContextWithVariousVariableTypesYaml;
+      });
+      const filesList: [string, string][] = [
+        ["valid-client-context-various-types.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
+
+    it("should validate client context without variables field (backward compatibility)", async () => {
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return clientContextYaml;
+      });
+      const filesList: [string, string][] = [
+        ["valid-client-context-no-variables.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
+
+    it("should reject client context with variables as non-object type", async () => {
+      const invalidYaml = `
+- name: Invalid
+  clientContext:
+    theme: default
+  variables: "not an object"`;
+
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return invalidYaml;
+      });
+      const filesList: [string, string][] = [
+        ["invalid-variables-type.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result.length).toBeGreaterThan(0);
+      expect(result[0]).toContain("path/to/file");
+    });
+
+    it("should reject client context with variables as array", async () => {
+      const invalidYaml = `
+- name: Invalid
+  clientContext:
+    theme: default
+  variables:
+    - item1
+    - item2`;
+
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return invalidYaml;
+      });
+      const filesList: [string, string][] = [
+        ["invalid-variables-array.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result.length).toBeGreaterThan(0);
+      expect(result[0]).toContain("path/to/file");
+    });
+
+    it("should validate client context with variables containing null values", async () => {
+      const yamlWithNull = `
+- name: WithNull
+  clientContext:
+    theme: default
+  variables:
+    nullableVar: null
+    stringVar: "value"`;
+
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return yamlWithNull;
+      });
+      const filesList: [string, string][] = [
+        ["valid-with-null.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
+
+    it("should validate multiple client contexts with variables in same file", async () => {
+      const multipleContextsYaml = `
+- name: US
+  clientContext:
+    theme: default
+  variables:
+    currency: USD
+- name: UK
+  clientContext:
+    theme: default
+  variables:
+    currency: GBP`;
+
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return multipleContextsYaml;
+      });
+      const filesList: [string, string][] = [
+        ["multiple-contexts.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
+
+    it("should validate client context with variables having special characters in keys", async () => {
+      const yamlWithSpecialKeys = `
+- name: SpecialKeys
+  clientContext:
+    theme: default
+  variables:
+    "key-with-dashes": "value1"
+    "key_with_underscores": "value2"
+    "key.with.dots": "value3"
+    "key with spaces": "value4"`;
+
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return yamlWithSpecialKeys;
+      });
+      const filesList: [string, string][] = [
+        ["special-keys.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
+
+    it("should validate client context with deeply nested variables", async () => {
+      const yamlWithNested = `
+- name: Nested
+  clientContext:
+    theme: default
+  variables:
+    level1:
+      level2:
+        level3: "deep value"
+        array: [1, 2, 3]
+      simple: "value"`;
+
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return yamlWithNested;
+      });
+      const filesList: [string, string][] = [
+        ["nested-variables.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
+
+    it("should validate client context with variables and canvas together", async () => {
+      const yamlWithBoth = `
+- name: Complete
+  clientContext:
+    theme: default
+  variables:
+    currency: USD
+  canvas:
+    width: 800`;
+
+      vi.mocked(fs.readFile).mockImplementation(async () => {
+        return yamlWithBoth;
+      });
+      const filesList: [string, string][] = [
+        ["complete-context.yaml", "path/to/file"],
+      ];
+      const result = await clientContextValidation(filesList);
+      expect(result).toEqual([]);
+    });
   });
 });

package/src/validate.ts

@@ -237,6 +237,7 @@ const clientContextSchema = z.array(
     .object({
       name: z.string(),
       clientContext: z.object({}), // can be any object
+      variables: z.record(z.any()).optional(), // variables key-value pairs
       canvas: z.object({}).optional(),
     })
     .strict(),