@embeddable.com/sdk-core 4.0.0-next.2 → 4.0.1-next.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@embeddable.com/sdk-core",
-  "version": "4.0.0-next.2",
+  "version": "4.0.1-next.0",
   "description": "Core Embeddable SDK module responsible for web-components bundling and publishing.",
   "keywords": [
     "embeddable",
@@ -40,8 +40,8 @@
   },
   "license": "MIT",
   "dependencies": {
-    "@embeddable.com/core": "2.10.4",
-    "@embeddable.com/sdk-utils": "0.8.1-next.0",
+    "@embeddable.com/core": "2.10.6-next.0",
+    "@embeddable.com/sdk-utils": "0.8.1",
     "@inquirer/prompts": "^7.2.1",
     "@stencil/core": "^4.23.0",
     "@swc-node/register": "^1.10.9",

package/src/buildTypes.test.ts

@@ -101,6 +101,9 @@ describe("buildTypes", () => {
     expect(build).toHaveBeenCalledWith({
       build: {
         emptyOutDir: false,
+        sourcemap: true,
+        minify: true,
+        rollupOptions: undefined,
         lib: {
           entry: "resolvedPath",
           fileName: "embeddable-types",
@@ -134,6 +137,49 @@ import '../relativePath';`,
     expect(getContentHash).not.toHaveBeenCalled();
     expect(fs.rename).not.toHaveBeenCalled();
   });
+
+  it("should use dev optimizations when watch mode is enabled", async () => {
+    await buildTypes({
+      ...config,
+      dev: { watch: true, logger: undefined, sys: undefined },
+    } as unknown as ResolvedEmbeddableConfig);
+
+    expect(build).toHaveBeenCalledWith({
+      build: {
+        emptyOutDir: false,
+        sourcemap: false,
+        minify: false,
+        rollupOptions: { treeshake: false },
+        lib: {
+          entry: "resolvedPath",
+          fileName: "embeddable-types",
+          formats: ["es"],
+        },
+        outDir: "build",
+      },
+      logLevel: "error",
+    });
+  });
+
+  it("should rename the built file with hash when not in watch mode", async () => {
+    // Reset the mock to control it better
+    vi.mocked(path.resolve).mockReset();
+    
+    // Mock the calls in order they happen
+    vi.mocked(path.resolve)
+      .mockReturnValueOnce("resolvedPath") // typesFilePath in build()
+      .mockReturnValueOnce("resolvedPath") // typesFilePath for readFile
+      .mockReturnValueOnce("build/embeddable-types.js") // source file for rename
+      .mockReturnValueOnce("build/embeddable-types-somehash.js"); // target file for rename
+
+    await buildTypes(config as unknown as ResolvedEmbeddableConfig);
+
+    expect(fs.rename).toHaveBeenCalledWith(
+      "build/embeddable-types.js",
+      "build/embeddable-types-somehash.js"
+    );
+  });
+
   it("should import types from installed libraries if present", async () => {
     const configWithLibrary = {
       ...config,

package/src/buildTypes.ts

@@ -66,6 +66,9 @@ async function build(ctx: ResolvedEmbeddableConfig) {
     logLevel: "error",
     build: {
       emptyOutDir: false,
+      sourcemap: ctx.dev?.watch ? (false as const) : true, // No sourcemaps for types in dev
+      minify: !ctx.dev?.watch, // No minification in dev
+      rollupOptions: ctx.dev?.watch ? { treeshake: false } : undefined,
       lib: {
         entry: typesFilePath,
         formats: ["es"],

package/src/defineConfig.test.ts

@@ -35,7 +35,7 @@ describe("defineConfig", () => {
     vi.mocked(path.resolve).mockReturnValue(coreRoot);
 
     vi.spyOn(process, "cwd").mockReturnValue(
-      "/embeddable-sdk/packages/core-sdk"
+      "/embeddable-sdk/packages/core-sdk",
     );
   });
 
@@ -94,17 +94,17 @@ describe("defineConfig", () => {
 
   it("throws error for invalid property", () => {
     expect(() =>
-      defineConfig({ plugins: [], invalidProp: "INVALID" as any } as any)
+      defineConfig({ plugins: [], invalidProp: "INVALID" as any } as any),
     ).toThrow(
-      `Invalid Embeddable Configuration: "": Unrecognized key(s) in object: 'invalidProp'}`
+      `Invalid Embeddable Configuration: "": Unrecognized key(s) in object: 'invalidProp'}`,
     );
   });
 
   it("throws error for invalid property value", () => {
     expect(() =>
-      defineConfig({ plugins: [], pushBaseUrl: 123 as any } as any)
+      defineConfig({ plugins: [], pushBaseUrl: 123 as any } as any),
     ).toThrow(
-      `Invalid Embeddable Configuration: "pushBaseUrl": Expected string, received number}`
+      `Invalid Embeddable Configuration: "pushBaseUrl": Expected string, received number}`,
     );
   });
 
@@ -157,9 +157,9 @@ describe("defineConfig", () => {
 
     it("throws error for invalid region", () => {
       expect(() =>
-        defineConfig({ plugins: [], region: "INVALID" as any })
+        defineConfig({ plugins: [], region: "INVALID" as any }),
       ).toThrow(
-        `Invalid Embeddable Configuration: "region": Invalid literal value, expected "legacy-US"}`
+        `Invalid Embeddable Configuration: "region": Invalid literal value, expected "legacy-US"}`,
       );
     });
   });