@embeddable.com/sdk-core 3.9.14 → 3.10.1

package/loader/entryPoint.js

@@ -0,0 +1,75 @@
+import COMMANDS_MAP from "../lib/index.js";
+import { spawn } from "child_process";
+import path from "path";
+import fs from "fs";
+
+export async function main() {
+  const command = process.argv[2];
+  const runScript = COMMANDS_MAP[command];
+  const args = process.argv.slice(2);
+  const skipTypeCheck = args.includes("--force");
+
+  if (!runScript) {
+    process.exit(1);
+  }
+
+  if (command === "build") {
+    await runTypeScriptCheck(skipTypeCheck);
+  }
+
+  await runScript();
+}
+
+async function outputWarning(message) {
+  console.warn(`\x1b[33m⚠️  WARNING: ${message}\x1b[0m`);
+}
+
+async function runTypeScriptCheck(skipTypeCheck = false) {
+  const skipTypeCheckWarning =
+    "You can skip type checking by running with the --force flag, if you know what you are doing.";
+  return new Promise((resolve) => {
+    const customerProjectDir = process.cwd();
+    const tsconfigPath = path.join(customerProjectDir, "tsconfig.json");
+
+    if (skipTypeCheck) {
+      outputWarning("Type checking skipped.");
+    }
+
+    if (!fs.existsSync(tsconfigPath) || skipTypeCheck) {
+      resolve();
+      return;
+    }
+
+    const tscPath = path.join(
+      customerProjectDir,
+      "node_modules",
+      ".bin",
+      process.platform === "win32" ? "tsc.cmd" : "tsc",
+    );
+
+    if (!fs.existsSync(tscPath) && !skipTypeCheck) {
+      outputWarning(
+        "TypeScript compiler not found. Please ensure 'typescript' is installed in your project dependencies.",
+      );
+      outputWarning(skipTypeCheckWarning);
+      process.exit(1);
+    }
+
+    const tsc = spawn(tscPath, ["--noEmit", "--pretty"], {
+      cwd: customerProjectDir,
+      stdio: "inherit",
+      env: { ...process.env, FORCE_COLOR: "true" },
+    });
+
+    tsc.on("exit", (code) => {
+      if (code !== 0) {
+        outputWarning(skipTypeCheckWarning);
+        process.exit(1);
+      } else {
+        resolve();
+      }
+    });
+  });
+}
+
+main();

package/loader/entryPoint.test.js

@@ -0,0 +1,122 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { spawn } from "child_process";
+import fs from "fs";
+import path from "path";
+
+// Mock the dependencies
+vi.mock("child_process");
+vi.mock("fs");
+vi.mock("path");
+vi.mock("../lib/index.js", () => ({
+  default: {
+    build: vi.fn().mockResolvedValue(undefined),
+    someOtherCommand: vi.fn().mockResolvedValue(undefined),
+  },
+}));
+
+describe("entryPoint", () => {
+  let originalWarn;
+  let main;
+  beforeEach(async () => {
+    // Reset all mocks before each test
+    vi.clearAllMocks();
+    originalWarn = console.warn;
+    console.warn = vi.fn();
+
+    fs.existsSync.mockReturnValue(true);
+
+    // Mock process.on to avoid actually setting up process listeners
+    vi.spyOn(process, "on").mockImplementation(() => process);
+    vi.spyOn(process, "exit").mockImplementation(() => {
+      throw new Error("Process.exit called with code 1");
+    });
+
+    // Mock path.join to return predictable paths
+    path.join.mockImplementation((...args) => args.join("/"));
+
+    // Mock spawn
+    spawn.mockReturnValue({
+      on: vi.fn().mockImplementation((event, cb) => {
+        if (event === "exit") {
+          cb(0); // Success by default
+        }
+      }),
+    });
+
+    // Set up process.argv for the test
+    process.argv = ["node", "script.js", "someOtherCommand"];
+
+    // Dynamically import main after mocking process.exit
+    const entryPoint = await import("./entryPoint.js");
+    main = entryPoint.main;
+  });
+
+  afterEach(() => {
+    console.warn = originalWarn;
+  });
+
+  it("should run typescript check before build command", async () => {
+    process.argv = ["node", "script.js", "build"];
+    await main();
+
+    expect(spawn).toHaveBeenCalledWith(
+      expect.stringContaining("tsc"),
+      ["--noEmit", "--pretty"],
+      expect.any(Object),
+    );
+  });
+
+  it("should skip typescript check with --force flag", async () => {
+    process.argv = ["node", "script.js", "build", "--force"];
+    await main();
+
+    expect(spawn).not.toHaveBeenCalled();
+    expect(console.warn).toHaveBeenCalled();
+  });
+
+  it("should handle missing tsconfig.json", async () => {
+    process.argv = ["node", "script.js", "build"];
+    fs.existsSync.mockImplementation((path) => {
+      return !path.includes("tsconfig.json");
+    });
+
+    await main();
+    expect(spawn).not.toHaveBeenCalled();
+  });
+
+  it("should exit if typescript check fails", async () => {
+    process.argv = ["node", "script.js", "build"];
+
+    spawn.mockReturnValue({
+      on: vi.fn().mockImplementation((event, cb) => {
+        if (event === "exit") {
+          cb(1); // Simulate failure
+        }
+      }),
+    });
+
+    try {
+      await main();
+    } catch (error) {
+      expect(error.message).toBe("Process.exit called with code 1");
+      expect(console.warn).toHaveBeenCalled();
+    }
+  });
+
+  it("should handle missing typescript compiler", async () => {
+    process.argv = ["node", "script.js", "build"];
+
+    // Mock both tsconfig.json existence and tsc missing
+    fs.existsSync.mockImplementation((filePath) => {
+      if (filePath.includes("tsconfig.json")) return true;
+      if (filePath.includes("tsc")) return false;
+      return true;
+    });
+
+    try {
+      await main();
+    } catch (error) {
+      expect(error.message).toBe("Process.exit called with code 1");
+    }
+  });
+});

package/loader/package.json

@@ -0,0 +1,3 @@
+{
+  "type": "module"
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@embeddable.com/sdk-core",
-  "version": "3.9.14",
+  "version": "3.10.1",
   "description": "Core Embeddable SDK module responsible for web-components bundling and publishing.",
   "keywords": [
     "embeddable",
@@ -39,22 +39,23 @@
   "license": "MIT",
   "dependencies": {
     "@embeddable.com/sdk-utils": "*",
-    "@inquirer/prompts": "^7.0.0",
-    "@stencil/core": "^4.22.0",
+    "@inquirer/prompts": "^7.1.0",
+    "@stencil/core": "^4.22.3",
     "@swc-node/register": "^1.10.9",
-    "archiver": "^5.3.1",
-    "axios": "^1.7.2",
-    "chokidar": "^3.6.0",
-    "finalhandler": "^1.2.0",
+    "archiver": "^5.3.2",
+    "axios": "^1.7.8",
+    "chokidar": "^4.0.1",
+    "fast-glob": "^3.3.2",
+    "finalhandler": "^1.3.1",
     "formdata-node": "^6.0.3",
     "minimist": "^1.2.8",
     "open": "^9.1.0",
-    "ora": "^8.0.1",
-    "serve-static": "^1.15.0",
-    "sorcery": "^0.11.0",
-    "vite": "^5.4.8",
-    "ws": "^8.17.0",
-    "yaml": "^2.3.3"
+    "ora": "^8.1.1",
+    "serve-static": "^1.16.2",
+    "sorcery": "^0.11.1",
+    "vite": "^5.4.11",
+    "ws": "^8.18.0",
+    "yaml": "^2.6.1"
   },
   "lint-staged": {
     "*.{js,ts,json}": [
@@ -63,6 +64,6 @@
   },
   "devDependencies": {
     "@types/archiver": "^5.3.4",
-    "@types/ws": "^8.5.10"
+    "@types/ws": "^8.5.13"
   }
 }

package/src/build.test.ts

@@ -5,7 +5,6 @@ import buildTypes from "./buildTypes";
 import provideConfig from "./provideConfig";
 import generate from "./generate";
 import cleanup from "./cleanup";
-import { initLogger, logError } from "./logger";
 
 // @ts-ignore
 import reportErrorToRollbar from "./rollbar.mjs";

package/src/dev.ts

@@ -10,6 +10,7 @@ import {
   createNodeLogger,
   createNodeSys,
 } from "@stencil/core/sys/node";
+import { glob } from "node:fs/promises";
 import { RollupWatcher } from "rollup";
 import * as http from "node:http";
 import { IncomingMessage, Server, ServerResponse } from "http";
@@ -29,6 +30,7 @@ import { selectWorkspace } from "./workspaceUtils";
 import * as fs from "fs";
 const minimist = require("minimist");
 import { initLogger, logError } from "./logger";
+import fg from "fast-glob";
 
 const oraP = import("ora");
 let wss: WSServer;
@@ -206,8 +208,7 @@ export default async () => {
       }
 
       const dataModelAndSecurityContextWatch =
-        dataModelAndSecurityContextWatcher(config);
-
+        await dataModelAndSecurityContextWatcher(config);
       const customGlobalCssWatch = globalCssWatcher(config);
       watchers.push(dataModelAndSecurityContextWatch);
       watchers.push(customGlobalCssWatch);
@@ -272,17 +273,26 @@ const onBundleBuildEnd = async (ctx: any) => {
   }
 };
 
-const dataModelAndSecurityContextWatcher = (ctx: any): FSWatcher => {
+const dataModelAndSecurityContextWatcher = async (
+  ctx: any,
+): Promise<FSWatcher> => {
+  const [modelsFiles, presetsFiles] = await Promise.all([
+    fg("**/*.cube.{yaml,yml,js}", {
+      cwd: ctx.client.modelsSrc,
+      absolute: true,
+    }),
+    fg("**/*.{sc,cc}.{yaml,yml}", {
+      cwd: ctx.client.presetsSrc,
+      absolute: true,
+    }),
+  ]);
+
   const fsWatcher = chokidar.watch(
-    [
-      path.resolve(ctx.client.modelsSrc, "**/*.cube.{yaml,yml,js}"),
-      path.resolve(ctx.client.presetsSrc, "**/*.{sc,cc}.{yaml,yml}"),
-    ],
+    [...modelsFiles, ...presetsFiles],
     chokidarWatchOptions,
   );
-  fsWatcher.on("all", async () => {
-    await sendDataModelsAndContextsChanges(ctx);
-  });
+
+  fsWatcher.on("all", () => sendDataModelsAndContextsChanges(ctx));
 
   return fsWatcher;
 };

package/src/rollbar.test.ts

@@ -5,7 +5,6 @@ import Rollbar from "rollbar";
 import * as path from "node:path";
 import * as fs from "node:fs/promises";
 import { jwtDecode } from "jwt-decode";
-import { readFile } from "node:fs";
 
 const config = {
   applicationEnvironment: "test",

package/src/entryPoint.js

@@ -1,12 +0,0 @@
-const COMMANDS_MAP = require("../lib/index.js");
-
-async function main() {
-  const command = process.argv[2];
-  const runScript = COMMANDS_MAP[command];
-
-  if (!runScript) process.exit(1);
-
-  await runScript();
-}
-
-main();